Skip to content

Fixed resolving secrets for keyvault references in run mode - #8751

Merged
David Fowler (davidfowl) merged 1 commit into
mainfrom
davidfowl/fix-kv
Apr 13, 2025
Merged

Fixed resolving secrets for keyvault references in run mode#8751
David Fowler (davidfowl) merged 1 commit into
mainfrom
davidfowl/fix-kv

Conversation

@davidfowl

@davidfowlDavid Fowler (davidfowl) commented Apr 13, 2025•
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

  • Moved token credential resolution out of the AzureProvisioner so it can shared.
  • Configure the secret resolving in both configure and provision cases.

Fixes#8750

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • No (Manual coverage to keep the change small in an attempt to patch in 9.2.x)
  • Did you add public API?
    • No
  • Does the change make any security assumptions or guarantees?
    • No
  • Does the change require an update in our Aspire docs?
    template=02-docs-request.yml)):
    • No

@davidfowl
Fixed resolving secrets for keyvault refernces in run mode
a6bb6f2
- Moved token credential resolution out of the AzureProvisioner so it can shared.
- Configure the secret resolving in both configure and provision cases.
@github-actionsgithub-actionsBot added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Apr 13, 2025
@mitchdenny

Mitch Denny (mitchdenny) commented Apr 13, 2025

Copy link
Copy Markdown
Member

Looks good. Should we be hotfixing this?

@davidfowl

David Fowler (davidfowl) commented Apr 13, 2025

Copy link
Copy Markdown
CollaboratorAuthor

Yep

@davidfowlDavid Fowler (davidfowl) changed the title Fixed resolving secrets for keyvault refernces in run modeFixed resolving secrets for keyvault references in run modeApr 13, 2025
@onionhammer

Erik O'Leary (onionhammer) commented Apr 13, 2025

Copy link
Copy Markdown
Contributor

Legend

@davidfowl
David Fowler (davidfowl) deleted the davidfowl/fix-kv branch April 13, 2025 15:00
@davidfowl

David Fowler (davidfowl) commented Apr 13, 2025

Copy link
Copy Markdown
CollaboratorAuthor

/backport to release/9.2

@github-actions

github-actionsBot commented Apr 13, 2025

Copy link
Copy Markdown
Contributor

Started backporting to release/9.2: https://github.com/dotnet/aspire/actions/runs/14430623244

@github-actionsgithub-actionsBot mentioned this pull request Apr 13, 2025
Merged
@eerhardtEric Erhardt (eerhardt) mentioned this pull request Apr 21, 2025
Closed
1 task
@davidfowlDavid Fowler (davidfowl) mentioned this pull request Apr 28, 2025
Merged
5 tasks
@github-actionsgithub-actionsBot locked and limited conversation to collaborators May 14, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mitchdennyMitch Denny (mitchdenny)mitchdenny approved these changes
@eerhardtEric Erhardt (eerhardt)Awaiting requested review from eerhardteerhardt is a code owner

Assignees

No one assigned

Labels

area-app-modelIssues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unclear how to create custom bicep resources which generate secrets

3 participants

@davidfowl@mitchdenny@onionhammer