Skip to content

[release/9.2] Fixed resolving secrets for keyvault references in run mode - #8755

Merged
David Fowler (davidfowl) merged 2 commits into
release/9.2from
backport/pr-8751-to-release/9.2
Apr 18, 2025
Merged

[release/9.2] Fixed resolving secrets for keyvault references in run mode#8755
David Fowler (davidfowl) merged 2 commits into
release/9.2from
backport/pr-8751-to-release/9.2

Conversation

@github-actions

@github-actionsgithub-actionsBot commented Apr 13, 2025

Copy link
Copy Markdown
Contributor

Backport of #8751 to release/9.2

/cc David Fowler (@davidfowl)

Customer Impact

The new first class key vault secret reference feature does not work in run mode after the first run. This makes it impossible to move away from bicep secret outputs in your own resources or use any of our resources with key references in run mode.

Testing

Manul on the customer's repro.

Risk

Low

Regression?

Yes.

…ken credential resolution out of the AzureProvisioner so it can shared. - Configure the secret resolving in both configure and provision cases.
Comment threadsrc/Aspire.Hosting.Azure/Provisioning/Provisioners/TokenCredentialHolder.cs Outdated
@danmoseleyDan Moseley (danmoseley) added area-integrations Issues pertaining to Aspire Integrations packages Servicing-approved Approved for servicing release labels Apr 16, 2025
@davidfowl
David Fowler (davidfowl) merged commit 7187153 into release/9.2Apr 18, 2025
@davidfowl
David Fowler (davidfowl) deleted the backport/pr-8751-to-release/9.2 branch April 18, 2025 18:40
@github-actionsgithub-actionsBot locked and limited conversation to collaborators May 19, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-integrationsIssues pertaining to Aspire Integrations packagesRe-opened Github-Action PRServicing-approvedApproved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@davidfowl@mitchdenny@eerhardt@danmoseley@joperezr