Uh oh!
There was an error while loading. Please reload this page.
Test and mark Python 3.12 support. Update setuptools support for >67 - #469
Merged
Merged
Conversation
Anthony Shaw (tonybaloney)
marked this pull request as draft
October 7, 2023 00:06
…the clash of azure.core namespace from the msrest package
Anthony Shaw (tonybaloney)
marked this pull request as ready for review
October 11, 2023 02:27
Stefan J. Wernli (swernli) added a commit
to microsoft/qdk
that referenced
this pull request
Oct 11, 2023
This change updates the build scripts and yaml to use Rust 1.73, which introduced some new clippy lints that the code was in violation of. The changes have the version update and the code updates for compatibility, and to keep the new clippy lints in check the minimum required version is updated in prereqs.py. This also updates the devcontainer definition to include the Azure CLI and fixes the Python version to 3.11 (3.12 was releast on Oct 3, 2023 and does not yet play nice with azure-cli packages, see microsoft/azure-devops-python-api#469).
Jonathan Myers (jmyersmsft)
commented
Oct 18, 2023
Member
Petr Nechvátal (@nechvatalp) Can you review this? Looks like there are very few others who have permission. |
Steve Dower (zooba)
commented
Oct 26, 2023
Member
Petr Nechvátal (@nechvatalp) Any chance of a review? |
cmollgaard
commented
Nov 15, 2023
A review would be very helpful. |
Jonathan Myers (jmyersmsft)
commented
Nov 15, 2023
Member
Pinging some other folks who might be able to help: Sarah Kaiser (@crazy4pi314)Matt Cooper (@vtbassmatt)Ted Chambers (@tedchamb) |
Matt Cooper (vtbassmatt)
commented
Nov 15, 2023
Member
I haven't worked on this product in years, and wouldn't be comfortable approving a PR. |
Sarah Kaiser (crazy4pi314)
self-requested a review
November 15, 2023 18:44
Sarah Kaiser (crazy4pi314)
left a comment
There was a problem hiding this comment.
Looks good to me! Easy 3.12 upgrade party 🥳
Petr Nechvátal (nechvatalp)
commented
Nov 20, 2023
Collaborator
Looks good to me, thanks for your contribution |
Petr Nechvátal (nechvatalp) added a commit
that referenced
this pull request
Jul 26, 2024
Test and mark Python 3.12 support. Update setuptools support for >67
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This package is broken in the latest version of setuptools, this PR fixes the issue and tests the patch on Python 3.12