Uh oh!
There was an error while loading. Please reload this page.
Update to Rust 1.73 - #784
Merged
Merged
Conversation
This change updates the build scripts and yaml to use Rust 1.73, which introduced some new clippy lints that the code was in violation of. The changes have the version update and the code updates for compatibility, and to keep the new clippy lints in check the minimum required version is updated in prereqs.py. This also updates the devcontainer definition to include the Azure CLI and fixes the Python version to 3.11 (3.12 was releast on Oct 3, 2023 and does not yet play nice with azure-cli packages, see microsoft/azure-devops-python-api#469).
Stefan J. Wernli (swernli)
requested review from
Bill Ticehurst (billti), Ian Davis (idavis) and Mine Starks (minestarks)
as code ownersOctober 11, 2023 19:41
Uh oh!
There was an error while loading. Please reload this page.
Alex Hansen (sezna)
approved these changes
Oct 11, 2023
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Bill Ticehurst (billti)
approved these changes
Oct 11, 2023
Stefan J. Wernli (swernli)
enabled auto-merge
October 11, 2023 22:27
Ian Davis (idavis)
approved these changes
Oct 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change updates the build scripts and yaml to use Rust 1.73, which introduced some new clippy lints that the code was in violation of. The changes have the version update and the code updates for compatibility, and to keep the new clippy lints in check the minimum required version is updated in prereqs.py.
This also updates the devcontainer to pin Python 3.11 because latest is now pointing to 3.12 which fails to build during container creation.