Uh oh!
There was an error while loading. Please reload this page.
fix(install): show uv output on Windows install failure and use correct Defender cmdlet - #149
Merged
Conversation
The Windows installer caught uv tool install output into a variable but never displayed it on failure. Users saw a generic 'this is often caused by Windows Defender' guess with no way to confirm or refute. Worse, the suggested mitigation referenced a non-existent cmdlet (Add-MpExclusion); the real cmdlet is Add-MpPreference -ExclusionPath, which on most configurations also requires running PowerShell as Administrator. Changes: - Capture the last attempt's combined stdout/stderr in $lastOutput and print it under a labeled header before the failure summary. - Replace the bogus Add-MpExclusion suggestion with the correct Add-MpPreference -ExclusionPath form, with a note about the admin requirement. - Reframe the Defender messaging as conditional on the actual error text rather than an unconditional speculation. This does not change any successful-install behavior; it only improves the diagnostic surface when uv tool install fails three times. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Uh oh!
There was an error while loading. Please reload this page.
Merged
Jason Robert (jrob5756) added a commit
that referenced
this pull request
May 6, 2026
* chore: release 0.1.12 Bumps version to 0.1.12 and updates CHANGELOG with the four PRs merged since v0.1.11: - #149: Windows install diagnostics - #151: Tag-based registry versioning with # ref syntax - #152: Unified reasoning.effort configuration - #153: Dashboard layout fix for human_gate options + loop-backs Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * chore: add #155 (Windows update reliability) to 0.1.12 changelog Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two bugs in
install.ps1that combine to make Windows install failures essentially undebuggable:1.
uv tool installoutput was swallowedThe script captured each retry's combined stdout/stderr into
$outputand then discarded it. On failure, users saw only a generic 'this is often caused by Windows Defender' guess with no way to confirm or refute it.2. Suggested mitigation cmdlet doesn't exist
The error path recommended
Add-MpExclusion -Path ...— that cmdlet does not exist in any version of PowerShell. Users who tried to follow the advice hitThe term 'Add-MpExclusion' is not recognized. The real cmdlet isAdd-MpPreference -ExclusionPath ..., which additionally requires running PowerShell as Administrator on most Windows configurations.Changes
$lastOutputand print it under a labeled header before the failure summary, so users can see whatuvactually said.Add-MpExclusionwith the correctAdd-MpPreference -ExclusionPathform, noting the admin requirement.Out of scope
This PR does not try to detect or auto-resolve the underlying constrained-install failure that produced the bug report. With this fix, users (and the maintainers) can now see what
uvprinted and triage from there. A follow-up could add a constrained → unconstrained fallback with a warning, but that risks silently producing subtly broken installs and was deferred.Verification
$lastOutputis captured and printed; cmdlet name is correct.