Skip to content

Add ContainerStatistics proto messages for Stats shim query - #695

Closed
Justin (jterry75) wants to merge 1 commit into
microsoft:masterfrom
jterry75:container_stats
Closed

Add ContainerStatistics proto messages for Stats shim query#695
Justin (jterry75) wants to merge 1 commit into
microsoft:masterfrom
jterry75:container_stats

Conversation

@jterry75

@jterry75Justin (jterry75) commented Sep 17, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Implements WCOW/LCOW V2 container statistics queries on the shim stats calls.

Signed-off-by: Justin Terry (VM) juterry@microsoft.com

@jterry75

Justin (jterry75) commented Sep 17, 2019

Copy link
Copy Markdown
ContributorAuthor

Kevin Parsons (@kevpar) - This is just the proto part but should unblock you

jterry75
Justin (jterry75) commented Sep 17, 2019
View reviewed changes
Comment threadvendor/github.com/containerd/cgroups/blkio.go Outdated
Random-Liu
Lantao Liu (Random-Liu) reviewed Sep 18, 2019
View reviewed changes
Comment threadcmd/containerd-shim-runhcs-v1/options/runhcs.proto Outdated
Comment threadcmd/containerd-shim-runhcs-v1/options/runhcs.proto Outdated
@Random-LiuLantao Liu (Random-Liu) mentioned this pull request Sep 18, 2019
Closed
@jterry75
Justin (jterry75)force-pushed the container_stats branch 2 times, most recently from 37451eb to b723892CompareSeptember 18, 2019 23:27
jterry75
Justin (jterry75) commented Sep 18, 2019
View reviewed changes
Comment threadcmd/containerd-shim-runhcs-v1/stats/stats.proto
@jterry75Justin (jterry75) changed the title Add ContainerStatistics proto messages for Stats shim query[WIP] Add ContainerStatistics proto messages for Stats shim querySep 18, 2019
@jterry75
Justin (jterry75)force-pushed the container_stats branch 2 times, most recently from 66e11a7 to edf78f8CompareOctober 9, 2019 18:15
@jterry75Justin (jterry75) changed the title [WIP] Add ContainerStatistics proto messages for Stats shim queryAdd ContainerStatistics proto messages for Stats shim queryOct 9, 2019
@jterry75

Justin (jterry75) commented Oct 9, 2019

Copy link
Copy Markdown
ContributorAuthor

Kathryn Baldauf (@katiewasnothere), Kevin Parsons (@kevpar) - This is close. We need to implement the method in the OpenGCS for LCOW to match the host expectation in hcs_task.go but I believe this should be 90% there.

Kathryn Baldauf (@katiewasnothere) - Please take the commit test/improve and feel free to carry onto a new PR or push a new commit here if needed. Thanks

@jterry75
Add container Statistics proto messages for Stats shim query
480159a
Implements WCOW/LCOW V2 container statistics queries on the shim stats calls.
Signed-off-by: Justin Terry (VM) <juterry@microsoft.com>
@jterry75

Justin (jterry75) commented Oct 9, 2019

Copy link
Copy Markdown
ContributorAuthor

Kathryn Baldauf (@katiewasnothere) - Ok that should fix the build break in the test code.

@jterry75

Justin (jterry75) commented Oct 17, 2019

Copy link
Copy Markdown
ContributorAuthor

Kathryn Baldauf (@katiewasnothere) - Do we want to take this PR and then you submit your changes or do we want to close it out?

@jterry75

Justin (jterry75) commented Oct 18, 2019

Copy link
Copy Markdown
ContributorAuthor

Closing in favor of #719. Lantao Liu (@Random-Liu) - Should be good to revendor into upstream now.

@jterry75
Justin (jterry75) deleted the container_stats branch October 18, 2019 18:25
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevparKevin Parsons (kevpar)Awaiting requested review from kevpar
1 more reviewer
@Random-LiuLantao Liu (Random-Liu)Random-Liu left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jterry75@Random-Liu