Uh oh!
There was an error while loading. Please reload this page.
Container Stats for LCOW/WCOW - #719
Conversation
Related PR: microsoft/opengcs#352 |
Uh oh!
There was an error while loading. Please reload this page.
| return "" | ||
| } | ||
| // should only be called if hcs task is WCOW |
There was a problem hiding this comment.
We dont run lint like we should on this repo but this would fail. A comment needs to say "// ..."
There was a problem hiding this comment.
Why do we need the method actually? I figured it was for code reuse but there is only one caller.
There was a problem hiding this comment.
This was just to make the code clearer in the Stats function.
Uh oh!
There was an error while loading. Please reload this page.
0b095e9 to
1aad565Compare| message VirtualMachineMemoryStatistics { | ||
| uint64 working_set_bytes = 1; | ||
| int32 virtual_node_count = 2; |
There was a problem hiding this comment.
I guess as long as were at it: uint8
There was a problem hiding this comment.
Protobuild doesn't seem to like uint8. Should I change to uint32 or would you prefer this not be changed then?
There was a problem hiding this comment.
Lame. uint32 it is. No byte type it looks like
| message VirtualMachineMemory { | ||
| int32 available_memory = 1; | ||
| int32 available_memory_buffer = 2; | ||
| int32 reserved_memory = 3; |
There was a problem hiding this comment.
reserved, assigned should be uint64
Justin (jterry75)
left a comment
There was a problem hiding this comment.
LGTM. Minor change to the proto for types
* update hcs api with correct field types * refactor stats retrieval * add tests for container stats Signed-off-by: Kathryn Baldauf <kabaldau@microsoft.com>
1aad565 to
fd7da3dCompare…r_stats Container Stats for LCOW/WCOW
Implements WCOW/LCOW V2 container statistics queries on the shim stats calls.