Merge sources into one repo by andrueastman · Pull Request #329 · microsoft/kiota-python

Andrew Omondi (andrueastman) · 2024-09-10T09:00:48Z

Todo

Resolved mypy issues via resolve typing errors in project after merge #331
Unify versioning across projects via feat: setup release please. #344
Sync changes for fix serialization of pendulum.DateTime objects in JsonSerializationWriter kiota-serialization-json-python#369 via Sync sources for changes in https://github.com/microsoft/kiota-serialization-json-python/pull/369 #345
Validate workflows

…rors

…dation adds validation with generated project

Vincent Biret (baywet)

started reviewing the PR but stopped midway through since I realized #331 still needs to be merged in this branch anyway

Andrew Omondi (andrueastman) · 2024-09-24T14:11:20Z

started reviewing the PR but stopped midway through since I realized #331 still needs to be merged in this branch anyway

Thanks Vincent Biret (@baywet), Just to set expectations here, once we close #331, I'll need to make some updates to do the following before this is fully ready for review.

Cleanup readmes and related docs
Validate workflows
Align versioning

Vincent Biret (baywet) · 2024-10-09T12:39:50Z

Andrew Omondi (@andrueastman) the policy definition probably needs to be updated here

Andrew Omondi (andrueastman) · 2024-10-09T12:43:12Z

agreed.
I'll open a sepate PR targeting main in order to close #327 before we merge this.

Musale Martin (musale)

Good stuff Andrew Omondi (@andrueastman)!

Vincent Biret (baywet) · 2024-10-11T18:52:35Z

this PR also needs to be ported microsoft/kiota-http-python#434

The merge-base changed after approval.

Andrew Omondi (andrueastman) · 2024-10-14T09:16:27Z

Sync latest sources at sync sources for https://github.com/microsoft/kiota-http-python/pull/434 #351
Resolving policy in main branch before merge at chore: add policy file for the repository #350

sync sources for microsoft/kiota-http-python#434

github-actions · 2024-10-14T12:38:19Z

This pull request has conflicting changes, the author must resolve the conflicts before this pull request can be merged.

github-actions · 2024-10-14T12:54:16Z

Conflicts have been resolved. A maintainer will take a look shortly.

sonarqubecloud · 2024-10-14T13:08:18Z

Quality Gate failed

Failed conditions
12 Security Hotspots
17.1% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Andrew Omondi (andrueastman) · 2024-10-14T13:14:11Z

This should be good to go with the resolution of #351 and #350

Andrew Omondi added 23 commits September 8, 2024 17:44

WIP: consistent abstractions project.
d28b49d

add authentication project
5b0ed83

add http package
424c151

add json serialization package
dd3472c

add form serialization
0dc8a32

add multipart package
34efc40

add text serialization library
260342a

test workflows
68d8ca9

use path
2bc6a18

remove lock files
db2dd38

align configs
17acde0

more validations
0203e83

fix typo
fe9acfc

todo validate missing imports
f1124eb

fix typo
a928f96

fixing failing multipart lib
5782dce

add missing dev dependency
74af29b

use relative path project imports
eb817e7

setup publishing workflow
7ec7701

Merge main into feature/kiota-python
08bc61b

Merge main into feature/kiota-python
1f879d7

resolve typing errors in the project
2227122

format code
ede3732

Andrew Omondi (andrueastman) mentioned this pull request Sep 13, 2024
resolve typing errors in project after merge #331
Merged

Andrew Omondiand others added 4 commits September 23, 2024 10:07

Merge main into feature/kiota-python
d371499

Merge branch 'feature/kiota-python' into andrueastman/resolvetypinger…
b02c779
…rors

adds validation with generated project
6465520

Merge pull request#340from microsoft/andrueastman/addgenerationVali…
a6f130d
…dation adds validation with generated project

Vincent Biret (baywet) reviewed Sep 24, 2024
View reviewed changes

Comment threadpackages/authentication/azure/README.md Outdated
Comment threadpackages/http/httpx/README.md Outdated

Andrew Omondi (andrueastman) changed the title ~~WIP: Merge repos into one repo~~Merge sources into one repoOct 9, 2024

Andrew Omondi (andrueastman) marked this pull request as ready for review October 9, 2024 10:35

Andrew Omondi (andrueastman) requested a review from a team as a code owner October 9, 2024 10:35

Vincent Biret (baywet) previously approved these changes Oct 9, 2024
View reviewed changes

Musale Martin (musale) previously approved these changes Oct 9, 2024
View reviewed changes

Merge branch 'main' into feature/kiota-python
412d8b9

sync sources formicrosoft/kiota-http-python#434
505c5b9

Andrew Omondi (andrueastman) mentioned this pull request Oct 14, 2024
sync sources for https://github.com/microsoft/kiota-http-python/pull/434 #351
Merged

Merge pull request#351from microsoft/andrueastman/syncSources
8a41b73
sync sources for microsoft/kiota-http-python#434

github-actionsBot added the conflicting label Oct 14, 2024

Merge remote-tracking branch 'origin/main' into feature/kiota-python
0461225

github-actionsBot removed the conflicting label Oct 14, 2024

resolve missed typing issue.
6da0197

Andrew Omondi (andrueastman) requested review from Vincent Biret (baywet) and Musale Martin (musale)October 14, 2024 13:13

Vincent Biret (baywet) approved these changes Oct 14, 2024
View reviewed changes

Musale Martin (musale) approved these changes Oct 14, 2024
View reviewed changes

Andrew Omondi (andrueastman) merged commit aa37ef4 into mainOct 14, 2024

Andrew Omondi (andrueastman) deleted the feature/kiota-python branch October 14, 2024 14:48

Andrew Omondi (andrueastman) mentioned this pull request Oct 18, 2024
fix: removes the tests directory from the package microsoftgraph/msgraph-sdk-python-core#709
Merged

Navigation Menu

Uh oh!

Merge sources into one repo - #329

Merge sources into one repo#329
Andrew Omondi (andrueastman) merged 42 commits into
mainfrom
feature/kiota-python

Andrew Omondi (andrueastman) commented Sep 10, 2024•
edited
Loading

Uh oh!

Vincent Biret (baywet) left a comment

Uh oh!

Uh oh!

Uh oh!

Andrew Omondi (andrueastman) commented Sep 24, 2024

Uh oh!

Vincent Biret (baywet) commented Oct 9, 2024

Uh oh!

Andrew Omondi (andrueastman) commented Oct 9, 2024

Uh oh!

Musale Martin (musale) left a comment

Uh oh!

Vincent Biret (baywet) commented Oct 11, 2024

Uh oh!

Andrew Omondi (andrueastman) commented Oct 14, 2024

Uh oh!

github-actionsBot commented Oct 14, 2024

Uh oh!

github-actionsBot commented Oct 14, 2024

Uh oh!

sonarqubecloudBot commented Oct 14, 2024

Uh oh!

Andrew Omondi (andrueastman) commented Oct 14, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Andrew Omondi (andrueastman) commented Sep 10, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Vincent Biret (baywet) left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Andrew Omondi (andrueastman) commented Sep 24, 2024

Uh oh!

Vincent Biret (baywet) commented Oct 9, 2024

Uh oh!

Andrew Omondi (andrueastman) commented Oct 9, 2024

Uh oh!

Musale Martin (musale) left a comment

Choose a reason for hiding this comment

Uh oh!

Vincent Biret (baywet) commented Oct 11, 2024

Uh oh!

Andrew Omondi (andrueastman) commented Oct 14, 2024

Uh oh!

github-actionsBot commented Oct 14, 2024

Uh oh!

github-actionsBot commented Oct 14, 2024

Uh oh!

sonarqubecloudBot commented Oct 14, 2024

Quality Gate failed

Uh oh!

Andrew Omondi (andrueastman) commented Oct 14, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Andrew Omondi (andrueastman) commented Sep 10, 2024•
edited
Loading