fix serialization of pendulum.DateTime objects in JsonSerializationWriter

[Eran Avrahami (eran-av)]

Environment

• Python Version: 3.11.7
• kiota-serialization-json version: 1.3.2
• OS: MacOS

Describe the bug
The write_any_value method in JsonSerializationWriter fails to properly handle pendulum.DateTime objects. This is due to insufficient type checking, which causes pendulum.DateTime objects to be treated as non-primitive types instead of as datetime objects. Specifically, the issue stems from not using isinstance() to check for datetime types, which prevents pendulum.DateTime from being recognized as a subclass of the primitive datetime.datetime.

To Reproduce

1. Create a JsonSerializationWriter instance
2. Attempt to serialize an object containing a pendulum.DateTime field (specifically as an additional_datadict)
3. Observe that the pendulum.DateTime object is not serialized correctly

Expected behavior
pendulum.DateTime objects should be treated as datetime objects and serialized correctly, just like datetime.datetime objects. The serialization process should recognize pendulum.DateTime as a subclass of datetime.datetime and handle it accordingly.

Code to reproduce

fromkiota_serialization_jsonimportJsonSerializationWriterimportpendulumwriter=JsonSerializationWriter()
writer.write_additional_data_value({
"created_at": pendulum.DateTime(2024, 9, 24)
})
content=writer.get_serialized_content()
print(content.decode('utf-8'))

[Eran Avrahami (eran-av)]

Eran Avrahami (@eran-av) please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

• (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.

@microsoft-github-policy-service agree

• (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.

@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

[Eran Avrahami (eran-av)]

Vincent Biret (@baywet), Andrew Omondi (@andrueastman) Can you please take a look?

[Vincent Biret (baywet)]

Thanks for the contribution!
Can you please also bump the patch version in the version file and add a changelog entry? (today's date, changed) to ensure a swift release.

Also, sorry about the delay in reviewing, I missed this one in my many, many notifications...

[Vincent Biret (baywet)]

Additionally, the code needs to be formatted (see the build logs)

[Vincent Biret (baywet)]

Thank you for making the changes!

[Vincent Biret (baywet)]

Eran Avrahami (@eran-av) it seems some unit tests are not passing, can you have a look into it please?

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[Eran Avrahami (eran-av)]

Eran Avrahami (@eran-av) it seems some unit tests are not passing, can you have a look into it please?

Fixed it,
Also - sorry about the linting issues.
Couldn't quite figure which linter + conf you're using.

[Vincent Biret (baywet)]

Eran Avrahami (@eran-av) it seems some unit tests are not passing, can you have a look into it please?

Fixed it, Also - sorry about the linting issues. Couldn't quite figure which linter + conf you're using.

yeah this is a bit confusing: pylint + yapf