Fixes to simplify VTL1 boot sequence

[tgopinath-microsoft]

Simplify VTL1 boot sequence by

1. Removing the need for cmdline and bootparams pages
2. Removing the need for boot signal page to bring up secondary processors

[tgopinath-microsoft]

This need corresponding VTL0 Linux changes. Do not merge till that is ready. This was done as part of clean up for submitting the initial set of VTL0 patches upstream

[Sangho Lee (sangho2)]

Thanks! Overall, looks good to me. There is one uncertain change; let me test it as well.

[tgopinath-microsoft]

Thanks! Overall, looks good to me. There is one uncertain change; let me test it as well.

Thanks for the review ! If you want to test it , use the thara/project/lvbs/6.6/main branch in https://dev.azure.com/msazure/LSG-linux/_git/LSG-linux-rolling?_a=history . And use azl3_lvbs_main_config to build the config

[Sangho Lee (sangho2)]

Looks good to me. Seems that we need to revert or change the default COM port number.

[Sangho Lee (sangho2)]

Thanks! Overall, looks good to me. There is one uncertain change; let me test it as well.

Thanks for the review ! If you want to test it , use the thara/project/lvbs/6.6/main branch in https://dev.azure.com/msazure/LSG-linux/_git/LSG-linux-rolling?_a=history . And use azl3_lvbs_main_config to build the config

Thanks! Let me test it. One question: does this branch have OP-TEE support you've made as well?

[tgopinath-microsoft]

No. though Angelina has a PR against this branch. Once this gets checked in, I will check in the other branch as well and then push in Angelina's PR

[github-actions]

🤖 SemverChecks 🤖 ⚠️ Potential breaking API changes detected ⚠️

Click for details

--- failure enum_missing: pub enum removed or renamed ---
Description:
A publicly-visible enum cannot be imported by its prior path. A `pub use` may have been removed, or the enum itself may have been renamed or removed entirely.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/enum_missing.ron
Failed in:
enum litebox_platform_lvbs::mshv::vtl1_mem_layout::VtlMemoryError, previously in file /home/runner/work/litebox/litebox/target/semver-checks/git-main/e218c7cc0b39b6a0402839f2d17ffb4c681921c3/litebox_platform_lvbs/src/mshv/vtl1_mem_layout.rs:123
--- failure function_missing: pub fn removed or renamed ---
Description:
A publicly-visible function cannot be imported by its prior path. A `pub use` may have been removed, or the function itself may have been renamed or removed entirely.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/function_missing.ron
Failed in:
function litebox_platform_lvbs::host::bootparam::parse_boot_info, previously in file /home/runner/work/litebox/litebox/target/semver-checks/git-main/e218c7cc0b39b6a0402839f2d17ffb4c681921c3/litebox_platform_lvbs/src/host/bootparam.rs:178
--- failure function_parameter_count_changed: pub fn parameter count changed ---
Description:
A publicly-visible function now takes a different number of parameters.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/function_parameter_count_changed.ron
Failed in:
litebox_platform_lvbs::mshv::vsm::mshv_vsm_boot_aps now takes 1 parameters instead of 2, in /home/runner/work/litebox/litebox/litebox_platform_lvbs/src/mshv/vsm.rs:115
--- failure pub_module_level_const_missing: pub module-level const is missing ---
Description:
A public const is missing or renamed
ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/pub_module_level_const_missing.ron
Failed in:
VTL1_CMDLINE_PAGE in file /home/runner/work/litebox/litebox/target/semver-checks/git-main/e218c7cc0b39b6a0402839f2d17ffb4c681921c3/litebox_platform_lvbs/src/mshv/vtl1_mem_layout.rs:58
HV_SECURE_VTL_BOOT_TOKEN in file /home/runner/work/litebox/litebox/target/semver-checks/git-main/e218c7cc0b39b6a0402839f2d17ffb4c681921c3/litebox_platform_lvbs/src/mshv/mod.rs:114
VTL1_TOTAL_MEMORY_SIZE in file /home/runner/work/litebox/litebox/target/semver-checks/git-main/e218c7cc0b39b6a0402839f2d17ffb4c681921c3/litebox_platform_lvbs/src/mshv/vtl1_mem_layout.rs:16
VTL1_BOOT_PARAMS_PAGE in file /home/runner/work/litebox/litebox/target/semver-checks/git-main/e218c7cc0b39b6a0402839f2d17ffb4c681921c3/litebox_platform_lvbs/src/mshv/vtl1_mem_layout.rs:57

[Sangho Lee (sangho2)]

No. though Angelina has a PR against this branch. Once this gets checked in, I will check in the other branch as well and then push in Angelina's PR

That sounds like a chicken-and-egg problem because I need the OP-TEE support for adding features and fixing some bugs. Anyway, seems that I need to maintain my own branch for a while.

[tgopinath-microsoft]

Simplify VTL1 boot sequence by

1. Removing the need for cmdline and bootparams pages
2. Removing the need for boot signal page to bring up secondary processors

[tgopinath-microsoft]

This need corresponding VTL0 Linux changes. Do not merge till that is ready. This was done as part of clean up for submitting the initial set of VTL0 patches upstream

[Sangho Lee (sangho2)]

Thanks! Overall, looks good to me. There is one uncertain change; let me test it as well.

[tgopinath-microsoft]

Thanks! Overall, looks good to me. There is one uncertain change; let me test it as well.

Thanks for the review ! If you want to test it , use the thara/project/lvbs/6.6/main branch in https://dev.azure.com/msazure/LSG-linux/_git/LSG-linux-rolling?_a=history . And use azl3_lvbs_main_config to build the config

[Sangho Lee (sangho2)]

Looks good to me. Seems that we need to revert or change the default COM port number.

[Sangho Lee (sangho2)]

Thanks! Overall, looks good to me. There is one uncertain change; let me test it as well.

Thanks for the review ! If you want to test it , use the thara/project/lvbs/6.6/main branch in https://dev.azure.com/msazure/LSG-linux/_git/LSG-linux-rolling?_a=history . And use azl3_lvbs_main_config to build the config

Thanks! Let me test it. One question: does this branch have OP-TEE support you've made as well?

[tgopinath-microsoft]

No. though Angelina has a PR against this branch. Once this gets checked in, I will check in the other branch as well and then push in Angelina's PR

[github-actions]

🤖 SemverChecks 🤖 ⚠️ Potential breaking API changes detected ⚠️

Click for details

--- failure enum_missing: pub enum removed or renamed ---
Description:
A publicly-visible enum cannot be imported by its prior path. A `pub use` may have been removed, or the enum itself may have been renamed or removed entirely.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/enum_missing.ron
Failed in:
enum litebox_platform_lvbs::mshv::vtl1_mem_layout::VtlMemoryError, previously in file /home/runner/work/litebox/litebox/target/semver-checks/git-main/e218c7cc0b39b6a0402839f2d17ffb4c681921c3/litebox_platform_lvbs/src/mshv/vtl1_mem_layout.rs:123
--- failure function_missing: pub fn removed or renamed ---
Description:
A publicly-visible function cannot be imported by its prior path. A `pub use` may have been removed, or the function itself may have been renamed or removed entirely.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/function_missing.ron
Failed in:
function litebox_platform_lvbs::host::bootparam::parse_boot_info, previously in file /home/runner/work/litebox/litebox/target/semver-checks/git-main/e218c7cc0b39b6a0402839f2d17ffb4c681921c3/litebox_platform_lvbs/src/host/bootparam.rs:178
--- failure function_parameter_count_changed: pub fn parameter count changed ---
Description:
A publicly-visible function now takes a different number of parameters.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/function_parameter_count_changed.ron
Failed in:
litebox_platform_lvbs::mshv::vsm::mshv_vsm_boot_aps now takes 1 parameters instead of 2, in /home/runner/work/litebox/litebox/litebox_platform_lvbs/src/mshv/vsm.rs:115
--- failure pub_module_level_const_missing: pub module-level const is missing ---
Description:
A public const is missing or renamed
ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/pub_module_level_const_missing.ron
Failed in:
VTL1_CMDLINE_PAGE in file /home/runner/work/litebox/litebox/target/semver-checks/git-main/e218c7cc0b39b6a0402839f2d17ffb4c681921c3/litebox_platform_lvbs/src/mshv/vtl1_mem_layout.rs:58
HV_SECURE_VTL_BOOT_TOKEN in file /home/runner/work/litebox/litebox/target/semver-checks/git-main/e218c7cc0b39b6a0402839f2d17ffb4c681921c3/litebox_platform_lvbs/src/mshv/mod.rs:114
VTL1_TOTAL_MEMORY_SIZE in file /home/runner/work/litebox/litebox/target/semver-checks/git-main/e218c7cc0b39b6a0402839f2d17ffb4c681921c3/litebox_platform_lvbs/src/mshv/vtl1_mem_layout.rs:16
VTL1_BOOT_PARAMS_PAGE in file /home/runner/work/litebox/litebox/target/semver-checks/git-main/e218c7cc0b39b6a0402839f2d17ffb4c681921c3/litebox_platform_lvbs/src/mshv/vtl1_mem_layout.rs:57

[Sangho Lee (sangho2)]

No. though Angelina has a PR against this branch. Once this gets checked in, I will check in the other branch as well and then push in Angelina's PR

That sounds like a chicken-and-egg problem because I need the OP-TEE support for adding features and fixing some bugs. Anyway, seems that I need to maintain my own branch for a while.

[tgopinath-microsoft]

Simplify VTL1 boot sequence by

1. Removing the need for cmdline and bootparams pages
2. Removing the need for boot signal page to bring up secondary processors

[tgopinath-microsoft]

This need corresponding VTL0 Linux changes. Do not merge till that is ready. This was done as part of clean up for submitting the initial set of VTL0 patches upstream

[Sangho Lee (sangho2)]

Thanks! Overall, looks good to me. There is one uncertain change; let me test it as well.

[tgopinath-microsoft]

Thanks! Overall, looks good to me. There is one uncertain change; let me test it as well.

Thanks for the review ! If you want to test it , use the thara/project/lvbs/6.6/main branch in https://dev.azure.com/msazure/LSG-linux/_git/LSG-linux-rolling?_a=history . And use azl3_lvbs_main_config to build the config

[Sangho Lee (sangho2)]

Looks good to me. Seems that we need to revert or change the default COM port number.

[Sangho Lee (sangho2)]

Thanks! Overall, looks good to me. There is one uncertain change; let me test it as well.

Thanks for the review ! If you want to test it , use the thara/project/lvbs/6.6/main branch in https://dev.azure.com/msazure/LSG-linux/_git/LSG-linux-rolling?_a=history . And use azl3_lvbs_main_config to build the config

Thanks! Let me test it. One question: does this branch have OP-TEE support you've made as well?

[tgopinath-microsoft]

No. though Angelina has a PR against this branch. Once this gets checked in, I will check in the other branch as well and then push in Angelina's PR

[github-actions]

🤖 SemverChecks 🤖 ⚠️ Potential breaking API changes detected ⚠️

Click for details

--- failure enum_missing: pub enum removed or renamed ---
Description:
A publicly-visible enum cannot be imported by its prior path. A `pub use` may have been removed, or the enum itself may have been renamed or removed entirely.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/enum_missing.ron
Failed in:
enum litebox_platform_lvbs::mshv::vtl1_mem_layout::VtlMemoryError, previously in file /home/runner/work/litebox/litebox/target/semver-checks/git-main/e218c7cc0b39b6a0402839f2d17ffb4c681921c3/litebox_platform_lvbs/src/mshv/vtl1_mem_layout.rs:123
--- failure function_missing: pub fn removed or renamed ---
Description:
A publicly-visible function cannot be imported by its prior path. A `pub use` may have been removed, or the function itself may have been renamed or removed entirely.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/function_missing.ron
Failed in:
function litebox_platform_lvbs::host::bootparam::parse_boot_info, previously in file /home/runner/work/litebox/litebox/target/semver-checks/git-main/e218c7cc0b39b6a0402839f2d17ffb4c681921c3/litebox_platform_lvbs/src/host/bootparam.rs:178
--- failure function_parameter_count_changed: pub fn parameter count changed ---
Description:
A publicly-visible function now takes a different number of parameters.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/function_parameter_count_changed.ron
Failed in:
litebox_platform_lvbs::mshv::vsm::mshv_vsm_boot_aps now takes 1 parameters instead of 2, in /home/runner/work/litebox/litebox/litebox_platform_lvbs/src/mshv/vsm.rs:115
--- failure pub_module_level_const_missing: pub module-level const is missing ---
Description:
A public const is missing or renamed
ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/pub_module_level_const_missing.ron
Failed in:
VTL1_CMDLINE_PAGE in file /home/runner/work/litebox/litebox/target/semver-checks/git-main/e218c7cc0b39b6a0402839f2d17ffb4c681921c3/litebox_platform_lvbs/src/mshv/vtl1_mem_layout.rs:58
HV_SECURE_VTL_BOOT_TOKEN in file /home/runner/work/litebox/litebox/target/semver-checks/git-main/e218c7cc0b39b6a0402839f2d17ffb4c681921c3/litebox_platform_lvbs/src/mshv/mod.rs:114
VTL1_TOTAL_MEMORY_SIZE in file /home/runner/work/litebox/litebox/target/semver-checks/git-main/e218c7cc0b39b6a0402839f2d17ffb4c681921c3/litebox_platform_lvbs/src/mshv/vtl1_mem_layout.rs:16
VTL1_BOOT_PARAMS_PAGE in file /home/runner/work/litebox/litebox/target/semver-checks/git-main/e218c7cc0b39b6a0402839f2d17ffb4c681921c3/litebox_platform_lvbs/src/mshv/vtl1_mem_layout.rs:57

[Sangho Lee (sangho2)]

No. though Angelina has a PR against this branch. Once this gets checked in, I will check in the other branch as well and then push in Angelina's PR

That sounds like a chicken-and-egg problem because I need the OP-TEE support for adding features and fixing some bugs. Anyway, seems that I need to maintain my own branch for a while.

[tgopinath-microsoft]

Simplify VTL1 boot sequence by

1. Removing the need for cmdline and bootparams pages
2. Removing the need for boot signal page to bring up secondary processors

[tgopinath-microsoft]

This need corresponding VTL0 Linux changes. Do not merge till that is ready. This was done as part of clean up for submitting the initial set of VTL0 patches upstream

[Sangho Lee (sangho2)]

Thanks! Overall, looks good to me. There is one uncertain change; let me test it as well.

[tgopinath-microsoft]

Thanks! Overall, looks good to me. There is one uncertain change; let me test it as well.

Thanks for the review ! If you want to test it , use the thara/project/lvbs/6.6/main branch in https://dev.azure.com/msazure/LSG-linux/_git/LSG-linux-rolling?_a=history . And use azl3_lvbs_main_config to build the config

[Sangho Lee (sangho2)]

Looks good to me. Seems that we need to revert or change the default COM port number.

[Sangho Lee (sangho2)]

Thanks! Overall, looks good to me. There is one uncertain change; let me test it as well.

Thanks for the review ! If you want to test it , use the thara/project/lvbs/6.6/main branch in https://dev.azure.com/msazure/LSG-linux/_git/LSG-linux-rolling?_a=history . And use azl3_lvbs_main_config to build the config

Thanks! Let me test it. One question: does this branch have OP-TEE support you've made as well?

[tgopinath-microsoft]

No. though Angelina has a PR against this branch. Once this gets checked in, I will check in the other branch as well and then push in Angelina's PR

[github-actions]

🤖 SemverChecks 🤖 ⚠️ Potential breaking API changes detected ⚠️

Click for details

--- failure enum_missing: pub enum removed or renamed ---
Description:
A publicly-visible enum cannot be imported by its prior path. A `pub use` may have been removed, or the enum itself may have been renamed or removed entirely.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/enum_missing.ron
Failed in:
enum litebox_platform_lvbs::mshv::vtl1_mem_layout::VtlMemoryError, previously in file /home/runner/work/litebox/litebox/target/semver-checks/git-main/e218c7cc0b39b6a0402839f2d17ffb4c681921c3/litebox_platform_lvbs/src/mshv/vtl1_mem_layout.rs:123
--- failure function_missing: pub fn removed or renamed ---
Description:
A publicly-visible function cannot be imported by its prior path. A `pub use` may have been removed, or the function itself may have been renamed or removed entirely.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/function_missing.ron
Failed in:
function litebox_platform_lvbs::host::bootparam::parse_boot_info, previously in file /home/runner/work/litebox/litebox/target/semver-checks/git-main/e218c7cc0b39b6a0402839f2d17ffb4c681921c3/litebox_platform_lvbs/src/host/bootparam.rs:178
--- failure function_parameter_count_changed: pub fn parameter count changed ---
Description:
A publicly-visible function now takes a different number of parameters.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/function_parameter_count_changed.ron
Failed in:
litebox_platform_lvbs::mshv::vsm::mshv_vsm_boot_aps now takes 1 parameters instead of 2, in /home/runner/work/litebox/litebox/litebox_platform_lvbs/src/mshv/vsm.rs:115
--- failure pub_module_level_const_missing: pub module-level const is missing ---
Description:
A public const is missing or renamed
ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/pub_module_level_const_missing.ron
Failed in:
VTL1_CMDLINE_PAGE in file /home/runner/work/litebox/litebox/target/semver-checks/git-main/e218c7cc0b39b6a0402839f2d17ffb4c681921c3/litebox_platform_lvbs/src/mshv/vtl1_mem_layout.rs:58
HV_SECURE_VTL_BOOT_TOKEN in file /home/runner/work/litebox/litebox/target/semver-checks/git-main/e218c7cc0b39b6a0402839f2d17ffb4c681921c3/litebox_platform_lvbs/src/mshv/mod.rs:114
VTL1_TOTAL_MEMORY_SIZE in file /home/runner/work/litebox/litebox/target/semver-checks/git-main/e218c7cc0b39b6a0402839f2d17ffb4c681921c3/litebox_platform_lvbs/src/mshv/vtl1_mem_layout.rs:16
VTL1_BOOT_PARAMS_PAGE in file /home/runner/work/litebox/litebox/target/semver-checks/git-main/e218c7cc0b39b6a0402839f2d17ffb4c681921c3/litebox_platform_lvbs/src/mshv/vtl1_mem_layout.rs:57

[Sangho Lee (sangho2)]

No. though Angelina has a PR against this branch. Once this gets checked in, I will check in the other branch as well and then push in Angelina's PR

That sounds like a chicken-and-egg problem because I need the OP-TEE support for adding features and fixing some bugs. Anyway, seems that I need to maintain my own branch for a while.

[tgopinath-microsoft]

Simplify VTL1 boot sequence by

1. Removing the need for cmdline and bootparams pages
2. Removing the need for boot signal page to bring up secondary processors

[tgopinath-microsoft]

This need corresponding VTL0 Linux changes. Do not merge till that is ready. This was done as part of clean up for submitting the initial set of VTL0 patches upstream

[Sangho Lee (sangho2)]

Thanks! Overall, looks good to me. There is one uncertain change; let me test it as well.

[tgopinath-microsoft]

Thanks! Overall, looks good to me. There is one uncertain change; let me test it as well.

Thanks for the review ! If you want to test it , use the thara/project/lvbs/6.6/main branch in https://dev.azure.com/msazure/LSG-linux/_git/LSG-linux-rolling?_a=history . And use azl3_lvbs_main_config to build the config

[Sangho Lee (sangho2)]

Looks good to me. Seems that we need to revert or change the default COM port number.

[Sangho Lee (sangho2)]

Thanks! Overall, looks good to me. There is one uncertain change; let me test it as well.

Thanks for the review ! If you want to test it , use the thara/project/lvbs/6.6/main branch in https://dev.azure.com/msazure/LSG-linux/_git/LSG-linux-rolling?_a=history . And use azl3_lvbs_main_config to build the config

Thanks! Let me test it. One question: does this branch have OP-TEE support you've made as well?

[tgopinath-microsoft]

No. though Angelina has a PR against this branch. Once this gets checked in, I will check in the other branch as well and then push in Angelina's PR

[github-actions]

🤖 SemverChecks 🤖 ⚠️ Potential breaking API changes detected ⚠️

Click for details

--- failure enum_missing: pub enum removed or renamed ---
Description:
A publicly-visible enum cannot be imported by its prior path. A `pub use` may have been removed, or the enum itself may have been renamed or removed entirely.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/enum_missing.ron
Failed in:
enum litebox_platform_lvbs::mshv::vtl1_mem_layout::VtlMemoryError, previously in file /home/runner/work/litebox/litebox/target/semver-checks/git-main/e218c7cc0b39b6a0402839f2d17ffb4c681921c3/litebox_platform_lvbs/src/mshv/vtl1_mem_layout.rs:123
--- failure function_missing: pub fn removed or renamed ---
Description:
A publicly-visible function cannot be imported by its prior path. A `pub use` may have been removed, or the function itself may have been renamed or removed entirely.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/function_missing.ron
Failed in:
function litebox_platform_lvbs::host::bootparam::parse_boot_info, previously in file /home/runner/work/litebox/litebox/target/semver-checks/git-main/e218c7cc0b39b6a0402839f2d17ffb4c681921c3/litebox_platform_lvbs/src/host/bootparam.rs:178
--- failure function_parameter_count_changed: pub fn parameter count changed ---
Description:
A publicly-visible function now takes a different number of parameters.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/function_parameter_count_changed.ron
Failed in:
litebox_platform_lvbs::mshv::vsm::mshv_vsm_boot_aps now takes 1 parameters instead of 2, in /home/runner/work/litebox/litebox/litebox_platform_lvbs/src/mshv/vsm.rs:115
--- failure pub_module_level_const_missing: pub module-level const is missing ---
Description:
A public const is missing or renamed
ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/pub_module_level_const_missing.ron
Failed in:
VTL1_CMDLINE_PAGE in file /home/runner/work/litebox/litebox/target/semver-checks/git-main/e218c7cc0b39b6a0402839f2d17ffb4c681921c3/litebox_platform_lvbs/src/mshv/vtl1_mem_layout.rs:58
HV_SECURE_VTL_BOOT_TOKEN in file /home/runner/work/litebox/litebox/target/semver-checks/git-main/e218c7cc0b39b6a0402839f2d17ffb4c681921c3/litebox_platform_lvbs/src/mshv/mod.rs:114
VTL1_TOTAL_MEMORY_SIZE in file /home/runner/work/litebox/litebox/target/semver-checks/git-main/e218c7cc0b39b6a0402839f2d17ffb4c681921c3/litebox_platform_lvbs/src/mshv/vtl1_mem_layout.rs:16
VTL1_BOOT_PARAMS_PAGE in file /home/runner/work/litebox/litebox/target/semver-checks/git-main/e218c7cc0b39b6a0402839f2d17ffb4c681921c3/litebox_platform_lvbs/src/mshv/vtl1_mem_layout.rs:57

[Sangho Lee (sangho2)]

No. though Angelina has a PR against this branch. Once this gets checked in, I will check in the other branch as well and then push in Angelina's PR

That sounds like a chicken-and-egg problem because I need the OP-TEE support for adding features and fixing some bugs. Anyway, seems that I need to maintain my own branch for a while.

[tgopinath-microsoft]

Simplify VTL1 boot sequence by

1. Removing the need for cmdline and bootparams pages
2. Removing the need for boot signal page to bring up secondary processors

[tgopinath-microsoft]

This need corresponding VTL0 Linux changes. Do not merge till that is ready. This was done as part of clean up for submitting the initial set of VTL0 patches upstream

[Sangho Lee (sangho2)]

Thanks! Overall, looks good to me. There is one uncertain change; let me test it as well.

[tgopinath-microsoft]

Thanks! Overall, looks good to me. There is one uncertain change; let me test it as well.

Thanks for the review ! If you want to test it , use the thara/project/lvbs/6.6/main branch in https://dev.azure.com/msazure/LSG-linux/_git/LSG-linux-rolling?_a=history . And use azl3_lvbs_main_config to build the config

[Sangho Lee (sangho2)]

Looks good to me. Seems that we need to revert or change the default COM port number.

[Sangho Lee (sangho2)]

Thanks! Overall, looks good to me. There is one uncertain change; let me test it as well.

Thanks for the review ! If you want to test it , use the thara/project/lvbs/6.6/main branch in https://dev.azure.com/msazure/LSG-linux/_git/LSG-linux-rolling?_a=history . And use azl3_lvbs_main_config to build the config

Thanks! Let me test it. One question: does this branch have OP-TEE support you've made as well?

[tgopinath-microsoft]

No. though Angelina has a PR against this branch. Once this gets checked in, I will check in the other branch as well and then push in Angelina's PR

[github-actions]

🤖 SemverChecks 🤖 ⚠️ Potential breaking API changes detected ⚠️

Click for details

--- failure enum_missing: pub enum removed or renamed ---
Description:
A publicly-visible enum cannot be imported by its prior path. A `pub use` may have been removed, or the enum itself may have been renamed or removed entirely.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/enum_missing.ron
Failed in:
enum litebox_platform_lvbs::mshv::vtl1_mem_layout::VtlMemoryError, previously in file /home/runner/work/litebox/litebox/target/semver-checks/git-main/e218c7cc0b39b6a0402839f2d17ffb4c681921c3/litebox_platform_lvbs/src/mshv/vtl1_mem_layout.rs:123
--- failure function_missing: pub fn removed or renamed ---
Description:
A publicly-visible function cannot be imported by its prior path. A `pub use` may have been removed, or the function itself may have been renamed or removed entirely.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/function_missing.ron
Failed in:
function litebox_platform_lvbs::host::bootparam::parse_boot_info, previously in file /home/runner/work/litebox/litebox/target/semver-checks/git-main/e218c7cc0b39b6a0402839f2d17ffb4c681921c3/litebox_platform_lvbs/src/host/bootparam.rs:178
--- failure function_parameter_count_changed: pub fn parameter count changed ---
Description:
A publicly-visible function now takes a different number of parameters.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/function_parameter_count_changed.ron
Failed in:
litebox_platform_lvbs::mshv::vsm::mshv_vsm_boot_aps now takes 1 parameters instead of 2, in /home/runner/work/litebox/litebox/litebox_platform_lvbs/src/mshv/vsm.rs:115
--- failure pub_module_level_const_missing: pub module-level const is missing ---
Description:
A public const is missing or renamed
ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/pub_module_level_const_missing.ron
Failed in:
VTL1_CMDLINE_PAGE in file /home/runner/work/litebox/litebox/target/semver-checks/git-main/e218c7cc0b39b6a0402839f2d17ffb4c681921c3/litebox_platform_lvbs/src/mshv/vtl1_mem_layout.rs:58
HV_SECURE_VTL_BOOT_TOKEN in file /home/runner/work/litebox/litebox/target/semver-checks/git-main/e218c7cc0b39b6a0402839f2d17ffb4c681921c3/litebox_platform_lvbs/src/mshv/mod.rs:114
VTL1_TOTAL_MEMORY_SIZE in file /home/runner/work/litebox/litebox/target/semver-checks/git-main/e218c7cc0b39b6a0402839f2d17ffb4c681921c3/litebox_platform_lvbs/src/mshv/vtl1_mem_layout.rs:16
VTL1_BOOT_PARAMS_PAGE in file /home/runner/work/litebox/litebox/target/semver-checks/git-main/e218c7cc0b39b6a0402839f2d17ffb4c681921c3/litebox_platform_lvbs/src/mshv/vtl1_mem_layout.rs:57

[Sangho Lee (sangho2)]

No. though Angelina has a PR against this branch. Once this gets checked in, I will check in the other branch as well and then push in Angelina's PR

That sounds like a chicken-and-egg problem because I need the OP-TEE support for adding features and fixing some bugs. Anyway, seems that I need to maintain my own branch for a while.

[tgopinath-microsoft]

Simplify VTL1 boot sequence by

1. Removing the need for cmdline and bootparams pages
2. Removing the need for boot signal page to bring up secondary processors

[tgopinath-microsoft]

This need corresponding VTL0 Linux changes. Do not merge till that is ready. This was done as part of clean up for submitting the initial set of VTL0 patches upstream

[Sangho Lee (sangho2)]

Thanks! Overall, looks good to me. There is one uncertain change; let me test it as well.

[tgopinath-microsoft]

Thanks! Overall, looks good to me. There is one uncertain change; let me test it as well.

Thanks for the review ! If you want to test it , use the thara/project/lvbs/6.6/main branch in https://dev.azure.com/msazure/LSG-linux/_git/LSG-linux-rolling?_a=history . And use azl3_lvbs_main_config to build the config

[Sangho Lee (sangho2)]

Looks good to me. Seems that we need to revert or change the default COM port number.

[Sangho Lee (sangho2)]

Thanks! Overall, looks good to me. There is one uncertain change; let me test it as well.

Thanks for the review ! If you want to test it , use the thara/project/lvbs/6.6/main branch in https://dev.azure.com/msazure/LSG-linux/_git/LSG-linux-rolling?_a=history . And use azl3_lvbs_main_config to build the config

Thanks! Let me test it. One question: does this branch have OP-TEE support you've made as well?

[tgopinath-microsoft]

No. though Angelina has a PR against this branch. Once this gets checked in, I will check in the other branch as well and then push in Angelina's PR

[github-actions]

🤖 SemverChecks 🤖 ⚠️ Potential breaking API changes detected ⚠️

Click for details

--- failure enum_missing: pub enum removed or renamed ---
Description:
A publicly-visible enum cannot be imported by its prior path. A `pub use` may have been removed, or the enum itself may have been renamed or removed entirely.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/enum_missing.ron
Failed in:
enum litebox_platform_lvbs::mshv::vtl1_mem_layout::VtlMemoryError, previously in file /home/runner/work/litebox/litebox/target/semver-checks/git-main/e218c7cc0b39b6a0402839f2d17ffb4c681921c3/litebox_platform_lvbs/src/mshv/vtl1_mem_layout.rs:123
--- failure function_missing: pub fn removed or renamed ---
Description:
A publicly-visible function cannot be imported by its prior path. A `pub use` may have been removed, or the function itself may have been renamed or removed entirely.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/function_missing.ron
Failed in:
function litebox_platform_lvbs::host::bootparam::parse_boot_info, previously in file /home/runner/work/litebox/litebox/target/semver-checks/git-main/e218c7cc0b39b6a0402839f2d17ffb4c681921c3/litebox_platform_lvbs/src/host/bootparam.rs:178
--- failure function_parameter_count_changed: pub fn parameter count changed ---
Description:
A publicly-visible function now takes a different number of parameters.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/function_parameter_count_changed.ron
Failed in:
litebox_platform_lvbs::mshv::vsm::mshv_vsm_boot_aps now takes 1 parameters instead of 2, in /home/runner/work/litebox/litebox/litebox_platform_lvbs/src/mshv/vsm.rs:115
--- failure pub_module_level_const_missing: pub module-level const is missing ---
Description:
A public const is missing or renamed
ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/pub_module_level_const_missing.ron
Failed in:
VTL1_CMDLINE_PAGE in file /home/runner/work/litebox/litebox/target/semver-checks/git-main/e218c7cc0b39b6a0402839f2d17ffb4c681921c3/litebox_platform_lvbs/src/mshv/vtl1_mem_layout.rs:58
HV_SECURE_VTL_BOOT_TOKEN in file /home/runner/work/litebox/litebox/target/semver-checks/git-main/e218c7cc0b39b6a0402839f2d17ffb4c681921c3/litebox_platform_lvbs/src/mshv/mod.rs:114
VTL1_TOTAL_MEMORY_SIZE in file /home/runner/work/litebox/litebox/target/semver-checks/git-main/e218c7cc0b39b6a0402839f2d17ffb4c681921c3/litebox_platform_lvbs/src/mshv/vtl1_mem_layout.rs:16
VTL1_BOOT_PARAMS_PAGE in file /home/runner/work/litebox/litebox/target/semver-checks/git-main/e218c7cc0b39b6a0402839f2d17ffb4c681921c3/litebox_platform_lvbs/src/mshv/vtl1_mem_layout.rs:57

[Sangho Lee (sangho2)]

No. though Angelina has a PR against this branch. Once this gets checked in, I will check in the other branch as well and then push in Angelina's PR

That sounds like a chicken-and-egg problem because I need the OP-TEE support for adding features and fixing some bugs. Anyway, seems that I need to maintain my own branch for a while.

[tgopinath-microsoft]

Simplify VTL1 boot sequence by

1. Removing the need for cmdline and bootparams pages
2. Removing the need for boot signal page to bring up secondary processors

[tgopinath-microsoft]

This need corresponding VTL0 Linux changes. Do not merge till that is ready. This was done as part of clean up for submitting the initial set of VTL0 patches upstream

[Sangho Lee (sangho2)]

Thanks! Overall, looks good to me. There is one uncertain change; let me test it as well.

[tgopinath-microsoft]

Thanks! Overall, looks good to me. There is one uncertain change; let me test it as well.

Thanks for the review ! If you want to test it , use the thara/project/lvbs/6.6/main branch in https://dev.azure.com/msazure/LSG-linux/_git/LSG-linux-rolling?_a=history . And use azl3_lvbs_main_config to build the config

[Sangho Lee (sangho2)]

Looks good to me. Seems that we need to revert or change the default COM port number.

[Sangho Lee (sangho2)]

Thanks! Overall, looks good to me. There is one uncertain change; let me test it as well.

Thanks for the review ! If you want to test it , use the thara/project/lvbs/6.6/main branch in https://dev.azure.com/msazure/LSG-linux/_git/LSG-linux-rolling?_a=history . And use azl3_lvbs_main_config to build the config

Thanks! Let me test it. One question: does this branch have OP-TEE support you've made as well?

[tgopinath-microsoft]

No. though Angelina has a PR against this branch. Once this gets checked in, I will check in the other branch as well and then push in Angelina's PR

[github-actions]

🤖 SemverChecks 🤖 ⚠️ Potential breaking API changes detected ⚠️

Click for details

--- failure enum_missing: pub enum removed or renamed ---
Description:
A publicly-visible enum cannot be imported by its prior path. A `pub use` may have been removed, or the enum itself may have been renamed or removed entirely.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/enum_missing.ron
Failed in:
enum litebox_platform_lvbs::mshv::vtl1_mem_layout::VtlMemoryError, previously in file /home/runner/work/litebox/litebox/target/semver-checks/git-main/e218c7cc0b39b6a0402839f2d17ffb4c681921c3/litebox_platform_lvbs/src/mshv/vtl1_mem_layout.rs:123
--- failure function_missing: pub fn removed or renamed ---
Description:
A publicly-visible function cannot be imported by its prior path. A `pub use` may have been removed, or the function itself may have been renamed or removed entirely.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/function_missing.ron
Failed in:
function litebox_platform_lvbs::host::bootparam::parse_boot_info, previously in file /home/runner/work/litebox/litebox/target/semver-checks/git-main/e218c7cc0b39b6a0402839f2d17ffb4c681921c3/litebox_platform_lvbs/src/host/bootparam.rs:178
--- failure function_parameter_count_changed: pub fn parameter count changed ---
Description:
A publicly-visible function now takes a different number of parameters.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/function_parameter_count_changed.ron
Failed in:
litebox_platform_lvbs::mshv::vsm::mshv_vsm_boot_aps now takes 1 parameters instead of 2, in /home/runner/work/litebox/litebox/litebox_platform_lvbs/src/mshv/vsm.rs:115
--- failure pub_module_level_const_missing: pub module-level const is missing ---
Description:
A public const is missing or renamed
ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/pub_module_level_const_missing.ron
Failed in:
VTL1_CMDLINE_PAGE in file /home/runner/work/litebox/litebox/target/semver-checks/git-main/e218c7cc0b39b6a0402839f2d17ffb4c681921c3/litebox_platform_lvbs/src/mshv/vtl1_mem_layout.rs:58
HV_SECURE_VTL_BOOT_TOKEN in file /home/runner/work/litebox/litebox/target/semver-checks/git-main/e218c7cc0b39b6a0402839f2d17ffb4c681921c3/litebox_platform_lvbs/src/mshv/mod.rs:114
VTL1_TOTAL_MEMORY_SIZE in file /home/runner/work/litebox/litebox/target/semver-checks/git-main/e218c7cc0b39b6a0402839f2d17ffb4c681921c3/litebox_platform_lvbs/src/mshv/vtl1_mem_layout.rs:16
VTL1_BOOT_PARAMS_PAGE in file /home/runner/work/litebox/litebox/target/semver-checks/git-main/e218c7cc0b39b6a0402839f2d17ffb4c681921c3/litebox_platform_lvbs/src/mshv/vtl1_mem_layout.rs:57

[Sangho Lee (sangho2)]

No. though Angelina has a PR against this branch. Once this gets checked in, I will check in the other branch as well and then push in Angelina's PR

That sounds like a chicken-and-egg problem because I need the OP-TEE support for adding features and fixing some bugs. Anyway, seems that I need to maintain my own branch for a while.