Parse attributes in extended VTL0 APIs by femiatl · Pull Request #653 · microsoft/litebox

Femi Adeyemi (femiatl) · 2026-02-09T19:49:51Z

VTL0 sends data to the secure kernel during and after initial boot. Use the new attributes parameter to extend load_kdata, allowing it to process data after boot and use the improved format for sending data from VTL0. Small, simple data buffers like certificates can be sent efficiently with the same APIs used for larger aggregated data like module info.

The new data format is leveraged to reduce the size of the kernel string table passed from ~10MB (all of rodata) to ~250KB.

The validate_module and validate_kexec APIs are extended to use the new attributes.

Sangho Lee (sangho2) · 2026-02-10T17:45:15Z

Femi Adeyemi (@femiatl) Could you please resolve the conflicts such that CI can work on this PR.

Sangho Lee (sangho2) · 2026-02-13T15:18:49Z

It seems that this change is based on new ABI to simplify data transfer. Good idea! As tgopinath-microsoft noted in #652, this cannot be merged yet.

One overall feedback or requested change: This PR needs some detailed comments to explain new ABI and data structures. Also, some functions are with old comments (e.g., these functions no longer get nranges), and some other functions are without any comments.

VTL0 sends data to the secure kernel during and after initial boot. Use the new attributes parameter to extend load_kdata, allowing it to process data after boot and use the improved format for sending data from VTL0. Small, simple data buffers like certificates can be sent efficiently with the same APIs used for larger aggregated data like module info. The new data format is leveraged to reduce the size of the kernel string table passed from ~10MB (all of rodata) to ~250KB. The validate_module and validate_kexec APIs are extended to use the new attributes.

- Updata modular_field crate to latest to fix warnings - Rename attr field in HekiData range to mem_attr to reflect usage - Resize HekiDatRange to take more ranges per page - Rename and refactor HekiDataAttr to HekiDataApiAttr to clarify usage - Add comments for updated public functions and update parameter names - Add convenience data page iterator to simplyfy processing

Latest modular_bitfield generates warnings

github-actions · 2026-02-25T11:19:03Z

🤖 SemverChecks 🤖 ⚠️ Potential breaking API changes detected ⚠️

Click for details

--- failure function_parameter_count_changed: pub fn parameter count changed ---
Description:
A publicly-visible function now takes a different number of parameters.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.46.0/src/lints/function_parameter_count_changed.ron
Failed in:
litebox_platform_lvbs::mshv::vsm::mshv_vsm_protect_memory now takes 3 parameters instead of 2, in /home/runner/work/litebox/litebox/litebox_platform_lvbs/src/mshv/vsm.rs:266
litebox_platform_lvbs::mshv::vsm::mshv_vsm_load_kdata now takes 3 parameters instead of 2, in /home/runner/work/litebox/litebox/litebox_platform_lvbs/src/mshv/vsm.rs:348
--- failure inherent_method_missing: pub method removed or renamed ---
Description:
A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.46.0/src/lints/inherent_method_missing.ron
Failed in:
Symbol::from_bytes, previously in file /home/runner/work/litebox/litebox/target/semver-checks/git-main/075ab7c6d077e0d81bb34571e3dec9b66e93a36a/litebox_platform_lvbs/src/mshv/vsm.rs:1766
--- failure method_parameter_count_changed: pub method parameter count changed ---
Description:
A publicly-visible method now takes a different number of parameters, not counting the receiver (self) parameter.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.46.0/src/lints/method_parameter_count_changed.ron
Failed in:
litebox_platform_lvbs::mshv::vsm::SymbolTable::build_from_container now takes 2 parameters instead of 4, in /home/runner/work/litebox/litebox/litebox_platform_lvbs/src/mshv/vsm.rs:1864

Femi Adeyemi (femiatl) · 2026-02-09T19:49:51Z

VTL0 sends data to the secure kernel during and after initial boot. Use the new attributes parameter to extend load_kdata, allowing it to process data after boot and use the improved format for sending data from VTL0. Small, simple data buffers like certificates can be sent efficiently with the same APIs used for larger aggregated data like module info.

The new data format is leveraged to reduce the size of the kernel string table passed from ~10MB (all of rodata) to ~250KB.

The validate_module and validate_kexec APIs are extended to use the new attributes.

Sangho Lee (sangho2) · 2026-02-10T17:45:15Z

Femi Adeyemi (@femiatl) Could you please resolve the conflicts such that CI can work on this PR.

Sangho Lee (sangho2) · 2026-02-13T15:18:49Z

It seems that this change is based on new ABI to simplify data transfer. Good idea! As tgopinath-microsoft noted in #652, this cannot be merged yet.

One overall feedback or requested change: This PR needs some detailed comments to explain new ABI and data structures. Also, some functions are with old comments (e.g., these functions no longer get nranges), and some other functions are without any comments.

VTL0 sends data to the secure kernel during and after initial boot. Use the new attributes parameter to extend load_kdata, allowing it to process data after boot and use the improved format for sending data from VTL0. Small, simple data buffers like certificates can be sent efficiently with the same APIs used for larger aggregated data like module info. The new data format is leveraged to reduce the size of the kernel string table passed from ~10MB (all of rodata) to ~250KB. The validate_module and validate_kexec APIs are extended to use the new attributes.

- Updata modular_field crate to latest to fix warnings - Rename attr field in HekiData range to mem_attr to reflect usage - Resize HekiDatRange to take more ranges per page - Rename and refactor HekiDataAttr to HekiDataApiAttr to clarify usage - Add comments for updated public functions and update parameter names - Add convenience data page iterator to simplyfy processing

Latest modular_bitfield generates warnings

github-actions · 2026-02-25T11:19:03Z

🤖 SemverChecks 🤖 ⚠️ Potential breaking API changes detected ⚠️

Click for details

--- failure function_parameter_count_changed: pub fn parameter count changed ---
Description:
A publicly-visible function now takes a different number of parameters.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.46.0/src/lints/function_parameter_count_changed.ron
Failed in:
litebox_platform_lvbs::mshv::vsm::mshv_vsm_protect_memory now takes 3 parameters instead of 2, in /home/runner/work/litebox/litebox/litebox_platform_lvbs/src/mshv/vsm.rs:266
litebox_platform_lvbs::mshv::vsm::mshv_vsm_load_kdata now takes 3 parameters instead of 2, in /home/runner/work/litebox/litebox/litebox_platform_lvbs/src/mshv/vsm.rs:348
--- failure inherent_method_missing: pub method removed or renamed ---
Description:
A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.46.0/src/lints/inherent_method_missing.ron
Failed in:
Symbol::from_bytes, previously in file /home/runner/work/litebox/litebox/target/semver-checks/git-main/075ab7c6d077e0d81bb34571e3dec9b66e93a36a/litebox_platform_lvbs/src/mshv/vsm.rs:1766
--- failure method_parameter_count_changed: pub method parameter count changed ---
Description:
A publicly-visible method now takes a different number of parameters, not counting the receiver (self) parameter.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.46.0/src/lints/method_parameter_count_changed.ron
Failed in:
litebox_platform_lvbs::mshv::vsm::SymbolTable::build_from_container now takes 2 parameters instead of 4, in /home/runner/work/litebox/litebox/litebox_platform_lvbs/src/mshv/vsm.rs:1864

Femi Adeyemi (femiatl) · 2026-02-09T19:49:51Z

VTL0 sends data to the secure kernel during and after initial boot. Use the new attributes parameter to extend load_kdata, allowing it to process data after boot and use the improved format for sending data from VTL0. Small, simple data buffers like certificates can be sent efficiently with the same APIs used for larger aggregated data like module info.

The new data format is leveraged to reduce the size of the kernel string table passed from ~10MB (all of rodata) to ~250KB.

The validate_module and validate_kexec APIs are extended to use the new attributes.

Sangho Lee (sangho2) · 2026-02-10T17:45:15Z

Femi Adeyemi (@femiatl) Could you please resolve the conflicts such that CI can work on this PR.

Sangho Lee (sangho2) · 2026-02-13T15:18:49Z

It seems that this change is based on new ABI to simplify data transfer. Good idea! As tgopinath-microsoft noted in #652, this cannot be merged yet.

One overall feedback or requested change: This PR needs some detailed comments to explain new ABI and data structures. Also, some functions are with old comments (e.g., these functions no longer get nranges), and some other functions are without any comments.

VTL0 sends data to the secure kernel during and after initial boot. Use the new attributes parameter to extend load_kdata, allowing it to process data after boot and use the improved format for sending data from VTL0. Small, simple data buffers like certificates can be sent efficiently with the same APIs used for larger aggregated data like module info. The new data format is leveraged to reduce the size of the kernel string table passed from ~10MB (all of rodata) to ~250KB. The validate_module and validate_kexec APIs are extended to use the new attributes.

- Updata modular_field crate to latest to fix warnings - Rename attr field in HekiData range to mem_attr to reflect usage - Resize HekiDatRange to take more ranges per page - Rename and refactor HekiDataAttr to HekiDataApiAttr to clarify usage - Add comments for updated public functions and update parameter names - Add convenience data page iterator to simplyfy processing

Latest modular_bitfield generates warnings

github-actions · 2026-02-25T11:19:03Z

🤖 SemverChecks 🤖 ⚠️ Potential breaking API changes detected ⚠️

Click for details

--- failure function_parameter_count_changed: pub fn parameter count changed ---
Description:
A publicly-visible function now takes a different number of parameters.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.46.0/src/lints/function_parameter_count_changed.ron
Failed in:
litebox_platform_lvbs::mshv::vsm::mshv_vsm_protect_memory now takes 3 parameters instead of 2, in /home/runner/work/litebox/litebox/litebox_platform_lvbs/src/mshv/vsm.rs:266
litebox_platform_lvbs::mshv::vsm::mshv_vsm_load_kdata now takes 3 parameters instead of 2, in /home/runner/work/litebox/litebox/litebox_platform_lvbs/src/mshv/vsm.rs:348
--- failure inherent_method_missing: pub method removed or renamed ---
Description:
A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.46.0/src/lints/inherent_method_missing.ron
Failed in:
Symbol::from_bytes, previously in file /home/runner/work/litebox/litebox/target/semver-checks/git-main/075ab7c6d077e0d81bb34571e3dec9b66e93a36a/litebox_platform_lvbs/src/mshv/vsm.rs:1766
--- failure method_parameter_count_changed: pub method parameter count changed ---
Description:
A publicly-visible method now takes a different number of parameters, not counting the receiver (self) parameter.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.46.0/src/lints/method_parameter_count_changed.ron
Failed in:
litebox_platform_lvbs::mshv::vsm::SymbolTable::build_from_container now takes 2 parameters instead of 4, in /home/runner/work/litebox/litebox/litebox_platform_lvbs/src/mshv/vsm.rs:1864

Femi Adeyemi (femiatl) · 2026-02-09T19:49:51Z

VTL0 sends data to the secure kernel during and after initial boot. Use the new attributes parameter to extend load_kdata, allowing it to process data after boot and use the improved format for sending data from VTL0. Small, simple data buffers like certificates can be sent efficiently with the same APIs used for larger aggregated data like module info.

The new data format is leveraged to reduce the size of the kernel string table passed from ~10MB (all of rodata) to ~250KB.

The validate_module and validate_kexec APIs are extended to use the new attributes.

Sangho Lee (sangho2) · 2026-02-10T17:45:15Z

Femi Adeyemi (@femiatl) Could you please resolve the conflicts such that CI can work on this PR.

Sangho Lee (sangho2) · 2026-02-13T15:18:49Z

It seems that this change is based on new ABI to simplify data transfer. Good idea! As tgopinath-microsoft noted in #652, this cannot be merged yet.

One overall feedback or requested change: This PR needs some detailed comments to explain new ABI and data structures. Also, some functions are with old comments (e.g., these functions no longer get nranges), and some other functions are without any comments.

VTL0 sends data to the secure kernel during and after initial boot. Use the new attributes parameter to extend load_kdata, allowing it to process data after boot and use the improved format for sending data from VTL0. Small, simple data buffers like certificates can be sent efficiently with the same APIs used for larger aggregated data like module info. The new data format is leveraged to reduce the size of the kernel string table passed from ~10MB (all of rodata) to ~250KB. The validate_module and validate_kexec APIs are extended to use the new attributes.

- Updata modular_field crate to latest to fix warnings - Rename attr field in HekiData range to mem_attr to reflect usage - Resize HekiDatRange to take more ranges per page - Rename and refactor HekiDataAttr to HekiDataApiAttr to clarify usage - Add comments for updated public functions and update parameter names - Add convenience data page iterator to simplyfy processing

Latest modular_bitfield generates warnings

github-actions · 2026-02-25T11:19:03Z

🤖 SemverChecks 🤖 ⚠️ Potential breaking API changes detected ⚠️

Click for details

--- failure function_parameter_count_changed: pub fn parameter count changed ---
Description:
A publicly-visible function now takes a different number of parameters.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.46.0/src/lints/function_parameter_count_changed.ron
Failed in:
litebox_platform_lvbs::mshv::vsm::mshv_vsm_protect_memory now takes 3 parameters instead of 2, in /home/runner/work/litebox/litebox/litebox_platform_lvbs/src/mshv/vsm.rs:266
litebox_platform_lvbs::mshv::vsm::mshv_vsm_load_kdata now takes 3 parameters instead of 2, in /home/runner/work/litebox/litebox/litebox_platform_lvbs/src/mshv/vsm.rs:348
--- failure inherent_method_missing: pub method removed or renamed ---
Description:
A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.46.0/src/lints/inherent_method_missing.ron
Failed in:
Symbol::from_bytes, previously in file /home/runner/work/litebox/litebox/target/semver-checks/git-main/075ab7c6d077e0d81bb34571e3dec9b66e93a36a/litebox_platform_lvbs/src/mshv/vsm.rs:1766
--- failure method_parameter_count_changed: pub method parameter count changed ---
Description:
A publicly-visible method now takes a different number of parameters, not counting the receiver (self) parameter.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.46.0/src/lints/method_parameter_count_changed.ron
Failed in:
litebox_platform_lvbs::mshv::vsm::SymbolTable::build_from_container now takes 2 parameters instead of 4, in /home/runner/work/litebox/litebox/litebox_platform_lvbs/src/mshv/vsm.rs:1864

Femi Adeyemi (femiatl) · 2026-02-09T19:49:51Z

VTL0 sends data to the secure kernel during and after initial boot. Use the new attributes parameter to extend load_kdata, allowing it to process data after boot and use the improved format for sending data from VTL0. Small, simple data buffers like certificates can be sent efficiently with the same APIs used for larger aggregated data like module info.

The new data format is leveraged to reduce the size of the kernel string table passed from ~10MB (all of rodata) to ~250KB.

The validate_module and validate_kexec APIs are extended to use the new attributes.

Sangho Lee (sangho2) · 2026-02-10T17:45:15Z

Femi Adeyemi (@femiatl) Could you please resolve the conflicts such that CI can work on this PR.

Sangho Lee (sangho2) · 2026-02-13T15:18:49Z

It seems that this change is based on new ABI to simplify data transfer. Good idea! As tgopinath-microsoft noted in #652, this cannot be merged yet.

One overall feedback or requested change: This PR needs some detailed comments to explain new ABI and data structures. Also, some functions are with old comments (e.g., these functions no longer get nranges), and some other functions are without any comments.

VTL0 sends data to the secure kernel during and after initial boot. Use the new attributes parameter to extend load_kdata, allowing it to process data after boot and use the improved format for sending data from VTL0. Small, simple data buffers like certificates can be sent efficiently with the same APIs used for larger aggregated data like module info. The new data format is leveraged to reduce the size of the kernel string table passed from ~10MB (all of rodata) to ~250KB. The validate_module and validate_kexec APIs are extended to use the new attributes.

- Updata modular_field crate to latest to fix warnings - Rename attr field in HekiData range to mem_attr to reflect usage - Resize HekiDatRange to take more ranges per page - Rename and refactor HekiDataAttr to HekiDataApiAttr to clarify usage - Add comments for updated public functions and update parameter names - Add convenience data page iterator to simplyfy processing

Latest modular_bitfield generates warnings

github-actions · 2026-02-25T11:19:03Z

🤖 SemverChecks 🤖 ⚠️ Potential breaking API changes detected ⚠️

Click for details

--- failure function_parameter_count_changed: pub fn parameter count changed ---
Description:
A publicly-visible function now takes a different number of parameters.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.46.0/src/lints/function_parameter_count_changed.ron
Failed in:
litebox_platform_lvbs::mshv::vsm::mshv_vsm_protect_memory now takes 3 parameters instead of 2, in /home/runner/work/litebox/litebox/litebox_platform_lvbs/src/mshv/vsm.rs:266
litebox_platform_lvbs::mshv::vsm::mshv_vsm_load_kdata now takes 3 parameters instead of 2, in /home/runner/work/litebox/litebox/litebox_platform_lvbs/src/mshv/vsm.rs:348
--- failure inherent_method_missing: pub method removed or renamed ---
Description:
A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.46.0/src/lints/inherent_method_missing.ron
Failed in:
Symbol::from_bytes, previously in file /home/runner/work/litebox/litebox/target/semver-checks/git-main/075ab7c6d077e0d81bb34571e3dec9b66e93a36a/litebox_platform_lvbs/src/mshv/vsm.rs:1766
--- failure method_parameter_count_changed: pub method parameter count changed ---
Description:
A publicly-visible method now takes a different number of parameters, not counting the receiver (self) parameter.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.46.0/src/lints/method_parameter_count_changed.ron
Failed in:
litebox_platform_lvbs::mshv::vsm::SymbolTable::build_from_container now takes 2 parameters instead of 4, in /home/runner/work/litebox/litebox/litebox_platform_lvbs/src/mshv/vsm.rs:1864

Femi Adeyemi (femiatl) · 2026-02-09T19:49:51Z

VTL0 sends data to the secure kernel during and after initial boot. Use the new attributes parameter to extend load_kdata, allowing it to process data after boot and use the improved format for sending data from VTL0. Small, simple data buffers like certificates can be sent efficiently with the same APIs used for larger aggregated data like module info.

The new data format is leveraged to reduce the size of the kernel string table passed from ~10MB (all of rodata) to ~250KB.

The validate_module and validate_kexec APIs are extended to use the new attributes.

Sangho Lee (sangho2) · 2026-02-10T17:45:15Z

Femi Adeyemi (@femiatl) Could you please resolve the conflicts such that CI can work on this PR.

Sangho Lee (sangho2) · 2026-02-13T15:18:49Z

It seems that this change is based on new ABI to simplify data transfer. Good idea! As tgopinath-microsoft noted in #652, this cannot be merged yet.

One overall feedback or requested change: This PR needs some detailed comments to explain new ABI and data structures. Also, some functions are with old comments (e.g., these functions no longer get nranges), and some other functions are without any comments.

VTL0 sends data to the secure kernel during and after initial boot. Use the new attributes parameter to extend load_kdata, allowing it to process data after boot and use the improved format for sending data from VTL0. Small, simple data buffers like certificates can be sent efficiently with the same APIs used for larger aggregated data like module info. The new data format is leveraged to reduce the size of the kernel string table passed from ~10MB (all of rodata) to ~250KB. The validate_module and validate_kexec APIs are extended to use the new attributes.

- Updata modular_field crate to latest to fix warnings - Rename attr field in HekiData range to mem_attr to reflect usage - Resize HekiDatRange to take more ranges per page - Rename and refactor HekiDataAttr to HekiDataApiAttr to clarify usage - Add comments for updated public functions and update parameter names - Add convenience data page iterator to simplyfy processing

Latest modular_bitfield generates warnings

github-actions · 2026-02-25T11:19:03Z

🤖 SemverChecks 🤖 ⚠️ Potential breaking API changes detected ⚠️

Click for details

--- failure function_parameter_count_changed: pub fn parameter count changed ---
Description:
A publicly-visible function now takes a different number of parameters.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.46.0/src/lints/function_parameter_count_changed.ron
Failed in:
litebox_platform_lvbs::mshv::vsm::mshv_vsm_protect_memory now takes 3 parameters instead of 2, in /home/runner/work/litebox/litebox/litebox_platform_lvbs/src/mshv/vsm.rs:266
litebox_platform_lvbs::mshv::vsm::mshv_vsm_load_kdata now takes 3 parameters instead of 2, in /home/runner/work/litebox/litebox/litebox_platform_lvbs/src/mshv/vsm.rs:348
--- failure inherent_method_missing: pub method removed or renamed ---
Description:
A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.46.0/src/lints/inherent_method_missing.ron
Failed in:
Symbol::from_bytes, previously in file /home/runner/work/litebox/litebox/target/semver-checks/git-main/075ab7c6d077e0d81bb34571e3dec9b66e93a36a/litebox_platform_lvbs/src/mshv/vsm.rs:1766
--- failure method_parameter_count_changed: pub method parameter count changed ---
Description:
A publicly-visible method now takes a different number of parameters, not counting the receiver (self) parameter.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.46.0/src/lints/method_parameter_count_changed.ron
Failed in:
litebox_platform_lvbs::mshv::vsm::SymbolTable::build_from_container now takes 2 parameters instead of 4, in /home/runner/work/litebox/litebox/litebox_platform_lvbs/src/mshv/vsm.rs:1864

Femi Adeyemi (femiatl) · 2026-02-09T19:49:51Z

VTL0 sends data to the secure kernel during and after initial boot. Use the new attributes parameter to extend load_kdata, allowing it to process data after boot and use the improved format for sending data from VTL0. Small, simple data buffers like certificates can be sent efficiently with the same APIs used for larger aggregated data like module info.

The new data format is leveraged to reduce the size of the kernel string table passed from ~10MB (all of rodata) to ~250KB.

The validate_module and validate_kexec APIs are extended to use the new attributes.

Sangho Lee (sangho2) · 2026-02-10T17:45:15Z

Femi Adeyemi (@femiatl) Could you please resolve the conflicts such that CI can work on this PR.

Sangho Lee (sangho2) · 2026-02-13T15:18:49Z

It seems that this change is based on new ABI to simplify data transfer. Good idea! As tgopinath-microsoft noted in #652, this cannot be merged yet.

One overall feedback or requested change: This PR needs some detailed comments to explain new ABI and data structures. Also, some functions are with old comments (e.g., these functions no longer get nranges), and some other functions are without any comments.

VTL0 sends data to the secure kernel during and after initial boot. Use the new attributes parameter to extend load_kdata, allowing it to process data after boot and use the improved format for sending data from VTL0. Small, simple data buffers like certificates can be sent efficiently with the same APIs used for larger aggregated data like module info. The new data format is leveraged to reduce the size of the kernel string table passed from ~10MB (all of rodata) to ~250KB. The validate_module and validate_kexec APIs are extended to use the new attributes.

- Updata modular_field crate to latest to fix warnings - Rename attr field in HekiData range to mem_attr to reflect usage - Resize HekiDatRange to take more ranges per page - Rename and refactor HekiDataAttr to HekiDataApiAttr to clarify usage - Add comments for updated public functions and update parameter names - Add convenience data page iterator to simplyfy processing

Latest modular_bitfield generates warnings

github-actions · 2026-02-25T11:19:03Z

🤖 SemverChecks 🤖 ⚠️ Potential breaking API changes detected ⚠️

Click for details

--- failure function_parameter_count_changed: pub fn parameter count changed ---
Description:
A publicly-visible function now takes a different number of parameters.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.46.0/src/lints/function_parameter_count_changed.ron
Failed in:
litebox_platform_lvbs::mshv::vsm::mshv_vsm_protect_memory now takes 3 parameters instead of 2, in /home/runner/work/litebox/litebox/litebox_platform_lvbs/src/mshv/vsm.rs:266
litebox_platform_lvbs::mshv::vsm::mshv_vsm_load_kdata now takes 3 parameters instead of 2, in /home/runner/work/litebox/litebox/litebox_platform_lvbs/src/mshv/vsm.rs:348
--- failure inherent_method_missing: pub method removed or renamed ---
Description:
A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.46.0/src/lints/inherent_method_missing.ron
Failed in:
Symbol::from_bytes, previously in file /home/runner/work/litebox/litebox/target/semver-checks/git-main/075ab7c6d077e0d81bb34571e3dec9b66e93a36a/litebox_platform_lvbs/src/mshv/vsm.rs:1766
--- failure method_parameter_count_changed: pub method parameter count changed ---
Description:
A publicly-visible method now takes a different number of parameters, not counting the receiver (self) parameter.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.46.0/src/lints/method_parameter_count_changed.ron
Failed in:
litebox_platform_lvbs::mshv::vsm::SymbolTable::build_from_container now takes 2 parameters instead of 4, in /home/runner/work/litebox/litebox/litebox_platform_lvbs/src/mshv/vsm.rs:1864

Femi Adeyemi (femiatl) · 2026-02-09T19:49:51Z

VTL0 sends data to the secure kernel during and after initial boot. Use the new attributes parameter to extend load_kdata, allowing it to process data after boot and use the improved format for sending data from VTL0. Small, simple data buffers like certificates can be sent efficiently with the same APIs used for larger aggregated data like module info.

The new data format is leveraged to reduce the size of the kernel string table passed from ~10MB (all of rodata) to ~250KB.

The validate_module and validate_kexec APIs are extended to use the new attributes.

Sangho Lee (sangho2) · 2026-02-10T17:45:15Z

Femi Adeyemi (@femiatl) Could you please resolve the conflicts such that CI can work on this PR.

Sangho Lee (sangho2) · 2026-02-13T15:18:49Z

It seems that this change is based on new ABI to simplify data transfer. Good idea! As tgopinath-microsoft noted in #652, this cannot be merged yet.

One overall feedback or requested change: This PR needs some detailed comments to explain new ABI and data structures. Also, some functions are with old comments (e.g., these functions no longer get nranges), and some other functions are without any comments.

VTL0 sends data to the secure kernel during and after initial boot. Use the new attributes parameter to extend load_kdata, allowing it to process data after boot and use the improved format for sending data from VTL0. Small, simple data buffers like certificates can be sent efficiently with the same APIs used for larger aggregated data like module info. The new data format is leveraged to reduce the size of the kernel string table passed from ~10MB (all of rodata) to ~250KB. The validate_module and validate_kexec APIs are extended to use the new attributes.

- Updata modular_field crate to latest to fix warnings - Rename attr field in HekiData range to mem_attr to reflect usage - Resize HekiDatRange to take more ranges per page - Rename and refactor HekiDataAttr to HekiDataApiAttr to clarify usage - Add comments for updated public functions and update parameter names - Add convenience data page iterator to simplyfy processing

Latest modular_bitfield generates warnings

github-actions · 2026-02-25T11:19:03Z

🤖 SemverChecks 🤖 ⚠️ Potential breaking API changes detected ⚠️

Click for details

--- failure function_parameter_count_changed: pub fn parameter count changed ---
Description:
A publicly-visible function now takes a different number of parameters.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.46.0/src/lints/function_parameter_count_changed.ron
Failed in:
litebox_platform_lvbs::mshv::vsm::mshv_vsm_protect_memory now takes 3 parameters instead of 2, in /home/runner/work/litebox/litebox/litebox_platform_lvbs/src/mshv/vsm.rs:266
litebox_platform_lvbs::mshv::vsm::mshv_vsm_load_kdata now takes 3 parameters instead of 2, in /home/runner/work/litebox/litebox/litebox_platform_lvbs/src/mshv/vsm.rs:348
--- failure inherent_method_missing: pub method removed or renamed ---
Description:
A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.46.0/src/lints/inherent_method_missing.ron
Failed in:
Symbol::from_bytes, previously in file /home/runner/work/litebox/litebox/target/semver-checks/git-main/075ab7c6d077e0d81bb34571e3dec9b66e93a36a/litebox_platform_lvbs/src/mshv/vsm.rs:1766
--- failure method_parameter_count_changed: pub method parameter count changed ---
Description:
A publicly-visible method now takes a different number of parameters, not counting the receiver (self) parameter.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.46.0/src/lints/method_parameter_count_changed.ron
Failed in:
litebox_platform_lvbs::mshv::vsm::SymbolTable::build_from_container now takes 2 parameters instead of 4, in /home/runner/work/litebox/litebox/litebox_platform_lvbs/src/mshv/vsm.rs:1864

Femi Adeyemi (femiatl) requested review from Angelina Vu (athvu), karissanchez, Sangho Lee (sangho2) and tgopinath-microsoft February 9, 2026 19:49

Femi Adeyemi (femiatl) self-assigned this Feb 9, 2026

Femi Adeyemi (femiatl)force-pushed the femia/lvbs/pagewalk branch 3 times, most recently from 54e3a52 to d4626b2Compare February 11, 2026 02:49

Sangho Lee (sangho2) reviewed Feb 13, 2026
View reviewed changes

Comment threadlitebox_platform_lvbs/src/mshv/vsm.rs Outdated

Femi Adeyemi (femiatl)force-pushed the femia/lvbs/pagewalk branch 2 times, most recently from 3a4f589 to 73eb949Compare February 23, 2026 16:17

Femi Adeyemi (femiatl) added 2 commits February 23, 2026 16:24

Femi Adeyemi (femiatl)force-pushed the femia/lvbs/pagewalk branch from 73eb949 to c7c723cCompare February 23, 2026 16:29

Fix Clippy warning
f9aaae3
Latest modular_bitfield generates warnings