') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); feat: add failOnStatusCode option to API request context by JacksonLei123 · Pull Request #34346 · microsoft/playwright · GitHub
Skip to content

feat: add failOnStatusCode option to API request context - #34346

Merged
Yury Semikhatsky (yury-s) merged 15 commits into
microsoft:mainfrom
JacksonLei123:main
Feb 11, 2025
Merged

feat: add failOnStatusCode option to API request context#34346
Yury Semikhatsky (yury-s) merged 15 commits into
microsoft:mainfrom
JacksonLei123:main

Conversation

@JacksonLei123

@JacksonLei123JacksonLei123 commented Jan 15, 2025

Copy link
Copy Markdown
Contributor

Add failOnStatusCode option to API request context so that the flag is applied to every request made unless specified.

References issue #34204

@github-actions

This comment has been minimized.

Sign in to view
yury-s
Yury Semikhatsky (yury-s) reviewed Jan 15, 2025
View reviewed changes
Comment threaddocs/src/api/params.md Outdated
Comment threadtests/library/global-fetch.spec.ts Outdated
Comment threadtests/library/global-fetch.spec.ts Outdated
yury-s
Yury Semikhatsky (yury-s) reviewed Jan 17, 2025
View reviewed changes
Comment threadpackages/playwright-core/types/types.d.ts Outdated
Comment threaddocs/src/api/params.md Outdated
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@Skn0tt

Simon Knott (Skn0tt) commented Feb 5, 2025

Copy link
Copy Markdown
Contributor

Hi JacksonLei123! The code looks generally good, but CI is failing because there's a mismatch in the generated files. Could you run npm run build and commit the generated files?

@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
yury-s
Yury Semikhatsky (yury-s) approved these changes Feb 11, 2025
View reviewed changes
Comment threaddocs/src/api/params.md Outdated
Comment threadtests/library/global-fetch.spec.ts Outdated
JacksonLei123and others added 2 commits February 10, 2025 22:43
@JacksonLei123@yury-s
Update tests/library/global-fetch.spec.ts
b42bf79
Co-authored-by: Yury Semikhatsky <yurys@chromium.org>
Signed-off-by: JacksonLei123 <46788895+JacksonLei123@users.noreply.github.com>
@JacksonLei123
fix: lint fixes from suggested commit
ee59e0f
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

github-actionsBot commented Feb 11, 2025

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

9 flaky⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [playwright-test] › tests/ui-mode-test-output.spec.ts:80:5 › should show console messages for test @macos-latest-node18-1
⚠️ [playwright-test] › tests/ui-mode-test-watch.spec.ts:145:5 › should watch all @ubuntu-latest-node18-1
⚠️ [webkit-page] › tests/page/page-leaks.spec.ts:82:5 › click should not leak @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-leaks.spec.ts:107:5 › fill should not leak @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-leaks.spec.ts:161:5 › waitFor should not leak @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-set-input-files.spec.ts:205:3 › should upload multiple large files @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › tests/ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

37883 passed, 654 skipped
✔️✔️✔️

Merge workflow run.

yury-s
Yury Semikhatsky (yury-s) approved these changes Feb 11, 2025
View reviewed changes
Comment threadtests/library/browsercontext-fetchFailOnStatusCode.spec.ts

@yury-sYury Semikhatsky (yury-s)Feb 11, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should probably be renamed in accord with the new name of the property.

@yury-s
Yury Semikhatsky (yury-s) merged commit 5a76b17 into microsoft:mainFeb 11, 2025
This was referenced Feb 11, 2025
Closed
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yury-sYury Semikhatsky (yury-s)yury-s approved these changes
@Skn0ttSimon Knott (Skn0tt)Awaiting requested review from Skn0tt

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JacksonLei123@Skn0tt@yury-s