feat(electron): add timeout option to electronApp.close() by SebTardif · Pull Request #40587 · microsoft/playwright

Sebastien Tardif (SebTardif) · 2026-05-03T19:47:56Z

Summary

Adds an opt-in timeout option to electronApp.close() that force-kills the Electron process when the graceful shutdown exceeds the specified deadline.

Fixes#40586

Motivation

electronApp.close() waits indefinitely for the process to exit. If the application prevents shutdown (via before-quit handlers, leaky IPC, or lingering child processes), close() hangs until the test-level timeout fires. This is a recurring issue in CI environments:

[Question] Call app.quit() in Electron but process sticks around #12189 — app.quit() called but process sticks around
[REGRESSION]: electron tests sometimes freezes for 30 seconds #27523 — Electron tests freeze 30s on close
[Bug]: Leaky Electron IPC handlers cause tests to hang on Linux/Windows #39248 — Leaky IPC handlers cause hangs
[BUG] - Electron hangs closing the context #13874 — Electron hangs closing context

PR #11336 correctly removed the old hardcoded 30s timeout, but left no way to opt into a grace period with force-kill escalation.

API

// Default: unchanged — waits indefinitelyawaitelectronApp.close();// With timeout: force-kills if app does not exit within 10sawaitelectronApp.close({timeout: 10_000});

Implementation

Minimal change — wires the existing kill function from processLauncher into ElectronApplication:

electron.ts: ElectronApplication constructor now receives the kill function from launchProcess
close(): When timeout is set, starts a timer that calls kill() (SIGKILL on Unix, taskkill /T /F on Windows). If the process exits gracefully before the timer, clearTimeout cancels the force-kill. No new kill logic — reuses existing infrastructure in processLauncher.ts.
Backward compatible: Without timeout, behavior is identical to before.

Key difference from the removed PR #11336 behavior:

Old: hardcoded 30s timeout that threw an error and left the process running
New: opt-in timeout that force-kills and waits for cleanup — the caller always gets a clean exit

Test Plan

should force-kill app when close timeout is exceeded — Uses a test app with a before-quit handler that prevents shutdown. Verifies close({ timeout: 3000 }) successfully kills the process and emits all expected events.
should not force-kill when app closes within timeout — Verifies a normal app closes gracefully when a generous timeout is specified.

Files Changed

File	Change
`packages/playwright-core/src/electron/electron.ts`	Pass `kill` to constructor, add `timeout` option to `close()`
`docs/src/electron-api/class-electronapplication.md`	Document the new `timeout` option
`packages/playwright-core/types/types.d.ts`	Auto-generated from docs
`packages/playwright-client/types/types.d.ts`	Auto-generated from docs
`tests/electron/electron-app-hang-on-close.js`	Test fixture: Electron app that prevents quit
`tests/electron/electron-app.spec.ts`	Two new tests for timeout behavior

When an Electron app does not exit cleanly (e.g. before-quit handlers that prevent shutdown, leaky IPC handlers, or child processes), close() hangs indefinitely. This adds an opt-in timeout option that escalates to force-kill (SIGKILL/taskkill) when exceeded. Default behavior is unchanged — no timeout means wait forever. The implementation wires the existing kill() function from processLauncher into ElectronApplication, so no new kill logic is introduced. Fixesmicrosoft#40586

Sebastien Tardif (SebTardif) · 2026-05-03T19:52:31Z

@microsoft-github-policy-service agree

Sebastien Tardif (SebTardif) · 2026-05-03T19:52:36Z

@microsoft-github-policy-service agree

Pavel Feldman (pavelfeldman) · 2026-05-04T22:46:50Z

- await this._closedPromise;
+
+ if (options?.timeout) {
+ const timer = setTimeout(() => this._kill().catch(() => {}), options.timeout);


My agent did a better job than yours - you are not awaiting kill here. Closing in favor of #40613.

It's rude and funny at the same time...

Sebastien Tardif (SebTardif) · 2026-05-03T19:47:56Z

Summary

Adds an opt-in timeout option to electronApp.close() that force-kills the Electron process when the graceful shutdown exceeds the specified deadline.

Fixes#40586

Motivation

electronApp.close() waits indefinitely for the process to exit. If the application prevents shutdown (via before-quit handlers, leaky IPC, or lingering child processes), close() hangs until the test-level timeout fires. This is a recurring issue in CI environments:

[Question] Call app.quit() in Electron but process sticks around #12189 — app.quit() called but process sticks around
[REGRESSION]: electron tests sometimes freezes for 30 seconds #27523 — Electron tests freeze 30s on close
[Bug]: Leaky Electron IPC handlers cause tests to hang on Linux/Windows #39248 — Leaky IPC handlers cause hangs
[BUG] - Electron hangs closing the context #13874 — Electron hangs closing context

PR #11336 correctly removed the old hardcoded 30s timeout, but left no way to opt into a grace period with force-kill escalation.

API

// Default: unchanged — waits indefinitelyawaitelectronApp.close();// With timeout: force-kills if app does not exit within 10sawaitelectronApp.close({timeout: 10_000});

Implementation

Minimal change — wires the existing kill function from processLauncher into ElectronApplication:

electron.ts: ElectronApplication constructor now receives the kill function from launchProcess
close(): When timeout is set, starts a timer that calls kill() (SIGKILL on Unix, taskkill /T /F on Windows). If the process exits gracefully before the timer, clearTimeout cancels the force-kill. No new kill logic — reuses existing infrastructure in processLauncher.ts.
Backward compatible: Without timeout, behavior is identical to before.

Key difference from the removed PR #11336 behavior:

Old: hardcoded 30s timeout that threw an error and left the process running
New: opt-in timeout that force-kills and waits for cleanup — the caller always gets a clean exit

Test Plan

should force-kill app when close timeout is exceeded — Uses a test app with a before-quit handler that prevents shutdown. Verifies close({ timeout: 3000 }) successfully kills the process and emits all expected events.
should not force-kill when app closes within timeout — Verifies a normal app closes gracefully when a generous timeout is specified.

Files Changed

File	Change
`packages/playwright-core/src/electron/electron.ts`	Pass `kill` to constructor, add `timeout` option to `close()`
`docs/src/electron-api/class-electronapplication.md`	Document the new `timeout` option
`packages/playwright-core/types/types.d.ts`	Auto-generated from docs
`packages/playwright-client/types/types.d.ts`	Auto-generated from docs
`tests/electron/electron-app-hang-on-close.js`	Test fixture: Electron app that prevents quit
`tests/electron/electron-app.spec.ts`	Two new tests for timeout behavior

When an Electron app does not exit cleanly (e.g. before-quit handlers that prevent shutdown, leaky IPC handlers, or child processes), close() hangs indefinitely. This adds an opt-in timeout option that escalates to force-kill (SIGKILL/taskkill) when exceeded. Default behavior is unchanged — no timeout means wait forever. The implementation wires the existing kill() function from processLauncher into ElectronApplication, so no new kill logic is introduced. Fixesmicrosoft#40586

Sebastien Tardif (SebTardif) · 2026-05-03T19:52:31Z

@microsoft-github-policy-service agree

Sebastien Tardif (SebTardif) · 2026-05-03T19:52:36Z

@microsoft-github-policy-service agree

Pavel Feldman (pavelfeldman) · 2026-05-04T22:46:50Z

- await this._closedPromise;
+
+ if (options?.timeout) {
+ const timer = setTimeout(() => this._kill().catch(() => {}), options.timeout);


My agent did a better job than yours - you are not awaiting kill here. Closing in favor of #40613.

It's rude and funny at the same time...

Sebastien Tardif (SebTardif) · 2026-05-03T19:47:56Z

Summary

Adds an opt-in timeout option to electronApp.close() that force-kills the Electron process when the graceful shutdown exceeds the specified deadline.

Fixes#40586

Motivation

electronApp.close() waits indefinitely for the process to exit. If the application prevents shutdown (via before-quit handlers, leaky IPC, or lingering child processes), close() hangs until the test-level timeout fires. This is a recurring issue in CI environments:

[Question] Call app.quit() in Electron but process sticks around #12189 — app.quit() called but process sticks around
[REGRESSION]: electron tests sometimes freezes for 30 seconds #27523 — Electron tests freeze 30s on close
[Bug]: Leaky Electron IPC handlers cause tests to hang on Linux/Windows #39248 — Leaky IPC handlers cause hangs
[BUG] - Electron hangs closing the context #13874 — Electron hangs closing context

PR #11336 correctly removed the old hardcoded 30s timeout, but left no way to opt into a grace period with force-kill escalation.

API

// Default: unchanged — waits indefinitelyawaitelectronApp.close();// With timeout: force-kills if app does not exit within 10sawaitelectronApp.close({timeout: 10_000});

Implementation

Minimal change — wires the existing kill function from processLauncher into ElectronApplication:

electron.ts: ElectronApplication constructor now receives the kill function from launchProcess
close(): When timeout is set, starts a timer that calls kill() (SIGKILL on Unix, taskkill /T /F on Windows). If the process exits gracefully before the timer, clearTimeout cancels the force-kill. No new kill logic — reuses existing infrastructure in processLauncher.ts.
Backward compatible: Without timeout, behavior is identical to before.

Key difference from the removed PR #11336 behavior:

Old: hardcoded 30s timeout that threw an error and left the process running
New: opt-in timeout that force-kills and waits for cleanup — the caller always gets a clean exit

Test Plan

should force-kill app when close timeout is exceeded — Uses a test app with a before-quit handler that prevents shutdown. Verifies close({ timeout: 3000 }) successfully kills the process and emits all expected events.
should not force-kill when app closes within timeout — Verifies a normal app closes gracefully when a generous timeout is specified.

Files Changed

File	Change
`packages/playwright-core/src/electron/electron.ts`	Pass `kill` to constructor, add `timeout` option to `close()`
`docs/src/electron-api/class-electronapplication.md`	Document the new `timeout` option
`packages/playwright-core/types/types.d.ts`	Auto-generated from docs
`packages/playwright-client/types/types.d.ts`	Auto-generated from docs
`tests/electron/electron-app-hang-on-close.js`	Test fixture: Electron app that prevents quit
`tests/electron/electron-app.spec.ts`	Two new tests for timeout behavior

When an Electron app does not exit cleanly (e.g. before-quit handlers that prevent shutdown, leaky IPC handlers, or child processes), close() hangs indefinitely. This adds an opt-in timeout option that escalates to force-kill (SIGKILL/taskkill) when exceeded. Default behavior is unchanged — no timeout means wait forever. The implementation wires the existing kill() function from processLauncher into ElectronApplication, so no new kill logic is introduced. Fixesmicrosoft#40586

Sebastien Tardif (SebTardif) · 2026-05-03T19:52:31Z

@microsoft-github-policy-service agree

Sebastien Tardif (SebTardif) · 2026-05-03T19:52:36Z

@microsoft-github-policy-service agree

Pavel Feldman (pavelfeldman) · 2026-05-04T22:46:50Z

- await this._closedPromise;
+
+ if (options?.timeout) {
+ const timer = setTimeout(() => this._kill().catch(() => {}), options.timeout);


My agent did a better job than yours - you are not awaiting kill here. Closing in favor of #40613.

It's rude and funny at the same time...

Sebastien Tardif (SebTardif) · 2026-05-03T19:47:56Z

Summary

Adds an opt-in timeout option to electronApp.close() that force-kills the Electron process when the graceful shutdown exceeds the specified deadline.

Fixes#40586

Motivation

electronApp.close() waits indefinitely for the process to exit. If the application prevents shutdown (via before-quit handlers, leaky IPC, or lingering child processes), close() hangs until the test-level timeout fires. This is a recurring issue in CI environments:

[Question] Call app.quit() in Electron but process sticks around #12189 — app.quit() called but process sticks around
[REGRESSION]: electron tests sometimes freezes for 30 seconds #27523 — Electron tests freeze 30s on close
[Bug]: Leaky Electron IPC handlers cause tests to hang on Linux/Windows #39248 — Leaky IPC handlers cause hangs
[BUG] - Electron hangs closing the context #13874 — Electron hangs closing context

PR #11336 correctly removed the old hardcoded 30s timeout, but left no way to opt into a grace period with force-kill escalation.

API

// Default: unchanged — waits indefinitelyawaitelectronApp.close();// With timeout: force-kills if app does not exit within 10sawaitelectronApp.close({timeout: 10_000});

Implementation

Minimal change — wires the existing kill function from processLauncher into ElectronApplication:

electron.ts: ElectronApplication constructor now receives the kill function from launchProcess
close(): When timeout is set, starts a timer that calls kill() (SIGKILL on Unix, taskkill /T /F on Windows). If the process exits gracefully before the timer, clearTimeout cancels the force-kill. No new kill logic — reuses existing infrastructure in processLauncher.ts.
Backward compatible: Without timeout, behavior is identical to before.

Key difference from the removed PR #11336 behavior:

Old: hardcoded 30s timeout that threw an error and left the process running
New: opt-in timeout that force-kills and waits for cleanup — the caller always gets a clean exit

Test Plan

should force-kill app when close timeout is exceeded — Uses a test app with a before-quit handler that prevents shutdown. Verifies close({ timeout: 3000 }) successfully kills the process and emits all expected events.
should not force-kill when app closes within timeout — Verifies a normal app closes gracefully when a generous timeout is specified.

Files Changed

File	Change
`packages/playwright-core/src/electron/electron.ts`	Pass `kill` to constructor, add `timeout` option to `close()`
`docs/src/electron-api/class-electronapplication.md`	Document the new `timeout` option
`packages/playwright-core/types/types.d.ts`	Auto-generated from docs
`packages/playwright-client/types/types.d.ts`	Auto-generated from docs
`tests/electron/electron-app-hang-on-close.js`	Test fixture: Electron app that prevents quit
`tests/electron/electron-app.spec.ts`	Two new tests for timeout behavior

When an Electron app does not exit cleanly (e.g. before-quit handlers that prevent shutdown, leaky IPC handlers, or child processes), close() hangs indefinitely. This adds an opt-in timeout option that escalates to force-kill (SIGKILL/taskkill) when exceeded. Default behavior is unchanged — no timeout means wait forever. The implementation wires the existing kill() function from processLauncher into ElectronApplication, so no new kill logic is introduced. Fixesmicrosoft#40586

Sebastien Tardif (SebTardif) · 2026-05-03T19:52:31Z

@microsoft-github-policy-service agree

Sebastien Tardif (SebTardif) · 2026-05-03T19:52:36Z

@microsoft-github-policy-service agree

Pavel Feldman (pavelfeldman) · 2026-05-04T22:46:50Z

- await this._closedPromise;
+
+ if (options?.timeout) {
+ const timer = setTimeout(() => this._kill().catch(() => {}), options.timeout);


My agent did a better job than yours - you are not awaiting kill here. Closing in favor of #40613.

It's rude and funny at the same time...

Sebastien Tardif (SebTardif) · 2026-05-03T19:47:56Z

Summary

Adds an opt-in timeout option to electronApp.close() that force-kills the Electron process when the graceful shutdown exceeds the specified deadline.

Fixes#40586

Motivation

electronApp.close() waits indefinitely for the process to exit. If the application prevents shutdown (via before-quit handlers, leaky IPC, or lingering child processes), close() hangs until the test-level timeout fires. This is a recurring issue in CI environments:

[Question] Call app.quit() in Electron but process sticks around #12189 — app.quit() called but process sticks around
[REGRESSION]: electron tests sometimes freezes for 30 seconds #27523 — Electron tests freeze 30s on close
[Bug]: Leaky Electron IPC handlers cause tests to hang on Linux/Windows #39248 — Leaky IPC handlers cause hangs
[BUG] - Electron hangs closing the context #13874 — Electron hangs closing context

PR #11336 correctly removed the old hardcoded 30s timeout, but left no way to opt into a grace period with force-kill escalation.

API

// Default: unchanged — waits indefinitelyawaitelectronApp.close();// With timeout: force-kills if app does not exit within 10sawaitelectronApp.close({timeout: 10_000});

Implementation

Minimal change — wires the existing kill function from processLauncher into ElectronApplication:

electron.ts: ElectronApplication constructor now receives the kill function from launchProcess
close(): When timeout is set, starts a timer that calls kill() (SIGKILL on Unix, taskkill /T /F on Windows). If the process exits gracefully before the timer, clearTimeout cancels the force-kill. No new kill logic — reuses existing infrastructure in processLauncher.ts.
Backward compatible: Without timeout, behavior is identical to before.

Key difference from the removed PR #11336 behavior:

Old: hardcoded 30s timeout that threw an error and left the process running
New: opt-in timeout that force-kills and waits for cleanup — the caller always gets a clean exit

Test Plan

should force-kill app when close timeout is exceeded — Uses a test app with a before-quit handler that prevents shutdown. Verifies close({ timeout: 3000 }) successfully kills the process and emits all expected events.
should not force-kill when app closes within timeout — Verifies a normal app closes gracefully when a generous timeout is specified.

Files Changed

File	Change
`packages/playwright-core/src/electron/electron.ts`	Pass `kill` to constructor, add `timeout` option to `close()`
`docs/src/electron-api/class-electronapplication.md`	Document the new `timeout` option
`packages/playwright-core/types/types.d.ts`	Auto-generated from docs
`packages/playwright-client/types/types.d.ts`	Auto-generated from docs
`tests/electron/electron-app-hang-on-close.js`	Test fixture: Electron app that prevents quit
`tests/electron/electron-app.spec.ts`	Two new tests for timeout behavior

When an Electron app does not exit cleanly (e.g. before-quit handlers that prevent shutdown, leaky IPC handlers, or child processes), close() hangs indefinitely. This adds an opt-in timeout option that escalates to force-kill (SIGKILL/taskkill) when exceeded. Default behavior is unchanged — no timeout means wait forever. The implementation wires the existing kill() function from processLauncher into ElectronApplication, so no new kill logic is introduced. Fixesmicrosoft#40586

Sebastien Tardif (SebTardif) · 2026-05-03T19:52:31Z

@microsoft-github-policy-service agree

Sebastien Tardif (SebTardif) · 2026-05-03T19:52:36Z

@microsoft-github-policy-service agree

Pavel Feldman (pavelfeldman) · 2026-05-04T22:46:50Z

- await this._closedPromise;
+
+ if (options?.timeout) {
+ const timer = setTimeout(() => this._kill().catch(() => {}), options.timeout);


My agent did a better job than yours - you are not awaiting kill here. Closing in favor of #40613.

It's rude and funny at the same time...

Sebastien Tardif (SebTardif) · 2026-05-03T19:47:56Z

Summary

Adds an opt-in timeout option to electronApp.close() that force-kills the Electron process when the graceful shutdown exceeds the specified deadline.

Fixes#40586

Motivation

electronApp.close() waits indefinitely for the process to exit. If the application prevents shutdown (via before-quit handlers, leaky IPC, or lingering child processes), close() hangs until the test-level timeout fires. This is a recurring issue in CI environments:

[Question] Call app.quit() in Electron but process sticks around #12189 — app.quit() called but process sticks around
[REGRESSION]: electron tests sometimes freezes for 30 seconds #27523 — Electron tests freeze 30s on close
[Bug]: Leaky Electron IPC handlers cause tests to hang on Linux/Windows #39248 — Leaky IPC handlers cause hangs
[BUG] - Electron hangs closing the context #13874 — Electron hangs closing context

PR #11336 correctly removed the old hardcoded 30s timeout, but left no way to opt into a grace period with force-kill escalation.

API

// Default: unchanged — waits indefinitelyawaitelectronApp.close();// With timeout: force-kills if app does not exit within 10sawaitelectronApp.close({timeout: 10_000});

Implementation

Minimal change — wires the existing kill function from processLauncher into ElectronApplication:

electron.ts: ElectronApplication constructor now receives the kill function from launchProcess
close(): When timeout is set, starts a timer that calls kill() (SIGKILL on Unix, taskkill /T /F on Windows). If the process exits gracefully before the timer, clearTimeout cancels the force-kill. No new kill logic — reuses existing infrastructure in processLauncher.ts.
Backward compatible: Without timeout, behavior is identical to before.

Key difference from the removed PR #11336 behavior:

Old: hardcoded 30s timeout that threw an error and left the process running
New: opt-in timeout that force-kills and waits for cleanup — the caller always gets a clean exit

Test Plan

should force-kill app when close timeout is exceeded — Uses a test app with a before-quit handler that prevents shutdown. Verifies close({ timeout: 3000 }) successfully kills the process and emits all expected events.
should not force-kill when app closes within timeout — Verifies a normal app closes gracefully when a generous timeout is specified.

Files Changed

File	Change
`packages/playwright-core/src/electron/electron.ts`	Pass `kill` to constructor, add `timeout` option to `close()`
`docs/src/electron-api/class-electronapplication.md`	Document the new `timeout` option
`packages/playwright-core/types/types.d.ts`	Auto-generated from docs
`packages/playwright-client/types/types.d.ts`	Auto-generated from docs
`tests/electron/electron-app-hang-on-close.js`	Test fixture: Electron app that prevents quit
`tests/electron/electron-app.spec.ts`	Two new tests for timeout behavior

When an Electron app does not exit cleanly (e.g. before-quit handlers that prevent shutdown, leaky IPC handlers, or child processes), close() hangs indefinitely. This adds an opt-in timeout option that escalates to force-kill (SIGKILL/taskkill) when exceeded. Default behavior is unchanged — no timeout means wait forever. The implementation wires the existing kill() function from processLauncher into ElectronApplication, so no new kill logic is introduced. Fixesmicrosoft#40586

Sebastien Tardif (SebTardif) · 2026-05-03T19:52:31Z

@microsoft-github-policy-service agree

Sebastien Tardif (SebTardif) · 2026-05-03T19:52:36Z

@microsoft-github-policy-service agree

Pavel Feldman (pavelfeldman) · 2026-05-04T22:46:50Z

- await this._closedPromise;
+
+ if (options?.timeout) {
+ const timer = setTimeout(() => this._kill().catch(() => {}), options.timeout);


My agent did a better job than yours - you are not awaiting kill here. Closing in favor of #40613.

It's rude and funny at the same time...

Sebastien Tardif (SebTardif) · 2026-05-03T19:47:56Z

Summary

Adds an opt-in timeout option to electronApp.close() that force-kills the Electron process when the graceful shutdown exceeds the specified deadline.

Fixes#40586

Motivation

electronApp.close() waits indefinitely for the process to exit. If the application prevents shutdown (via before-quit handlers, leaky IPC, or lingering child processes), close() hangs until the test-level timeout fires. This is a recurring issue in CI environments:

[Question] Call app.quit() in Electron but process sticks around #12189 — app.quit() called but process sticks around
[REGRESSION]: electron tests sometimes freezes for 30 seconds #27523 — Electron tests freeze 30s on close
[Bug]: Leaky Electron IPC handlers cause tests to hang on Linux/Windows #39248 — Leaky IPC handlers cause hangs
[BUG] - Electron hangs closing the context #13874 — Electron hangs closing context

PR #11336 correctly removed the old hardcoded 30s timeout, but left no way to opt into a grace period with force-kill escalation.

API

// Default: unchanged — waits indefinitelyawaitelectronApp.close();// With timeout: force-kills if app does not exit within 10sawaitelectronApp.close({timeout: 10_000});

Implementation

Minimal change — wires the existing kill function from processLauncher into ElectronApplication:

electron.ts: ElectronApplication constructor now receives the kill function from launchProcess
close(): When timeout is set, starts a timer that calls kill() (SIGKILL on Unix, taskkill /T /F on Windows). If the process exits gracefully before the timer, clearTimeout cancels the force-kill. No new kill logic — reuses existing infrastructure in processLauncher.ts.
Backward compatible: Without timeout, behavior is identical to before.

Key difference from the removed PR #11336 behavior:

Old: hardcoded 30s timeout that threw an error and left the process running
New: opt-in timeout that force-kills and waits for cleanup — the caller always gets a clean exit

Test Plan

should force-kill app when close timeout is exceeded — Uses a test app with a before-quit handler that prevents shutdown. Verifies close({ timeout: 3000 }) successfully kills the process and emits all expected events.
should not force-kill when app closes within timeout — Verifies a normal app closes gracefully when a generous timeout is specified.

Files Changed

File	Change
`packages/playwright-core/src/electron/electron.ts`	Pass `kill` to constructor, add `timeout` option to `close()`
`docs/src/electron-api/class-electronapplication.md`	Document the new `timeout` option
`packages/playwright-core/types/types.d.ts`	Auto-generated from docs
`packages/playwright-client/types/types.d.ts`	Auto-generated from docs
`tests/electron/electron-app-hang-on-close.js`	Test fixture: Electron app that prevents quit
`tests/electron/electron-app.spec.ts`	Two new tests for timeout behavior

When an Electron app does not exit cleanly (e.g. before-quit handlers that prevent shutdown, leaky IPC handlers, or child processes), close() hangs indefinitely. This adds an opt-in timeout option that escalates to force-kill (SIGKILL/taskkill) when exceeded. Default behavior is unchanged — no timeout means wait forever. The implementation wires the existing kill() function from processLauncher into ElectronApplication, so no new kill logic is introduced. Fixesmicrosoft#40586

Sebastien Tardif (SebTardif) · 2026-05-03T19:52:31Z

@microsoft-github-policy-service agree

Sebastien Tardif (SebTardif) · 2026-05-03T19:52:36Z

@microsoft-github-policy-service agree

Pavel Feldman (pavelfeldman) · 2026-05-04T22:46:50Z

- await this._closedPromise;
+
+ if (options?.timeout) {
+ const timer = setTimeout(() => this._kill().catch(() => {}), options.timeout);


My agent did a better job than yours - you are not awaiting kill here. Closing in favor of #40613.

It's rude and funny at the same time...

Sebastien Tardif (SebTardif) · 2026-05-03T19:47:56Z

Summary

Adds an opt-in timeout option to electronApp.close() that force-kills the Electron process when the graceful shutdown exceeds the specified deadline.

Fixes#40586

Motivation

electronApp.close() waits indefinitely for the process to exit. If the application prevents shutdown (via before-quit handlers, leaky IPC, or lingering child processes), close() hangs until the test-level timeout fires. This is a recurring issue in CI environments:

[Question] Call app.quit() in Electron but process sticks around #12189 — app.quit() called but process sticks around
[REGRESSION]: electron tests sometimes freezes for 30 seconds #27523 — Electron tests freeze 30s on close
[Bug]: Leaky Electron IPC handlers cause tests to hang on Linux/Windows #39248 — Leaky IPC handlers cause hangs
[BUG] - Electron hangs closing the context #13874 — Electron hangs closing context

PR #11336 correctly removed the old hardcoded 30s timeout, but left no way to opt into a grace period with force-kill escalation.

API

// Default: unchanged — waits indefinitelyawaitelectronApp.close();// With timeout: force-kills if app does not exit within 10sawaitelectronApp.close({timeout: 10_000});

Implementation

Minimal change — wires the existing kill function from processLauncher into ElectronApplication:

electron.ts: ElectronApplication constructor now receives the kill function from launchProcess
close(): When timeout is set, starts a timer that calls kill() (SIGKILL on Unix, taskkill /T /F on Windows). If the process exits gracefully before the timer, clearTimeout cancels the force-kill. No new kill logic — reuses existing infrastructure in processLauncher.ts.
Backward compatible: Without timeout, behavior is identical to before.

Key difference from the removed PR #11336 behavior:

Old: hardcoded 30s timeout that threw an error and left the process running
New: opt-in timeout that force-kills and waits for cleanup — the caller always gets a clean exit

Test Plan

should force-kill app when close timeout is exceeded — Uses a test app with a before-quit handler that prevents shutdown. Verifies close({ timeout: 3000 }) successfully kills the process and emits all expected events.
should not force-kill when app closes within timeout — Verifies a normal app closes gracefully when a generous timeout is specified.

Files Changed

File	Change
`packages/playwright-core/src/electron/electron.ts`	Pass `kill` to constructor, add `timeout` option to `close()`
`docs/src/electron-api/class-electronapplication.md`	Document the new `timeout` option
`packages/playwright-core/types/types.d.ts`	Auto-generated from docs
`packages/playwright-client/types/types.d.ts`	Auto-generated from docs
`tests/electron/electron-app-hang-on-close.js`	Test fixture: Electron app that prevents quit
`tests/electron/electron-app.spec.ts`	Two new tests for timeout behavior

When an Electron app does not exit cleanly (e.g. before-quit handlers that prevent shutdown, leaky IPC handlers, or child processes), close() hangs indefinitely. This adds an opt-in timeout option that escalates to force-kill (SIGKILL/taskkill) when exceeded. Default behavior is unchanged — no timeout means wait forever. The implementation wires the existing kill() function from processLauncher into ElectronApplication, so no new kill logic is introduced. Fixesmicrosoft#40586

Sebastien Tardif (SebTardif) · 2026-05-03T19:52:31Z

@microsoft-github-policy-service agree

Sebastien Tardif (SebTardif) · 2026-05-03T19:52:36Z

@microsoft-github-policy-service agree

Pavel Feldman (pavelfeldman) · 2026-05-04T22:46:50Z

- await this._closedPromise;
+
+ if (options?.timeout) {
+ const timer = setTimeout(() => this._kill().catch(() => {}), options.timeout);


My agent did a better job than yours - you are not awaiting kill here. Closing in favor of #40613.

It's rude and funny at the same time...

Pavel Feldman (pavelfeldman) reviewed May 4, 2026
View reviewed changes

Pavel Feldman (pavelfeldman) closed this May 4, 2026

Pavel Feldman (pavelfeldman) reviewed May 4, 2026
View reviewed changes

Pavel Feldman (pavelfeldman) closed this May 4, 2026

Pavel Feldman (pavelfeldman) reviewed May 4, 2026
View reviewed changes

Pavel Feldman (pavelfeldman) closed this May 4, 2026

Pavel Feldman (pavelfeldman) reviewed May 4, 2026
View reviewed changes

Pavel Feldman (pavelfeldman) closed this May 4, 2026

Pavel Feldman (pavelfeldman) reviewed May 4, 2026
View reviewed changes

Pavel Feldman (pavelfeldman) closed this May 4, 2026

Pavel Feldman (pavelfeldman) reviewed May 4, 2026
View reviewed changes

Pavel Feldman (pavelfeldman) closed this May 4, 2026

Pavel Feldman (pavelfeldman) reviewed May 4, 2026
View reviewed changes

Pavel Feldman (pavelfeldman) closed this May 4, 2026

Pavel Feldman (pavelfeldman) reviewed May 4, 2026
View reviewed changes

Pavel Feldman (pavelfeldman) closed this May 4, 2026

Uh oh!

Conversation

Sebastien Tardif (SebTardif) commented May 3, 2026

Summary

Motivation

API

Implementation

Test Plan

Files Changed

Uh oh!

Sebastien Tardif (SebTardif) commented May 3, 2026

Uh oh!

Sebastien Tardif (SebTardif) commented May 3, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Sebastien Tardif (SebTardif) commented May 3, 2026

Summary

Motivation

API

Implementation

Test Plan

Files Changed

Uh oh!

Sebastien Tardif (SebTardif) commented May 3, 2026

Uh oh!

Sebastien Tardif (SebTardif) commented May 3, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Sebastien Tardif (SebTardif) commented May 3, 2026

Summary

Motivation

API

Implementation

Test Plan

Files Changed

Uh oh!

Sebastien Tardif (SebTardif) commented May 3, 2026

Uh oh!

Sebastien Tardif (SebTardif) commented May 3, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation