feat(electron): add timeout option to electronApp.close() for force-kill escalation by Copilot · Pull Request #40613 · microsoft/playwright

Copilot · 2026-05-04T21:50:11Z

electronApp.close() waits indefinitely for the Electron process to exit. Apps with before-quit handlers, leaky IPC handlers, or stray child processes can hang teardown until the test-level timeout kills everything. The force-kill path already exists in processLauncher but is only reachable via OS signals.

Changes

packages/playwright-core/src/electron/electron.ts — thread the existing kill from launchProcess into ElectronApplication. Add an opt-in { timeout?: number } to close(): after the existing graceful shutdown (browser.close() → app.quit() → worker._disconnect()), race _closedPromise against a timer; if the timer wins, invoke kill() (SIGKILL / taskkill /T /F) and await full exit.
Backward compatible — without timeout, behavior is unchanged (waits forever, no force-kill).
docs/src/electron-api/class-electronapplication.md — document the new option; types.d.ts regenerated.
Tests — new electron-app-hang-on-close.js fixture (preventDefaults before-quit + keeps the loop busy). Two specs: one asserts force-kill fires near the timeout, one asserts a cooperating app still exits with code 0 (no force-kill).

Usage

// Unchanged: wait forever.awaitelectronApp.close();// New: force-kill if the app does not exit within 10s.awaitelectronApp.close({timeout: 10_000});

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

redirector.gvt1.com
- Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --disable-dev-shm-usage --enable-crash-reporter=856dbc92-6ec9-48ff-ad01-9585c6f246ca,no_channel --user-data-dir=/tmp/playwright-test-UD55eR/Electron --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,11195650865713303302,599583126570378049,262144 --enable-features=CDPScreenshotNewSurface,PdfUseShowSaveFilePicker --disable-features=AutoDeElevate,AvoidUnnecessaryBeforeUnloadCheckSync,BoundaryEventDispatchTracksNodeRemoval,DestroyProfileOnBrowserClose,DialMediaRouteProvider,GlobalMediaControls,HttpsUpgrades,LensOverlay,LocalNetworkAccessChecks,MediaRouter,Optimizati right/playwright--clearScreen=false ypes/test/tsconfig.json /usr/bin/dirname (dns block)
- Triggering command: /home/REDACTED/work/playwright/playwright/node_modules/electron/dist/electron /home/REDACTED/work/playwright/playwright/node_modules/electron/dist/electron -r /home/REDACTED/work/playwright/playwright/packages/playwright-core/lib/electron/loader.js --no-sandbox --inspect=0 --remote-debugging-port=0 /home/REDACTED/work/playwright/playwright/tests/electron/electron-app.js 2/x64/lib/node_modules/npm/node_modules/@npmcli/run-script/lib/node-gyp-bin/sh (dns block)
- Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --disable-dev-shm-usage --enable-crash-reporter=2769063e-04a3-4f49-884c-c9d911de6ba5,no_channel --user-data-dir=/tmp/playwright-test-QcPS47/Electron --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,275575950628164391,10456952859755863149,262144 --enable-features=CDPScreenshotNewSurface,PdfUseShowSaveFilePicker --disable-features=AutoDeElevate,AvoidUnnecessaryBeforeUnloadCheckSync,BoundaryEventDispatchTracksNodeRemoval,DestroyProfileOnBrowserClose,DialMediaRouteProvider,GlobalMediaControls,HttpsUpgrades,LensOverlay,LocalNetworkAccessChecks,MediaRouter,Optimizati right/playwright--clearScreen=false ypes/test/tsconfig.json tnet/tools/sh (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

…ill escalation Agent-Logs-Url: https://github.com/microsoft/playwright/sessions/c48dfc8b-1a28-476b-bd4b-5ec7f5a64d83 Co-authored-by: pavelfeldman <883973+pavelfeldman@users.noreply.github.com>

Agent-Logs-Url: https://github.com/microsoft/playwright/sessions/c48dfc8b-1a28-476b-bd4b-5ec7f5a64d83 Co-authored-by: pavelfeldman <883973+pavelfeldman@users.noreply.github.com>

Follow-up to the revert of PR microsoft#40184 that brings the tree to a working state on top of the main-branch changes that landed after the PR: - Re-add Electron protocol entries to packages/protocol/spec/electron.yml and the Electron initializer to packages/protocol/spec/playwright.yml (protocol.yml was split into per-interface spec/*.yml files in microsoft#40645). - Keep Electron docs in docs/src/electron-api/ but restore their pre-PR full content (the PR had truncated docs to match the trimmed-down CDP-only API). doclint cli.js merges electron-api docs. - Drop the leftover docs/src/electron/loader bundling step from utils/build/build.js (loader is back at server/electron/loader.ts). - Update the restored server/electron/electron.ts import after the toConsoleMessageLocation -> stackTraceToLocation rename in microsoft#39767. - Drop the explicit _electron registration from inprocess.ts; with the server-side dispatcher restored, _electron is wired through the Playwright initializer again. - Remove duplicate _electron exports in index.mjs and overrides.d.ts. - Restore the pre-PR ElectronApplication evaluate/evaluateHandle override signatures so the generated types are consistent. Also re-applies the timeout option from microsoft#40613 (electronApp.close({ timeout })) on top of the restored server-side architecture: a new ElectronApplication.close protocol command takes an optional timeout and force-kills the underlying browser process via browserProcess.kill() when graceful close exceeds the deadline.

Copilot · 2026-05-04T21:50:11Z

electronApp.close() waits indefinitely for the Electron process to exit. Apps with before-quit handlers, leaky IPC handlers, or stray child processes can hang teardown until the test-level timeout kills everything. The force-kill path already exists in processLauncher but is only reachable via OS signals.

Changes

packages/playwright-core/src/electron/electron.ts — thread the existing kill from launchProcess into ElectronApplication. Add an opt-in { timeout?: number } to close(): after the existing graceful shutdown (browser.close() → app.quit() → worker._disconnect()), race _closedPromise against a timer; if the timer wins, invoke kill() (SIGKILL / taskkill /T /F) and await full exit.
Backward compatible — without timeout, behavior is unchanged (waits forever, no force-kill).
docs/src/electron-api/class-electronapplication.md — document the new option; types.d.ts regenerated.
Tests — new electron-app-hang-on-close.js fixture (preventDefaults before-quit + keeps the loop busy). Two specs: one asserts force-kill fires near the timeout, one asserts a cooperating app still exits with code 0 (no force-kill).

Usage

// Unchanged: wait forever.awaitelectronApp.close();// New: force-kill if the app does not exit within 10s.awaitelectronApp.close({timeout: 10_000});

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

redirector.gvt1.com
- Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --disable-dev-shm-usage --enable-crash-reporter=856dbc92-6ec9-48ff-ad01-9585c6f246ca,no_channel --user-data-dir=/tmp/playwright-test-UD55eR/Electron --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,11195650865713303302,599583126570378049,262144 --enable-features=CDPScreenshotNewSurface,PdfUseShowSaveFilePicker --disable-features=AutoDeElevate,AvoidUnnecessaryBeforeUnloadCheckSync,BoundaryEventDispatchTracksNodeRemoval,DestroyProfileOnBrowserClose,DialMediaRouteProvider,GlobalMediaControls,HttpsUpgrades,LensOverlay,LocalNetworkAccessChecks,MediaRouter,Optimizati right/playwright--clearScreen=false ypes/test/tsconfig.json /usr/bin/dirname (dns block)
- Triggering command: /home/REDACTED/work/playwright/playwright/node_modules/electron/dist/electron /home/REDACTED/work/playwright/playwright/node_modules/electron/dist/electron -r /home/REDACTED/work/playwright/playwright/packages/playwright-core/lib/electron/loader.js --no-sandbox --inspect=0 --remote-debugging-port=0 /home/REDACTED/work/playwright/playwright/tests/electron/electron-app.js 2/x64/lib/node_modules/npm/node_modules/@npmcli/run-script/lib/node-gyp-bin/sh (dns block)
- Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --disable-dev-shm-usage --enable-crash-reporter=2769063e-04a3-4f49-884c-c9d911de6ba5,no_channel --user-data-dir=/tmp/playwright-test-QcPS47/Electron --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,275575950628164391,10456952859755863149,262144 --enable-features=CDPScreenshotNewSurface,PdfUseShowSaveFilePicker --disable-features=AutoDeElevate,AvoidUnnecessaryBeforeUnloadCheckSync,BoundaryEventDispatchTracksNodeRemoval,DestroyProfileOnBrowserClose,DialMediaRouteProvider,GlobalMediaControls,HttpsUpgrades,LensOverlay,LocalNetworkAccessChecks,MediaRouter,Optimizati right/playwright--clearScreen=false ypes/test/tsconfig.json tnet/tools/sh (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

…ill escalation Agent-Logs-Url: https://github.com/microsoft/playwright/sessions/c48dfc8b-1a28-476b-bd4b-5ec7f5a64d83 Co-authored-by: pavelfeldman <883973+pavelfeldman@users.noreply.github.com>

Agent-Logs-Url: https://github.com/microsoft/playwright/sessions/c48dfc8b-1a28-476b-bd4b-5ec7f5a64d83 Co-authored-by: pavelfeldman <883973+pavelfeldman@users.noreply.github.com>

Follow-up to the revert of PR microsoft#40184 that brings the tree to a working state on top of the main-branch changes that landed after the PR: - Re-add Electron protocol entries to packages/protocol/spec/electron.yml and the Electron initializer to packages/protocol/spec/playwright.yml (protocol.yml was split into per-interface spec/*.yml files in microsoft#40645). - Keep Electron docs in docs/src/electron-api/ but restore their pre-PR full content (the PR had truncated docs to match the trimmed-down CDP-only API). doclint cli.js merges electron-api docs. - Drop the leftover docs/src/electron/loader bundling step from utils/build/build.js (loader is back at server/electron/loader.ts). - Update the restored server/electron/electron.ts import after the toConsoleMessageLocation -> stackTraceToLocation rename in microsoft#39767. - Drop the explicit _electron registration from inprocess.ts; with the server-side dispatcher restored, _electron is wired through the Playwright initializer again. - Remove duplicate _electron exports in index.mjs and overrides.d.ts. - Restore the pre-PR ElectronApplication evaluate/evaluateHandle override signatures so the generated types are consistent. Also re-applies the timeout option from microsoft#40613 (electronApp.close({ timeout })) on top of the restored server-side architecture: a new ElectronApplication.close protocol command takes an optional timeout and force-kills the underlying browser process via browserProcess.kill() when graceful close exceeds the deadline.

Copilot · 2026-05-04T21:50:11Z

electronApp.close() waits indefinitely for the Electron process to exit. Apps with before-quit handlers, leaky IPC handlers, or stray child processes can hang teardown until the test-level timeout kills everything. The force-kill path already exists in processLauncher but is only reachable via OS signals.

Changes

packages/playwright-core/src/electron/electron.ts — thread the existing kill from launchProcess into ElectronApplication. Add an opt-in { timeout?: number } to close(): after the existing graceful shutdown (browser.close() → app.quit() → worker._disconnect()), race _closedPromise against a timer; if the timer wins, invoke kill() (SIGKILL / taskkill /T /F) and await full exit.
Backward compatible — without timeout, behavior is unchanged (waits forever, no force-kill).
docs/src/electron-api/class-electronapplication.md — document the new option; types.d.ts regenerated.
Tests — new electron-app-hang-on-close.js fixture (preventDefaults before-quit + keeps the loop busy). Two specs: one asserts force-kill fires near the timeout, one asserts a cooperating app still exits with code 0 (no force-kill).

Usage

// Unchanged: wait forever.awaitelectronApp.close();// New: force-kill if the app does not exit within 10s.awaitelectronApp.close({timeout: 10_000});

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

redirector.gvt1.com
- Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --disable-dev-shm-usage --enable-crash-reporter=856dbc92-6ec9-48ff-ad01-9585c6f246ca,no_channel --user-data-dir=/tmp/playwright-test-UD55eR/Electron --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,11195650865713303302,599583126570378049,262144 --enable-features=CDPScreenshotNewSurface,PdfUseShowSaveFilePicker --disable-features=AutoDeElevate,AvoidUnnecessaryBeforeUnloadCheckSync,BoundaryEventDispatchTracksNodeRemoval,DestroyProfileOnBrowserClose,DialMediaRouteProvider,GlobalMediaControls,HttpsUpgrades,LensOverlay,LocalNetworkAccessChecks,MediaRouter,Optimizati right/playwright--clearScreen=false ypes/test/tsconfig.json /usr/bin/dirname (dns block)
- Triggering command: /home/REDACTED/work/playwright/playwright/node_modules/electron/dist/electron /home/REDACTED/work/playwright/playwright/node_modules/electron/dist/electron -r /home/REDACTED/work/playwright/playwright/packages/playwright-core/lib/electron/loader.js --no-sandbox --inspect=0 --remote-debugging-port=0 /home/REDACTED/work/playwright/playwright/tests/electron/electron-app.js 2/x64/lib/node_modules/npm/node_modules/@npmcli/run-script/lib/node-gyp-bin/sh (dns block)
- Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --disable-dev-shm-usage --enable-crash-reporter=2769063e-04a3-4f49-884c-c9d911de6ba5,no_channel --user-data-dir=/tmp/playwright-test-QcPS47/Electron --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,275575950628164391,10456952859755863149,262144 --enable-features=CDPScreenshotNewSurface,PdfUseShowSaveFilePicker --disable-features=AutoDeElevate,AvoidUnnecessaryBeforeUnloadCheckSync,BoundaryEventDispatchTracksNodeRemoval,DestroyProfileOnBrowserClose,DialMediaRouteProvider,GlobalMediaControls,HttpsUpgrades,LensOverlay,LocalNetworkAccessChecks,MediaRouter,Optimizati right/playwright--clearScreen=false ypes/test/tsconfig.json tnet/tools/sh (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

…ill escalation Agent-Logs-Url: https://github.com/microsoft/playwright/sessions/c48dfc8b-1a28-476b-bd4b-5ec7f5a64d83 Co-authored-by: pavelfeldman <883973+pavelfeldman@users.noreply.github.com>

Agent-Logs-Url: https://github.com/microsoft/playwright/sessions/c48dfc8b-1a28-476b-bd4b-5ec7f5a64d83 Co-authored-by: pavelfeldman <883973+pavelfeldman@users.noreply.github.com>

Follow-up to the revert of PR microsoft#40184 that brings the tree to a working state on top of the main-branch changes that landed after the PR: - Re-add Electron protocol entries to packages/protocol/spec/electron.yml and the Electron initializer to packages/protocol/spec/playwright.yml (protocol.yml was split into per-interface spec/*.yml files in microsoft#40645). - Keep Electron docs in docs/src/electron-api/ but restore their pre-PR full content (the PR had truncated docs to match the trimmed-down CDP-only API). doclint cli.js merges electron-api docs. - Drop the leftover docs/src/electron/loader bundling step from utils/build/build.js (loader is back at server/electron/loader.ts). - Update the restored server/electron/electron.ts import after the toConsoleMessageLocation -> stackTraceToLocation rename in microsoft#39767. - Drop the explicit _electron registration from inprocess.ts; with the server-side dispatcher restored, _electron is wired through the Playwright initializer again. - Remove duplicate _electron exports in index.mjs and overrides.d.ts. - Restore the pre-PR ElectronApplication evaluate/evaluateHandle override signatures so the generated types are consistent. Also re-applies the timeout option from microsoft#40613 (electronApp.close({ timeout })) on top of the restored server-side architecture: a new ElectronApplication.close protocol command takes an optional timeout and force-kills the underlying browser process via browserProcess.kill() when graceful close exceeds the deadline.

Copilot · 2026-05-04T21:50:11Z

electronApp.close() waits indefinitely for the Electron process to exit. Apps with before-quit handlers, leaky IPC handlers, or stray child processes can hang teardown until the test-level timeout kills everything. The force-kill path already exists in processLauncher but is only reachable via OS signals.

Changes

packages/playwright-core/src/electron/electron.ts — thread the existing kill from launchProcess into ElectronApplication. Add an opt-in { timeout?: number } to close(): after the existing graceful shutdown (browser.close() → app.quit() → worker._disconnect()), race _closedPromise against a timer; if the timer wins, invoke kill() (SIGKILL / taskkill /T /F) and await full exit.
Backward compatible — without timeout, behavior is unchanged (waits forever, no force-kill).
docs/src/electron-api/class-electronapplication.md — document the new option; types.d.ts regenerated.
Tests — new electron-app-hang-on-close.js fixture (preventDefaults before-quit + keeps the loop busy). Two specs: one asserts force-kill fires near the timeout, one asserts a cooperating app still exits with code 0 (no force-kill).

Usage

// Unchanged: wait forever.awaitelectronApp.close();// New: force-kill if the app does not exit within 10s.awaitelectronApp.close({timeout: 10_000});

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

redirector.gvt1.com
- Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --disable-dev-shm-usage --enable-crash-reporter=856dbc92-6ec9-48ff-ad01-9585c6f246ca,no_channel --user-data-dir=/tmp/playwright-test-UD55eR/Electron --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,11195650865713303302,599583126570378049,262144 --enable-features=CDPScreenshotNewSurface,PdfUseShowSaveFilePicker --disable-features=AutoDeElevate,AvoidUnnecessaryBeforeUnloadCheckSync,BoundaryEventDispatchTracksNodeRemoval,DestroyProfileOnBrowserClose,DialMediaRouteProvider,GlobalMediaControls,HttpsUpgrades,LensOverlay,LocalNetworkAccessChecks,MediaRouter,Optimizati right/playwright--clearScreen=false ypes/test/tsconfig.json /usr/bin/dirname (dns block)
- Triggering command: /home/REDACTED/work/playwright/playwright/node_modules/electron/dist/electron /home/REDACTED/work/playwright/playwright/node_modules/electron/dist/electron -r /home/REDACTED/work/playwright/playwright/packages/playwright-core/lib/electron/loader.js --no-sandbox --inspect=0 --remote-debugging-port=0 /home/REDACTED/work/playwright/playwright/tests/electron/electron-app.js 2/x64/lib/node_modules/npm/node_modules/@npmcli/run-script/lib/node-gyp-bin/sh (dns block)
- Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --disable-dev-shm-usage --enable-crash-reporter=2769063e-04a3-4f49-884c-c9d911de6ba5,no_channel --user-data-dir=/tmp/playwright-test-QcPS47/Electron --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,275575950628164391,10456952859755863149,262144 --enable-features=CDPScreenshotNewSurface,PdfUseShowSaveFilePicker --disable-features=AutoDeElevate,AvoidUnnecessaryBeforeUnloadCheckSync,BoundaryEventDispatchTracksNodeRemoval,DestroyProfileOnBrowserClose,DialMediaRouteProvider,GlobalMediaControls,HttpsUpgrades,LensOverlay,LocalNetworkAccessChecks,MediaRouter,Optimizati right/playwright--clearScreen=false ypes/test/tsconfig.json tnet/tools/sh (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

…ill escalation Agent-Logs-Url: https://github.com/microsoft/playwright/sessions/c48dfc8b-1a28-476b-bd4b-5ec7f5a64d83 Co-authored-by: pavelfeldman <883973+pavelfeldman@users.noreply.github.com>

Agent-Logs-Url: https://github.com/microsoft/playwright/sessions/c48dfc8b-1a28-476b-bd4b-5ec7f5a64d83 Co-authored-by: pavelfeldman <883973+pavelfeldman@users.noreply.github.com>

Follow-up to the revert of PR microsoft#40184 that brings the tree to a working state on top of the main-branch changes that landed after the PR: - Re-add Electron protocol entries to packages/protocol/spec/electron.yml and the Electron initializer to packages/protocol/spec/playwright.yml (protocol.yml was split into per-interface spec/*.yml files in microsoft#40645). - Keep Electron docs in docs/src/electron-api/ but restore their pre-PR full content (the PR had truncated docs to match the trimmed-down CDP-only API). doclint cli.js merges electron-api docs. - Drop the leftover docs/src/electron/loader bundling step from utils/build/build.js (loader is back at server/electron/loader.ts). - Update the restored server/electron/electron.ts import after the toConsoleMessageLocation -> stackTraceToLocation rename in microsoft#39767. - Drop the explicit _electron registration from inprocess.ts; with the server-side dispatcher restored, _electron is wired through the Playwright initializer again. - Remove duplicate _electron exports in index.mjs and overrides.d.ts. - Restore the pre-PR ElectronApplication evaluate/evaluateHandle override signatures so the generated types are consistent. Also re-applies the timeout option from microsoft#40613 (electronApp.close({ timeout })) on top of the restored server-side architecture: a new ElectronApplication.close protocol command takes an optional timeout and force-kills the underlying browser process via browserProcess.kill() when graceful close exceeds the deadline.

Copilot · 2026-05-04T21:50:11Z

electronApp.close() waits indefinitely for the Electron process to exit. Apps with before-quit handlers, leaky IPC handlers, or stray child processes can hang teardown until the test-level timeout kills everything. The force-kill path already exists in processLauncher but is only reachable via OS signals.

Changes

packages/playwright-core/src/electron/electron.ts — thread the existing kill from launchProcess into ElectronApplication. Add an opt-in { timeout?: number } to close(): after the existing graceful shutdown (browser.close() → app.quit() → worker._disconnect()), race _closedPromise against a timer; if the timer wins, invoke kill() (SIGKILL / taskkill /T /F) and await full exit.
Backward compatible — without timeout, behavior is unchanged (waits forever, no force-kill).
docs/src/electron-api/class-electronapplication.md — document the new option; types.d.ts regenerated.
Tests — new electron-app-hang-on-close.js fixture (preventDefaults before-quit + keeps the loop busy). Two specs: one asserts force-kill fires near the timeout, one asserts a cooperating app still exits with code 0 (no force-kill).

Usage

// Unchanged: wait forever.awaitelectronApp.close();// New: force-kill if the app does not exit within 10s.awaitelectronApp.close({timeout: 10_000});

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

redirector.gvt1.com
- Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --disable-dev-shm-usage --enable-crash-reporter=856dbc92-6ec9-48ff-ad01-9585c6f246ca,no_channel --user-data-dir=/tmp/playwright-test-UD55eR/Electron --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,11195650865713303302,599583126570378049,262144 --enable-features=CDPScreenshotNewSurface,PdfUseShowSaveFilePicker --disable-features=AutoDeElevate,AvoidUnnecessaryBeforeUnloadCheckSync,BoundaryEventDispatchTracksNodeRemoval,DestroyProfileOnBrowserClose,DialMediaRouteProvider,GlobalMediaControls,HttpsUpgrades,LensOverlay,LocalNetworkAccessChecks,MediaRouter,Optimizati right/playwright--clearScreen=false ypes/test/tsconfig.json /usr/bin/dirname (dns block)
- Triggering command: /home/REDACTED/work/playwright/playwright/node_modules/electron/dist/electron /home/REDACTED/work/playwright/playwright/node_modules/electron/dist/electron -r /home/REDACTED/work/playwright/playwright/packages/playwright-core/lib/electron/loader.js --no-sandbox --inspect=0 --remote-debugging-port=0 /home/REDACTED/work/playwright/playwright/tests/electron/electron-app.js 2/x64/lib/node_modules/npm/node_modules/@npmcli/run-script/lib/node-gyp-bin/sh (dns block)
- Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --disable-dev-shm-usage --enable-crash-reporter=2769063e-04a3-4f49-884c-c9d911de6ba5,no_channel --user-data-dir=/tmp/playwright-test-QcPS47/Electron --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,275575950628164391,10456952859755863149,262144 --enable-features=CDPScreenshotNewSurface,PdfUseShowSaveFilePicker --disable-features=AutoDeElevate,AvoidUnnecessaryBeforeUnloadCheckSync,BoundaryEventDispatchTracksNodeRemoval,DestroyProfileOnBrowserClose,DialMediaRouteProvider,GlobalMediaControls,HttpsUpgrades,LensOverlay,LocalNetworkAccessChecks,MediaRouter,Optimizati right/playwright--clearScreen=false ypes/test/tsconfig.json tnet/tools/sh (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

…ill escalation Agent-Logs-Url: https://github.com/microsoft/playwright/sessions/c48dfc8b-1a28-476b-bd4b-5ec7f5a64d83 Co-authored-by: pavelfeldman <883973+pavelfeldman@users.noreply.github.com>

Agent-Logs-Url: https://github.com/microsoft/playwright/sessions/c48dfc8b-1a28-476b-bd4b-5ec7f5a64d83 Co-authored-by: pavelfeldman <883973+pavelfeldman@users.noreply.github.com>

Follow-up to the revert of PR microsoft#40184 that brings the tree to a working state on top of the main-branch changes that landed after the PR: - Re-add Electron protocol entries to packages/protocol/spec/electron.yml and the Electron initializer to packages/protocol/spec/playwright.yml (protocol.yml was split into per-interface spec/*.yml files in microsoft#40645). - Keep Electron docs in docs/src/electron-api/ but restore their pre-PR full content (the PR had truncated docs to match the trimmed-down CDP-only API). doclint cli.js merges electron-api docs. - Drop the leftover docs/src/electron/loader bundling step from utils/build/build.js (loader is back at server/electron/loader.ts). - Update the restored server/electron/electron.ts import after the toConsoleMessageLocation -> stackTraceToLocation rename in microsoft#39767. - Drop the explicit _electron registration from inprocess.ts; with the server-side dispatcher restored, _electron is wired through the Playwright initializer again. - Remove duplicate _electron exports in index.mjs and overrides.d.ts. - Restore the pre-PR ElectronApplication evaluate/evaluateHandle override signatures so the generated types are consistent. Also re-applies the timeout option from microsoft#40613 (electronApp.close({ timeout })) on top of the restored server-side architecture: a new ElectronApplication.close protocol command takes an optional timeout and force-kills the underlying browser process via browserProcess.kill() when graceful close exceeds the deadline.

Copilot · 2026-05-04T21:50:11Z

electronApp.close() waits indefinitely for the Electron process to exit. Apps with before-quit handlers, leaky IPC handlers, or stray child processes can hang teardown until the test-level timeout kills everything. The force-kill path already exists in processLauncher but is only reachable via OS signals.

Changes

packages/playwright-core/src/electron/electron.ts — thread the existing kill from launchProcess into ElectronApplication. Add an opt-in { timeout?: number } to close(): after the existing graceful shutdown (browser.close() → app.quit() → worker._disconnect()), race _closedPromise against a timer; if the timer wins, invoke kill() (SIGKILL / taskkill /T /F) and await full exit.
Backward compatible — without timeout, behavior is unchanged (waits forever, no force-kill).
docs/src/electron-api/class-electronapplication.md — document the new option; types.d.ts regenerated.
Tests — new electron-app-hang-on-close.js fixture (preventDefaults before-quit + keeps the loop busy). Two specs: one asserts force-kill fires near the timeout, one asserts a cooperating app still exits with code 0 (no force-kill).

Usage

// Unchanged: wait forever.awaitelectronApp.close();// New: force-kill if the app does not exit within 10s.awaitelectronApp.close({timeout: 10_000});

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

redirector.gvt1.com
- Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --disable-dev-shm-usage --enable-crash-reporter=856dbc92-6ec9-48ff-ad01-9585c6f246ca,no_channel --user-data-dir=/tmp/playwright-test-UD55eR/Electron --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,11195650865713303302,599583126570378049,262144 --enable-features=CDPScreenshotNewSurface,PdfUseShowSaveFilePicker --disable-features=AutoDeElevate,AvoidUnnecessaryBeforeUnloadCheckSync,BoundaryEventDispatchTracksNodeRemoval,DestroyProfileOnBrowserClose,DialMediaRouteProvider,GlobalMediaControls,HttpsUpgrades,LensOverlay,LocalNetworkAccessChecks,MediaRouter,Optimizati right/playwright--clearScreen=false ypes/test/tsconfig.json /usr/bin/dirname (dns block)
- Triggering command: /home/REDACTED/work/playwright/playwright/node_modules/electron/dist/electron /home/REDACTED/work/playwright/playwright/node_modules/electron/dist/electron -r /home/REDACTED/work/playwright/playwright/packages/playwright-core/lib/electron/loader.js --no-sandbox --inspect=0 --remote-debugging-port=0 /home/REDACTED/work/playwright/playwright/tests/electron/electron-app.js 2/x64/lib/node_modules/npm/node_modules/@npmcli/run-script/lib/node-gyp-bin/sh (dns block)
- Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --disable-dev-shm-usage --enable-crash-reporter=2769063e-04a3-4f49-884c-c9d911de6ba5,no_channel --user-data-dir=/tmp/playwright-test-QcPS47/Electron --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,275575950628164391,10456952859755863149,262144 --enable-features=CDPScreenshotNewSurface,PdfUseShowSaveFilePicker --disable-features=AutoDeElevate,AvoidUnnecessaryBeforeUnloadCheckSync,BoundaryEventDispatchTracksNodeRemoval,DestroyProfileOnBrowserClose,DialMediaRouteProvider,GlobalMediaControls,HttpsUpgrades,LensOverlay,LocalNetworkAccessChecks,MediaRouter,Optimizati right/playwright--clearScreen=false ypes/test/tsconfig.json tnet/tools/sh (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

…ill escalation Agent-Logs-Url: https://github.com/microsoft/playwright/sessions/c48dfc8b-1a28-476b-bd4b-5ec7f5a64d83 Co-authored-by: pavelfeldman <883973+pavelfeldman@users.noreply.github.com>

Agent-Logs-Url: https://github.com/microsoft/playwright/sessions/c48dfc8b-1a28-476b-bd4b-5ec7f5a64d83 Co-authored-by: pavelfeldman <883973+pavelfeldman@users.noreply.github.com>

Follow-up to the revert of PR microsoft#40184 that brings the tree to a working state on top of the main-branch changes that landed after the PR: - Re-add Electron protocol entries to packages/protocol/spec/electron.yml and the Electron initializer to packages/protocol/spec/playwright.yml (protocol.yml was split into per-interface spec/*.yml files in microsoft#40645). - Keep Electron docs in docs/src/electron-api/ but restore their pre-PR full content (the PR had truncated docs to match the trimmed-down CDP-only API). doclint cli.js merges electron-api docs. - Drop the leftover docs/src/electron/loader bundling step from utils/build/build.js (loader is back at server/electron/loader.ts). - Update the restored server/electron/electron.ts import after the toConsoleMessageLocation -> stackTraceToLocation rename in microsoft#39767. - Drop the explicit _electron registration from inprocess.ts; with the server-side dispatcher restored, _electron is wired through the Playwright initializer again. - Remove duplicate _electron exports in index.mjs and overrides.d.ts. - Restore the pre-PR ElectronApplication evaluate/evaluateHandle override signatures so the generated types are consistent. Also re-applies the timeout option from microsoft#40613 (electronApp.close({ timeout })) on top of the restored server-side architecture: a new ElectronApplication.close protocol command takes an optional timeout and force-kills the underlying browser process via browserProcess.kill() when graceful close exceeds the deadline.

Copilot · 2026-05-04T21:50:11Z

electronApp.close() waits indefinitely for the Electron process to exit. Apps with before-quit handlers, leaky IPC handlers, or stray child processes can hang teardown until the test-level timeout kills everything. The force-kill path already exists in processLauncher but is only reachable via OS signals.

Changes

packages/playwright-core/src/electron/electron.ts — thread the existing kill from launchProcess into ElectronApplication. Add an opt-in { timeout?: number } to close(): after the existing graceful shutdown (browser.close() → app.quit() → worker._disconnect()), race _closedPromise against a timer; if the timer wins, invoke kill() (SIGKILL / taskkill /T /F) and await full exit.
Backward compatible — without timeout, behavior is unchanged (waits forever, no force-kill).
docs/src/electron-api/class-electronapplication.md — document the new option; types.d.ts regenerated.
Tests — new electron-app-hang-on-close.js fixture (preventDefaults before-quit + keeps the loop busy). Two specs: one asserts force-kill fires near the timeout, one asserts a cooperating app still exits with code 0 (no force-kill).

Usage

// Unchanged: wait forever.awaitelectronApp.close();// New: force-kill if the app does not exit within 10s.awaitelectronApp.close({timeout: 10_000});

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

redirector.gvt1.com
- Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --disable-dev-shm-usage --enable-crash-reporter=856dbc92-6ec9-48ff-ad01-9585c6f246ca,no_channel --user-data-dir=/tmp/playwright-test-UD55eR/Electron --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,11195650865713303302,599583126570378049,262144 --enable-features=CDPScreenshotNewSurface,PdfUseShowSaveFilePicker --disable-features=AutoDeElevate,AvoidUnnecessaryBeforeUnloadCheckSync,BoundaryEventDispatchTracksNodeRemoval,DestroyProfileOnBrowserClose,DialMediaRouteProvider,GlobalMediaControls,HttpsUpgrades,LensOverlay,LocalNetworkAccessChecks,MediaRouter,Optimizati right/playwright--clearScreen=false ypes/test/tsconfig.json /usr/bin/dirname (dns block)
- Triggering command: /home/REDACTED/work/playwright/playwright/node_modules/electron/dist/electron /home/REDACTED/work/playwright/playwright/node_modules/electron/dist/electron -r /home/REDACTED/work/playwright/playwright/packages/playwright-core/lib/electron/loader.js --no-sandbox --inspect=0 --remote-debugging-port=0 /home/REDACTED/work/playwright/playwright/tests/electron/electron-app.js 2/x64/lib/node_modules/npm/node_modules/@npmcli/run-script/lib/node-gyp-bin/sh (dns block)
- Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --disable-dev-shm-usage --enable-crash-reporter=2769063e-04a3-4f49-884c-c9d911de6ba5,no_channel --user-data-dir=/tmp/playwright-test-QcPS47/Electron --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,275575950628164391,10456952859755863149,262144 --enable-features=CDPScreenshotNewSurface,PdfUseShowSaveFilePicker --disable-features=AutoDeElevate,AvoidUnnecessaryBeforeUnloadCheckSync,BoundaryEventDispatchTracksNodeRemoval,DestroyProfileOnBrowserClose,DialMediaRouteProvider,GlobalMediaControls,HttpsUpgrades,LensOverlay,LocalNetworkAccessChecks,MediaRouter,Optimizati right/playwright--clearScreen=false ypes/test/tsconfig.json tnet/tools/sh (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

…ill escalation Agent-Logs-Url: https://github.com/microsoft/playwright/sessions/c48dfc8b-1a28-476b-bd4b-5ec7f5a64d83 Co-authored-by: pavelfeldman <883973+pavelfeldman@users.noreply.github.com>

Agent-Logs-Url: https://github.com/microsoft/playwright/sessions/c48dfc8b-1a28-476b-bd4b-5ec7f5a64d83 Co-authored-by: pavelfeldman <883973+pavelfeldman@users.noreply.github.com>

Follow-up to the revert of PR microsoft#40184 that brings the tree to a working state on top of the main-branch changes that landed after the PR: - Re-add Electron protocol entries to packages/protocol/spec/electron.yml and the Electron initializer to packages/protocol/spec/playwright.yml (protocol.yml was split into per-interface spec/*.yml files in microsoft#40645). - Keep Electron docs in docs/src/electron-api/ but restore their pre-PR full content (the PR had truncated docs to match the trimmed-down CDP-only API). doclint cli.js merges electron-api docs. - Drop the leftover docs/src/electron/loader bundling step from utils/build/build.js (loader is back at server/electron/loader.ts). - Update the restored server/electron/electron.ts import after the toConsoleMessageLocation -> stackTraceToLocation rename in microsoft#39767. - Drop the explicit _electron registration from inprocess.ts; with the server-side dispatcher restored, _electron is wired through the Playwright initializer again. - Remove duplicate _electron exports in index.mjs and overrides.d.ts. - Restore the pre-PR ElectronApplication evaluate/evaluateHandle override signatures so the generated types are consistent. Also re-applies the timeout option from microsoft#40613 (electronApp.close({ timeout })) on top of the restored server-side architecture: a new ElectronApplication.close protocol command takes an optional timeout and force-kills the underlying browser process via browserProcess.kill() when graceful close exceeds the deadline.

Copilot · 2026-05-04T21:50:11Z

electronApp.close() waits indefinitely for the Electron process to exit. Apps with before-quit handlers, leaky IPC handlers, or stray child processes can hang teardown until the test-level timeout kills everything. The force-kill path already exists in processLauncher but is only reachable via OS signals.

Changes

packages/playwright-core/src/electron/electron.ts — thread the existing kill from launchProcess into ElectronApplication. Add an opt-in { timeout?: number } to close(): after the existing graceful shutdown (browser.close() → app.quit() → worker._disconnect()), race _closedPromise against a timer; if the timer wins, invoke kill() (SIGKILL / taskkill /T /F) and await full exit.
Backward compatible — without timeout, behavior is unchanged (waits forever, no force-kill).
docs/src/electron-api/class-electronapplication.md — document the new option; types.d.ts regenerated.
Tests — new electron-app-hang-on-close.js fixture (preventDefaults before-quit + keeps the loop busy). Two specs: one asserts force-kill fires near the timeout, one asserts a cooperating app still exits with code 0 (no force-kill).

Usage

// Unchanged: wait forever.awaitelectronApp.close();// New: force-kill if the app does not exit within 10s.awaitelectronApp.close({timeout: 10_000});

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

redirector.gvt1.com
- Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --disable-dev-shm-usage --enable-crash-reporter=856dbc92-6ec9-48ff-ad01-9585c6f246ca,no_channel --user-data-dir=/tmp/playwright-test-UD55eR/Electron --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,11195650865713303302,599583126570378049,262144 --enable-features=CDPScreenshotNewSurface,PdfUseShowSaveFilePicker --disable-features=AutoDeElevate,AvoidUnnecessaryBeforeUnloadCheckSync,BoundaryEventDispatchTracksNodeRemoval,DestroyProfileOnBrowserClose,DialMediaRouteProvider,GlobalMediaControls,HttpsUpgrades,LensOverlay,LocalNetworkAccessChecks,MediaRouter,Optimizati right/playwright--clearScreen=false ypes/test/tsconfig.json /usr/bin/dirname (dns block)
- Triggering command: /home/REDACTED/work/playwright/playwright/node_modules/electron/dist/electron /home/REDACTED/work/playwright/playwright/node_modules/electron/dist/electron -r /home/REDACTED/work/playwright/playwright/packages/playwright-core/lib/electron/loader.js --no-sandbox --inspect=0 --remote-debugging-port=0 /home/REDACTED/work/playwright/playwright/tests/electron/electron-app.js 2/x64/lib/node_modules/npm/node_modules/@npmcli/run-script/lib/node-gyp-bin/sh (dns block)
- Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=none --no-sandbox --disable-dev-shm-usage --enable-crash-reporter=2769063e-04a3-4f49-884c-c9d911de6ba5,no_channel --user-data-dir=/tmp/playwright-test-QcPS47/Electron --shared-files=v8_context_snapshot_data:100 --field-trial-handle=3,i,275575950628164391,10456952859755863149,262144 --enable-features=CDPScreenshotNewSurface,PdfUseShowSaveFilePicker --disable-features=AutoDeElevate,AvoidUnnecessaryBeforeUnloadCheckSync,BoundaryEventDispatchTracksNodeRemoval,DestroyProfileOnBrowserClose,DialMediaRouteProvider,GlobalMediaControls,HttpsUpgrades,LensOverlay,LocalNetworkAccessChecks,MediaRouter,Optimizati right/playwright--clearScreen=false ypes/test/tsconfig.json tnet/tools/sh (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

…ill escalation Agent-Logs-Url: https://github.com/microsoft/playwright/sessions/c48dfc8b-1a28-476b-bd4b-5ec7f5a64d83 Co-authored-by: pavelfeldman <883973+pavelfeldman@users.noreply.github.com>

Agent-Logs-Url: https://github.com/microsoft/playwright/sessions/c48dfc8b-1a28-476b-bd4b-5ec7f5a64d83 Co-authored-by: pavelfeldman <883973+pavelfeldman@users.noreply.github.com>

Follow-up to the revert of PR microsoft#40184 that brings the tree to a working state on top of the main-branch changes that landed after the PR: - Re-add Electron protocol entries to packages/protocol/spec/electron.yml and the Electron initializer to packages/protocol/spec/playwright.yml (protocol.yml was split into per-interface spec/*.yml files in microsoft#40645). - Keep Electron docs in docs/src/electron-api/ but restore their pre-PR full content (the PR had truncated docs to match the trimmed-down CDP-only API). doclint cli.js merges electron-api docs. - Drop the leftover docs/src/electron/loader bundling step from utils/build/build.js (loader is back at server/electron/loader.ts). - Update the restored server/electron/electron.ts import after the toConsoleMessageLocation -> stackTraceToLocation rename in microsoft#39767. - Drop the explicit _electron registration from inprocess.ts; with the server-side dispatcher restored, _electron is wired through the Playwright initializer again. - Remove duplicate _electron exports in index.mjs and overrides.d.ts. - Restore the pre-PR ElectronApplication evaluate/evaluateHandle override signatures so the generated types are consistent. Also re-applies the timeout option from microsoft#40613 (electronApp.close({ timeout })) on top of the restored server-side architecture: a new ElectronApplication.close protocol command takes an optional timeout and force-kills the underlying browser process via browserProcess.kill() when graceful close exceeds the deadline.

Initial plan
567aadd

CopilotAI assigned Copilot and Pavel Feldman (pavelfeldman)May 4, 2026

Copilotstarted work on behalf of Pavel Feldman (pavelfeldman)May 4, 2026 21:50 View session

CopilotAI linked an issue May 4, 2026 that may be closed by this pull request
feat(electron): add timeout option to electronApp.close() for force-kill escalation #40586
Open

CopilotAIand others added 2 commits May 4, 2026 22:29

feat(electron): add timeout option to electronApp.close() for force-k…
1f3fd77
…ill escalation Agent-Logs-Url: https://github.com/microsoft/playwright/sessions/c48dfc8b-1a28-476b-bd4b-5ec7f5a64d83 Co-authored-by: pavelfeldman <883973+pavelfeldman@users.noreply.github.com>

test(electron): tighten elapsed-time bound on force-kill close test
bd64e55
Agent-Logs-Url: https://github.com/microsoft/playwright/sessions/c48dfc8b-1a28-476b-bd4b-5ec7f5a64d83 Co-authored-by: pavelfeldman <883973+pavelfeldman@users.noreply.github.com>

CopilotAI changed the title ~~[WIP] Add timeout option to electronApp.close() for force-kill escalation~~feat(electron): add timeout option to electronApp.close() for force-kill escalationMay 4, 2026

Copilotfinished work on behalf of Pavel Feldman (pavelfeldman)May 4, 2026 22:31

CopilotAI requested a review from Pavel Feldman (pavelfeldman)May 4, 2026 22:31

Pavel Feldman (pavelfeldman) marked this pull request as ready for review May 4, 2026 22:45

Pavel Feldman (pavelfeldman) mentioned this pull request May 4, 2026
feat(electron): add timeout option to electronApp.close() #40587
Closed

Pavel Feldman (pavelfeldman) approved these changes May 4, 2026
View reviewed changes

Yury Semikhatsky (yury-s) approved these changes May 4, 2026
View reviewed changes

Pavel Feldman (pavelfeldman) merged commit 5263a48 into mainMay 4, 2026
41 of 43 checks passed

Pavel Feldman (pavelfeldman) deleted the copilot/add-timeout-option-to-electronapp-close branch May 4, 2026 23:39

This was referenced May 8, 2026
chore(electron): revert #40184 (move Electron API to a separate package) #40733
Merged
Revert "feat(electron): add timeout option to electronApp.close() for force-kill escalation" #40736
Merged