Uh oh!
There was an error while loading. Please reload this page.
chore: split protocol.yml - #40645
Conversation
85f76b8
into
microsoft:mainUh oh!
There was an error while loading. Please reload this page.
Test results for "MCP"17 failed 1 flaky6925 passed, 1052 skipped Merge workflow run. |
Test results for "tests 1"2 flaky41639 passed, 851 skipped Merge workflow run. |
Follow-up to the revert of PR microsoft#40184 that brings the tree to a working state on top of the main-branch changes that landed after the PR: - Re-add Electron protocol entries to packages/protocol/spec/electron.yml and the Electron initializer to packages/protocol/spec/playwright.yml (protocol.yml was split into per-interface spec/*.yml files in microsoft#40645). - Keep Electron docs in docs/src/electron-api/ but restore their pre-PR full content (the PR had truncated docs to match the trimmed-down CDP-only API). doclint cli.js merges electron-api docs. - Drop the leftover docs/src/electron/loader bundling step from utils/build/build.js (loader is back at server/electron/loader.ts). - Update the restored server/electron/electron.ts import after the toConsoleMessageLocation -> stackTraceToLocation rename in microsoft#39767. - Drop the explicit _electron registration from inprocess.ts; with the server-side dispatcher restored, _electron is wired through the Playwright initializer again. - Remove duplicate _electron exports in index.mjs and overrides.d.ts. - Restore the pre-PR ElectronApplication evaluate/evaluateHandle override signatures so the generated types are consistent. Also re-applies the timeout option from microsoft#40613 (electronApp.close({ timeout })) on top of the restored server-side architecture: a new ElectronApplication.close protocol command takes an optional timeout and force-kills the underlying browser process via browserProcess.kill() when graceful close exceeds the deadline.
Follow-up to the revert of PR microsoft#40184 that brings the tree to a working state on top of the main-branch changes that landed after the PR: - Re-add Electron protocol entries to packages/protocol/spec/electron.yml and the Electron initializer to packages/protocol/spec/playwright.yml (protocol.yml was split into per-interface spec/*.yml files in microsoft#40645). - Keep Electron docs in docs/src/electron-api/ but restore their pre-PR full content (the PR had truncated docs to match the trimmed-down CDP-only API). doclint cli.js merges electron-api docs. - Drop the leftover docs/src/electron/loader bundling step from utils/build/build.js (loader is back at server/electron/loader.ts). - Update the restored server/electron/electron.ts import after the toConsoleMessageLocation -> stackTraceToLocation rename in microsoft#39767. - Drop the explicit _electron registration from inprocess.ts; with the server-side dispatcher restored, _electron is wired through the Playwright initializer again. - Remove duplicate _electron exports in index.mjs and overrides.d.ts. - Restore the pre-PR ElectronApplication evaluate/evaluateHandle override signatures so the generated types are consistent.
Follow-up to the revert of PR microsoft#40184 that brings the tree to a working state on top of the main-branch changes that landed after the PR: - Re-add Electron protocol entries to packages/protocol/spec/electron.yml and the Electron initializer to packages/protocol/spec/playwright.yml (protocol.yml was split into per-interface spec/*.yml files in microsoft#40645). - Keep Electron docs in docs/src/electron-api/ but restore their pre-PR full content (the PR had truncated docs to match the trimmed-down CDP-only API). doclint cli.js merges electron-api docs. - Drop the leftover docs/src/electron/loader bundling step from utils/build/build.js (loader is back at server/electron/loader.ts). - Update the restored server/electron/electron.ts import after the toConsoleMessageLocation -> stackTraceToLocation rename in microsoft#39767. - Drop the explicit _electron registration from inprocess.ts; with the server-side dispatcher restored, _electron is wired through the Playwright initializer again. - Remove duplicate _electron exports in index.mjs and overrides.d.ts. - Restore the pre-PR ElectronApplication evaluate/evaluateHandle override signatures so the generated types are consistent.
No description provided.