Uh oh!
There was an error while loading. Please reload this page.
fix(aria): do not hang ai snapshot on frameset pages - #41816
Conversation
Query "body,frameset" instead of just "body" when taking a snapshot without an explicit selector, following the "document.body" spec. Otherwise, snapshot never resolves on frameset pages that do not have a "body" element. Fixes: microsoft#41784
Test results for "MCP"2 failed 7758 passed, 1249 skipped Merge workflow run. |
Hi, I'm the Playwright bot and I took a first look at the CI failures. 🟢 The two failures are pre-existing flakes — this PR is clearBoth failures are in DetailsThis PR only changes the no-selector aria-snapshot query in Pre-existing flake / infra
No test the diff can reach failed, and everything else passed (7758 passed, 1249 skipped). Triaged by the Playwright bot - agent run |
Test results for "tests 1"1 failed 8 flaky49724 passed, 1156 skipped Merge workflow run. |
Hi, I'm the Playwright bot and I took a first look at the CI failures. 🟡 Two confirmed flakes, plus one failure I can't fully close outThis PR only changes the no-selector aria-snapshot query in DetailsCaused by this PR
Pre-existing flake / infra
Uncertain
Everything else passed (MCP: 7758 passed / 1249 skipped; tests 1: 49724 passed / 1156 skipped, 8 flaky rescued on retry). Triaged by the Playwright bot - agent run |
43e262f
into
microsoft:mainUh oh!
There was an error while loading. Please reload this page.
Summary
body,framesetinstead of justbodywhen taking an aria snapshot without an explicit selector, following thedocument.bodyspec. Otherwise, snapshot never resolves on frameset pages that do not have abodyelement.framesetelements.Fixes#41784