Skip to content

feat(chromium): roll to r1242 - #42356

Open
microsoft-playwright-automation[bot] wants to merge 1 commit into
mainfrom
roll-into-pw-chromium/1242
Open

feat(chromium): roll to r1242#42356
microsoft-playwright-automation[bot] wants to merge 1 commit into
mainfrom
roll-into-pw-chromium/1242

Conversation

@microsoft-playwright-automation

Copy link
Copy Markdown
Contributor

Browser build: https://github.com/microsoft/playwright-browsers/commit/070414d1d6d79233fbac01d4e3503c43affb6b0c. Build has full platform coverage - check that all tests pass there.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

6 failed
❌ [chromium] › mcp/clipboard.spec.ts:19 › clipboard write without permission dialog @mcp-macos-latest-chromium
❌ [chromium] › mcp/clipboard.spec.ts:19 › clipboard write without permission dialog @mcp-windows-latest-chromium
❌ [chromium] › mcp/clipboard.spec.ts:19 › clipboard write without permission dialog @mcp-ubuntu-latest-chromium
❌ [firefox] › mcp/annotate.spec.ts:349 › should annotate when context has no fixed viewport @mcp-windows-latest-firefox
❌ [firefox] › mcp/annotate.spec.ts:386 › should cancel browser_annotate when the MCP request is aborted @mcp-windows-latest-firefox
❌ [firefox] › mcp/annotate.spec.ts:446 › should switch screencast to -s session on show --annotate @mcp-windows-latest-firefox

8136 passed, 1361 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

1 failed
❌ [playwright-test] › playwright.spec.ts:248 › should respect headless in launchPersistent @ubuntu-latest-node26

4 flaky⚠️ [chromium-library] › library/video.spec.ts:294 › screencast › should capture navigation `@frozen-time-library-chromium-linux`
⚠️ [chromium-library] › library/video.spec.ts:736 › screencast › should work with video+trace `@frozen-time-library-chromium-linux`
⚠️ [chromium-page] › page/workers.spec.ts:191 › should attribute network activity for worker inside iframe to the iframe `@chromium-ubuntu-22.04-node20`
⚠️ [chromium-library] › library/video.spec.ts:736 › screencast › should work with video+trace `@chromium-ubuntu-22.04-node22`

51279 passed, 1238 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Hi, I'm the Playwright bot and I took a first look at the CI failures.

🔴 One failure looks caused by this roll

mcp/clipboard.spec.ts:19 fails on Chromium across all three OSes (ubuntu, windows, macos) — navigator.clipboard.readText() comes back "" instead of "Hello from Playwright!". The clipboard write silently no-ops after the r1242 roll. The three Firefox annotate.spec.ts failures are pre-existing flakes and unrelated to this Chromium-only change.

Details

Caused by this PR

  • [chromium] › mcp/clipboard.spec.ts:19 › clipboard write without permission dialog (ubuntu / windows / macos) — real assertion failure, not a timeout: readText() returns "" where the test expects the text it just wrote. This test is otherwise rock-solid — 1 failure in 732 runs in the results DB, and that one failure is this PR's run. Failing on every platform at once is a systematic change, not a flake. Since the only thing this PR does is roll Chromium to r1242 (152.0.7977.54), the roll changed clipboard write/permission behavior. Worth confirming whether Chromium now needs an extra opt-in for clipboard-write, or whether the grant isn't taking effect.

Pre-existing flake / infra

  • [firefox] › mcp/annotate.spec.ts:349 › should annotate when context has no fixed viewport — flakes on Firefox across 5 distinct SHAs in the DB, only one of which is this PR.
  • [firefox] › mcp/annotate.spec.ts:386 › should cancel browser_annotate when the MCP request is aborted — flakes across 7 distinct SHAs.
  • [firefox] › mcp/annotate.spec.ts:446 › should switch screencast to -s session on show --annotate — a well-known flake, failing on 37 distinct SHAs (~5% of Firefox runs).

All three are Firefox-only, and this PR touches nothing but the Chromium binary (browsers.json, Chromium protocol.d.ts, device descriptors, README badges), so it can't be responsible for them.

I'm a first pass, not the final word — but the clipboard signal is strong enough that I'd hold this roll until it's understood.

Triaged by the Playwright bot - agent run

@github-actions

Copy link
Copy Markdown
Contributor

Hi, I'm the Playwright bot and I took a first pass at the CI failures here.

🔴 One failure looks caused by this roll

mcp/clipboard.spec.ts:19 › clipboard write without permission dialog fails on Chromium across all three OSes (Ubuntu, Windows, macOS). This test has never failed on Chromium before (0 of 728 runs in the results DB), and this is a Chromium-only roll to r1242 — clipboard-permission behavior is exactly the kind of thing a browser bump changes. The other four failures are pre-existing flakes.

Details

Caused by this PR

  • [chromium] › mcp/clipboard.spec.ts:19 › clipboard write without permission dialog (@mcp-ubuntu-latest-chromium, @mcp-windows-latest-chromium, @mcp-macos-latest-chromium) — deterministic on every OS, in the browser that this PR rolls. The test grants clipboard-read,clipboard-write and asserts navigator.clipboard.writeText/readText succeed without a permission dialog; a clipboard-permission change in r1242 is the most likely cause. History is clean on Chromium (0/728), so this isn't a flake — it lines up one-to-one with the roll. Worth checking how the new build handles the clipboard permission grant.

Pre-existing flake / infra

  • [firefox] › mcp/annotate.spec.ts:349 › should annotate when context has no fixed viewport, :386 › should cancel browser_annotate when the MCP request is aborted, :446 › should switch screencast to -s session on show --annotate (@mcp-windows-latest-firefox) — Firefox, which this Chromium roll doesn't touch. All three already flake on unrelated SHAs/PRs: :349 failed 4/718 Firefox runs across 4 PRs, :386 4/718 across 3 PRs (also flakes on chrome/msedge), and :446 32/716 (4.5%) across 21 PRs — a well-known flake.
  • [playwright-test] › playwright.spec.ts:248 › should respect headless in launchPersistent (@ubuntu-latest-node26) — same test failed with the identical expect(received).toBe(expected) // Expected: 0 Received: 1 signature on the same node26 bot on unrelated PR fix(aria): do not hang ai snapshot on frameset pages #41816 (sha bc932d0), where a retry rescued it. This roll can't be responsible for that occurrence, and it only shows up on the experimental node26 bot. Pre-existing flake.

Overall: only the Chromium clipboard failure looks like the roll; the rest is pre-existing noise.

Triaged by the Playwright bot - agent run

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 2"

2 fatal errors, not part of any test

28 flaky⚠️ [chromium-page] › page/page-screenshot.spec.ts:504 › page screenshot › should take fullPage screenshots during navigation `@tracing-chromium`
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:23 › launch server › should work `@msedge-dev-windows-latest`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:373 › should produce network events, routing, and annotations for Service Worker `@chrome-ubuntu-22.04`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:213 › should intercept service worker requests (main and within) `@chromium-macos-14-xlarge`
⚠️ [chromium-library] › library/video.spec.ts:495 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) `@chrome-windows-latest`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:179 › serviceWorker(), and fromServiceWorker() work `@chrome-macos-latest`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:301 › should report intercepted service worker requests in HAR `@chrome-macos-latest`
⚠️ [chromium-library] › library/selector-generator.spec.ts:151 › selector generator › should use description when role has no name `@chrome-macos-latest`
⚠️ [chromium-library] › library/selector-generator.spec.ts:170 › selector generator › should try to improve label text by shortening `@chrome-macos-latest`
⚠️ [chromium-library] › library/selector-generator.spec.ts:203 › selector generator › should use ordinal for identical nodes `@chrome-macos-latest`
⚠️ [chromium-library] › library/selector-generator.spec.ts:356 › selector generator › should use nested ordinals `@chrome-macos-latest`
⚠️ [chromium-library] › library/selector-generator.spec.ts:574 › selector generator › should ignore empty data-test-id for candidate consideration `@chrome-macos-latest`
⚠️ [chromium-library] › library/selectors-register.spec.ts:29 › should work `@chrome-macos-latest`
⚠️ [firefox-page] › page/page-emulate-media.spec.ts:144 › should keep reduced motion and color emulation after reload `@tracing-firefox`
⚠️ [firefox-page] › page/page-event-request.spec.ts:181 › should return response body when Cross-Origin-Opener-Policy is set `@tracing-firefox`
⚠️ [firefox-page] › page/page-goto.spec.ts:90 › should work with Cross-Origin-Opener-Policy `@tracing-firefox`
⚠️ [firefox-library] › library/inspector/cli-codegen-csharp.spec.ts:208 › should print context options method override in nunit if options were passed `@firefox-macos-15-large`
⚠️ [firefox-library] › library/inspector/cli-codegen-java.spec.ts:125 › should print a valid basic program in junit `@firefox-macos-15-large`
⚠️ [firefox-library] › library/inspector/cli-codegen-python-async.spec.ts:80 › should save the codegen output to a file if specified `@firefox-macos-15-large`
⚠️ [firefox-library] › library/inspector/cli-codegen-test.spec.ts:20 › should print the correct imports and context options `@firefox-macos-15-large`
⚠️ [firefox-library] › library/screenshot.spec.ts:292 › element screenshot › should restore default viewport after fullPage screenshot `@firefox-macos-15-large`
⚠️ [firefox-page] › page/page-emulate-media.spec.ts:144 › should keep reduced motion and color emulation after reload `@firefox-macos-15-large`
⚠️ [firefox-page] › page/page-event-request.spec.ts:181 › should return response body when Cross-Origin-Opener-Policy is set `@firefox-macos-15-large`
⚠️ [firefox-library] › library/browsercontext-viewport.spec.ts:29 › should set the proper viewport size `@firefox-macos-15-xlarge`
⚠️ [webkit-library] › library/har.spec.ts:472 › should return receive time `@webkit-windows-latest`
⚠️ [webkit-library] › library/trace-viewer.spec.ts:1965 › canvas disabled title `@webkit-macos-15-xlarge`
⚠️ [webkit-library] › library/trace-viewer.spec.ts:1975 › canvas clipping `@webkit-macos-15-xlarge`
⚠️ [webkit-page] › page/page-screenshot.spec.ts:356 › page screenshot › should work for canvas `@webkit-macos-15-xlarge`

110755 passed, 4723 skipped, 6 did not run


Merge workflow run.

@yury-s

Copy link
Copy Markdown
Member

Devin Rousso (@dcrousso) are these clipboard test failures expected? should we update the tests?

@dcrousso

Copy link
Copy Markdown
Contributor

they're not expected, but they're already fixed upstream in https://chromium-review.googlesource.com/c/chromium/src/+/8268727

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@yury-s@dcrousso