Skip to content

feat(webkit): roll to r2355 - #42337

Merged
Yury Semikhatsky (yury-s) merged 1 commit into
mainfrom
roll-into-pw-webkit/2355
Aug 20, 2026
Merged

feat(webkit): roll to r2355#42337
Yury Semikhatsky (yury-s) merged 1 commit into
mainfrom
roll-into-pw-webkit/2355

Conversation

@microsoft-playwright-automation

Copy link
Copy Markdown
Contributor

Browser build: https://github.com/microsoft/playwright-browsers/commit/d28ceab9bf6f9e3beff783e6378184afe65d4b80. Build has full platform coverage - check that all tests pass there.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

2 failed
❌ [chrome] › mcp/config.spec.ts:203 › chromiumSandbox › --sandbox enables the sandbox @mcp-ubuntu-latest-chrome
❌ [webkit] › mcp/cli-killall.spec.ts:42 › kill-all kills filtered dashboard pid @mcp-windows-latest-webkit

8121 passed, 1341 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Hi, I'm the Playwright bot and I took a first look at the CI failures.

🟢 Both failures are pre-existing flakes — this WebKit roll is clear

This PR only bumps browsers.json to WebKit r2355, and neither failing test is tied to the WebKit build. Both flip verdict across many runs on SHAs this PR can't be responsible for.

Details

Overall: The diff is a one-line WebKit roll (packages/playwright-core/browsers.json). One failure is a Chromium-only test (unrelated engine), the other is a process-management test that flakes on every browser. No failure traces back to the roll.

Pre-existing flake / infra

  • [chrome] › mcp/config.spec.ts:203 › chromiumSandbox › --sandbox enables the sandbox — Chromium sandbox test, unrelated to a WebKit roll. Across the results DB it's badly bimodal: failed 9 of 48 runs, passed 39, with 32 more rescued on retry, on unrelated SHAs.

  • [webkit] › mcp/cli-killall.spec.ts:42 › kill-all kills filtered dashboard pid — a process-kill test, not WebKit-version-specific. It flakes across every browser, not just WebKit: webkit failed 5/741, chromium 4/735, chrome 2/739, firefox 1/725, plus retry rescues on each — on SHAs unrelated to this PR.

I'm a first pass, not the final word, but I couldn't find any link between these two and the roll.

Triaged by the Playwright bot - agent run

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

17 flaky⚠️ [chromium-library] › library/global-fetch.spec.ts:293 › should return security details from response `@frozen-time-library-chromium-linux`
⚠️ [chromium-library] › library/har.spec.ts:639 › should have security details `@frozen-time-library-chromium-linux`
⚠️ [chromium-library] › library/global-fetch.spec.ts:293 › should return security details from response `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/har.spec.ts:639 › should have security details `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/global-fetch.spec.ts:293 › should return security details from response `@realtime-time-library-chromium-linux`
⚠️ [chromium-library] › library/har.spec.ts:639 › should have security details `@realtime-time-library-chromium-linux`
⚠️ [chromium-library] › library/global-fetch.spec.ts:293 › should return security details from response `@chromium-ubuntu-22.04-node24`
⚠️ [chromium-library] › library/har.spec.ts:639 › should have security details `@chromium-ubuntu-22.04-node24`
⚠️ [chromium-library] › library/global-fetch.spec.ts:293 › should return security details from response `@chromium-ubuntu-22.04-node20`
⚠️ [chromium-library] › library/har.spec.ts:639 › should have security details `@chromium-ubuntu-22.04-node20`
⚠️ [chromium-library] › library/global-fetch.spec.ts:293 › should return security details from response `@chromium-ubuntu-22.04-node22`
⚠️ [chromium-library] › library/har.spec.ts:639 › should have security details `@chromium-ubuntu-22.04-node22`
⚠️ [firefox-library] › library/global-fetch.spec.ts:293 › should return security details from response `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/har.spec.ts:639 › should have security details `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-page] › page/page-event-request.spec.ts:181 › should return response body when Cross-Origin-Opener-Policy is set `@firefox-ubuntu-22.04-node20`
⚠️ [webkit-library] › library/global-fetch.spec.ts:293 › should return security details from response `@webkit-ubuntu-22.04-node20`
⚠️ [webkit-library] › library/har.spec.ts:639 › should have security details `@webkit-ubuntu-22.04-node20`

51227 passed, 1233 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 2"

1 failed
❌ [playwright-test] › to-have-screenshot.spec.ts:1501 › should throw pretty error if expected PNG file is not a PNG @frozen-time-runner-chromium-linux

64 flaky⚠️ [chromium-library] › library/global-fetch.spec.ts:293 › should return security details from response `@tracing-chromium`
⚠️ [chromium-library] › library/har.spec.ts:639 › should have security details `@tracing-chromium`
⚠️ [chromium-library] › library/global-fetch.spec.ts:293 › should return security details from response `@msedge-dev-windows-latest`
⚠️ [chromium-library] › library/har.spec.ts:639 › should have security details `@msedge-dev-windows-latest`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:373 › should produce network events, routing, and annotations for Service Worker `@chrome-ubuntu-22.04`
⚠️ [chromium-library] › library/global-fetch.spec.ts:293 › should return security details from response `@chrome-ubuntu-22.04`
⚠️ [chromium-library] › library/har.spec.ts:639 › should have security details `@chrome-ubuntu-22.04`
⚠️ [chromium-library] › library/global-fetch.spec.ts:293 › should return security details from response `@msedge-windows-latest`
⚠️ [chromium-library] › library/har.spec.ts:639 › should have security details `@msedge-windows-latest`
⚠️ [chromium-library] › library/global-fetch.spec.ts:293 › should return security details from response `@chromium-windows-latest`
⚠️ [chromium-library] › library/har.spec.ts:639 › should have security details `@chromium-windows-latest`
⚠️ [chromium-library] › library/global-fetch.spec.ts:293 › should return security details from response `@chromium-macos-15-large`
⚠️ [chromium-library] › library/har.spec.ts:639 › should have security details `@chromium-macos-15-large`
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1850 › should not leak recorders `@chromium-macos-15-large`
⚠️ [chromium-page] › page/page-add-init-script-callback.spec.ts:50 › should pass arguments to the callback `@chromium-macos-15-large`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:373 › should produce network events, routing, and annotations for Service Worker `@chromium-macos-14-xlarge`
⚠️ [chromium-library] › library/chromium/oopif.spec.ts:179 › should take screenshot `@chromium-macos-14-xlarge`
⚠️ [chromium-library] › library/global-fetch.spec.ts:293 › should return security details from response `@chromium-macos-14-xlarge`
⚠️ [chromium-library] › library/har.spec.ts:639 › should have security details `@chromium-macos-14-xlarge`
⚠️ [chromium-library] › library/video.spec.ts:736 › screencast › should work with video+trace `@chromium-macos-14-xlarge`
⚠️ [chromium-library] › library/global-fetch.spec.ts:293 › should return security details from response `@chromium-macos-15-xlarge`
⚠️ [chromium-library] › library/har.spec.ts:639 › should have security details `@chromium-macos-15-xlarge`
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1850 › should not leak recorders `@chromium-macos-15-xlarge`
⚠️ [chromium-library] › library/beforeunload.spec.ts:20 › should close browser with beforeunload page `@chrome-windows-latest`
⚠️ [chromium-library] › library/global-fetch.spec.ts:293 › should return security details from response `@chrome-windows-latest`
⚠️ [chromium-library] › library/har.spec.ts:639 › should have security details `@chrome-windows-latest`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:213 › should intercept service worker requests (main and within) `@chrome-beta-ubuntu-22.04`
⚠️ [chromium-library] › library/global-fetch.spec.ts:293 › should return security details from response `@chrome-beta-ubuntu-22.04`
⚠️ [chromium-library] › library/har.spec.ts:639 › should have security details `@chrome-beta-ubuntu-22.04`
⚠️ [chromium-library] › library/beforeunload.spec.ts:130 › should support dismissing the dialog multiple times `@chrome-macos-latest`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:373 › should produce network events, routing, and annotations for Service Worker `@chrome-macos-latest`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:436 › should produce network events, routing, and annotations for Service Worker (advanced) `@chrome-macos-latest`
⚠️ [chromium-library] › library/global-fetch.spec.ts:293 › should return security details from response `@chrome-macos-latest`
⚠️ [chromium-library] › library/har.spec.ts:639 › should have security details `@chrome-macos-latest`
⚠️ [chromium-library] › library/selector-generator.spec.ts:129 › selector generator › should use consistent exactness for name and description `@chrome-macos-latest`
⚠️ [chromium-library] › library/selector-generator.spec.ts:356 › selector generator › should use nested ordinals `@chrome-macos-latest`
⚠️ [chromium-library] › library/selector-generator.spec.ts:430 › selector generator › should prioritize attributes correctly › name `@chrome-macos-latest`
⚠️ [chromium-library] › library/selector-generator.spec.ts:678 › selector generator › should generate noText: no name from content `@chrome-macos-latest`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:373 › should produce network events, routing, and annotations for Service Worker `@driver`
⚠️ [firefox-library] › library/global-fetch.spec.ts:293 › should return security details from response `@tracing-firefox`
⚠️ [firefox-library] › library/har.spec.ts:639 › should have security details `@tracing-firefox`
⚠️ [firefox-page] › page/page-event-request.spec.ts:181 › should return response body when Cross-Origin-Opener-Policy is set `@tracing-firefox`
⚠️ [firefox-library] › library/global-fetch.spec.ts:293 › should return security details from response `@firefox-macos-15-large`
⚠️ [firefox-library] › library/har.spec.ts:639 › should have security details `@firefox-macos-15-large`
⚠️ [firefox-library] › library/inspector/cli-codegen-javascript.spec.ts:104 › should save the codegen output to a file if specified `@firefox-macos-15-large`
⚠️ [firefox-library] › library/trace-viewer-scrub.spec.ts:98 › should support keyboard navigation on scrubber `@firefox-macos-15-large`
⚠️ [firefox-library] › library/global-fetch.spec.ts:293 › should return security details from response `@firefox-windows-latest`
⚠️ [firefox-library] › library/har.spec.ts:639 › should have security details `@firefox-windows-latest`
⚠️ [firefox-library] › library/browsercontext-basic.spec.ts:163 › should propagate default viewport to the page `@firefox-macos-15-xlarge`
⚠️ [firefox-library] › library/browsercontext-basic.spec.ts:170 › should make a copy of default viewport `@firefox-macos-15-xlarge`
⚠️ [firefox-library] › library/browsercontext-viewport.spec.ts:132 › should set both screen and viewport options `@firefox-macos-15-xlarge`
⚠️ [firefox-library] › library/global-fetch.spec.ts:293 › should return security details from response `@firefox-macos-15-xlarge`
⚠️ [firefox-library] › library/har.spec.ts:639 › should have security details `@firefox-macos-15-xlarge`
⚠️ [webkit-library] › library/global-fetch.spec.ts:293 › should return security details from response `@tracing-webkit`
⚠️ [webkit-library] › library/har.spec.ts:639 › should have security details `@tracing-webkit`
⚠️ [webkit-library] › library/global-fetch.spec.ts:293 › should return security details from response `@webkit-windows-latest`
⚠️ [webkit-library] › library/global-fetch.spec.ts:293 › should return security details from response `@webkit-macos-15-xlarge`
⚠️ [webkit-library] › library/har.spec.ts:639 › should have security details `@webkit-macos-15-xlarge`
⚠️ [webkit-library] › library/trace-viewer.spec.ts:1850 › should not leak recorders `@webkit-macos-15-xlarge`
⚠️ [webkit-library] › library/trace-viewer.spec.ts:2076 › should toggle canvas rendering `@webkit-macos-15-xlarge`
⚠️ [webkit-library] › library/browsertype-connect.spec.ts:807 › launchServer › should upload a folder `@webkit-macos-15-large`
⚠️ [webkit-library] › library/browsertype-connect.spec.ts:807 › run-server › should upload a folder `@webkit-macos-15-large`
⚠️ [webkit-library] › library/global-fetch.spec.ts:293 › should return security details from response `@webkit-macos-15-large`
⚠️ [webkit-library] › library/trace-viewer.spec.ts:1850 › should not leak recorders `@webkit-macos-15-large`

110655 passed, 4708 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Hi, I'm the Playwright bot and I took another look after the "tests 2" shard came in.

🟡 One failure I can't fully clear — but it has no plausible link to this roll

to-have-screenshot.spec.ts:1501 failed once on the frozen-time Chromium runner. This is a WebKit-only roll, so it shouldn't be able to reach a Chromium image-decode test — but the test has never failed anywhere else, so I can't call it a proven flake. The two MCP failures from the earlier report are confirmed pre-existing flakes.

Details

Overall: The diff is a one-line WebKit roll (browsers.json → r2355). Nothing in it touches Chromium screenshots, the playwright-test image comparator, or process management, so I don't see a path from the roll to any of these three. Two are clearly pre-existing flakes; the third is a lone one-off I can only mark uncertain.

Uncertain

  • [playwright-test] › to-have-screenshot.spec.ts:1501 › should throw pretty error if expected PNG file is not a PNG (@frozen-time-runner-chromium-linux) — the jpg subtest expected Could not decode expected image as JPEG. but the output only had ...as PNG., i.e. the comparator picked PNG for a JPEG screenshot. This is pure Node-side image-decode logic on a Chromium page — a WebKit binary roll can't reach it. But I can't call it a flake either: across the results DB it's failed 1 of 361 runs on this exact bot, and 0 of 1035 runs everywhere else, and it passed on the realtime-time-runner-chromium-linux sibling in the same run. One-off with no prior occurrence → uncertain, not proven flake. A re-run of that shard should settle it.

Pre-existing flake / infra

  • [chrome] › mcp/config.spec.ts:203 › chromiumSandbox › --sandbox enables the sandbox — a Chromium sandbox test, unrelated to a WebKit roll. Badly bimodal in the DB: failed 16 of 51 runs, passed 35, with 28 more rescued on retry, on unrelated SHAs.

  • [webkit] › mcp/cli-killall.spec.ts:42 › kill-all kills filtered dashboard pid — a process-kill test, not WebKit-version-specific. It flakes on every browser, not just WebKit: webkit 6/842, chromium 5/837, chrome 2/841, firefox 2/823 failed, plus retry rescues on each, on SHAs unrelated to this PR.

I'm a first pass, not the final word — the screenshot one is almost certainly not the roll, but I couldn't prove it, so I left it yellow rather than green.

Triaged by the Playwright bot - agent run

@yury-s
Yury Semikhatsky (yury-s) merged commit bee00ad into mainAug 20, 2026
72 of 75 checks passed
@yury-s
Yury Semikhatsky (yury-s) deleted the roll-into-pw-webkit/2355 branch August 20, 2026 22:57
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@yury-s