Uh oh!
There was an error while loading. Please reload this page.
chore(trace): remove snapshot pointers from action events - #42431
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Snapshots are now addressed by their name, which includes the call id and is therefore unique across the trace, with an optional frameId query parameter for child frames. This makes `BeforeActionTraceEvent.pageId` unnecessary, along with `CallMetadata.pageId` and the never used `CallMetadata.frameId`. The list of pages in the model is now derived from page open/close events. To keep it complete, tracing reports the already open pages when a chunk starts, and no longer reports internal pages, e.g. the one used to collect the storage state, to the instrumentation.
Frame snapshots already carry the call id, so recording their name in the before/input/after action events was redundant. Snapshots now carry the `phase` they were captured at, matching how screenshots and aria snapshots are already keyed, and actions no longer point at them at all. Which phases have a snapshot is derived from the recorded snapshots, so an action whose capture failed now correctly falls back to a neighbouring snapshot instead of pointing at one that was never written. The `trace snapshot` command takes `--phase <before|action|after>` instead of `--name <before|input|after>`.
78d3718 to
3ccf5a2CompareTest results for "tests 1"1 failed 3 flaky51249 passed, 1240 skipped Merge workflow run. |
Test results for "MCP"3 failed 8256 passed, 1361 skipped Merge workflow run. |
Hi, I'm the Playwright bot and I took a first look at the CI failures here. 🟢 The one failure is a pre-existing screencast flake — this PR looks clear
DetailsThis PR changes the trace model, snapshotter, trace-viewer and the Pre-existing flake / infra
Not triaged (flaky, passed on retry)
Triaged by the Playwright bot - agent run |
9a450a2
into
microsoft:mainUh oh!
There was an error while loading. Please reload this page.
Hi, I'm the Playwright bot and I took a look at the CI failures here. 🟢 Both failures are pre-existing flakes/infra — this PR looks clearThe latest runs report a DetailsPre-existing flake / infra
Failing on Triaged by the Playwright bot - agent run |
Summary
callId+phase, the same way screenshots and aria snapshots already are.BeforeActionTraceEvent.pageId,beforeSnapshot,inputSnapshotandafterSnapshot, plus the now unusedCallMetadata.pageId/CallMetadata.frameId.trace snapshottakes--phase <before|action|after>instead of--name <before|input|after>.