Uh oh!
There was an error while loading. Please reload this page.
chore(recorder): move fill coalescing back to collapseActions - #42442
chore(recorder): move fill coalescing back to collapseActions#42442Dmitry Gozman (dgozman) wants to merge 1 commit into
Conversation
Revert the fill part of RecorderSignalProcessor buffering, and bring back the "actionUpdated" event together with client-side collapseActions(). Click and navigate coalescing stays in the signal processor.
Test results for "tests 1"10 flaky51243 passed, 1240 skipped Merge workflow run. |
Test results for "MCP"3 failed 8256 passed, 1361 skipped Merge workflow run. |
Hi, I'm the Playwright bot and I took a look at the failing CI. 🟢 CI is clear — the one failure is pre-existing, not from this PRThe only real failures are DetailsOverall: nothing in this diff explains the failures. It moves Pre-existing flake / infra
No real failures elsewhere
Triaged by the Playwright bot - agent run |
| else | ||
| recordedActions.push(code); | ||
| }, | ||
| signalAdded: (page, signal, code) => { |
There was a problem hiding this comment.
should we remove this handler now that there is an explicit actionUpdated event?
Summary
Partially reverts #41958:
RecorderSignalProcessorno longer buffersfillactions; click and navigate coalescing stays there.shouldMergeAction()/collapseActions()(fill-only now) and theactionUpdatedprotocol event.#41958 forced quick typing into the same input - a pause over 500ms would generate two separate
fill()actions, which is a behavior change we don't necessarily need to make yet.