Skip to content
This repository was archived by the owner on May 20, 2025. It is now read-only.

Replace DevInternalSettings with DeveloperSettings for react-native 0.73.0 - #2617

Merged
Dmitriy Kirakosyan (DmitriyKirakosyan) merged 4 commits into
masterfrom
support-rn-0.73
Jan 17, 2024
Merged

Replace DevInternalSettings with DeveloperSettings for react-native 0.73.0#2617
Dmitriy Kirakosyan (DmitriyKirakosyan) merged 4 commits into
masterfrom
support-rn-0.73

Conversation

@DmitriyKirakosyan

Copy link
Copy Markdown
Contributor

DevInternalSettings was enclosed in ReactNative 0.73.0-rc.2, so we need to replace it with public class DeveloperSettings.

#2601
AB#103487

DevInternalSettings was enclosed in ReactNative 0.73.0-rc.2, so we need to replace it with public class DeveloperSettings.
react/react-native#37256
@velimirj

Copy link
Copy Markdown

/azp run

@azure-pipelines

Copy link
Copy Markdown
Commenter does not have sufficient privileges for PR 2617 in repo microsoft/react-native-code-push

@lucen-ms

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
No pipelines are associated with this pull request.

@serybva

Copy link
Copy Markdown

Hey guys, any plans to merge this soon? Lukas Cenovsky (@lucen-ms)velimirj

velimir-jankovic
velimir-jankovic previously approved these changes Dec 14, 2023
@larsmunkholm

Copy link
Copy Markdown

I need this

@agusvazquez

Can we merge this? Right now 0.73 is broken. I made it work using a patch.

@yevhenlv

Copy link
Copy Markdown

Can't update RN version.... hope for faster result)

@lernerb

Copy link
Copy Markdown

This is blocking multiple production apps from using react native code push, and is making us reconsider using it long term if it's not going to be supported in a timely manner. It's been two months, is this getting fixed or not?

@lernerb

Copy link
Copy Markdown

Also bumping for visibility to Anatoly Pristensky (@AnatolyPristensky) 👍

@agusvazquez

For all facing this issue, you can use this tool as a temporal fix until this is merged and released.

https://www.npmjs.com/package/patch-package

@caiodeambrosio

Copy link
Copy Markdown

need this

@aderiushev

Copy link
Copy Markdown

need this!

@huextrat

Copy link
Copy Markdown

Hi Dmitriy Kirakosyan (@DmitriyKirakosyan)Anatoly Pristensky (@AnatolyPristensky)velimir-jankovic Can one of you press the green button please?

@mchtkuk

Copy link
Copy Markdown

need this

@olegklimakov

Copy link
Copy Markdown

Hi. Any plans to release this change?

@caiodeambrosio

Copy link
Copy Markdown

Release please 🙏🏽😬

@AnatolyPristensky

Copy link
Copy Markdown
Contributor

caiodeambrosio, release 8.2.0 is available.

@larsmunkholm

Lars Munkholm (larsmunkholm) commented Jan 23, 2024

Copy link
Copy Markdown

caiodeambrosio, release 8.2.0 is available.

There's a bug, so maybe wait
#2649

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

17 participants

@DmitriyKirakosyan@velimirj@lucen-ms@serybva@larsmunkholm@agusvazquez@yevhenlv@lernerb@caiodeambrosio@aderiushev@huextrat@mchtkuk@olegklimakov@AnatolyPristensky@Dallas62@velimir-jankovic@MikhailSuendukov