Uh oh!
There was an error while loading. Please reload this page.
Reduce visibility of DevInternalSettings class - #37256
Closed
cortinico wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
commented
May 4, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D45566473 |
Summary: Pull Request resolved: react#37256 This class is public but annotated with VisibleForTesting which is not correct (as there are no tests for it). Apparently this class is used only within this package so it's safe to reduce its visibility to package internal. On top of this, we had methods which were not annotated with Override, which I've fixed + I've sorted the methods to have first all the public/Override ones and the then others after. Changelog: [Android] [Removed] - Reduce visibility of DevInternalSettings class Reviewed By: mdvacca Differential Revision: D45566473 fbshipit-source-id: 41cc0d584c328125a7866e15b483b2206958cd80
facebook-github-bot
commented
May 4, 2023
Contributor
This pull request was exported from Phabricator. Differential Revision: D45566473 |
analysis-bot
commented
May 4, 2023
Base commit: 4c91e8a |
facebook-github-bot
commented
May 4, 2023
Contributor
This pull request has been merged in 1a9e444. |
DmitriyKirakosyan added a commit
to microsoft/react-native-code-push
that referenced
this pull request
Nov 9, 2023
DevInternalSettings was enclosed in ReactNative 0.73.0-rc.2, so we need to replace it with public class DeveloperSettings. react/react-native#37256
DmitriyKirakosyan added a commit
to microsoft/react-native-code-push
that referenced
this pull request
Jan 17, 2024
….73.0 (#2617) * Replace DevInternalSettings with DeveloperSettings DevInternalSettings was enclosed in ReactNative 0.73.0-rc.2, so we need to replace it with public class DeveloperSettings. react/react-native#37256 * auto install cocoapods in tests --------- Co-authored-by: velimir-jankovic <84719115+velimir-jankovic@users.noreply.github.com> Co-authored-by: JiglioNero <mikhail.suendukov@akvelon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This class is public but annotated with VisibleForTesting which is not correct (as there are no tests for it).
Apparently this class is used only within this package so it's safe to reduce its visibility to package internal.
On top of this, we had methods which were not annotated with Override, which I've fixed + I've sorted the methods to have first all the public/Override ones and the then others after.
Changelog:
[Android] [Removed] - Reduce visibility of DevInternalSettings class
Reviewed By: mdvacca
Differential Revision: D45566473