Skip to content

Fix transforms - #1035

Merged
Saad Najmi (Saadnajmi) merged 6 commits into
microsoft:mainfrom
Saadnajmi:fix-transforms-new
Feb 26, 2022
Merged

Fix transforms #1035
Saad Najmi (Saadnajmi) merged 6 commits into
microsoft:mainfrom
Saadnajmi:fix-transforms-new

Conversation

@Saadnajmi

@SaadnajmiSaad Najmi (Saadnajmi) commented Feb 21, 2022•
edited
Loading

Copy link
Copy Markdown
Collaborator

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

This picks up where #280 and #460 left off, fixing animations on macOS.

Changelog

[macOS] [Fixed] - Fixed 3D Transforms not working properly

Test Plan

RN-Tester's transform page look identical on both iOS and macOS

Screen Shot 2022-02-25 at 12 24 55 PM

@Saadnajmi
Saad Najmi (Saadnajmi) requested a review from a team as a code ownerFebruary 21, 2022 20:44
@SaadnajmiSaad Najmi (Saadnajmi) mentioned this pull request Feb 25, 2022
Closed
4 tasks
@SaadnajmiSaad Najmi (Saadnajmi) changed the title [Draft] Fix transforms Fix transforms Feb 25, 2022
harrieshin
Harrie Shin (harrieshin) reviewed Feb 25, 2022
View reviewed changes
Comment threadReact/Views/RCTView.m Outdated
harrieshin
Harrie Shin (harrieshin) reviewed Feb 25, 2022
View reviewed changes
Comment threadpackages/rn-tester/RNTesterPods.xcodeproj/project.pbxproj
harrieshin
Harrie Shin (harrieshin) reviewed Feb 25, 2022
View reviewed changes
Comment threadReact/Views/RCTView.m
@Saadnajmi
Saad Najmi (Saadnajmi) merged commit e7cfa13 into microsoft:mainFeb 26, 2022
@Saadnajmi
Saad Najmi (Saadnajmi) deleted the fix-transforms-new branch February 26, 2022 03:33
Saad Najmi (Saadnajmi) added a commit to Saadnajmi/react-native-macos that referenced this pull request Feb 27, 2022
@Saadnajmi@sahrens
Fix transforms (microsoft#1035)
1d576f1
* fix transforms microsoft#280
* remove duplicate
* fix errors
* Update from PR feedback
Co-authored-by: Spencer Ahrens <spencer.ahrens@gmail.com>
@SaadnajmiSaad Najmi (Saadnajmi) mentioned this pull request Feb 27, 2022
Merged
@jdk

Jason Kotzin (jdk) commented Feb 28, 2022•
edited
Loading

Copy link
Copy Markdown

Saad Najmi (@Saadnajmi) We did some testing and this looks great, thank you.

@Saadnajmi

Saad Najmi (Saadnajmi) commented Feb 28, 2022

Copy link
Copy Markdown
CollaboratorAuthor

Saad Najmi (@Saadnajmi) We did some testing and this looks great, thank you.

Thanks! It should be included in the next patch release of rn-macOS 0.66 =)

Saad Najmi (Saadnajmi) added a commit that referenced this pull request Feb 28, 2022
@Saadnajmi@sahrens
[0.66] Cherry pick Transforms fix and CI fix (#1058)
874bd4e
* Fix transforms (#1035)
* fix transforms #280
* remove duplicate
* fix errors
* Update from PR feedback
Co-authored-by: Spencer Ahrens <spencer.ahrens@gmail.com>
* Disable failing CircleCI test (#1052)
* Disable circleci test
* Disable another test
Co-authored-by: Spencer Ahrens <spencer.ahrens@gmail.com>
@SaadnajmiSaad Najmi (Saadnajmi) mentioned this pull request Aug 9, 2022
Closed
@SaadnajmiSaad Najmi (Saadnajmi) mentioned this pull request Nov 21, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@harrieshinHarrie Shin (harrieshin)harrieshin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Saadnajmi@jdk@harrieshin@sahrens