Skip to content

[0.66] Cherry pick Transforms fix and CI fix - #1058

Merged
Saad Najmi (Saadnajmi) merged 2 commits into
microsoft:0.66-stablefrom
Saadnajmi:99-picks
Feb 28, 2022
Merged

[0.66] Cherry pick Transforms fix and CI fix#1058
Saad Najmi (Saadnajmi) merged 2 commits into
microsoft:0.66-stablefrom
Saadnajmi:99-picks

Conversation

@Saadnajmi

@SaadnajmiSaad Najmi (Saadnajmi) commented Feb 27, 2022•
edited
Loading

Copy link
Copy Markdown
Collaborator

Cherry pick #1035 and #1052 into 0.66-stable.

Summary

Changelog

[CATEGORY] [TYPE] - Message

Test Plan

@Saadnajmi@sahrens
Fix transforms (microsoft#1035)
1d576f1
* fix transforms microsoft#280
* remove duplicate
* fix errors
* Update from PR feedback
Co-authored-by: Spencer Ahrens <spencer.ahrens@gmail.com>
@Saadnajmi
Disable failing CircleCI test (microsoft#1052)
bf5951c
* Disable circleci test
* Disable another test
@pull-bot

Pull Request Analyser (pull-bot) commented Feb 27, 2022

Copy link
Copy Markdown
Fails
🚫

❔ This pull request needs a description.

Warnings
⚠️

❔ Base Branch - The base branch for this PR is something other than main. Are you sure you want to merge these changes into a stable release? If you are interested in backporting updates to an older release, the suggested approach is to land those changes on main first and then cherry-pick the commits into the branch for that release. The Releases Guide has more information.

Messages
📖

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

DetailsCATEGORY may be:
  • General
  • macOS
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

📖📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against bf5951c

@Saadnajmi
Saad Najmi (Saadnajmi) requested a review from a teamFebruary 27, 2022 05:46
@Saadnajmi
Saad Najmi (Saadnajmi) merged commit 874bd4e into microsoft:0.66-stableFeb 28, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@harrieshinHarrie Shin (harrieshin)harrieshin approved these changes
@alloyEloy Durán (alloy)Awaiting requested review from alloy

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Saadnajmi@pull-bot@harrieshin