Skip to content

Remove comment on merging stable branches -> main - #1595

Merged
Saad Najmi (Saadnajmi) merged 1 commit into
microsoft:mainfrom
Saadnajmi:remove-comment
Dec 22, 2022
Merged

Remove comment on merging stable branches -> main#1595
Saad Najmi (Saadnajmi) merged 1 commit into
microsoft:mainfrom
Saadnajmi:remove-comment

Conversation

@Saadnajmi

Copy link
Copy Markdown
Collaborator

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

Back in #944 , I had added a comment about merging stable branches into our main branch. We have then since learned and documented that we shouldn't be doing that: main should merge to main, and stable should either have merges from upstream stable, or cherry picks.

Let's remove the comment, removing another diff from our repo.

Changelog

[Internal] [Removed] - Remove comment on merging stable branches -> main

Test Plan

Removing a comment, nothing should be affected.

@Saadnajmi
Saad Najmi (Saadnajmi) requested a review from a team as a code ownerDecember 19, 2022 18:21
@analysis-bot

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
ios-universaln/a--

Base commit: e71b094
Branch: main

@Saadnajmi
Saad Najmi (Saadnajmi) merged commit ec1a9f2 into microsoft:mainDec 22, 2022
@Saadnajmi
Saad Najmi (Saadnajmi) deleted the remove-comment branch January 15, 2023 23:46
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Saadnajmi@analysis-bot@chiuam