Skip to content

Remove hardcoded 0.6x.x version numbers from main branch - #944

Merged
Saad Najmi (Saadnajmi) merged 8 commits into
microsoft:mainfrom
Saadnajmi:fix-ci
Feb 7, 2022
Merged

Remove hardcoded 0.6x.x version numbers from main branch #944
Saad Najmi (Saadnajmi) merged 8 commits into
microsoft:mainfrom
Saadnajmi:fix-ci

Conversation

@Saadnajmi

Copy link
Copy Markdown
Collaborator

This reverts commit 7100756.

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

There are several places in the react native repo where the version number is hardcoded. On the *-stable branches, the version matches the actual version. On main/master, the version number is set to 1000.0.0 (To make it obvious the tip of the repo is not an official version of RN). At some point in one of our merges, we didn't revert the version number, meaning we were reporting we are still 0.63.3. Coincidentally, I'm pretty sure this is heavily related to why our circle-ci job fails.

Let's fix the version numbers back to 1000.0.0

Changelog

[Internal] [Fixed] - Set main branch version numbers back to 1000.0.0

Test Plan

@SaadnajmiSaad Najmi (Saadnajmi) changed the title Remove hardcoded 0.63.3 version numbers from mainRemove hardcoded 0.63.3 version numbers from main branch Jan 9, 2022
@SaadnajmiSaad Najmi (Saadnajmi) mentioned this pull request Jan 19, 2022
4 tasks
@Saadnajmi

Copy link
Copy Markdown
CollaboratorAuthor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 3 pipeline(s).

Comment threadtemplate/package.json
@kelset

Copy link
Copy Markdown

hey Saad Najmi (@Saadnajmi) now that the main branch has merged back stuff from the 0.66 stable is this still needed? I think that if the answer is yes it'd be great to get it in soon :) I'm sure that a quick rebase then CI should be ✅ and we can 🚢 it :)

Comment threadLibraries/Core/ReactNativeVersion.js
@SaadnajmiSaad Najmi (Saadnajmi) changed the title Remove hardcoded 0.63.3 version numbers from main branch Remove hardcoded 0.6x.x version numbers from main branch Feb 7, 2022
@Saadnajmi
Saad Najmi (Saadnajmi) merged commit cf2105f into microsoft:mainFeb 7, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Saadnajmi@kelset@HeyImChris