Skip to content

chore: remove props validKeysDown, validKeysUp, and passThroughAllKeyEvents - #1615

Merged
Saad Najmi (Saadnajmi) merged 6 commits into
microsoft:mainfrom
Saadnajmi:keyDownEvents
Jan 15, 2025
Merged

chore: remove props validKeysDown, validKeysUp, and passThroughAllKeyEvents#1615
Saad Najmi (Saadnajmi) merged 6 commits into
microsoft:mainfrom
Saadnajmi:keyDownEvents

Conversation

@Saadnajmi

@SaadnajmiSaad Najmi (Saadnajmi) commented Jan 3, 2023

Copy link
Copy Markdown
Collaborator

Note: Don't merge until #2171 has landed

Summary:

Followup to #2171 , remove the JS and native handling for validKeysDown, validKeysUp, and passThroughAllKeyEvents. On the native side, rework the native handling to take the props keyDownEvents and keyUpEvents instead.

Test Plan:

Updated the RNTester example.

@pull-bot

Pull Request Analyser (pull-bot) commented Jan 3, 2023

Copy link
Copy Markdown
Messages
📖

📋 Verify Changelog Format - A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

DetailsCATEGORY may be:
  • General
  • macOS
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against 09137a92987643513dab051c09c5dc7d915f55ef

@github-actions

github-actionsBot commented Jul 5, 2023

Copy link
Copy Markdown
Fails
🚫

📋 Verify Changelog Format - A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

DetailsCATEGORY may be:
  • General
  • macOS
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Warnings
⚠️

Libraries/NativeComponent/BaseViewConfig.macos.js#L13 - Libraries/NativeComponent/BaseViewConfig.macos.js line 13 – Requires should be sorted alphabetically (lint/sort-imports)

Generated by 🚫 dangerJS against dfa985df46f93ce0b6496b014b2cc1b07e5aa4b2

@SaadnajmiSaad Najmi (Saadnajmi) changed the title [Draft] Add support for keyDownEvents and keyUpEventsRemove validKeysDown, validKeysUp, passThroughAllKeyEventsAug 22, 2024
@Saadnajmi
Saad Najmi (Saadnajmi) marked this pull request as ready for review August 22, 2024 07:59
@Saadnajmi
Saad Najmi (Saadnajmi) requested a review from a team as a code ownerAugust 22, 2024 07:59
@Saadnajmi
Saad Najmi (Saadnajmi)force-pushed the keyDownEvents branch 5 times, most recently from 38371f2 to 5856e32CompareAugust 23, 2024 00:49
@SaadnajmiSaad Najmi (Saadnajmi) changed the title Remove validKeysDown, validKeysUp, passThroughAllKeyEventschore: remove props validKeysDown, validKeysUp, and passThroughAllKeyEventsDec 13, 2024
@Saadnajmi
Saad Najmi (Saadnajmi) merged commit a3f5c10 into microsoft:mainJan 15, 2025
@Saadnajmi
Saad Najmi (Saadnajmi) deleted the keyDownEvents branch January 15, 2025 22:17
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Saadnajmi@pull-bot@tido64