Uh oh!
There was an error while loading. Please reload this page.
[DRAFT] fix(fabric, Text): render with NSTextView + support text selection - #2673
Closed
Saad Najmi (Saadnajmi) wants to merge 3 commits into
Closed
[DRAFT] fix(fabric, Text): render with NSTextView + support text selection#2673Saad Najmi (Saadnajmi) wants to merge 3 commits into
Saad Najmi (Saadnajmi) wants to merge 3 commits into
Conversation
CollaboratorAuthor
There was a problem hiding this comment.
Don't want else here
Saad Najmi (Saadnajmi) added a commit
that referenced
this pull request
Sep 10, 2025
## Summary: Revert #2286 There are 3 commits that make Text Selection work via NSTextView on Fabric, but we only ever merged two of them in. The 3rd (currently in #2673 ) is a work-in-progress, as it currently doesn't work. I need to debug why text selection doesn't work, but as it stands, the diffs to render with an NSTextView add more complexity for not much gain without it. I'd rather reland all the commits together and test with an implementation of Text closer to iOS in the meanwhile. ## Test Plan: CI should pass
Summary: Override the hitTest and mouseDown handler in `RCTParagraphComponentView` to forward mouse drag events to the underlying NSTextView to get text selection support in Fabric with correct rendering. Test Plan: - Run Zeratul with Fabric enabled. - Select text https://pxl.cl/3q3b3 Reviewers: shawndempsey, chpurrer, #rn-desktop Reviewed By: shawndempsey Differential Revision: https://phabricator.intern.facebook.com/D49465174 Tasks: T163838519
Saad Najmi (Saadnajmi)force-pushed
the
fabric/selection
branch
from
September 10, 2025 22:15
d9e3280 to
82ee34fCompareSaad Najmi (Saadnajmi)force-pushed
the
fabric/selection
branch
from
September 10, 2025 22:19
82ee34f to
5db7cd1Compare8 tasks
Saad Najmi (Saadnajmi)
commented
Mar 21, 2026
CollaboratorAuthor
Succeeded by #2864 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Cherry pick a commit from #2117 to support Text selection, along with some changes to
RCTSurfaceTouchHandlerfrom #2394Test Plan:
Todo