Uh oh!
There was an error while loading. Please reload this page.
fix: revert "render Text in an NSTextView (#2286)" - #2676
Merged
Conversation
…tentView" This reverts commit 22b7063.
Adam Gleitman (amgleitman)
approved these changes
Sep 6, 2025
Saad Najmi (Saadnajmi)
enabled auto-merge (squash)
September 10, 2025 01:00
Saad Najmi (Saadnajmi)
disabled auto-merge
September 10, 2025 14:00
Uh oh!
There was an error while loading. Please reload this page.
Saad Najmi (Saadnajmi) added a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Sep 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Revert #2286
There are 3 commits that make Text Selection work via NSTextView on Fabric, but we only ever merged two of them in. The 3rd (currently in #2673 ) is a work-in-progress, as it currently doesn't work.
I need to debug why text selection doesn't work, but as it stands, the diffs to render with an NSTextView add more complexity for not much gain without it. I'd rather reland all the commits together and test with an implementation of Text closer to iOS in the meanwhile.
Test Plan:
CI should pass