Uh oh!
There was an error while loading. Please reload this page.
chore(fabric): implement focus view props - #2692
Merged
Merged
Conversation
Saad Najmi (Saadnajmi)
marked this pull request as ready for review
September 19, 2025 18:37
Andrew Coates (acoates-ms)
approved these changes
Sep 19, 2025
Saad Najmi (Saadnajmi)
enabled auto-merge (squash)
September 19, 2025 19:17
Uh oh!
There was an error while loading. Please reload this page.
Saad Najmi (Saadnajmi) added a commit
that referenced
this pull request
Sep 23, 2025
## Summary: Followup to #2692 , we need to add `focus` and `blur` to the View native components' commands, and implement them so they can be called by JS. This matches what is later implemented upstream in react@3e58380 ## Test Plan: `ref.current?.focus()` actually works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs #2690 to land first.
Summary:
Implement focus on RCTViewComponentView. Much of the implementation is taken from #1437, #2117 and comparing against
RCTView. The border path used fordrawFocusRingMaskis the same as what is used for box shadows and cursors.Test Plan:
The focus loop seems nonexistent on both paper and Fabric in RNTester... but I can verify that calling
ref.current?/.focus()on a Pressable displays the focus ring