Uh oh!
There was an error while loading. Please reload this page.
feat(fabric): Add macOS host platform to ReactCommon - #2690
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
43c25ad to
45957eaCompareAnother Q: Should we exclude the They're all files that most just namespace the base class, so they're safe to compile. namespacefacebook::react {
using HostPlatformFoo= BaseFoo;
} // namespace facebook::reactThe annoying part is they both show up in Xcode and it's hard to tell which one you want to edit. The counterargument would be that we would have different files included in our build for iOS vs macOS which might make building more annoying |
45957ea to
1a0b81aCompareUh oh!
There was an error while loading. Please reload this page.
Needs #2690 to land first. ## Summary: Implement focus on RCTViewComponentView. Much of the implementation is taken from #1437, #2117 and comparing against `RCTView`. The border path used for `drawFocusRingMask` is the same as what is used for box shadows and cursors. ## Test Plan: The focus loop seems nonexistent on both paper and Fabric in RNTester... but I can verify that calling `ref.current?/.focus()` on a Pressable displays the focus ring
Summary:
Add a new macOS host platform folder, with overrides for some of the HostPlatform* files to implement some macOS only props. This follows the pattern in React Native Core that Android uses, and what React Native Windows does.
Some notes:
RCTPullToRefreshViewComponentView.mm. This is later fixed upstream so we can remove the diff then.RCTViewComponentViewyet, that will be in a future PR)Test Plan:
CI should pass.