Skip to content

fix: keyDownEvents stops propogation, default events for Pressable - #2720

Merged
Saad Najmi (Saadnajmi) merged 22 commits into
microsoft:mainfrom
Saadnajmi:keyboard-events
Oct 9, 2025
Merged

fix: keyDownEvents stops propogation, default events for Pressable#2720
Saad Najmi (Saadnajmi) merged 22 commits into
microsoft:mainfrom
Saadnajmi:keyboard-events

Conversation

@Saadnajmi

@SaadnajmiSaad Najmi (Saadnajmi) commented Oct 8, 2025•
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary:

Two changes:

Test Plan:

Updated the test page:
Screenshot 2025-10-07 at 5 29 00 PM

@Saadnajmi
Saad Najmi (Saadnajmi) requested a review from a team as a code ownerOctober 8, 2025 00:30
tido64
Tommy Nguyen (tido64) reviewed Oct 8, 2025
View reviewed changes
Comment threadpackages/react-native/Libraries/Components/Pressable/Pressable.js Outdated
Comment threadpackages/react-native/Libraries/Components/TextInput/TextInput.js Outdated
Comment threadpackages/react-native/Libraries/Components/TextInput/TextInput.js Outdated
Comment threadpackages/react-native/Libraries/Components/TextInput/TextInput.js Outdated
Comment threadpackages/react-native/Libraries/Components/TextInput/TextInput.js Outdated
Comment threadpackages/react-native/Libraries/Components/TextInput/TextInput.js Outdated
Comment threadpackages/react-native/Libraries/Components/View/View.js Outdated
Comment threadpackages/react-native/Libraries/Components/View/View.js Outdated
Comment threadpackages/react-native/Libraries/Components/View/View.js Outdated
Comment threadpackages/react-native/Libraries/Components/View/View.js Outdated
@Saadnajmi@tido64
Update TextInput.js
5b485b8
Co-authored-by: Tommy Nguyen <4123478+tido64@users.noreply.github.com>
@Saadnajmi@tido64
Update TextInput.js
630d8a4
Co-authored-by: Tommy Nguyen <4123478+tido64@users.noreply.github.com>
@Saadnajmi@tido64
Update TextInput.js
b0cdbe0
Co-authored-by: Tommy Nguyen <4123478+tido64@users.noreply.github.com>
@Saadnajmi@tido64
Update TextInput.js
e65780a
Co-authored-by: Tommy Nguyen <4123478+tido64@users.noreply.github.com>
@Saadnajmi@tido64
Update View.js
50bc924
Co-authored-by: Tommy Nguyen <4123478+tido64@users.noreply.github.com>
@Saadnajmi@tido64
Update View.js
4e2d565
Co-authored-by: Tommy Nguyen <4123478+tido64@users.noreply.github.com>
@Saadnajmi@tido64
Update View.js
50332dc
Co-authored-by: Tommy Nguyen <4123478+tido64@users.noreply.github.com>
@Saadnajmi@tido64
Update View.js
a5bd962
Co-authored-by: Tommy Nguyen <4123478+tido64@users.noreply.github.com>
@Saadnajmi
Merge branch 'main' into keyboard-events
2a087e6
@Saadnajmi
Update Pressable.js
3d6203f
@Saadnajmi
Add bubbling explainer
68dcc40
@Saadnajmi
fix comparison
d666814
@Saadnajmi
Update example more
7d9bebc
@Saadnajmi
More updates
06fe614
@Saadnajmi
use Boolean more
39c1dfe
@Saadnajmi
Only pass in modified onKeyDown and onKeyUp if specified.
805e87f
@Saadnajmi
fix flow errors
844ff67
@Saadnajmi
prettier fix
a8cf49e
@Saadnajmi
Merge branch 'main' into keyboard-events
bedbc9c
@Saadnajmi
Saad Najmi (Saadnajmi) merged commit 55dbdfe into microsoft:mainOct 9, 2025
39 checks passed
@Saadnajmi
Saad Najmi (Saadnajmi) deleted the keyboard-events branch October 9, 2025 19:09
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tido64Tommy Nguyen (tido64)tido64 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Saadnajmi@tido64