Uh oh!
There was an error while loading. Please reload this page.
Call event.stopPropagation() with keyDownEvents specified. - #8077
Merged
Igor Klemenski (rectified95) merged 5 commits intoJul 8, 2021
Conversation
Nick Gerleman (NickGerleman)
approved these changes
Jun 22, 2021
Igor Klemenski (rectified95)force-pushed
the
stop_propagation
branch
from
June 22, 2021 21:02
2c09a24 to
03542f1CompareJon Thysell (jonthysell)
approved these changes
Jun 22, 2021
| const _keyUp = (event: KeyEvent) => { | ||
| if (props.keyUpEvents && !event.isPropagationStopped) { | ||
| for (const el of props.keyUpEvents) { | ||
| if (event.nativeEvent.code == el.code && el.handledEventPhase == 3) { |
Contributor
There was a problem hiding this comment.
Is there a constant somewhere we can use (or define) so as to not require a magic number here (and elsewhere)?
Uh oh!
There was an error while loading. Please reload this page.
Igor Klemenski (rectified95)force-pushed
the
stop_propagation
branch
from
July 1, 2021 20:03
b599e12 to
017845eCompareIgor Klemenski (rectified95)force-pushed
the
stop_propagation
branch
from
July 7, 2021 22:20
6856878 to
0e5a605Compare4 tasks
Saad Najmi (Saadnajmi) added a commit
to microsoft/react-native-macos
that referenced
this pull request
Oct 9, 2025
…2720) ## Summary: Two changes: - Similar to microsoft/react-native-windows#8077 , we would like to have JS event propagation (as well as native) stop if `keyDownEvents` or `keyUpEvents` is specified. - Add `Space` and `Enter` as default keyDown events for Pressable, to more closely match a button. ## Test Plan: Updated the test page:  --------- Co-authored-by: Tommy Nguyen <4123478+tido64@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
key(Down|Up)Eventsprops control whether the event handling should be left exclusively to the JS, or at least the native processing should stop at the native control emitting it. This is to match this behavior on the JS side, by hooking into theonKeyDown|Capturecallback and using event.stopPropagation() on the keys specified inkeyDownEvents.The change is in
Viewand so works forPressabletoo. I've made sure that the existing hooks inPressable, which special-caseSpacecontinue to work with this.Closes#5822
Microsoft Reviewers: Open in CodeFlow