Enable animated gif playback on Mac - #724

Merged
Harrie Shin (harrieshin) merged 4 commits into
microsoft:masterfrom
marty-wang:gif
Feb 22, 2021
Merged

Enable animated gif playback on Mac#724
Harrie Shin (harrieshin) merged 4 commits into
microsoft:masterfrom
marty-wang:gif

Conversation

@marty-wang

@marty-wangMo (marty-wang) commented Feb 13, 2021•
edited
Loading

Copy link
Copy Markdown

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

This PR is to enable animated gif playback on Mac

Changelog

[macOS] [Fixed] - Enable animated gif playback on Mac

Test Plan

Screen.Recording.2021-02-13.at.9.25.22.AM.mov
Screen.Recording.2021-02-20.at.11.19.53.AM.mov
Microsoft Reviewers: Open in CodeFlow

Mo Wang added 2 commits February 13, 2021 09:22
Mo Wang
enable gif for mac
6acce2c
Summary:
I verify that it works for Zeratul as well. It also works regardless turbo module is enabled or not.
Test Plan: |{F369886201}|{F369889196}|
Reviewers: skyle
Reviewed By: skyle
Subscribers: zackargyle
Differential Revision: https://phabricator.intern.facebook.com/D26272145
Tasks: T82742678
Signature: 26272145:1612513052:520a8b0b3ab4b211c953b3225c6c96ffb8a29fc5
Mo Wang
bypass setImage logic when it is Mac
f9b9a6a
Summary: as titled
Test Plan:
{F370138978}
{F370139033}
Reviewers: skyle
Reviewed By: skyle
Subscribers: zackargyle
Differential Revision: https://phabricator.intern.facebook.com/D26288169
Signature: 26288169:1612565769:8f779fe01614e3399ac3e484853bb61246210ff4
@ghost

Deleted user (ghost) commented Feb 13, 2021•
edited by ghost
Loading

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

HeyImChris
HeyImChris approved these changes Feb 17, 2021
View reviewed changes

@HeyImChrisHeyImChris left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! I didn't see it mentioned in the validation section but can you also just sanity check that iOS still works as expected?

Comment threadLibraries/Image/RCTUIImageViewAnimated.m Outdated
Comment threadLibraries/Image/RCTUIImageViewAnimated.m Outdated
@appden

Scott Kyle (appden) commented Feb 18, 2021

Copy link
Copy Markdown

This fixes #507

@harrieshin
Harrie Shin (harrieshin) merged commit 068ed05 into microsoft:masterFeb 22, 2021
HeyImChris pushed a commit to HeyImChris/react-native-macos that referenced this pull request Mar 2, 2021
@marty-wangMo Wang@HeyImChris
Enable animated gif playback on Mac (microsoft#724)
19f4a9c
* enable gif for mac
Summary:
I verify that it works for Zeratul as well. It also works regardless turbo module is enabled or not.
Test Plan: |{F369886201}|{F369889196}|
Reviewers: skyle
Reviewed By: skyle
Subscribers: zackargyle
Differential Revision: https://phabricator.intern.facebook.com/D26272145
Tasks: T82742678
Signature: 26272145:1612513052:520a8b0b3ab4b211c953b3225c6c96ffb8a29fc5
* bypass setImage logic when it is Mac
Summary: as titled
Test Plan:
{F370138978}
{F370139033}
Reviewers: skyle
Reviewed By: skyle
Subscribers: zackargyle
Differential Revision: https://phabricator.intern.facebook.com/D26288169
Signature: 26288169:1612565769:8f779fe01614e3399ac3e484853bb61246210ff4
* address PR comments
* address PR comments 1
Co-authored-by: Mo Wang <mowang@fb.com>
HeyImChris added a commit that referenced this pull request Mar 17, 2021
@HeyImChris@acoates-ms
@marty-wangMo Wang@appden@Saadnajmi@anandrajeswaran
Add some robustness to the CI and switch to Xcode 12 (#709)
3056c4e
* Update RCTCxxBridge.mm
* make CI xcode versioning more robust to xcode12
* update to xcode 12.4
* use apple variables file
* Update RCTCxxBridge.mm
* add quotes
* switch to catalina
* update pods to 10.15
* make CI xcode versioning more robust to xcode12
* update to xcode 12.4
* use apple variables file
* add quotes
* switch to catalina
* update pods to 10.15
* upgrade version requirements to n-2 for osx
* make CI xcode versioning more robust to xcode12
* update to xcode 12.4
* use apple variables file
* add quotes
* switch to catalina
* make CI xcode versioning more robust to xcode12
* update to xcode 12.4
* use apple variables file
* add quotes
* make CI xcode versioning more robust to xcode12
* update to xcode 12.4
* use apple variables file
* add quotes
* CI should run on PRs to future stable branches (#718)
* Pull in header's C declaration to stop symbol mangling (#728)
* Update RCTCxxBridge.mm
* Update RCTCxxBridge.mm
* fix undefined extern c symbol
* scroll content with animation (#725)
Summary: please see test plan
Test Plan:
|Before|After|
|{F371503806}|{F371499708}|
Reviewers: skyle
Reviewed By: skyle
Subscribers: zackargyle
Differential Revision: https://phabricator.intern.facebook.com/D26354172
Tasks: T84165504
Signature: 26354172:1612920735:2cd8455b1bae06ee555bd98cfd41c4dfb29c288e
Co-authored-by: Mo Wang <mowang@fb.com>
* Fix missing props on secure text input (#719)
* Enable animated gif playback on Mac (#724)
* enable gif for mac
Summary:
I verify that it works for Zeratul as well. It also works regardless turbo module is enabled or not.
Test Plan: |{F369886201}|{F369889196}|
Reviewers: skyle
Reviewed By: skyle
Subscribers: zackargyle
Differential Revision: https://phabricator.intern.facebook.com/D26272145
Tasks: T82742678
Signature: 26272145:1612513052:520a8b0b3ab4b211c953b3225c6c96ffb8a29fc5
* bypass setImage logic when it is Mac
Summary: as titled
Test Plan:
{F370138978}
{F370139033}
Reviewers: skyle
Reviewed By: skyle
Subscribers: zackargyle
Differential Revision: https://phabricator.intern.facebook.com/D26288169
Signature: 26288169:1612565769:8f779fe01614e3399ac3e484853bb61246210ff4
* address PR comments
* address PR comments 1
Co-authored-by: Mo Wang <mowang@fb.com>
* Add explicit Tab support to keyboarding (#723)
* Update RCTCxxBridge.mm
* Update RCTCxxBridge.mm
* add explicit tab support
* missing tab validity check
* Fix Deadlock in RCTi18nUtil (iOS) (#733)
* Initial Commit
* Fix typo
* Fix default initialization of isRTLAllowed and documentation
* use BOOL, remove superfluous readwrite decorator
* Fix another typo
* Add TODO Marker
* update to macOS 10.15
* make CI xcode versioning more robust to xcode12
* update to xcode 12.4
* use apple variables file
* add quotes
* switch to catalina
* update pods to 10.15
* upgrade version requirements to n-2 for osx
* make CI xcode versioning more robust to xcode12
* update to xcode 12.4
* use apple variables file
* add quotes
* switch to catalina
* make CI xcode versioning more robust to xcode12
* update to xcode 12.4
* use apple variables file
* add quotes
* make CI xcode versioning more robust to xcode12
* update to xcode 12.4
* use apple variables file
* add quotes
* update to macOS 10.15
* update to xcode 12.4
* use apple variables file
* switch to catalina
* 10.14
* CI has to run on 10.15.4 or later
* fix up pod errors
* upgrade iphone simulator
* iphone 13
* remove old post install script
* iphone 8
* Restore Podfile.lock to see if it fixes CI
* Restore compiler flags in TurboModuleCxx-WinRTPort
* Remove macOS arm64 build divergence
* Remove building all ARCHS temporarily
* Override ONLY_ACTIVE_ARCH in release builds too
* Push iOS 14 snapshots
Co-authored-by: Andrew Coates <30809111+acoates-ms@users.noreply.github.com>
Co-authored-by: Mo <mo.hy.wang@gmail.com>
Co-authored-by: Mo Wang <mowang@fb.com>
Co-authored-by: Scott Kyle <scott@appden.com>
Co-authored-by: Saad Najmi <saadnajmi2@gmail.com>
Co-authored-by: Anand Rajeswaran <anand.rajeswaran@outlook.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@harrieshinHarrie Shin (harrieshin)harrieshin approved these changes
@alloyEloy Durán (alloy)Awaiting requested review from alloy
+2 more reviewers
@HeyImChrisHeyImChrisHeyImChris approved these changes
@appdenScott Kyle (appden)appden approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@HeyImChrisHeyImChris

Labels

Partner: Facebook

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@marty-wang@appden@harrieshin@HeyImChris
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Enable animated gif playback on Mac - #724
Merged
Harrie Shin (harrieshin) merged 4 commits into
microsoft:masterfrom 
marty-wang:gif
Feb 22, 2021
Merged
Enable animated gif playback on Mac#724
Harrie Shin (harrieshin) merged 4 commits into
microsoft:masterfrom 
marty-wang:gif
Conversation
@marty-wang
@marty-wangMo (marty-wang)
commented
Feb 13, 2021•

edited

Loading

Copy link


Copy Markdown

Please select one of the following
  •  I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  •  I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  •  I am making a fix / change for the macOS implementation of react-native
  •  I am making a change required for Microsoft usage of react-native
Summary
This PR is to enable animated gif playback on Mac
Changelog
[macOS] [Fixed] - Enable animated gif playback on Mac
Test Plan
Screen.Recording.2021-02-13.at.9.25.22.AM.mov
Screen.Recording.2021-02-20.at.11.19.53.AM.mov
Microsoft Reviewers: Open in CodeFlow
Mo Wang
added 2 commits
February 13, 2021 09:22
Mo Wang
enable gif for mac
6acce2c
Summary:
I verify that it works for Zeratul as well. It also works regardless turbo module is enabled or not.
Test Plan: |{F369886201}|{F369889196}|
Reviewers: skyle
Reviewed By: skyle
Subscribers: zackargyle
Differential Revision: https://phabricator.intern.facebook.com/D26272145
Tasks: T82742678
Signature: 26272145:1612513052:520a8b0b3ab4b211c953b3225c6c96ffb8a29fc5
Mo Wang
bypass setImage logic when it is Mac
f9b9a6a
Summary: as titled
Test Plan:
{F370138978}
{F370139033}
Reviewers: skyle
Reviewed By: skyle
Subscribers: zackargyle
Differential Revision: https://phabricator.intern.facebook.com/D26288169
Signature: 26288169:1612565769:8f779fe01614e3399ac3e484853bb61246210ff4
@ghost
Deleted user (ghost)
commented
Feb 13, 2021•

edited by ghost

Loading

Copy link


Copy Markdown

CLA assistant check
All CLA requirements met.
HeyImChris
HeyImChris
approved these changes
Feb 17, 2021
View reviewed changes
@HeyImChrisHeyImChris
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! I didn't see it mentioned in the validation section but can you also just sanity check that iOS still works as expected?
Comment threadLibraries/Image/RCTUIImageViewAnimated.m
Outdated

Comment threadLibraries/Image/RCTUIImageViewAnimated.m
Outdated

@appden
Scott Kyle (appden)
commented
Feb 18, 2021

Copy link


Copy Markdown

This fixes #507
@harrieshin
Harrie Shin (harrieshin)
merged commit 068ed05
into
microsoft:masterFeb 22, 2021
HeyImChris pushed a commit
to HeyImChris/react-native-macos
that referenced
this pull request
Mar 2, 2021
@marty-wangMo Wang@HeyImChris
Enable animated gif playback on Mac (microsoft#724)
19f4a9c
* enable gif for mac
Summary:
I verify that it works for Zeratul as well. It also works regardless turbo module is enabled or not.
Test Plan: |{F369886201}|{F369889196}|
Reviewers: skyle
Reviewed By: skyle
Subscribers: zackargyle
Differential Revision: https://phabricator.intern.facebook.com/D26272145
Tasks: T82742678
Signature: 26272145:1612513052:520a8b0b3ab4b211c953b3225c6c96ffb8a29fc5
* bypass setImage logic when it is Mac
Summary: as titled
Test Plan:
{F370138978}
{F370139033}
Reviewers: skyle
Reviewed By: skyle
Subscribers: zackargyle
Differential Revision: https://phabricator.intern.facebook.com/D26288169
Signature: 26288169:1612565769:8f779fe01614e3399ac3e484853bb61246210ff4
* address PR comments
* address PR comments 1
Co-authored-by: Mo Wang <mowang@fb.com>
HeyImChris added a commit
that referenced
this pull request
Mar 17, 2021
@HeyImChris@acoates-ms
@marty-wangMo Wang@appden@Saadnajmi@anandrajeswaran
Add some robustness to the CI and switch to Xcode 12 (#709)
3056c4e
* Update RCTCxxBridge.mm
* make CI xcode versioning more robust to xcode12
* update to xcode 12.4
* use apple variables file
* Update RCTCxxBridge.mm
* add quotes
* switch to catalina
* update pods to 10.15
* make CI xcode versioning more robust to xcode12
* update to xcode 12.4
* use apple variables file
* add quotes
* switch to catalina
* update pods to 10.15
* upgrade version requirements to n-2 for osx
* make CI xcode versioning more robust to xcode12
* update to xcode 12.4
* use apple variables file
* add quotes
* switch to catalina
* make CI xcode versioning more robust to xcode12
* update to xcode 12.4
* use apple variables file
* add quotes
* make CI xcode versioning more robust to xcode12
* update to xcode 12.4
* use apple variables file
* add quotes
* CI should run on PRs to future stable branches (#718)
* Pull in header's C declaration to stop symbol mangling (#728)
* Update RCTCxxBridge.mm
* Update RCTCxxBridge.mm
* fix undefined extern c symbol
* scroll content with animation (#725)
Summary: please see test plan
Test Plan:
|Before|After|
|{F371503806}|{F371499708}|
Reviewers: skyle
Reviewed By: skyle
Subscribers: zackargyle
Differential Revision: https://phabricator.intern.facebook.com/D26354172
Tasks: T84165504
Signature: 26354172:1612920735:2cd8455b1bae06ee555bd98cfd41c4dfb29c288e
Co-authored-by: Mo Wang <mowang@fb.com>
* Fix missing props on secure text input (#719)
* Enable animated gif playback on Mac (#724)
* enable gif for mac
Summary:
I verify that it works for Zeratul as well. It also works regardless turbo module is enabled or not.
Test Plan: |{F369886201}|{F369889196}|
Reviewers: skyle
Reviewed By: skyle
Subscribers: zackargyle
Differential Revision: https://phabricator.intern.facebook.com/D26272145
Tasks: T82742678
Signature: 26272145:1612513052:520a8b0b3ab4b211c953b3225c6c96ffb8a29fc5
* bypass setImage logic when it is Mac
Summary: as titled
Test Plan:
{F370138978}
{F370139033}
Reviewers: skyle
Reviewed By: skyle
Subscribers: zackargyle
Differential Revision: https://phabricator.intern.facebook.com/D26288169
Signature: 26288169:1612565769:8f779fe01614e3399ac3e484853bb61246210ff4
* address PR comments
* address PR comments 1
Co-authored-by: Mo Wang <mowang@fb.com>
* Add explicit Tab support to keyboarding (#723)
* Update RCTCxxBridge.mm
* Update RCTCxxBridge.mm
* add explicit tab support
* missing tab validity check
* Fix Deadlock in RCTi18nUtil (iOS) (#733)
* Initial Commit
* Fix typo
* Fix default initialization of isRTLAllowed and documentation
* use BOOL, remove superfluous readwrite decorator
* Fix another typo
* Add TODO Marker
* update to macOS 10.15
* make CI xcode versioning more robust to xcode12
* update to xcode 12.4
* use apple variables file
* add quotes
* switch to catalina
* update pods to 10.15
* upgrade version requirements to n-2 for osx
* make CI xcode versioning more robust to xcode12
* update to xcode 12.4
* use apple variables file
* add quotes
* switch to catalina
* make CI xcode versioning more robust to xcode12
* update to xcode 12.4
* use apple variables file
* add quotes
* make CI xcode versioning more robust to xcode12
* update to xcode 12.4
* use apple variables file
* add quotes
* update to macOS 10.15
* update to xcode 12.4
* use apple variables file
* switch to catalina
* 10.14
* CI has to run on 10.15.4 or later
* fix up pod errors
* upgrade iphone simulator
* iphone 13
* remove old post install script
* iphone 8
* Restore Podfile.lock to see if it fixes CI
* Restore compiler flags in TurboModuleCxx-WinRTPort
* Remove macOS arm64 build divergence
* Remove building all ARCHS temporarily
* Override ONLY_ACTIVE_ARCH in release builds too
* Push iOS 14 snapshots
Co-authored-by: Andrew Coates <30809111+acoates-ms@users.noreply.github.com>
Co-authored-by: Mo <mo.hy.wang@gmail.com>
Co-authored-by: Mo Wang <mowang@fb.com>
Co-authored-by: Scott Kyle <scott@appden.com>
Co-authored-by: Saad Najmi <saadnajmi2@gmail.com>
Co-authored-by: Anand Rajeswaran <anand.rajeswaran@outlook.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@harrieshinHarrie Shin (harrieshin)harrieshin approved these changes
@alloyEloy Durán (alloy)Awaiting requested review from alloy

+2 more reviewers

@HeyImChrisHeyImChrisHeyImChris approved these changes
@appdenScott Kyle (appden)appden approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@HeyImChrisHeyImChris

Labels

Partner: Facebook

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@marty-wang@appden@harrieshin@HeyImChris

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Enable animated gif playback on Mac - #724
Merged
Harrie Shin (harrieshin) merged 4 commits into
microsoft:masterfrom 
marty-wang:gif
Feb 22, 2021
Merged
Enable animated gif playback on Mac#724
Harrie Shin (harrieshin) merged 4 commits into
microsoft:masterfrom 
marty-wang:gif
Conversation
@marty-wang
@marty-wangMo (marty-wang)
commented
Feb 13, 2021•

edited

Loading

Copy link


Copy Markdown

Please select one of the following
  •  I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  •  I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  •  I am making a fix / change for the macOS implementation of react-native
  •  I am making a change required for Microsoft usage of react-native
Summary
This PR is to enable animated gif playback on Mac
Changelog
[macOS] [Fixed] - Enable animated gif playback on Mac
Test Plan
Screen.Recording.2021-02-13.at.9.25.22.AM.mov
Screen.Recording.2021-02-20.at.11.19.53.AM.mov
Microsoft Reviewers: Open in CodeFlow
Mo Wang
added 2 commits
February 13, 2021 09:22
Mo Wang
enable gif for mac
6acce2c
Summary:
I verify that it works for Zeratul as well. It also works regardless turbo module is enabled or not.
Test Plan: |{F369886201}|{F369889196}|
Reviewers: skyle
Reviewed By: skyle
Subscribers: zackargyle
Differential Revision: https://phabricator.intern.facebook.com/D26272145
Tasks: T82742678
Signature: 26272145:1612513052:520a8b0b3ab4b211c953b3225c6c96ffb8a29fc5
Mo Wang
bypass setImage logic when it is Mac
f9b9a6a
Summary: as titled
Test Plan:
{F370138978}
{F370139033}
Reviewers: skyle
Reviewed By: skyle
Subscribers: zackargyle
Differential Revision: https://phabricator.intern.facebook.com/D26288169
Signature: 26288169:1612565769:8f779fe01614e3399ac3e484853bb61246210ff4
@ghost
Deleted user (ghost)
commented
Feb 13, 2021•

edited by ghost

Loading

Copy link


Copy Markdown

CLA assistant check
All CLA requirements met.
HeyImChris
HeyImChris
approved these changes
Feb 17, 2021
View reviewed changes
@HeyImChrisHeyImChris
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! I didn't see it mentioned in the validation section but can you also just sanity check that iOS still works as expected?
Comment threadLibraries/Image/RCTUIImageViewAnimated.m
Outdated

Comment threadLibraries/Image/RCTUIImageViewAnimated.m
Outdated

@appden
Scott Kyle (appden)
commented
Feb 18, 2021

Copy link


Copy Markdown

This fixes #507
@harrieshin
Harrie Shin (harrieshin)
merged commit 068ed05
into
microsoft:masterFeb 22, 2021
HeyImChris pushed a commit
to HeyImChris/react-native-macos
that referenced
this pull request
Mar 2, 2021
@marty-wangMo Wang@HeyImChris
Enable animated gif playback on Mac (microsoft#724)
19f4a9c
* enable gif for mac
Summary:
I verify that it works for Zeratul as well. It also works regardless turbo module is enabled or not.
Test Plan: |{F369886201}|{F369889196}|
Reviewers: skyle
Reviewed By: skyle
Subscribers: zackargyle
Differential Revision: https://phabricator.intern.facebook.com/D26272145
Tasks: T82742678
Signature: 26272145:1612513052:520a8b0b3ab4b211c953b3225c6c96ffb8a29fc5
* bypass setImage logic when it is Mac
Summary: as titled
Test Plan:
{F370138978}
{F370139033}
Reviewers: skyle
Reviewed By: skyle
Subscribers: zackargyle
Differential Revision: https://phabricator.intern.facebook.com/D26288169
Signature: 26288169:1612565769:8f779fe01614e3399ac3e484853bb61246210ff4
* address PR comments
* address PR comments 1
Co-authored-by: Mo Wang <mowang@fb.com>
HeyImChris added a commit
that referenced
this pull request
Mar 17, 2021
@HeyImChris@acoates-ms
@marty-wangMo Wang@appden@Saadnajmi@anandrajeswaran
Add some robustness to the CI and switch to Xcode 12 (#709)
3056c4e
* Update RCTCxxBridge.mm
* make CI xcode versioning more robust to xcode12
* update to xcode 12.4
* use apple variables file
* Update RCTCxxBridge.mm
* add quotes
* switch to catalina
* update pods to 10.15
* make CI xcode versioning more robust to xcode12
* update to xcode 12.4
* use apple variables file
* add quotes
* switch to catalina
* update pods to 10.15
* upgrade version requirements to n-2 for osx
* make CI xcode versioning more robust to xcode12
* update to xcode 12.4
* use apple variables file
* add quotes
* switch to catalina
* make CI xcode versioning more robust to xcode12
* update to xcode 12.4
* use apple variables file
* add quotes
* make CI xcode versioning more robust to xcode12
* update to xcode 12.4
* use apple variables file
* add quotes
* CI should run on PRs to future stable branches (#718)
* Pull in header's C declaration to stop symbol mangling (#728)
* Update RCTCxxBridge.mm
* Update RCTCxxBridge.mm
* fix undefined extern c symbol
* scroll content with animation (#725)
Summary: please see test plan
Test Plan:
|Before|After|
|{F371503806}|{F371499708}|
Reviewers: skyle
Reviewed By: skyle
Subscribers: zackargyle
Differential Revision: https://phabricator.intern.facebook.com/D26354172
Tasks: T84165504
Signature: 26354172:1612920735:2cd8455b1bae06ee555bd98cfd41c4dfb29c288e
Co-authored-by: Mo Wang <mowang@fb.com>
* Fix missing props on secure text input (#719)
* Enable animated gif playback on Mac (#724)
* enable gif for mac
Summary:
I verify that it works for Zeratul as well. It also works regardless turbo module is enabled or not.
Test Plan: |{F369886201}|{F369889196}|
Reviewers: skyle
Reviewed By: skyle
Subscribers: zackargyle
Differential Revision: https://phabricator.intern.facebook.com/D26272145
Tasks: T82742678
Signature: 26272145:1612513052:520a8b0b3ab4b211c953b3225c6c96ffb8a29fc5
* bypass setImage logic when it is Mac
Summary: as titled
Test Plan:
{F370138978}
{F370139033}
Reviewers: skyle
Reviewed By: skyle
Subscribers: zackargyle
Differential Revision: https://phabricator.intern.facebook.com/D26288169
Signature: 26288169:1612565769:8f779fe01614e3399ac3e484853bb61246210ff4
* address PR comments
* address PR comments 1
Co-authored-by: Mo Wang <mowang@fb.com>
* Add explicit Tab support to keyboarding (#723)
* Update RCTCxxBridge.mm
* Update RCTCxxBridge.mm
* add explicit tab support
* missing tab validity check
* Fix Deadlock in RCTi18nUtil (iOS) (#733)
* Initial Commit
* Fix typo
* Fix default initialization of isRTLAllowed and documentation
* use BOOL, remove superfluous readwrite decorator
* Fix another typo
* Add TODO Marker
* update to macOS 10.15
* make CI xcode versioning more robust to xcode12
* update to xcode 12.4
* use apple variables file
* add quotes
* switch to catalina
* update pods to 10.15
* upgrade version requirements to n-2 for osx
* make CI xcode versioning more robust to xcode12
* update to xcode 12.4
* use apple variables file
* add quotes
* switch to catalina
* make CI xcode versioning more robust to xcode12
* update to xcode 12.4
* use apple variables file
* add quotes
* make CI xcode versioning more robust to xcode12
* update to xcode 12.4
* use apple variables file
* add quotes
* update to macOS 10.15
* update to xcode 12.4
* use apple variables file
* switch to catalina
* 10.14
* CI has to run on 10.15.4 or later
* fix up pod errors
* upgrade iphone simulator
* iphone 13
* remove old post install script
* iphone 8
* Restore Podfile.lock to see if it fixes CI
* Restore compiler flags in TurboModuleCxx-WinRTPort
* Remove macOS arm64 build divergence
* Remove building all ARCHS temporarily
* Override ONLY_ACTIVE_ARCH in release builds too
* Push iOS 14 snapshots
Co-authored-by: Andrew Coates <30809111+acoates-ms@users.noreply.github.com>
Co-authored-by: Mo <mo.hy.wang@gmail.com>
Co-authored-by: Mo Wang <mowang@fb.com>
Co-authored-by: Scott Kyle <scott@appden.com>
Co-authored-by: Saad Najmi <saadnajmi2@gmail.com>
Co-authored-by: Anand Rajeswaran <anand.rajeswaran@outlook.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@harrieshinHarrie Shin (harrieshin)harrieshin approved these changes
@alloyEloy Durán (alloy)Awaiting requested review from alloy

+2 more reviewers

@HeyImChrisHeyImChrisHeyImChris approved these changes
@appdenScott Kyle (appden)appden approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@HeyImChrisHeyImChris

Labels

Partner: Facebook

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@marty-wang@appden@harrieshin@HeyImChris

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Enable animated gif playback on Mac - #724
Merged
Harrie Shin (harrieshin) merged 4 commits into
microsoft:masterfrom 
marty-wang:gif
Feb 22, 2021
Merged
Enable animated gif playback on Mac#724
Harrie Shin (harrieshin) merged 4 commits into
microsoft:masterfrom 
marty-wang:gif
Conversation
@marty-wang
@marty-wangMo (marty-wang)
commented
Feb 13, 2021•

edited

Loading

Copy link


Copy Markdown

Please select one of the following
  •  I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  •  I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  •  I am making a fix / change for the macOS implementation of react-native
  •  I am making a change required for Microsoft usage of react-native
Summary
This PR is to enable animated gif playback on Mac
Changelog
[macOS] [Fixed] - Enable animated gif playback on Mac
Test Plan
Screen.Recording.2021-02-13.at.9.25.22.AM.mov
Screen.Recording.2021-02-20.at.11.19.53.AM.mov
Microsoft Reviewers: Open in CodeFlow
Mo Wang
added 2 commits
February 13, 2021 09:22
Mo Wang
enable gif for mac
6acce2c
Summary:
I verify that it works for Zeratul as well. It also works regardless turbo module is enabled or not.
Test Plan: |{F369886201}|{F369889196}|
Reviewers: skyle
Reviewed By: skyle
Subscribers: zackargyle
Differential Revision: https://phabricator.intern.facebook.com/D26272145
Tasks: T82742678
Signature: 26272145:1612513052:520a8b0b3ab4b211c953b3225c6c96ffb8a29fc5
Mo Wang
bypass setImage logic when it is Mac
f9b9a6a
Summary: as titled
Test Plan:
{F370138978}
{F370139033}
Reviewers: skyle
Reviewed By: skyle
Subscribers: zackargyle
Differential Revision: https://phabricator.intern.facebook.com/D26288169
Signature: 26288169:1612565769:8f779fe01614e3399ac3e484853bb61246210ff4
@ghost
Deleted user (ghost)
commented
Feb 13, 2021•

edited by ghost

Loading

Copy link


Copy Markdown

CLA assistant check
All CLA requirements met.
HeyImChris
HeyImChris
approved these changes
Feb 17, 2021
View reviewed changes
@HeyImChrisHeyImChris
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! I didn't see it mentioned in the validation section but can you also just sanity check that iOS still works as expected?
Comment threadLibraries/Image/RCTUIImageViewAnimated.m
Outdated

Comment threadLibraries/Image/RCTUIImageViewAnimated.m
Outdated

@appden
Scott Kyle (appden)
commented
Feb 18, 2021

Copy link


Copy Markdown

This fixes #507
@harrieshin
Harrie Shin (harrieshin)
merged commit 068ed05
into
microsoft:masterFeb 22, 2021
HeyImChris pushed a commit
to HeyImChris/react-native-macos
that referenced
this pull request
Mar 2, 2021
@marty-wangMo Wang@HeyImChris
Enable animated gif playback on Mac (microsoft#724)
19f4a9c
* enable gif for mac
Summary:
I verify that it works for Zeratul as well. It also works regardless turbo module is enabled or not.
Test Plan: |{F369886201}|{F369889196}|
Reviewers: skyle
Reviewed By: skyle
Subscribers: zackargyle
Differential Revision: https://phabricator.intern.facebook.com/D26272145
Tasks: T82742678
Signature: 26272145:1612513052:520a8b0b3ab4b211c953b3225c6c96ffb8a29fc5
* bypass setImage logic when it is Mac
Summary: as titled
Test Plan:
{F370138978}
{F370139033}
Reviewers: skyle
Reviewed By: skyle
Subscribers: zackargyle
Differential Revision: https://phabricator.intern.facebook.com/D26288169
Signature: 26288169:1612565769:8f779fe01614e3399ac3e484853bb61246210ff4
* address PR comments
* address PR comments 1
Co-authored-by: Mo Wang <mowang@fb.com>
HeyImChris added a commit
that referenced
this pull request
Mar 17, 2021
@HeyImChris@acoates-ms
@marty-wangMo Wang@appden@Saadnajmi@anandrajeswaran
Add some robustness to the CI and switch to Xcode 12 (#709)
3056c4e
* Update RCTCxxBridge.mm
* make CI xcode versioning more robust to xcode12
* update to xcode 12.4
* use apple variables file
* Update RCTCxxBridge.mm
* add quotes
* switch to catalina
* update pods to 10.15
* make CI xcode versioning more robust to xcode12
* update to xcode 12.4
* use apple variables file
* add quotes
* switch to catalina
* update pods to 10.15
* upgrade version requirements to n-2 for osx
* make CI xcode versioning more robust to xcode12
* update to xcode 12.4
* use apple variables file
* add quotes
* switch to catalina
* make CI xcode versioning more robust to xcode12
* update to xcode 12.4
* use apple variables file
* add quotes
* make CI xcode versioning more robust to xcode12
* update to xcode 12.4
* use apple variables file
* add quotes
* CI should run on PRs to future stable branches (#718)
* Pull in header's C declaration to stop symbol mangling (#728)
* Update RCTCxxBridge.mm
* Update RCTCxxBridge.mm
* fix undefined extern c symbol
* scroll content with animation (#725)
Summary: please see test plan
Test Plan:
|Before|After|
|{F371503806}|{F371499708}|
Reviewers: skyle
Reviewed By: skyle
Subscribers: zackargyle
Differential Revision: https://phabricator.intern.facebook.com/D26354172
Tasks: T84165504
Signature: 26354172:1612920735:2cd8455b1bae06ee555bd98cfd41c4dfb29c288e
Co-authored-by: Mo Wang <mowang@fb.com>
* Fix missing props on secure text input (#719)
* Enable animated gif playback on Mac (#724)
* enable gif for mac
Summary:
I verify that it works for Zeratul as well. It also works regardless turbo module is enabled or not.
Test Plan: |{F369886201}|{F369889196}|
Reviewers: skyle
Reviewed By: skyle
Subscribers: zackargyle
Differential Revision: https://phabricator.intern.facebook.com/D26272145
Tasks: T82742678
Signature: 26272145:1612513052:520a8b0b3ab4b211c953b3225c6c96ffb8a29fc5
* bypass setImage logic when it is Mac
Summary: as titled
Test Plan:
{F370138978}
{F370139033}
Reviewers: skyle
Reviewed By: skyle
Subscribers: zackargyle
Differential Revision: https://phabricator.intern.facebook.com/D26288169
Signature: 26288169:1612565769:8f779fe01614e3399ac3e484853bb61246210ff4
* address PR comments
* address PR comments 1
Co-authored-by: Mo Wang <mowang@fb.com>
* Add explicit Tab support to keyboarding (#723)
* Update RCTCxxBridge.mm
* Update RCTCxxBridge.mm
* add explicit tab support
* missing tab validity check
* Fix Deadlock in RCTi18nUtil (iOS) (#733)
* Initial Commit
* Fix typo
* Fix default initialization of isRTLAllowed and documentation
* use BOOL, remove superfluous readwrite decorator
* Fix another typo
* Add TODO Marker
* update to macOS 10.15
* make CI xcode versioning more robust to xcode12
* update to xcode 12.4
* use apple variables file
* add quotes
* switch to catalina
* update pods to 10.15
* upgrade version requirements to n-2 for osx
* make CI xcode versioning more robust to xcode12
* update to xcode 12.4
* use apple variables file
* add quotes
* switch to catalina
* make CI xcode versioning more robust to xcode12
* update to xcode 12.4
* use apple variables file
* add quotes
* make CI xcode versioning more robust to xcode12
* update to xcode 12.4
* use apple variables file
* add quotes
* update to macOS 10.15
* update to xcode 12.4
* use apple variables file
* switch to catalina
* 10.14
* CI has to run on 10.15.4 or later
* fix up pod errors
* upgrade iphone simulator
* iphone 13
* remove old post install script
* iphone 8
* Restore Podfile.lock to see if it fixes CI
* Restore compiler flags in TurboModuleCxx-WinRTPort
* Remove macOS arm64 build divergence
* Remove building all ARCHS temporarily
* Override ONLY_ACTIVE_ARCH in release builds too
* Push iOS 14 snapshots
Co-authored-by: Andrew Coates <30809111+acoates-ms@users.noreply.github.com>
Co-authored-by: Mo <mo.hy.wang@gmail.com>
Co-authored-by: Mo Wang <mowang@fb.com>
Co-authored-by: Scott Kyle <scott@appden.com>
Co-authored-by: Saad Najmi <saadnajmi2@gmail.com>
Co-authored-by: Anand Rajeswaran <anand.rajeswaran@outlook.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@harrieshinHarrie Shin (harrieshin)harrieshin approved these changes
@alloyEloy Durán (alloy)Awaiting requested review from alloy

+2 more reviewers

@HeyImChrisHeyImChrisHeyImChris approved these changes
@appdenScott Kyle (appden)appden approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@HeyImChrisHeyImChris

Labels

Partner: Facebook

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@marty-wang@appden@harrieshin@HeyImChris

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Enable animated gif playback on Mac - #724
Merged
Harrie Shin (harrieshin) merged 4 commits into
microsoft:masterfrom 
marty-wang:gif
Feb 22, 2021
Merged
Enable animated gif playback on Mac#724
Harrie Shin (harrieshin) merged 4 commits into
microsoft:masterfrom 
marty-wang:gif
Conversation
@marty-wang
@marty-wangMo (marty-wang)
commented
Feb 13, 2021•

edited

Loading

Copy link


Copy Markdown

Please select one of the following
  •  I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  •  I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  •  I am making a fix / change for the macOS implementation of react-native
  •  I am making a change required for Microsoft usage of react-native
Summary
This PR is to enable animated gif playback on Mac
Changelog
[macOS] [Fixed] - Enable animated gif playback on Mac
Test Plan
Screen.Recording.2021-02-13.at.9.25.22.AM.mov
Screen.Recording.2021-02-20.at.11.19.53.AM.mov
Microsoft Reviewers: Open in CodeFlow
Mo Wang
added 2 commits
February 13, 2021 09:22
Mo Wang
enable gif for mac
6acce2c
Summary:
I verify that it works for Zeratul as well. It also works regardless turbo module is enabled or not.
Test Plan: |{F369886201}|{F369889196}|
Reviewers: skyle
Reviewed By: skyle
Subscribers: zackargyle
Differential Revision: https://phabricator.intern.facebook.com/D26272145
Tasks: T82742678
Signature: 26272145:1612513052:520a8b0b3ab4b211c953b3225c6c96ffb8a29fc5
Mo Wang
bypass setImage logic when it is Mac
f9b9a6a
Summary: as titled
Test Plan:
{F370138978}
{F370139033}
Reviewers: skyle
Reviewed By: skyle
Subscribers: zackargyle
Differential Revision: https://phabricator.intern.facebook.com/D26288169
Signature: 26288169:1612565769:8f779fe01614e3399ac3e484853bb61246210ff4
@ghost
Deleted user (ghost)
commented
Feb 13, 2021•

edited by ghost

Loading

Copy link


Copy Markdown

CLA assistant check
All CLA requirements met.
HeyImChris
HeyImChris
approved these changes
Feb 17, 2021
View reviewed changes
@HeyImChrisHeyImChris
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! I didn't see it mentioned in the validation section but can you also just sanity check that iOS still works as expected?
Comment threadLibraries/Image/RCTUIImageViewAnimated.m
Outdated

Comment threadLibraries/Image/RCTUIImageViewAnimated.m
Outdated

@appden
Scott Kyle (appden)
commented
Feb 18, 2021

Copy link


Copy Markdown

This fixes #507
@harrieshin
Harrie Shin (harrieshin)
merged commit 068ed05
into
microsoft:masterFeb 22, 2021
HeyImChris pushed a commit
to HeyImChris/react-native-macos
that referenced
this pull request
Mar 2, 2021
@marty-wangMo Wang@HeyImChris
Enable animated gif playback on Mac (microsoft#724)
19f4a9c
* enable gif for mac
Summary:
I verify that it works for Zeratul as well. It also works regardless turbo module is enabled or not.
Test Plan: |{F369886201}|{F369889196}|
Reviewers: skyle
Reviewed By: skyle
Subscribers: zackargyle
Differential Revision: https://phabricator.intern.facebook.com/D26272145
Tasks: T82742678
Signature: 26272145:1612513052:520a8b0b3ab4b211c953b3225c6c96ffb8a29fc5
* bypass setImage logic when it is Mac
Summary: as titled
Test Plan:
{F370138978}
{F370139033}
Reviewers: skyle
Reviewed By: skyle
Subscribers: zackargyle
Differential Revision: https://phabricator.intern.facebook.com/D26288169
Signature: 26288169:1612565769:8f779fe01614e3399ac3e484853bb61246210ff4
* address PR comments
* address PR comments 1
Co-authored-by: Mo Wang <mowang@fb.com>
HeyImChris added a commit
that referenced
this pull request
Mar 17, 2021
@HeyImChris@acoates-ms
@marty-wangMo Wang@appden@Saadnajmi@anandrajeswaran
Add some robustness to the CI and switch to Xcode 12 (#709)
3056c4e
* Update RCTCxxBridge.mm
* make CI xcode versioning more robust to xcode12
* update to xcode 12.4
* use apple variables file
* Update RCTCxxBridge.mm
* add quotes
* switch to catalina
* update pods to 10.15
* make CI xcode versioning more robust to xcode12
* update to xcode 12.4
* use apple variables file
* add quotes
* switch to catalina
* update pods to 10.15
* upgrade version requirements to n-2 for osx
* make CI xcode versioning more robust to xcode12
* update to xcode 12.4
* use apple variables file
* add quotes
* switch to catalina
* make CI xcode versioning more robust to xcode12
* update to xcode 12.4
* use apple variables file
* add quotes
* make CI xcode versioning more robust to xcode12
* update to xcode 12.4
* use apple variables file
* add quotes
* CI should run on PRs to future stable branches (#718)
* Pull in header's C declaration to stop symbol mangling (#728)
* Update RCTCxxBridge.mm
* Update RCTCxxBridge.mm
* fix undefined extern c symbol
* scroll content with animation (#725)
Summary: please see test plan
Test Plan:
|Before|After|
|{F371503806}|{F371499708}|
Reviewers: skyle
Reviewed By: skyle
Subscribers: zackargyle
Differential Revision: https://phabricator.intern.facebook.com/D26354172
Tasks: T84165504
Signature: 26354172:1612920735:2cd8455b1bae06ee555bd98cfd41c4dfb29c288e
Co-authored-by: Mo Wang <mowang@fb.com>
* Fix missing props on secure text input (#719)
* Enable animated gif playback on Mac (#724)
* enable gif for mac
Summary:
I verify that it works for Zeratul as well. It also works regardless turbo module is enabled or not.
Test Plan: |{F369886201}|{F369889196}|
Reviewers: skyle
Reviewed By: skyle
Subscribers: zackargyle
Differential Revision: https://phabricator.intern.facebook.com/D26272145
Tasks: T82742678
Signature: 26272145:1612513052:520a8b0b3ab4b211c953b3225c6c96ffb8a29fc5
* bypass setImage logic when it is Mac
Summary: as titled
Test Plan:
{F370138978}
{F370139033}
Reviewers: skyle
Reviewed By: skyle
Subscribers: zackargyle
Differential Revision: https://phabricator.intern.facebook.com/D26288169
Signature: 26288169:1612565769:8f779fe01614e3399ac3e484853bb61246210ff4
* address PR comments
* address PR comments 1
Co-authored-by: Mo Wang <mowang@fb.com>
* Add explicit Tab support to keyboarding (#723)
* Update RCTCxxBridge.mm
* Update RCTCxxBridge.mm
* add explicit tab support
* missing tab validity check
* Fix Deadlock in RCTi18nUtil (iOS) (#733)
* Initial Commit
* Fix typo
* Fix default initialization of isRTLAllowed and documentation
* use BOOL, remove superfluous readwrite decorator
* Fix another typo
* Add TODO Marker
* update to macOS 10.15
* make CI xcode versioning more robust to xcode12
* update to xcode 12.4
* use apple variables file
* add quotes
* switch to catalina
* update pods to 10.15
* upgrade version requirements to n-2 for osx
* make CI xcode versioning more robust to xcode12
* update to xcode 12.4
* use apple variables file
* add quotes
* switch to catalina
* make CI xcode versioning more robust to xcode12
* update to xcode 12.4
* use apple variables file
* add quotes
* make CI xcode versioning more robust to xcode12
* update to xcode 12.4
* use apple variables file
* add quotes
* update to macOS 10.15
* update to xcode 12.4
* use apple variables file
* switch to catalina
* 10.14
* CI has to run on 10.15.4 or later
* fix up pod errors
* upgrade iphone simulator
* iphone 13
* remove old post install script
* iphone 8
* Restore Podfile.lock to see if it fixes CI
* Restore compiler flags in TurboModuleCxx-WinRTPort
* Remove macOS arm64 build divergence
* Remove building all ARCHS temporarily
* Override ONLY_ACTIVE_ARCH in release builds too
* Push iOS 14 snapshots
Co-authored-by: Andrew Coates <30809111+acoates-ms@users.noreply.github.com>
Co-authored-by: Mo <mo.hy.wang@gmail.com>
Co-authored-by: Mo Wang <mowang@fb.com>
Co-authored-by: Scott Kyle <scott@appden.com>
Co-authored-by: Saad Najmi <saadnajmi2@gmail.com>
Co-authored-by: Anand Rajeswaran <anand.rajeswaran@outlook.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@harrieshinHarrie Shin (harrieshin)harrieshin approved these changes
@alloyEloy Durán (alloy)Awaiting requested review from alloy

+2 more reviewers

@HeyImChrisHeyImChrisHeyImChris approved these changes
@appdenScott Kyle (appden)appden approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@HeyImChrisHeyImChris

Labels

Partner: Facebook

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@marty-wang@appden@harrieshin@HeyImChris

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Enable animated gif playback on Mac - #724
Merged
Harrie Shin (harrieshin) merged 4 commits into
microsoft:masterfrom 
marty-wang:gif
Feb 22, 2021
Merged
Enable animated gif playback on Mac#724
Harrie Shin (harrieshin) merged 4 commits into
microsoft:masterfrom 
marty-wang:gif
Conversation
@marty-wang
@marty-wangMo (marty-wang)
commented
Feb 13, 2021•

edited

Loading

Copy link


Copy Markdown

Please select one of the following
  •  I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  •  I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  •  I am making a fix / change for the macOS implementation of react-native
  •  I am making a change required for Microsoft usage of react-native
Summary
This PR is to enable animated gif playback on Mac
Changelog
[macOS] [Fixed] - Enable animated gif playback on Mac
Test Plan
Screen.Recording.2021-02-13.at.9.25.22.AM.mov
Screen.Recording.2021-02-20.at.11.19.53.AM.mov
Microsoft Reviewers: Open in CodeFlow
Mo Wang
added 2 commits
February 13, 2021 09:22
Mo Wang
enable gif for mac
6acce2c
Summary:
I verify that it works for Zeratul as well. It also works regardless turbo module is enabled or not.
Test Plan: |{F369886201}|{F369889196}|
Reviewers: skyle
Reviewed By: skyle
Subscribers: zackargyle
Differential Revision: https://phabricator.intern.facebook.com/D26272145
Tasks: T82742678
Signature: 26272145:1612513052:520a8b0b3ab4b211c953b3225c6c96ffb8a29fc5
Mo Wang
bypass setImage logic when it is Mac
f9b9a6a
Summary: as titled
Test Plan:
{F370138978}
{F370139033}
Reviewers: skyle
Reviewed By: skyle
Subscribers: zackargyle
Differential Revision: https://phabricator.intern.facebook.com/D26288169
Signature: 26288169:1612565769:8f779fe01614e3399ac3e484853bb61246210ff4
@ghost
Deleted user (ghost)
commented
Feb 13, 2021•

edited by ghost

Loading

Copy link


Copy Markdown

CLA assistant check
All CLA requirements met.
HeyImChris
HeyImChris
approved these changes
Feb 17, 2021
View reviewed changes
@HeyImChrisHeyImChris
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! I didn't see it mentioned in the validation section but can you also just sanity check that iOS still works as expected?
Comment threadLibraries/Image/RCTUIImageViewAnimated.m
Outdated

Comment threadLibraries/Image/RCTUIImageViewAnimated.m
Outdated

@appden
Scott Kyle (appden)
commented
Feb 18, 2021

Copy link


Copy Markdown

This fixes #507
@harrieshin
Harrie Shin (harrieshin)
merged commit 068ed05
into
microsoft:masterFeb 22, 2021
HeyImChris pushed a commit
to HeyImChris/react-native-macos
that referenced
this pull request
Mar 2, 2021
@marty-wangMo Wang@HeyImChris
Enable animated gif playback on Mac (microsoft#724)
19f4a9c
* enable gif for mac
Summary:
I verify that it works for Zeratul as well. It also works regardless turbo module is enabled or not.
Test Plan: |{F369886201}|{F369889196}|
Reviewers: skyle
Reviewed By: skyle
Subscribers: zackargyle
Differential Revision: https://phabricator.intern.facebook.com/D26272145
Tasks: T82742678
Signature: 26272145:1612513052:520a8b0b3ab4b211c953b3225c6c96ffb8a29fc5
* bypass setImage logic when it is Mac
Summary: as titled
Test Plan:
{F370138978}
{F370139033}
Reviewers: skyle
Reviewed By: skyle
Subscribers: zackargyle
Differential Revision: https://phabricator.intern.facebook.com/D26288169
Signature: 26288169:1612565769:8f779fe01614e3399ac3e484853bb61246210ff4
* address PR comments
* address PR comments 1
Co-authored-by: Mo Wang <mowang@fb.com>
HeyImChris added a commit
that referenced
this pull request
Mar 17, 2021
@HeyImChris@acoates-ms
@marty-wangMo Wang@appden@Saadnajmi@anandrajeswaran
Add some robustness to the CI and switch to Xcode 12 (#709)
3056c4e
* Update RCTCxxBridge.mm
* make CI xcode versioning more robust to xcode12
* update to xcode 12.4
* use apple variables file
* Update RCTCxxBridge.mm
* add quotes
* switch to catalina
* update pods to 10.15
* make CI xcode versioning more robust to xcode12
* update to xcode 12.4
* use apple variables file
* add quotes
* switch to catalina
* update pods to 10.15
* upgrade version requirements to n-2 for osx
* make CI xcode versioning more robust to xcode12
* update to xcode 12.4
* use apple variables file
* add quotes
* switch to catalina
* make CI xcode versioning more robust to xcode12
* update to xcode 12.4
* use apple variables file
* add quotes
* make CI xcode versioning more robust to xcode12
* update to xcode 12.4
* use apple variables file
* add quotes
* CI should run on PRs to future stable branches (#718)
* Pull in header's C declaration to stop symbol mangling (#728)
* Update RCTCxxBridge.mm
* Update RCTCxxBridge.mm
* fix undefined extern c symbol
* scroll content with animation (#725)
Summary: please see test plan
Test Plan:
|Before|After|
|{F371503806}|{F371499708}|
Reviewers: skyle
Reviewed By: skyle
Subscribers: zackargyle
Differential Revision: https://phabricator.intern.facebook.com/D26354172
Tasks: T84165504
Signature: 26354172:1612920735:2cd8455b1bae06ee555bd98cfd41c4dfb29c288e
Co-authored-by: Mo Wang <mowang@fb.com>
* Fix missing props on secure text input (#719)
* Enable animated gif playback on Mac (#724)
* enable gif for mac
Summary:
I verify that it works for Zeratul as well. It also works regardless turbo module is enabled or not.
Test Plan: |{F369886201}|{F369889196}|
Reviewers: skyle
Reviewed By: skyle
Subscribers: zackargyle
Differential Revision: https://phabricator.intern.facebook.com/D26272145
Tasks: T82742678
Signature: 26272145:1612513052:520a8b0b3ab4b211c953b3225c6c96ffb8a29fc5
* bypass setImage logic when it is Mac
Summary: as titled
Test Plan:
{F370138978}
{F370139033}
Reviewers: skyle
Reviewed By: skyle
Subscribers: zackargyle
Differential Revision: https://phabricator.intern.facebook.com/D26288169
Signature: 26288169:1612565769:8f779fe01614e3399ac3e484853bb61246210ff4
* address PR comments
* address PR comments 1
Co-authored-by: Mo Wang <mowang@fb.com>
* Add explicit Tab support to keyboarding (#723)
* Update RCTCxxBridge.mm
* Update RCTCxxBridge.mm
* add explicit tab support
* missing tab validity check
* Fix Deadlock in RCTi18nUtil (iOS) (#733)
* Initial Commit
* Fix typo
* Fix default initialization of isRTLAllowed and documentation
* use BOOL, remove superfluous readwrite decorator
* Fix another typo
* Add TODO Marker
* update to macOS 10.15
* make CI xcode versioning more robust to xcode12
* update to xcode 12.4
* use apple variables file
* add quotes
* switch to catalina
* update pods to 10.15
* upgrade version requirements to n-2 for osx
* make CI xcode versioning more robust to xcode12
* update to xcode 12.4
* use apple variables file
* add quotes
* switch to catalina
* make CI xcode versioning more robust to xcode12
* update to xcode 12.4
* use apple variables file
* add quotes
* make CI xcode versioning more robust to xcode12
* update to xcode 12.4
* use apple variables file
* add quotes
* update to macOS 10.15
* update to xcode 12.4
* use apple variables file
* switch to catalina
* 10.14
* CI has to run on 10.15.4 or later
* fix up pod errors
* upgrade iphone simulator
* iphone 13
* remove old post install script
* iphone 8
* Restore Podfile.lock to see if it fixes CI
* Restore compiler flags in TurboModuleCxx-WinRTPort
* Remove macOS arm64 build divergence
* Remove building all ARCHS temporarily
* Override ONLY_ACTIVE_ARCH in release builds too
* Push iOS 14 snapshots
Co-authored-by: Andrew Coates <30809111+acoates-ms@users.noreply.github.com>
Co-authored-by: Mo <mo.hy.wang@gmail.com>
Co-authored-by: Mo Wang <mowang@fb.com>
Co-authored-by: Scott Kyle <scott@appden.com>
Co-authored-by: Saad Najmi <saadnajmi2@gmail.com>
Co-authored-by: Anand Rajeswaran <anand.rajeswaran@outlook.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@harrieshinHarrie Shin (harrieshin)harrieshin approved these changes
@alloyEloy Durán (alloy)Awaiting requested review from alloy

+2 more reviewers

@HeyImChrisHeyImChrisHeyImChris approved these changes
@appdenScott Kyle (appden)appden approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@HeyImChrisHeyImChris

Labels

Partner: Facebook

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@marty-wang@appden@harrieshin@HeyImChris

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Enable animated gif playback on Mac - #724
Merged
Harrie Shin (harrieshin) merged 4 commits into
microsoft:masterfrom 
marty-wang:gif
Feb 22, 2021
Merged
Enable animated gif playback on Mac#724
Harrie Shin (harrieshin) merged 4 commits into
microsoft:masterfrom 
marty-wang:gif
Conversation
@marty-wang
@marty-wangMo (marty-wang)
commented
Feb 13, 2021•

edited

Loading

Copy link


Copy Markdown

Please select one of the following
  •  I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  •  I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  •  I am making a fix / change for the macOS implementation of react-native
  •  I am making a change required for Microsoft usage of react-native
Summary
This PR is to enable animated gif playback on Mac
Changelog
[macOS] [Fixed] - Enable animated gif playback on Mac
Test Plan
Screen.Recording.2021-02-13.at.9.25.22.AM.mov
Screen.Recording.2021-02-20.at.11.19.53.AM.mov
Microsoft Reviewers: Open in CodeFlow
Mo Wang
added 2 commits
February 13, 2021 09:22
Mo Wang
enable gif for mac
6acce2c
Summary:
I verify that it works for Zeratul as well. It also works regardless turbo module is enabled or not.
Test Plan: |{F369886201}|{F369889196}|
Reviewers: skyle
Reviewed By: skyle
Subscribers: zackargyle
Differential Revision: https://phabricator.intern.facebook.com/D26272145
Tasks: T82742678
Signature: 26272145:1612513052:520a8b0b3ab4b211c953b3225c6c96ffb8a29fc5
Mo Wang
bypass setImage logic when it is Mac
f9b9a6a
Summary: as titled
Test Plan:
{F370138978}
{F370139033}
Reviewers: skyle
Reviewed By: skyle
Subscribers: zackargyle
Differential Revision: https://phabricator.intern.facebook.com/D26288169
Signature: 26288169:1612565769:8f779fe01614e3399ac3e484853bb61246210ff4
@ghost
Deleted user (ghost)
commented
Feb 13, 2021•

edited by ghost

Loading

Copy link


Copy Markdown

CLA assistant check
All CLA requirements met.
HeyImChris
HeyImChris
approved these changes
Feb 17, 2021
View reviewed changes
@HeyImChrisHeyImChris
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! I didn't see it mentioned in the validation section but can you also just sanity check that iOS still works as expected?
Comment threadLibraries/Image/RCTUIImageViewAnimated.m
Outdated

Comment threadLibraries/Image/RCTUIImageViewAnimated.m
Outdated

@appden
Scott Kyle (appden)
commented
Feb 18, 2021

Copy link


Copy Markdown

This fixes #507
@harrieshin
Harrie Shin (harrieshin)
merged commit 068ed05
into
microsoft:masterFeb 22, 2021
HeyImChris pushed a commit
to HeyImChris/react-native-macos
that referenced
this pull request
Mar 2, 2021
@marty-wangMo Wang@HeyImChris
Enable animated gif playback on Mac (microsoft#724)
19f4a9c
* enable gif for mac
Summary:
I verify that it works for Zeratul as well. It also works regardless turbo module is enabled or not.
Test Plan: |{F369886201}|{F369889196}|
Reviewers: skyle
Reviewed By: skyle
Subscribers: zackargyle
Differential Revision: https://phabricator.intern.facebook.com/D26272145
Tasks: T82742678
Signature: 26272145:1612513052:520a8b0b3ab4b211c953b3225c6c96ffb8a29fc5
* bypass setImage logic when it is Mac
Summary: as titled
Test Plan:
{F370138978}
{F370139033}
Reviewers: skyle
Reviewed By: skyle
Subscribers: zackargyle
Differential Revision: https://phabricator.intern.facebook.com/D26288169
Signature: 26288169:1612565769:8f779fe01614e3399ac3e484853bb61246210ff4
* address PR comments
* address PR comments 1
Co-authored-by: Mo Wang <mowang@fb.com>
HeyImChris added a commit
that referenced
this pull request
Mar 17, 2021
@HeyImChris@acoates-ms
@marty-wangMo Wang@appden@Saadnajmi@anandrajeswaran
Add some robustness to the CI and switch to Xcode 12 (#709)
3056c4e
* Update RCTCxxBridge.mm
* make CI xcode versioning more robust to xcode12
* update to xcode 12.4
* use apple variables file
* Update RCTCxxBridge.mm
* add quotes
* switch to catalina
* update pods to 10.15
* make CI xcode versioning more robust to xcode12
* update to xcode 12.4
* use apple variables file
* add quotes
* switch to catalina
* update pods to 10.15
* upgrade version requirements to n-2 for osx
* make CI xcode versioning more robust to xcode12
* update to xcode 12.4
* use apple variables file
* add quotes
* switch to catalina
* make CI xcode versioning more robust to xcode12
* update to xcode 12.4
* use apple variables file
* add quotes
* make CI xcode versioning more robust to xcode12
* update to xcode 12.4
* use apple variables file
* add quotes
* CI should run on PRs to future stable branches (#718)
* Pull in header's C declaration to stop symbol mangling (#728)
* Update RCTCxxBridge.mm
* Update RCTCxxBridge.mm
* fix undefined extern c symbol
* scroll content with animation (#725)
Summary: please see test plan
Test Plan:
|Before|After|
|{F371503806}|{F371499708}|
Reviewers: skyle
Reviewed By: skyle
Subscribers: zackargyle
Differential Revision: https://phabricator.intern.facebook.com/D26354172
Tasks: T84165504
Signature: 26354172:1612920735:2cd8455b1bae06ee555bd98cfd41c4dfb29c288e
Co-authored-by: Mo Wang <mowang@fb.com>
* Fix missing props on secure text input (#719)
* Enable animated gif playback on Mac (#724)
* enable gif for mac
Summary:
I verify that it works for Zeratul as well. It also works regardless turbo module is enabled or not.
Test Plan: |{F369886201}|{F369889196}|
Reviewers: skyle
Reviewed By: skyle
Subscribers: zackargyle
Differential Revision: https://phabricator.intern.facebook.com/D26272145
Tasks: T82742678
Signature: 26272145:1612513052:520a8b0b3ab4b211c953b3225c6c96ffb8a29fc5
* bypass setImage logic when it is Mac
Summary: as titled
Test Plan:
{F370138978}
{F370139033}
Reviewers: skyle
Reviewed By: skyle
Subscribers: zackargyle
Differential Revision: https://phabricator.intern.facebook.com/D26288169
Signature: 26288169:1612565769:8f779fe01614e3399ac3e484853bb61246210ff4
* address PR comments
* address PR comments 1
Co-authored-by: Mo Wang <mowang@fb.com>
* Add explicit Tab support to keyboarding (#723)
* Update RCTCxxBridge.mm
* Update RCTCxxBridge.mm
* add explicit tab support
* missing tab validity check
* Fix Deadlock in RCTi18nUtil (iOS) (#733)
* Initial Commit
* Fix typo
* Fix default initialization of isRTLAllowed and documentation
* use BOOL, remove superfluous readwrite decorator
* Fix another typo
* Add TODO Marker
* update to macOS 10.15
* make CI xcode versioning more robust to xcode12
* update to xcode 12.4
* use apple variables file
* add quotes
* switch to catalina
* update pods to 10.15
* upgrade version requirements to n-2 for osx
* make CI xcode versioning more robust to xcode12
* update to xcode 12.4
* use apple variables file
* add quotes
* switch to catalina
* make CI xcode versioning more robust to xcode12
* update to xcode 12.4
* use apple variables file
* add quotes
* make CI xcode versioning more robust to xcode12
* update to xcode 12.4
* use apple variables file
* add quotes
* update to macOS 10.15
* update to xcode 12.4
* use apple variables file
* switch to catalina
* 10.14
* CI has to run on 10.15.4 or later
* fix up pod errors
* upgrade iphone simulator
* iphone 13
* remove old post install script
* iphone 8
* Restore Podfile.lock to see if it fixes CI
* Restore compiler flags in TurboModuleCxx-WinRTPort
* Remove macOS arm64 build divergence
* Remove building all ARCHS temporarily
* Override ONLY_ACTIVE_ARCH in release builds too
* Push iOS 14 snapshots
Co-authored-by: Andrew Coates <30809111+acoates-ms@users.noreply.github.com>
Co-authored-by: Mo <mo.hy.wang@gmail.com>
Co-authored-by: Mo Wang <mowang@fb.com>
Co-authored-by: Scott Kyle <scott@appden.com>
Co-authored-by: Saad Najmi <saadnajmi2@gmail.com>
Co-authored-by: Anand Rajeswaran <anand.rajeswaran@outlook.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@harrieshinHarrie Shin (harrieshin)harrieshin approved these changes
@alloyEloy Durán (alloy)Awaiting requested review from alloy

+2 more reviewers

@HeyImChrisHeyImChrisHeyImChris approved these changes
@appdenScott Kyle (appden)appden approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@HeyImChrisHeyImChris

Labels

Partner: Facebook

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@marty-wang@appden@harrieshin@HeyImChris

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Enable animated gif playback on Mac - #724
Merged
Harrie Shin (harrieshin) merged 4 commits into
microsoft:masterfrom 
marty-wang:gif
Feb 22, 2021
Merged
Enable animated gif playback on Mac#724
Harrie Shin (harrieshin) merged 4 commits into
microsoft:masterfrom 
marty-wang:gif
Conversation
@marty-wang
@marty-wangMo (marty-wang)
commented
Feb 13, 2021•

edited

Loading

Copy link


Copy Markdown

Please select one of the following
  •  I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  •  I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  •  I am making a fix / change for the macOS implementation of react-native
  •  I am making a change required for Microsoft usage of react-native
Summary
This PR is to enable animated gif playback on Mac
Changelog
[macOS] [Fixed] - Enable animated gif playback on Mac
Test Plan
Screen.Recording.2021-02-13.at.9.25.22.AM.mov
Screen.Recording.2021-02-20.at.11.19.53.AM.mov
Microsoft Reviewers: Open in CodeFlow
Mo Wang
added 2 commits
February 13, 2021 09:22
Mo Wang
enable gif for mac
6acce2c
Summary:
I verify that it works for Zeratul as well. It also works regardless turbo module is enabled or not.
Test Plan: |{F369886201}|{F369889196}|
Reviewers: skyle
Reviewed By: skyle
Subscribers: zackargyle
Differential Revision: https://phabricator.intern.facebook.com/D26272145
Tasks: T82742678
Signature: 26272145:1612513052:520a8b0b3ab4b211c953b3225c6c96ffb8a29fc5
Mo Wang
bypass setImage logic when it is Mac
f9b9a6a
Summary: as titled
Test Plan:
{F370138978}
{F370139033}
Reviewers: skyle
Reviewed By: skyle
Subscribers: zackargyle
Differential Revision: https://phabricator.intern.facebook.com/D26288169
Signature: 26288169:1612565769:8f779fe01614e3399ac3e484853bb61246210ff4
@ghost
Deleted user (ghost)
commented
Feb 13, 2021•

edited by ghost

Loading

Copy link


Copy Markdown

CLA assistant check
All CLA requirements met.
HeyImChris
HeyImChris
approved these changes
Feb 17, 2021
View reviewed changes
@HeyImChrisHeyImChris
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! I didn't see it mentioned in the validation section but can you also just sanity check that iOS still works as expected?
Comment threadLibraries/Image/RCTUIImageViewAnimated.m
Outdated

Comment threadLibraries/Image/RCTUIImageViewAnimated.m
Outdated

@appden
Scott Kyle (appden)
commented
Feb 18, 2021

Copy link


Copy Markdown

This fixes #507
@harrieshin
Harrie Shin (harrieshin)
merged commit 068ed05
into
microsoft:masterFeb 22, 2021
HeyImChris pushed a commit
to HeyImChris/react-native-macos
that referenced
this pull request
Mar 2, 2021
@marty-wangMo Wang@HeyImChris
Enable animated gif playback on Mac (microsoft#724)
19f4a9c
* enable gif for mac
Summary:
I verify that it works for Zeratul as well. It also works regardless turbo module is enabled or not.
Test Plan: |{F369886201}|{F369889196}|
Reviewers: skyle
Reviewed By: skyle
Subscribers: zackargyle
Differential Revision: https://phabricator.intern.facebook.com/D26272145
Tasks: T82742678
Signature: 26272145:1612513052:520a8b0b3ab4b211c953b3225c6c96ffb8a29fc5
* bypass setImage logic when it is Mac
Summary: as titled
Test Plan:
{F370138978}
{F370139033}
Reviewers: skyle
Reviewed By: skyle
Subscribers: zackargyle
Differential Revision: https://phabricator.intern.facebook.com/D26288169
Signature: 26288169:1612565769:8f779fe01614e3399ac3e484853bb61246210ff4
* address PR comments
* address PR comments 1
Co-authored-by: Mo Wang <mowang@fb.com>
HeyImChris added a commit
that referenced
this pull request
Mar 17, 2021
@HeyImChris@acoates-ms
@marty-wangMo Wang@appden@Saadnajmi@anandrajeswaran
Add some robustness to the CI and switch to Xcode 12 (#709)
3056c4e
* Update RCTCxxBridge.mm
* make CI xcode versioning more robust to xcode12
* update to xcode 12.4
* use apple variables file
* Update RCTCxxBridge.mm
* add quotes
* switch to catalina
* update pods to 10.15
* make CI xcode versioning more robust to xcode12
* update to xcode 12.4
* use apple variables file
* add quotes
* switch to catalina
* update pods to 10.15
* upgrade version requirements to n-2 for osx
* make CI xcode versioning more robust to xcode12
* update to xcode 12.4
* use apple variables file
* add quotes
* switch to catalina
* make CI xcode versioning more robust to xcode12
* update to xcode 12.4
* use apple variables file
* add quotes
* make CI xcode versioning more robust to xcode12
* update to xcode 12.4
* use apple variables file
* add quotes
* CI should run on PRs to future stable branches (#718)
* Pull in header's C declaration to stop symbol mangling (#728)
* Update RCTCxxBridge.mm
* Update RCTCxxBridge.mm
* fix undefined extern c symbol
* scroll content with animation (#725)
Summary: please see test plan
Test Plan:
|Before|After|
|{F371503806}|{F371499708}|
Reviewers: skyle
Reviewed By: skyle
Subscribers: zackargyle
Differential Revision: https://phabricator.intern.facebook.com/D26354172
Tasks: T84165504
Signature: 26354172:1612920735:2cd8455b1bae06ee555bd98cfd41c4dfb29c288e
Co-authored-by: Mo Wang <mowang@fb.com>
* Fix missing props on secure text input (#719)
* Enable animated gif playback on Mac (#724)
* enable gif for mac
Summary:
I verify that it works for Zeratul as well. It also works regardless turbo module is enabled or not.
Test Plan: |{F369886201}|{F369889196}|
Reviewers: skyle
Reviewed By: skyle
Subscribers: zackargyle
Differential Revision: https://phabricator.intern.facebook.com/D26272145
Tasks: T82742678
Signature: 26272145:1612513052:520a8b0b3ab4b211c953b3225c6c96ffb8a29fc5
* bypass setImage logic when it is Mac
Summary: as titled
Test Plan:
{F370138978}
{F370139033}
Reviewers: skyle
Reviewed By: skyle
Subscribers: zackargyle
Differential Revision: https://phabricator.intern.facebook.com/D26288169
Signature: 26288169:1612565769:8f779fe01614e3399ac3e484853bb61246210ff4
* address PR comments
* address PR comments 1
Co-authored-by: Mo Wang <mowang@fb.com>
* Add explicit Tab support to keyboarding (#723)
* Update RCTCxxBridge.mm
* Update RCTCxxBridge.mm
* add explicit tab support
* missing tab validity check
* Fix Deadlock in RCTi18nUtil (iOS) (#733)
* Initial Commit
* Fix typo
* Fix default initialization of isRTLAllowed and documentation
* use BOOL, remove superfluous readwrite decorator
* Fix another typo
* Add TODO Marker
* update to macOS 10.15
* make CI xcode versioning more robust to xcode12
* update to xcode 12.4
* use apple variables file
* add quotes
* switch to catalina
* update pods to 10.15
* upgrade version requirements to n-2 for osx
* make CI xcode versioning more robust to xcode12
* update to xcode 12.4
* use apple variables file
* add quotes
* switch to catalina
* make CI xcode versioning more robust to xcode12
* update to xcode 12.4
* use apple variables file
* add quotes
* make CI xcode versioning more robust to xcode12
* update to xcode 12.4
* use apple variables file
* add quotes
* update to macOS 10.15
* update to xcode 12.4
* use apple variables file
* switch to catalina
* 10.14
* CI has to run on 10.15.4 or later
* fix up pod errors
* upgrade iphone simulator
* iphone 13
* remove old post install script
* iphone 8
* Restore Podfile.lock to see if it fixes CI
* Restore compiler flags in TurboModuleCxx-WinRTPort
* Remove macOS arm64 build divergence
* Remove building all ARCHS temporarily
* Override ONLY_ACTIVE_ARCH in release builds too
* Push iOS 14 snapshots
Co-authored-by: Andrew Coates <30809111+acoates-ms@users.noreply.github.com>
Co-authored-by: Mo <mo.hy.wang@gmail.com>
Co-authored-by: Mo Wang <mowang@fb.com>
Co-authored-by: Scott Kyle <scott@appden.com>
Co-authored-by: Saad Najmi <saadnajmi2@gmail.com>
Co-authored-by: Anand Rajeswaran <anand.rajeswaran@outlook.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@harrieshinHarrie Shin (harrieshin)harrieshin approved these changes
@alloyEloy Durán (alloy)Awaiting requested review from alloy

+2 more reviewers

@HeyImChrisHeyImChrisHeyImChris approved these changes
@appdenScott Kyle (appden)appden approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@HeyImChrisHeyImChris

Labels

Partner: Facebook

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@marty-wang@appden@harrieshin@HeyImChris