Skip to content

Disable Integration job on main branch - #947

Merged
HeyImChris merged 2 commits into
microsoft:mainfrom
Saadnajmi:disable-integration-on-main
Jan 14, 2022
Merged

Disable Integration job on main branch#947
HeyImChris merged 2 commits into
microsoft:mainfrom
Saadnajmi:disable-integration-on-main

Conversation

@Saadnajmi

Copy link
Copy Markdown
Collaborator

Our main branch isn't stable yet. I think this is because we've been doing our 0.66 merge in the fb66merge branch of HeyImChris 's fork.

While main isn't stable, let's disable another failing CI check to not unblock merges. We should track fixing this test (along with the disabled test in #945 ) because we will need nightly builds passing eventually.

@HeyImChris

Copy link
Copy Markdown

Can we just fix this test instead of disabling it? The fix lives in 0.66 so should be doable to track it down.

@pull-bot

Pull Request Analyser (pull-bot) commented Jan 9, 2022

Copy link
Copy Markdown
Fails
🚫

❗ Base Branch - The base branch for this PR is something other than master. Are you sure you want to target something other than the master branch?

Messages
📖

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

DetailsCATEGORY may be:
  • General
  • macOS
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

📖📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.
📖📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.

Generated by 🚫 dangerJS against f7a0e5f

@Saadnajmi

Copy link
Copy Markdown
CollaboratorAuthor

Can we just fix this test instead of disabling it? The fix lives in 0.66 so should be doable to track it down.

Sorry, feel free to ignore me till tomorrow.
We can, I just couldn't figure it yet. I assumed the test would start passing again whenever we merged the 0.66 merge branch.

Comment thread.ado/apple-integration.yml
@HeyImChris

Copy link
Copy Markdown

Can we just fix this test instead of disabling it? The fix lives in 0.66 so should be doable to track it down.

Sorry, feel free to ignore me till tomorrow. We can, I just couldn't figure it yet. I assumed the test would start passing again whenever we merged the 0.66 merge branch.

Yep test passes on 0.66! We'd just need a follow up to re-enable this test once 0.66 goes in which I'm hoping will be today.

@HeyImChris
HeyImChris self-requested a review January 14, 2022 23:42
@HeyImChris
HeyImChris merged commit 65f2be8 into microsoft:mainJan 14, 2022
@Saadnajmi
Saad Najmi (Saadnajmi) deleted the disable-integration-on-main branch January 15, 2022 00:19
Saad Najmi (Saadnajmi) added a commit that referenced this pull request Jan 15, 2022
Saad Najmi (Saadnajmi) added a commit to Saadnajmi/react-native-macos that referenced this pull request Jan 15, 2022
Saad Najmi (Saadnajmi) added a commit that referenced this pull request Jan 25, 2022
* Revert "Revert "Disable Integration job on main branch (#947)""
This reverts commit 00fdaca.
* update podfile
* Update apple-integration.yml
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Saadnajmi@HeyImChris@pull-bot