Skip to content

Comment out failing circle ci test - #945

Merged
HeyImChris merged 3 commits into
microsoft:mainfrom
Saadnajmi:comment-out-ci
Jan 12, 2022
Merged

Comment out failing circle ci test#945
HeyImChris merged 3 commits into
microsoft:mainfrom
Saadnajmi:comment-out-ci

Conversation

@Saadnajmi

@SaadnajmiSaad Najmi (Saadnajmi) commented Jan 9, 2022

Copy link
Copy Markdown
Collaborator

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

The Flow Check phase of our End to End Circle CI tests fails. This seems to be because the E2E test is installing _react-native-macosversion 0.63 instead of latest (which is missing theColors.darker` variable, which is how I figured that out. I haven't figured it out yet (perhaps #944 will help?), but this is blocking PRs quite a bit. Let's comment it out for now

Changelog

[Internal] [Removed] - Removed Flow check test from E2E tests temporarily

Test Plan

@pull-bot

Pull Request Analyser (pull-bot) commented Jan 9, 2022

Copy link
Copy Markdown
Fails
🚫

❗ Base Branch - The base branch for this PR is something other than master. Are you sure you want to target something other than the master branch?

Generated by 🚫 dangerJS against 21cdb45

@Saadnajmi

Copy link
Copy Markdown
CollaboratorAuthor

HeyImChrisHarrie Shin (@harrieshin) The failing circle-ci tests now pass, and #946 should take care of the analyze_pr check

@SaadnajmiSaad Najmi (Saadnajmi) changed the title [Draft] Comment out failing circle ci testComment out failing circle ci testJan 9, 2022

@HeyImChrisHeyImChris left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the CI is still failing? If we can keep most CI tests in tact and passing then that's great. We also don't really rely on CircleCI much anyway so could do away with them too

@Saadnajmi

Copy link
Copy Markdown
CollaboratorAuthor

Looks like the CI is still failing? If we can keep most CI tests in tact and passing then that's great. We also don't really rely on CircleCI much anyway so could do away with them too

test_js and test_js_prev_lts both now pass. The failing "analyze_pr" is bc of danger bot which I fixed with #946

@HeyImChris
HeyImChris merged commit bd55cf3 into microsoft:mainJan 12, 2022
@Saadnajmi
Saad Najmi (Saadnajmi) deleted the comment-out-ci branch January 12, 2022 18:33
@SaadnajmiSaad Najmi (Saadnajmi) mentioned this pull request Jan 14, 2022
4 tasks
Saad Najmi (Saadnajmi) added a commit to Saadnajmi/react-native-macos that referenced this pull request Jan 19, 2022
* comment out test
* Update run-ci-e2e-tests.js
* Update run-ci-e2e-tests.js
@SaadnajmiSaad Najmi (Saadnajmi) mentioned this pull request Jan 19, 2022
4 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Saadnajmi@pull-bot@HeyImChris