Skip to content

feat(android): populate home screen with AppRegistry entries - #1127

Merged
Tommy Nguyen (tido64) merged 1 commit into
trunkfrom
tido/android-app-registry
Oct 6, 2022
Merged

feat(android): populate home screen with AppRegistry entries#1127
Tommy Nguyen (tido64) merged 1 commit into
trunkfrom
tido/android-app-registry

Conversation

@tido64

@tido64Tommy Nguyen (tido64) commented Sep 21, 2022•
edited
Loading

Copy link
Copy Markdown
Member

Description

Similar to #482, but for Android.

Resolves#189.

Platforms affected

  • Android
  • iOS
  • macOS
  • Windows

Test plan

See test plan in #482.

Flipper crashes on startup with this change. I'm not sure why, but downgrading it to 0.105 resolves the issue. The SIGILL comes from the device trying to load different .so files on startup, but the app should load fine. Bump to 0.164 to make it go away.

This needs to be tested on:

  • 0.64 (no libjsi.so, should show blank screen)
  • 0.68 (has release libjsi.so)
  • 0.69 (has debug/release libjsi.so)
  • 0.69 + new arch (uses ndkBuild, libjsi.so already linked)
  • 0.70 (has debug/release libjsi.so)
  • 0.70 + new arch (uses cmake, libjsi.so already linked)

Note that for new arch, you will need to force resolve rn-cli to 9.x for autolinking.

device-2022-09-21-145225

@github-actionsgithub-actionsBot added the platform: Android This affects Android label Sep 21, 2022
This was referenced Sep 21, 2022
Merged
Closed
@tido64
Tommy Nguyen (tido64)force-pushed the tido/android-app-registry branch 6 times, most recently from 4a6eb9f to a22d262CompareSeptember 22, 2022 11:11
@tido64Tommy Nguyen (tido64) mentioned this pull request Sep 22, 2022
Open
@tido64
Tommy Nguyen (tido64)force-pushed the tido/android-app-registry branch 5 times, most recently from a03e388 to f5ebb75CompareSeptember 23, 2022 16:37
kelset
Lorenzo Sciandra (kelset) reviewed Oct 4, 2022
View reviewed changes

@kelsetLorenzo Sciandra (kelset) left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested:

  • ❌ 0.64 (no libjsi.so)

    • fails on yarn android with error react-native-test-app/example/node_modules/react-native-test-app/android/app/src/main/java/com/microsoft/reacttestapp/react/TestAppReactNativeHost.kt: (181, 24): Unresolved reference: loadLibrary and 
       Execution failed for task ':app:compileDebugKotlin'.
> A failure occurred while executing org.jetbrains.kotlin.compilerRunner.GradleCompilerRunnerWithWorkers$GradleKotlinCompilerWorkAction
> Compilation error. See log for more details

  • ✅ 0.68 (has release libjsi.so)

  • ✅🟡 0.69 (has debug/release libjsi.so) (but for some reason it just shows a blank page instead of the normal one with all the info, and just the version in the bottom right corner)

  • ❌ 0.69 + new arch (uses ndkBuild, libjsi.so already linked)

    • fails on yarn android with error react-native-test-app/example/android/app/build/generated/rncli/src/main/jni/Android-rncli.mk: No such file or directory and make: *** No rule to make target '/Users/lsciandra/Developer/oss/react-native-test-app/example/android/app/build/generated/rncli/src/main/jni/Android-rncli.mk'. Stop.

  • ✅ 0.70 (has debug/release libjsi.so)

  • ✅ 0.70 + new arch (uses cmake, libjsi.so already linked)

@tido64
Tommy Nguyen (tido64)force-pushed the tido/android-qr-code-scanner branch from 370b72c to 5357a81CompareOctober 4, 2022 17:14
@tido64

Tommy Nguyen (tido64) commented Oct 4, 2022

Copy link
Copy Markdown
MemberAuthor

Lorenzo Sciandra (@kelset):

For 0.64, we need a fix that landed on trunk. I've rebased now so it should work.

For 0.69: I forgot to mention that you need RN-CLI 9.x because 8 does not yet have autolinking. I also had to remove react-native-safe-area-context because the latest version dropped support for 0.69 and below when on new arch. Otherwise, I cannot repro the white screen you're seeing.

Screenshot_1664903958Screenshot_1664906394

@kelset

Lorenzo Sciandra (kelset) commented Oct 6, 2022

Copy link
Copy Markdown
Contributor

yeah, with the adjustments I managed to make it work for both 0.64 and both versions of 0.69 🎉

LGTM, when you want to open for review I can ✅

@tido64
Tommy Nguyen (tido64) marked this pull request as ready for review October 6, 2022 15:47
kelset
Lorenzo Sciandra (kelset) approved these changes Oct 6, 2022
View reviewed changes

@kelsetLorenzo Sciandra (kelset) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Base automatically changed from tido/android-qr-code-scanner to trunkOctober 6, 2022 16:21
@tido64
Tommy Nguyen (tido64) enabled auto-merge (squash) October 6, 2022 16:35
@tido64
Tommy Nguyen (tido64) merged commit 6b653c8 into trunkOct 6, 2022
@tido64
Tommy Nguyen (tido64) deleted the tido/android-app-registry branch October 6, 2022 16:54
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arazabishovAraz Abishov (arazabishov)Awaiting requested review from arazabishov
@sweggersenSam Mathias Weggersen (sweggersen)Awaiting requested review from sweggersen
1 more reviewer
@kelsetLorenzo Sciandra (kelset)kelset approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

platform: AndroidThis affects Android

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Populate components list from AppRegistry if app.json is empty/missing

2 participants

@tido64@kelset
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
feat(android): populate home screen with AppRegistry entries by tido64 · Pull Request #1127 · microsoft/react-native-test-app · GitHub
Skip to content
feat(android): populate home screen with AppRegistry entries - #1127
Merged
Tommy Nguyen (tido64) merged 1 commit into
trunkfrom 
tido/android-app-registry
Oct 6, 2022
Merged
feat(android): populate home screen with AppRegistry entries#1127
Tommy Nguyen (tido64) merged 1 commit into
trunkfrom 
tido/android-app-registry
Conversation
@tido64
@tido64Tommy Nguyen (tido64)
commented
Sep 21, 2022•

edited

Loading

Copy link


Copy Markdown

Member
Description
Similar to #482, but for Android.
Resolves#189.
Platforms affected
  •  Android
  •  iOS
  •  macOS
  •  Windows
Test plan
See test plan in #482.
Flipper crashes on startup with this change. I'm not sure why, but downgrading it to 0.105 resolves the issue. The SIGILL comes from the device trying to load different .so files on startup, but the app should load fine. Bump to 0.164 to make it go away.
This needs to be tested on:
  •  0.64 (no libjsi.so, should show blank screen)
  •  0.68 (has release libjsi.so)
  •  0.69 (has debug/release libjsi.so)
  •  0.69 + new arch (uses ndkBuild, libjsi.so already linked)
  •  0.70 (has debug/release libjsi.so)
  •  0.70 + new arch (uses cmake, libjsi.so already linked)
Note that for new arch, you will need to force resolve rn-cli to 9.x for autolinking.
device-2022-09-21-145225
@github-actionsgithub-actionsBot
added
the 
platform: Android
This affects Android
label
Sep 21, 2022

This was referenced Sep 21, 2022
 Merged


Closed

@tido64
Tommy Nguyen (tido64)force-pushed
the
tido/android-app-registry
branch
6 times, most recently
from
4a6eb9f to
a22d262CompareSeptember 22, 2022 11:11
@tido64Tommy Nguyen (tido64)
mentioned this pull request
Sep 22, 2022

Open

@tido64
Tommy Nguyen (tido64)force-pushed
the
tido/android-app-registry
branch
5 times, most recently
from
a03e388 to
f5ebb75CompareSeptember 23, 2022 16:37
kelset
Lorenzo Sciandra (kelset)
reviewed
Oct 4, 2022
View reviewed changes
@kelsetLorenzo Sciandra (kelset)
left a comment
•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested:
  • ❌ 0.64 (no libjsi.so)
    • fails on yarn android with error react-native-test-app/example/node_modules/react-native-test-app/android/app/src/main/java/com/microsoft/reacttestapp/react/TestAppReactNativeHost.kt: (181, 24): Unresolved reference: loadLibrary and

       Execution failed for task ':app:compileDebugKotlin'.
> A failure occurred while executing org.jetbrains.kotlin.compilerRunner.GradleCompilerRunnerWithWorkers$GradleKotlinCompilerWorkAction
> Compilation error. See log for more details

  • ✅ 0.68 (has release libjsi.so)
  • ✅🟡 0.69 (has debug/release libjsi.so) (but for some reason it just shows a blank page instead of the normal one with all the info, and just the version in the bottom right corner)
  • ❌ 0.69 + new arch (uses ndkBuild, libjsi.so already linked)
    • fails on yarn android with error react-native-test-app/example/android/app/build/generated/rncli/src/main/jni/Android-rncli.mk: No such file or directory and make: *** No rule to make target '/Users/lsciandra/Developer/oss/react-native-test-app/example/android/app/build/generated/rncli/src/main/jni/Android-rncli.mk'. Stop.
  • ✅ 0.70 (has debug/release libjsi.so)
  • ✅ 0.70 + new arch (uses cmake, libjsi.so already linked)
@tido64
Tommy Nguyen (tido64)force-pushed
the
tido/android-qr-code-scanner
branch
from
370b72c to
5357a81CompareOctober 4, 2022 17:14
@tido64
Tommy Nguyen (tido64)
commented
Oct 4, 2022

Copy link


Copy Markdown

MemberAuthor
Lorenzo Sciandra (@kelset):
For 0.64, we need a fix that landed on trunk. I've rebased now so it should work.
For 0.69: I forgot to mention that you need RN-CLI 9.x because 8 does not yet have autolinking. I also had to remove react-native-safe-area-context because the latest version dropped support for 0.69 and below when on new arch. Otherwise, I cannot repro the white screen you're seeing.
Screenshot_1664903958Screenshot_1664906394
@kelset
Lorenzo Sciandra (kelset)
commented
Oct 6, 2022

Copy link


Copy Markdown

Contributor
yeah, with the adjustments I managed to make it work for both 0.64 and both versions of 0.69 🎉
LGTM, when you want to open for review I can ✅
@tido64
Tommy Nguyen (tido64)
marked this pull request as ready for review
October 6, 2022 15:47
kelset
Lorenzo Sciandra (kelset)
approved these changes
Oct 6, 2022
View reviewed changes
@kelsetLorenzo Sciandra (kelset)
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Base automatically changed from
tido/android-qr-code-scanner to
trunkOctober 6, 2022 16:21
@tido64
Tommy Nguyen (tido64)
enabled auto-merge (squash)
October 6, 2022 16:35
@tido64
Tommy Nguyen (tido64)
merged commit 6b653c8
into
trunkOct 6, 2022
@tido64
Tommy Nguyen (tido64)
deleted the

tido/android-app-registry

branch
October 6, 2022 16:54
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@arazabishovAraz Abishov (arazabishov)Awaiting requested review from arazabishov
@sweggersenSam Mathias Weggersen (sweggersen)Awaiting requested review from sweggersen

1 more reviewer

@kelsetLorenzo Sciandra (kelset)kelset approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

platform: AndroidThis affects Android

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Populate components list from AppRegistry if app.json is empty/missing


2 participants

@tido64@kelset

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
feat(android): populate home screen with AppRegistry entries by tido64 · Pull Request #1127 · microsoft/react-native-test-app · GitHub
Skip to content
feat(android): populate home screen with AppRegistry entries - #1127
Merged
Tommy Nguyen (tido64) merged 1 commit into
trunkfrom 
tido/android-app-registry
Oct 6, 2022
Merged
feat(android): populate home screen with AppRegistry entries#1127
Tommy Nguyen (tido64) merged 1 commit into
trunkfrom 
tido/android-app-registry
Conversation
@tido64
@tido64Tommy Nguyen (tido64)
commented
Sep 21, 2022•

edited

Loading

Copy link


Copy Markdown

Member
Description
Similar to #482, but for Android.
Resolves#189.
Platforms affected
  •  Android
  •  iOS
  •  macOS
  •  Windows
Test plan
See test plan in #482.
Flipper crashes on startup with this change. I'm not sure why, but downgrading it to 0.105 resolves the issue. The SIGILL comes from the device trying to load different .so files on startup, but the app should load fine. Bump to 0.164 to make it go away.
This needs to be tested on:
  •  0.64 (no libjsi.so, should show blank screen)
  •  0.68 (has release libjsi.so)
  •  0.69 (has debug/release libjsi.so)
  •  0.69 + new arch (uses ndkBuild, libjsi.so already linked)
  •  0.70 (has debug/release libjsi.so)
  •  0.70 + new arch (uses cmake, libjsi.so already linked)
Note that for new arch, you will need to force resolve rn-cli to 9.x for autolinking.
device-2022-09-21-145225
@github-actionsgithub-actionsBot
added
the 
platform: Android
This affects Android
label
Sep 21, 2022

This was referenced Sep 21, 2022
 Merged


Closed

@tido64
Tommy Nguyen (tido64)force-pushed
the
tido/android-app-registry
branch
6 times, most recently
from
4a6eb9f to
a22d262CompareSeptember 22, 2022 11:11
@tido64Tommy Nguyen (tido64)
mentioned this pull request
Sep 22, 2022

Open

@tido64
Tommy Nguyen (tido64)force-pushed
the
tido/android-app-registry
branch
5 times, most recently
from
a03e388 to
f5ebb75CompareSeptember 23, 2022 16:37
kelset
Lorenzo Sciandra (kelset)
reviewed
Oct 4, 2022
View reviewed changes
@kelsetLorenzo Sciandra (kelset)
left a comment
•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested:
  • ❌ 0.64 (no libjsi.so)
    • fails on yarn android with error react-native-test-app/example/node_modules/react-native-test-app/android/app/src/main/java/com/microsoft/reacttestapp/react/TestAppReactNativeHost.kt: (181, 24): Unresolved reference: loadLibrary and

       Execution failed for task ':app:compileDebugKotlin'.
> A failure occurred while executing org.jetbrains.kotlin.compilerRunner.GradleCompilerRunnerWithWorkers$GradleKotlinCompilerWorkAction
> Compilation error. See log for more details

  • ✅ 0.68 (has release libjsi.so)
  • ✅🟡 0.69 (has debug/release libjsi.so) (but for some reason it just shows a blank page instead of the normal one with all the info, and just the version in the bottom right corner)
  • ❌ 0.69 + new arch (uses ndkBuild, libjsi.so already linked)
    • fails on yarn android with error react-native-test-app/example/android/app/build/generated/rncli/src/main/jni/Android-rncli.mk: No such file or directory and make: *** No rule to make target '/Users/lsciandra/Developer/oss/react-native-test-app/example/android/app/build/generated/rncli/src/main/jni/Android-rncli.mk'. Stop.
  • ✅ 0.70 (has debug/release libjsi.so)
  • ✅ 0.70 + new arch (uses cmake, libjsi.so already linked)
@tido64
Tommy Nguyen (tido64)force-pushed
the
tido/android-qr-code-scanner
branch
from
370b72c to
5357a81CompareOctober 4, 2022 17:14
@tido64
Tommy Nguyen (tido64)
commented
Oct 4, 2022

Copy link


Copy Markdown

MemberAuthor
Lorenzo Sciandra (@kelset):
For 0.64, we need a fix that landed on trunk. I've rebased now so it should work.
For 0.69: I forgot to mention that you need RN-CLI 9.x because 8 does not yet have autolinking. I also had to remove react-native-safe-area-context because the latest version dropped support for 0.69 and below when on new arch. Otherwise, I cannot repro the white screen you're seeing.
Screenshot_1664903958Screenshot_1664906394
@kelset
Lorenzo Sciandra (kelset)
commented
Oct 6, 2022

Copy link


Copy Markdown

Contributor
yeah, with the adjustments I managed to make it work for both 0.64 and both versions of 0.69 🎉
LGTM, when you want to open for review I can ✅
@tido64
Tommy Nguyen (tido64)
marked this pull request as ready for review
October 6, 2022 15:47
kelset
Lorenzo Sciandra (kelset)
approved these changes
Oct 6, 2022
View reviewed changes
@kelsetLorenzo Sciandra (kelset)
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Base automatically changed from
tido/android-qr-code-scanner to
trunkOctober 6, 2022 16:21
@tido64
Tommy Nguyen (tido64)
enabled auto-merge (squash)
October 6, 2022 16:35
@tido64
Tommy Nguyen (tido64)
merged commit 6b653c8
into
trunkOct 6, 2022
@tido64
Tommy Nguyen (tido64)
deleted the

tido/android-app-registry

branch
October 6, 2022 16:54
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@arazabishovAraz Abishov (arazabishov)Awaiting requested review from arazabishov
@sweggersenSam Mathias Weggersen (sweggersen)Awaiting requested review from sweggersen

1 more reviewer

@kelsetLorenzo Sciandra (kelset)kelset approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

platform: AndroidThis affects Android

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Populate components list from AppRegistry if app.json is empty/missing


2 participants

@tido64@kelset

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
feat(android): populate home screen with AppRegistry entries by tido64 · Pull Request #1127 · microsoft/react-native-test-app · GitHub
Skip to content
feat(android): populate home screen with AppRegistry entries - #1127
Merged
Tommy Nguyen (tido64) merged 1 commit into
trunkfrom 
tido/android-app-registry
Oct 6, 2022
Merged
feat(android): populate home screen with AppRegistry entries#1127
Tommy Nguyen (tido64) merged 1 commit into
trunkfrom 
tido/android-app-registry
Conversation
@tido64
@tido64Tommy Nguyen (tido64)
commented
Sep 21, 2022•

edited

Loading

Copy link


Copy Markdown

Member
Description
Similar to #482, but for Android.
Resolves#189.
Platforms affected
  •  Android
  •  iOS
  •  macOS
  •  Windows
Test plan
See test plan in #482.
Flipper crashes on startup with this change. I'm not sure why, but downgrading it to 0.105 resolves the issue. The SIGILL comes from the device trying to load different .so files on startup, but the app should load fine. Bump to 0.164 to make it go away.
This needs to be tested on:
  •  0.64 (no libjsi.so, should show blank screen)
  •  0.68 (has release libjsi.so)
  •  0.69 (has debug/release libjsi.so)
  •  0.69 + new arch (uses ndkBuild, libjsi.so already linked)
  •  0.70 (has debug/release libjsi.so)
  •  0.70 + new arch (uses cmake, libjsi.so already linked)
Note that for new arch, you will need to force resolve rn-cli to 9.x for autolinking.
device-2022-09-21-145225
@github-actionsgithub-actionsBot
added
the 
platform: Android
This affects Android
label
Sep 21, 2022

This was referenced Sep 21, 2022
 Merged


Closed

@tido64
Tommy Nguyen (tido64)force-pushed
the
tido/android-app-registry
branch
6 times, most recently
from
4a6eb9f to
a22d262CompareSeptember 22, 2022 11:11
@tido64Tommy Nguyen (tido64)
mentioned this pull request
Sep 22, 2022

Open

@tido64
Tommy Nguyen (tido64)force-pushed
the
tido/android-app-registry
branch
5 times, most recently
from
a03e388 to
f5ebb75CompareSeptember 23, 2022 16:37
kelset
Lorenzo Sciandra (kelset)
reviewed
Oct 4, 2022
View reviewed changes
@kelsetLorenzo Sciandra (kelset)
left a comment
•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested:
  • ❌ 0.64 (no libjsi.so)
    • fails on yarn android with error react-native-test-app/example/node_modules/react-native-test-app/android/app/src/main/java/com/microsoft/reacttestapp/react/TestAppReactNativeHost.kt: (181, 24): Unresolved reference: loadLibrary and

       Execution failed for task ':app:compileDebugKotlin'.
> A failure occurred while executing org.jetbrains.kotlin.compilerRunner.GradleCompilerRunnerWithWorkers$GradleKotlinCompilerWorkAction
> Compilation error. See log for more details

  • ✅ 0.68 (has release libjsi.so)
  • ✅🟡 0.69 (has debug/release libjsi.so) (but for some reason it just shows a blank page instead of the normal one with all the info, and just the version in the bottom right corner)
  • ❌ 0.69 + new arch (uses ndkBuild, libjsi.so already linked)
    • fails on yarn android with error react-native-test-app/example/android/app/build/generated/rncli/src/main/jni/Android-rncli.mk: No such file or directory and make: *** No rule to make target '/Users/lsciandra/Developer/oss/react-native-test-app/example/android/app/build/generated/rncli/src/main/jni/Android-rncli.mk'. Stop.
  • ✅ 0.70 (has debug/release libjsi.so)
  • ✅ 0.70 + new arch (uses cmake, libjsi.so already linked)
@tido64
Tommy Nguyen (tido64)force-pushed
the
tido/android-qr-code-scanner
branch
from
370b72c to
5357a81CompareOctober 4, 2022 17:14
@tido64
Tommy Nguyen (tido64)
commented
Oct 4, 2022

Copy link


Copy Markdown

MemberAuthor
Lorenzo Sciandra (@kelset):
For 0.64, we need a fix that landed on trunk. I've rebased now so it should work.
For 0.69: I forgot to mention that you need RN-CLI 9.x because 8 does not yet have autolinking. I also had to remove react-native-safe-area-context because the latest version dropped support for 0.69 and below when on new arch. Otherwise, I cannot repro the white screen you're seeing.
Screenshot_1664903958Screenshot_1664906394
@kelset
Lorenzo Sciandra (kelset)
commented
Oct 6, 2022

Copy link


Copy Markdown

Contributor
yeah, with the adjustments I managed to make it work for both 0.64 and both versions of 0.69 🎉
LGTM, when you want to open for review I can ✅
@tido64
Tommy Nguyen (tido64)
marked this pull request as ready for review
October 6, 2022 15:47
kelset
Lorenzo Sciandra (kelset)
approved these changes
Oct 6, 2022
View reviewed changes
@kelsetLorenzo Sciandra (kelset)
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Base automatically changed from
tido/android-qr-code-scanner to
trunkOctober 6, 2022 16:21
@tido64
Tommy Nguyen (tido64)
enabled auto-merge (squash)
October 6, 2022 16:35
@tido64
Tommy Nguyen (tido64)
merged commit 6b653c8
into
trunkOct 6, 2022
@tido64
Tommy Nguyen (tido64)
deleted the

tido/android-app-registry

branch
October 6, 2022 16:54
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@arazabishovAraz Abishov (arazabishov)Awaiting requested review from arazabishov
@sweggersenSam Mathias Weggersen (sweggersen)Awaiting requested review from sweggersen

1 more reviewer

@kelsetLorenzo Sciandra (kelset)kelset approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

platform: AndroidThis affects Android

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Populate components list from AppRegistry if app.json is empty/missing


2 participants

@tido64@kelset

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
feat(android): populate home screen with AppRegistry entries by tido64 · Pull Request #1127 · microsoft/react-native-test-app · GitHub
Skip to content
feat(android): populate home screen with AppRegistry entries - #1127
Merged
Tommy Nguyen (tido64) merged 1 commit into
trunkfrom 
tido/android-app-registry
Oct 6, 2022
Merged
feat(android): populate home screen with AppRegistry entries#1127
Tommy Nguyen (tido64) merged 1 commit into
trunkfrom 
tido/android-app-registry
Conversation
@tido64
@tido64Tommy Nguyen (tido64)
commented
Sep 21, 2022•

edited

Loading

Copy link


Copy Markdown

Member
Description
Similar to #482, but for Android.
Resolves#189.
Platforms affected
  •  Android
  •  iOS
  •  macOS
  •  Windows
Test plan
See test plan in #482.
Flipper crashes on startup with this change. I'm not sure why, but downgrading it to 0.105 resolves the issue. The SIGILL comes from the device trying to load different .so files on startup, but the app should load fine. Bump to 0.164 to make it go away.
This needs to be tested on:
  •  0.64 (no libjsi.so, should show blank screen)
  •  0.68 (has release libjsi.so)
  •  0.69 (has debug/release libjsi.so)
  •  0.69 + new arch (uses ndkBuild, libjsi.so already linked)
  •  0.70 (has debug/release libjsi.so)
  •  0.70 + new arch (uses cmake, libjsi.so already linked)
Note that for new arch, you will need to force resolve rn-cli to 9.x for autolinking.
device-2022-09-21-145225
@github-actionsgithub-actionsBot
added
the 
platform: Android
This affects Android
label
Sep 21, 2022

This was referenced Sep 21, 2022
 Merged


Closed

@tido64
Tommy Nguyen (tido64)force-pushed
the
tido/android-app-registry
branch
6 times, most recently
from
4a6eb9f to
a22d262CompareSeptember 22, 2022 11:11
@tido64Tommy Nguyen (tido64)
mentioned this pull request
Sep 22, 2022

Open

@tido64
Tommy Nguyen (tido64)force-pushed
the
tido/android-app-registry
branch
5 times, most recently
from
a03e388 to
f5ebb75CompareSeptember 23, 2022 16:37
kelset
Lorenzo Sciandra (kelset)
reviewed
Oct 4, 2022
View reviewed changes
@kelsetLorenzo Sciandra (kelset)
left a comment
•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested:
  • ❌ 0.64 (no libjsi.so)
    • fails on yarn android with error react-native-test-app/example/node_modules/react-native-test-app/android/app/src/main/java/com/microsoft/reacttestapp/react/TestAppReactNativeHost.kt: (181, 24): Unresolved reference: loadLibrary and

       Execution failed for task ':app:compileDebugKotlin'.
> A failure occurred while executing org.jetbrains.kotlin.compilerRunner.GradleCompilerRunnerWithWorkers$GradleKotlinCompilerWorkAction
> Compilation error. See log for more details

  • ✅ 0.68 (has release libjsi.so)
  • ✅🟡 0.69 (has debug/release libjsi.so) (but for some reason it just shows a blank page instead of the normal one with all the info, and just the version in the bottom right corner)
  • ❌ 0.69 + new arch (uses ndkBuild, libjsi.so already linked)
    • fails on yarn android with error react-native-test-app/example/android/app/build/generated/rncli/src/main/jni/Android-rncli.mk: No such file or directory and make: *** No rule to make target '/Users/lsciandra/Developer/oss/react-native-test-app/example/android/app/build/generated/rncli/src/main/jni/Android-rncli.mk'. Stop.
  • ✅ 0.70 (has debug/release libjsi.so)
  • ✅ 0.70 + new arch (uses cmake, libjsi.so already linked)
@tido64
Tommy Nguyen (tido64)force-pushed
the
tido/android-qr-code-scanner
branch
from
370b72c to
5357a81CompareOctober 4, 2022 17:14
@tido64
Tommy Nguyen (tido64)
commented
Oct 4, 2022

Copy link


Copy Markdown

MemberAuthor
Lorenzo Sciandra (@kelset):
For 0.64, we need a fix that landed on trunk. I've rebased now so it should work.
For 0.69: I forgot to mention that you need RN-CLI 9.x because 8 does not yet have autolinking. I also had to remove react-native-safe-area-context because the latest version dropped support for 0.69 and below when on new arch. Otherwise, I cannot repro the white screen you're seeing.
Screenshot_1664903958Screenshot_1664906394
@kelset
Lorenzo Sciandra (kelset)
commented
Oct 6, 2022

Copy link


Copy Markdown

Contributor
yeah, with the adjustments I managed to make it work for both 0.64 and both versions of 0.69 🎉
LGTM, when you want to open for review I can ✅
@tido64
Tommy Nguyen (tido64)
marked this pull request as ready for review
October 6, 2022 15:47
kelset
Lorenzo Sciandra (kelset)
approved these changes
Oct 6, 2022
View reviewed changes
@kelsetLorenzo Sciandra (kelset)
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Base automatically changed from
tido/android-qr-code-scanner to
trunkOctober 6, 2022 16:21
@tido64
Tommy Nguyen (tido64)
enabled auto-merge (squash)
October 6, 2022 16:35
@tido64
Tommy Nguyen (tido64)
merged commit 6b653c8
into
trunkOct 6, 2022
@tido64
Tommy Nguyen (tido64)
deleted the

tido/android-app-registry

branch
October 6, 2022 16:54
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@arazabishovAraz Abishov (arazabishov)Awaiting requested review from arazabishov
@sweggersenSam Mathias Weggersen (sweggersen)Awaiting requested review from sweggersen

1 more reviewer

@kelsetLorenzo Sciandra (kelset)kelset approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

platform: AndroidThis affects Android

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Populate components list from AppRegistry if app.json is empty/missing


2 participants

@tido64@kelset

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
feat(android): populate home screen with AppRegistry entries by tido64 · Pull Request #1127 · microsoft/react-native-test-app · GitHub
Skip to content
feat(android): populate home screen with AppRegistry entries - #1127
Merged
Tommy Nguyen (tido64) merged 1 commit into
trunkfrom 
tido/android-app-registry
Oct 6, 2022
Merged
feat(android): populate home screen with AppRegistry entries#1127
Tommy Nguyen (tido64) merged 1 commit into
trunkfrom 
tido/android-app-registry
Conversation
@tido64
@tido64Tommy Nguyen (tido64)
commented
Sep 21, 2022•

edited

Loading

Copy link


Copy Markdown

Member
Description
Similar to #482, but for Android.
Resolves#189.
Platforms affected
  •  Android
  •  iOS
  •  macOS
  •  Windows
Test plan
See test plan in #482.
Flipper crashes on startup with this change. I'm not sure why, but downgrading it to 0.105 resolves the issue. The SIGILL comes from the device trying to load different .so files on startup, but the app should load fine. Bump to 0.164 to make it go away.
This needs to be tested on:
  •  0.64 (no libjsi.so, should show blank screen)
  •  0.68 (has release libjsi.so)
  •  0.69 (has debug/release libjsi.so)
  •  0.69 + new arch (uses ndkBuild, libjsi.so already linked)
  •  0.70 (has debug/release libjsi.so)
  •  0.70 + new arch (uses cmake, libjsi.so already linked)
Note that for new arch, you will need to force resolve rn-cli to 9.x for autolinking.
device-2022-09-21-145225
@github-actionsgithub-actionsBot
added
the 
platform: Android
This affects Android
label
Sep 21, 2022

This was referenced Sep 21, 2022
 Merged


Closed

@tido64
Tommy Nguyen (tido64)force-pushed
the
tido/android-app-registry
branch
6 times, most recently
from
4a6eb9f to
a22d262CompareSeptember 22, 2022 11:11
@tido64Tommy Nguyen (tido64)
mentioned this pull request
Sep 22, 2022

Open

@tido64
Tommy Nguyen (tido64)force-pushed
the
tido/android-app-registry
branch
5 times, most recently
from
a03e388 to
f5ebb75CompareSeptember 23, 2022 16:37
kelset
Lorenzo Sciandra (kelset)
reviewed
Oct 4, 2022
View reviewed changes
@kelsetLorenzo Sciandra (kelset)
left a comment
•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested:
  • ❌ 0.64 (no libjsi.so)
    • fails on yarn android with error react-native-test-app/example/node_modules/react-native-test-app/android/app/src/main/java/com/microsoft/reacttestapp/react/TestAppReactNativeHost.kt: (181, 24): Unresolved reference: loadLibrary and

       Execution failed for task ':app:compileDebugKotlin'.
> A failure occurred while executing org.jetbrains.kotlin.compilerRunner.GradleCompilerRunnerWithWorkers$GradleKotlinCompilerWorkAction
> Compilation error. See log for more details

  • ✅ 0.68 (has release libjsi.so)
  • ✅🟡 0.69 (has debug/release libjsi.so) (but for some reason it just shows a blank page instead of the normal one with all the info, and just the version in the bottom right corner)
  • ❌ 0.69 + new arch (uses ndkBuild, libjsi.so already linked)
    • fails on yarn android with error react-native-test-app/example/android/app/build/generated/rncli/src/main/jni/Android-rncli.mk: No such file or directory and make: *** No rule to make target '/Users/lsciandra/Developer/oss/react-native-test-app/example/android/app/build/generated/rncli/src/main/jni/Android-rncli.mk'. Stop.
  • ✅ 0.70 (has debug/release libjsi.so)
  • ✅ 0.70 + new arch (uses cmake, libjsi.so already linked)
@tido64
Tommy Nguyen (tido64)force-pushed
the
tido/android-qr-code-scanner
branch
from
370b72c to
5357a81CompareOctober 4, 2022 17:14
@tido64
Tommy Nguyen (tido64)
commented
Oct 4, 2022

Copy link


Copy Markdown

MemberAuthor
Lorenzo Sciandra (@kelset):
For 0.64, we need a fix that landed on trunk. I've rebased now so it should work.
For 0.69: I forgot to mention that you need RN-CLI 9.x because 8 does not yet have autolinking. I also had to remove react-native-safe-area-context because the latest version dropped support for 0.69 and below when on new arch. Otherwise, I cannot repro the white screen you're seeing.
Screenshot_1664903958Screenshot_1664906394
@kelset
Lorenzo Sciandra (kelset)
commented
Oct 6, 2022

Copy link


Copy Markdown

Contributor
yeah, with the adjustments I managed to make it work for both 0.64 and both versions of 0.69 🎉
LGTM, when you want to open for review I can ✅
@tido64
Tommy Nguyen (tido64)
marked this pull request as ready for review
October 6, 2022 15:47
kelset
Lorenzo Sciandra (kelset)
approved these changes
Oct 6, 2022
View reviewed changes
@kelsetLorenzo Sciandra (kelset)
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Base automatically changed from
tido/android-qr-code-scanner to
trunkOctober 6, 2022 16:21
@tido64
Tommy Nguyen (tido64)
enabled auto-merge (squash)
October 6, 2022 16:35
@tido64
Tommy Nguyen (tido64)
merged commit 6b653c8
into
trunkOct 6, 2022
@tido64
Tommy Nguyen (tido64)
deleted the

tido/android-app-registry

branch
October 6, 2022 16:54
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@arazabishovAraz Abishov (arazabishov)Awaiting requested review from arazabishov
@sweggersenSam Mathias Weggersen (sweggersen)Awaiting requested review from sweggersen

1 more reviewer

@kelsetLorenzo Sciandra (kelset)kelset approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

platform: AndroidThis affects Android

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Populate components list from AppRegistry if app.json is empty/missing


2 participants

@tido64@kelset

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
feat(android): populate home screen with AppRegistry entries by tido64 · Pull Request #1127 · microsoft/react-native-test-app · GitHub
Skip to content
feat(android): populate home screen with AppRegistry entries - #1127
Merged
Tommy Nguyen (tido64) merged 1 commit into
trunkfrom 
tido/android-app-registry
Oct 6, 2022
Merged
feat(android): populate home screen with AppRegistry entries#1127
Tommy Nguyen (tido64) merged 1 commit into
trunkfrom 
tido/android-app-registry
Conversation
@tido64
@tido64Tommy Nguyen (tido64)
commented
Sep 21, 2022•

edited

Loading

Copy link


Copy Markdown

Member
Description
Similar to #482, but for Android.
Resolves#189.
Platforms affected
  •  Android
  •  iOS
  •  macOS
  •  Windows
Test plan
See test plan in #482.
Flipper crashes on startup with this change. I'm not sure why, but downgrading it to 0.105 resolves the issue. The SIGILL comes from the device trying to load different .so files on startup, but the app should load fine. Bump to 0.164 to make it go away.
This needs to be tested on:
  •  0.64 (no libjsi.so, should show blank screen)
  •  0.68 (has release libjsi.so)
  •  0.69 (has debug/release libjsi.so)
  •  0.69 + new arch (uses ndkBuild, libjsi.so already linked)
  •  0.70 (has debug/release libjsi.so)
  •  0.70 + new arch (uses cmake, libjsi.so already linked)
Note that for new arch, you will need to force resolve rn-cli to 9.x for autolinking.
device-2022-09-21-145225
@github-actionsgithub-actionsBot
added
the 
platform: Android
This affects Android
label
Sep 21, 2022

This was referenced Sep 21, 2022
 Merged


Closed

@tido64
Tommy Nguyen (tido64)force-pushed
the
tido/android-app-registry
branch
6 times, most recently
from
4a6eb9f to
a22d262CompareSeptember 22, 2022 11:11
@tido64Tommy Nguyen (tido64)
mentioned this pull request
Sep 22, 2022

Open

@tido64
Tommy Nguyen (tido64)force-pushed
the
tido/android-app-registry
branch
5 times, most recently
from
a03e388 to
f5ebb75CompareSeptember 23, 2022 16:37
kelset
Lorenzo Sciandra (kelset)
reviewed
Oct 4, 2022
View reviewed changes
@kelsetLorenzo Sciandra (kelset)
left a comment
•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested:
  • ❌ 0.64 (no libjsi.so)
    • fails on yarn android with error react-native-test-app/example/node_modules/react-native-test-app/android/app/src/main/java/com/microsoft/reacttestapp/react/TestAppReactNativeHost.kt: (181, 24): Unresolved reference: loadLibrary and

       Execution failed for task ':app:compileDebugKotlin'.
> A failure occurred while executing org.jetbrains.kotlin.compilerRunner.GradleCompilerRunnerWithWorkers$GradleKotlinCompilerWorkAction
> Compilation error. See log for more details

  • ✅ 0.68 (has release libjsi.so)
  • ✅🟡 0.69 (has debug/release libjsi.so) (but for some reason it just shows a blank page instead of the normal one with all the info, and just the version in the bottom right corner)
  • ❌ 0.69 + new arch (uses ndkBuild, libjsi.so already linked)
    • fails on yarn android with error react-native-test-app/example/android/app/build/generated/rncli/src/main/jni/Android-rncli.mk: No such file or directory and make: *** No rule to make target '/Users/lsciandra/Developer/oss/react-native-test-app/example/android/app/build/generated/rncli/src/main/jni/Android-rncli.mk'. Stop.
  • ✅ 0.70 (has debug/release libjsi.so)
  • ✅ 0.70 + new arch (uses cmake, libjsi.so already linked)
@tido64
Tommy Nguyen (tido64)force-pushed
the
tido/android-qr-code-scanner
branch
from
370b72c to
5357a81CompareOctober 4, 2022 17:14
@tido64
Tommy Nguyen (tido64)
commented
Oct 4, 2022

Copy link


Copy Markdown

MemberAuthor
Lorenzo Sciandra (@kelset):
For 0.64, we need a fix that landed on trunk. I've rebased now so it should work.
For 0.69: I forgot to mention that you need RN-CLI 9.x because 8 does not yet have autolinking. I also had to remove react-native-safe-area-context because the latest version dropped support for 0.69 and below when on new arch. Otherwise, I cannot repro the white screen you're seeing.
Screenshot_1664903958Screenshot_1664906394
@kelset
Lorenzo Sciandra (kelset)
commented
Oct 6, 2022

Copy link


Copy Markdown

Contributor
yeah, with the adjustments I managed to make it work for both 0.64 and both versions of 0.69 🎉
LGTM, when you want to open for review I can ✅
@tido64
Tommy Nguyen (tido64)
marked this pull request as ready for review
October 6, 2022 15:47
kelset
Lorenzo Sciandra (kelset)
approved these changes
Oct 6, 2022
View reviewed changes
@kelsetLorenzo Sciandra (kelset)
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Base automatically changed from
tido/android-qr-code-scanner to
trunkOctober 6, 2022 16:21
@tido64
Tommy Nguyen (tido64)
enabled auto-merge (squash)
October 6, 2022 16:35
@tido64
Tommy Nguyen (tido64)
merged commit 6b653c8
into
trunkOct 6, 2022
@tido64
Tommy Nguyen (tido64)
deleted the

tido/android-app-registry

branch
October 6, 2022 16:54
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@arazabishovAraz Abishov (arazabishov)Awaiting requested review from arazabishov
@sweggersenSam Mathias Weggersen (sweggersen)Awaiting requested review from sweggersen

1 more reviewer

@kelsetLorenzo Sciandra (kelset)kelset approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

platform: AndroidThis affects Android

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Populate components list from AppRegistry if app.json is empty/missing


2 participants

@tido64@kelset

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
feat(android): populate home screen with AppRegistry entries by tido64 · Pull Request #1127 · microsoft/react-native-test-app · GitHub
Skip to content
feat(android): populate home screen with AppRegistry entries - #1127
Merged
Tommy Nguyen (tido64) merged 1 commit into
trunkfrom 
tido/android-app-registry
Oct 6, 2022
Merged
feat(android): populate home screen with AppRegistry entries#1127
Tommy Nguyen (tido64) merged 1 commit into
trunkfrom 
tido/android-app-registry
Conversation
@tido64
@tido64Tommy Nguyen (tido64)
commented
Sep 21, 2022•

edited

Loading

Copy link


Copy Markdown

Member
Description
Similar to #482, but for Android.
Resolves#189.
Platforms affected
  •  Android
  •  iOS
  •  macOS
  •  Windows
Test plan
See test plan in #482.
Flipper crashes on startup with this change. I'm not sure why, but downgrading it to 0.105 resolves the issue. The SIGILL comes from the device trying to load different .so files on startup, but the app should load fine. Bump to 0.164 to make it go away.
This needs to be tested on:
  •  0.64 (no libjsi.so, should show blank screen)
  •  0.68 (has release libjsi.so)
  •  0.69 (has debug/release libjsi.so)
  •  0.69 + new arch (uses ndkBuild, libjsi.so already linked)
  •  0.70 (has debug/release libjsi.so)
  •  0.70 + new arch (uses cmake, libjsi.so already linked)
Note that for new arch, you will need to force resolve rn-cli to 9.x for autolinking.
device-2022-09-21-145225
@github-actionsgithub-actionsBot
added
the 
platform: Android
This affects Android
label
Sep 21, 2022

This was referenced Sep 21, 2022
 Merged


Closed

@tido64
Tommy Nguyen (tido64)force-pushed
the
tido/android-app-registry
branch
6 times, most recently
from
4a6eb9f to
a22d262CompareSeptember 22, 2022 11:11
@tido64Tommy Nguyen (tido64)
mentioned this pull request
Sep 22, 2022

Open

@tido64
Tommy Nguyen (tido64)force-pushed
the
tido/android-app-registry
branch
5 times, most recently
from
a03e388 to
f5ebb75CompareSeptember 23, 2022 16:37
kelset
Lorenzo Sciandra (kelset)
reviewed
Oct 4, 2022
View reviewed changes
@kelsetLorenzo Sciandra (kelset)
left a comment
•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested:
  • ❌ 0.64 (no libjsi.so)
    • fails on yarn android with error react-native-test-app/example/node_modules/react-native-test-app/android/app/src/main/java/com/microsoft/reacttestapp/react/TestAppReactNativeHost.kt: (181, 24): Unresolved reference: loadLibrary and

       Execution failed for task ':app:compileDebugKotlin'.
> A failure occurred while executing org.jetbrains.kotlin.compilerRunner.GradleCompilerRunnerWithWorkers$GradleKotlinCompilerWorkAction
> Compilation error. See log for more details

  • ✅ 0.68 (has release libjsi.so)
  • ✅🟡 0.69 (has debug/release libjsi.so) (but for some reason it just shows a blank page instead of the normal one with all the info, and just the version in the bottom right corner)
  • ❌ 0.69 + new arch (uses ndkBuild, libjsi.so already linked)
    • fails on yarn android with error react-native-test-app/example/android/app/build/generated/rncli/src/main/jni/Android-rncli.mk: No such file or directory and make: *** No rule to make target '/Users/lsciandra/Developer/oss/react-native-test-app/example/android/app/build/generated/rncli/src/main/jni/Android-rncli.mk'. Stop.
  • ✅ 0.70 (has debug/release libjsi.so)
  • ✅ 0.70 + new arch (uses cmake, libjsi.so already linked)
@tido64
Tommy Nguyen (tido64)force-pushed
the
tido/android-qr-code-scanner
branch
from
370b72c to
5357a81CompareOctober 4, 2022 17:14
@tido64
Tommy Nguyen (tido64)
commented
Oct 4, 2022

Copy link


Copy Markdown

MemberAuthor
Lorenzo Sciandra (@kelset):
For 0.64, we need a fix that landed on trunk. I've rebased now so it should work.
For 0.69: I forgot to mention that you need RN-CLI 9.x because 8 does not yet have autolinking. I also had to remove react-native-safe-area-context because the latest version dropped support for 0.69 and below when on new arch. Otherwise, I cannot repro the white screen you're seeing.
Screenshot_1664903958Screenshot_1664906394
@kelset
Lorenzo Sciandra (kelset)
commented
Oct 6, 2022

Copy link


Copy Markdown

Contributor
yeah, with the adjustments I managed to make it work for both 0.64 and both versions of 0.69 🎉
LGTM, when you want to open for review I can ✅
@tido64
Tommy Nguyen (tido64)
marked this pull request as ready for review
October 6, 2022 15:47
kelset
Lorenzo Sciandra (kelset)
approved these changes
Oct 6, 2022
View reviewed changes
@kelsetLorenzo Sciandra (kelset)
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Base automatically changed from
tido/android-qr-code-scanner to
trunkOctober 6, 2022 16:21
@tido64
Tommy Nguyen (tido64)
enabled auto-merge (squash)
October 6, 2022 16:35
@tido64
Tommy Nguyen (tido64)
merged commit 6b653c8
into
trunkOct 6, 2022
@tido64
Tommy Nguyen (tido64)
deleted the

tido/android-app-registry

branch
October 6, 2022 16:54
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@arazabishovAraz Abishov (arazabishov)Awaiting requested review from arazabishov
@sweggersenSam Mathias Weggersen (sweggersen)Awaiting requested review from sweggersen

1 more reviewer

@kelsetLorenzo Sciandra (kelset)kelset approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

platform: AndroidThis affects Android

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Populate components list from AppRegistry if app.json is empty/missing


2 participants

@tido64@kelset