feat: populate home screen with AppRegistry entries by tido64 · Pull Request #482 · microsoft/react-native-test-app

Tommy Nguyen (tido64) · 2021-09-08T08:30:28Z

Description

When components is missing or empty in app.json, we attempt to populate the home screen with entries found in the AppRegistry.

Resolves#189.

Platforms affected

Android
iOS
macOS
Windows

Test plan

Run yarn in example folder
```
cd example
yarn
```

Remove components from app.json:

diff --git a/example/app.json b/example/app.json
index 8463354..0d50753 100644
--- a/example/app.json+++ b/example/app.json@@ -1,17 +1,6 @@
{
"name": "Example",
"displayName": "Example",
- "components": [- {- "appKey": "Example",- "displayName": "App"- },- {- "appKey": "Example",- "displayName": "App (modal)",- "presentationStyle": "modal"- }- ],
"resources": {
"android": [
"dist/res",

Build and run test app, e.g. for iOS:

pod install --project-directory=ios
yarn ios
# In a separate terminal:
yarn start

Remaining work

Since this solution relies on JSI, we cannot reuse it on Android without requiring the user to install NDK. React Native currently does not have this requirement, and we don't want to add extra dependencies. A solution would be to build and ship AARs like react-native does, but this will have to be a separate PR.

Andrew Coates (acoates-ms) · 2021-09-14T20:41:34Z

+ // loading. However, it seems that by posting a callback, we can
+ // defer fetching app keys until everything is done executing.
+ reactContext.JSDispatcher().Post([reactContext]() noexcept {
+ auto &runtime =


What happens if you get here when webdebugging?

This is a good call. The test app is broken due to an unrelated issue fixed in #493.
With the fix applied, what happens is that we return early with an empty array here:
react-native-test-app/common/AppRegistry.cpp
Lines 22 to 25 in 09fca86
auto global = runtime.global();
if (!global.hasProperty(runtime, kFbBatchedBridgeId)) {
return result;
}
I'm hesitant to implement a fallback for this, especially when web debugging might go away soon. Unless you have any suggestions, I'm going to leave this as is.

Araz Abishov (arazabishov) · 2021-09-17T07:55:59Z

Could we send the list of components over the bridge instead? (to include android)

Tommy Nguyen (tido64) · 2021-09-17T07:57:23Z

Could we send the list of components over the bridge instead? (to include android)

We could, but that requires changes to the JS. I'm not sure how we can achieve that without requiring users to add an extra import or similar.

Tom Underhill (tom-un) · 2021-09-27T09:53:56Z

 }

- let components = manifest.components
+ onComponentsRegistered(components, enable: false)


If there is a list of componetns in the manifest, wouldn't you want to call this with enable: true?

The property is for deciding whether the menu item should be enabled. Since the bridge hasn't been initialized yet, we should prevent them from being clicked. They get enabled when it is:
react-native-test-app/macos/ReactTestApp/AppDelegate.swift
Line 83 in fae8b9f
strongSelf.reactMenu.items.forEach{ $0.isEnabled =true}

github-actions · 2021-09-27T13:05:18Z

🎉 This PR is included in version 0.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Tommy Nguyen (tido64) · 2021-09-08T08:30:28Z

Description

When components is missing or empty in app.json, we attempt to populate the home screen with entries found in the AppRegistry.

Resolves#189.

Platforms affected

Android
iOS
macOS
Windows

Test plan

Run yarn in example folder
```
cd example
yarn
```

Remove components from app.json:

diff --git a/example/app.json b/example/app.json
index 8463354..0d50753 100644
--- a/example/app.json+++ b/example/app.json@@ -1,17 +1,6 @@
{
"name": "Example",
"displayName": "Example",
- "components": [- {- "appKey": "Example",- "displayName": "App"- },- {- "appKey": "Example",- "displayName": "App (modal)",- "presentationStyle": "modal"- }- ],
"resources": {
"android": [
"dist/res",

Build and run test app, e.g. for iOS:

pod install --project-directory=ios
yarn ios
# In a separate terminal:
yarn start

Remaining work

Since this solution relies on JSI, we cannot reuse it on Android without requiring the user to install NDK. React Native currently does not have this requirement, and we don't want to add extra dependencies. A solution would be to build and ship AARs like react-native does, but this will have to be a separate PR.

Andrew Coates (acoates-ms) · 2021-09-14T20:41:34Z

+ // loading. However, it seems that by posting a callback, we can
+ // defer fetching app keys until everything is done executing.
+ reactContext.JSDispatcher().Post([reactContext]() noexcept {
+ auto &runtime =


What happens if you get here when webdebugging?

This is a good call. The test app is broken due to an unrelated issue fixed in #493.
With the fix applied, what happens is that we return early with an empty array here:
react-native-test-app/common/AppRegistry.cpp
Lines 22 to 25 in 09fca86
auto global = runtime.global();
if (!global.hasProperty(runtime, kFbBatchedBridgeId)) {
return result;
}
I'm hesitant to implement a fallback for this, especially when web debugging might go away soon. Unless you have any suggestions, I'm going to leave this as is.

Araz Abishov (arazabishov) · 2021-09-17T07:55:59Z

Could we send the list of components over the bridge instead? (to include android)

Tommy Nguyen (tido64) · 2021-09-17T07:57:23Z

Could we send the list of components over the bridge instead? (to include android)

We could, but that requires changes to the JS. I'm not sure how we can achieve that without requiring users to add an extra import or similar.

Tom Underhill (tom-un) · 2021-09-27T09:53:56Z

 }

- let components = manifest.components
+ onComponentsRegistered(components, enable: false)


If there is a list of componetns in the manifest, wouldn't you want to call this with enable: true?

The property is for deciding whether the menu item should be enabled. Since the bridge hasn't been initialized yet, we should prevent them from being clicked. They get enabled when it is:
react-native-test-app/macos/ReactTestApp/AppDelegate.swift
Line 83 in fae8b9f
strongSelf.reactMenu.items.forEach{ $0.isEnabled =true}

github-actions · 2021-09-27T13:05:18Z

🎉 This PR is included in version 0.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Tommy Nguyen (tido64) · 2021-09-08T08:30:28Z

Description

When components is missing or empty in app.json, we attempt to populate the home screen with entries found in the AppRegistry.

Resolves#189.

Platforms affected

Android
iOS
macOS
Windows

Test plan

Run yarn in example folder
```
cd example
yarn
```

Remove components from app.json:

diff --git a/example/app.json b/example/app.json
index 8463354..0d50753 100644
--- a/example/app.json+++ b/example/app.json@@ -1,17 +1,6 @@
{
"name": "Example",
"displayName": "Example",
- "components": [- {- "appKey": "Example",- "displayName": "App"- },- {- "appKey": "Example",- "displayName": "App (modal)",- "presentationStyle": "modal"- }- ],
"resources": {
"android": [
"dist/res",

Build and run test app, e.g. for iOS:

pod install --project-directory=ios
yarn ios
# In a separate terminal:
yarn start

Remaining work

Since this solution relies on JSI, we cannot reuse it on Android without requiring the user to install NDK. React Native currently does not have this requirement, and we don't want to add extra dependencies. A solution would be to build and ship AARs like react-native does, but this will have to be a separate PR.

Andrew Coates (acoates-ms) · 2021-09-14T20:41:34Z

+ // loading. However, it seems that by posting a callback, we can
+ // defer fetching app keys until everything is done executing.
+ reactContext.JSDispatcher().Post([reactContext]() noexcept {
+ auto &runtime =


What happens if you get here when webdebugging?

This is a good call. The test app is broken due to an unrelated issue fixed in #493.
With the fix applied, what happens is that we return early with an empty array here:
react-native-test-app/common/AppRegistry.cpp
Lines 22 to 25 in 09fca86
auto global = runtime.global();
if (!global.hasProperty(runtime, kFbBatchedBridgeId)) {
return result;
}
I'm hesitant to implement a fallback for this, especially when web debugging might go away soon. Unless you have any suggestions, I'm going to leave this as is.

Araz Abishov (arazabishov) · 2021-09-17T07:55:59Z

Could we send the list of components over the bridge instead? (to include android)

Tommy Nguyen (tido64) · 2021-09-17T07:57:23Z

Could we send the list of components over the bridge instead? (to include android)

We could, but that requires changes to the JS. I'm not sure how we can achieve that without requiring users to add an extra import or similar.

Tom Underhill (tom-un) · 2021-09-27T09:53:56Z

 }

- let components = manifest.components
+ onComponentsRegistered(components, enable: false)


If there is a list of componetns in the manifest, wouldn't you want to call this with enable: true?

The property is for deciding whether the menu item should be enabled. Since the bridge hasn't been initialized yet, we should prevent them from being clicked. They get enabled when it is:
react-native-test-app/macos/ReactTestApp/AppDelegate.swift
Line 83 in fae8b9f
strongSelf.reactMenu.items.forEach{ $0.isEnabled =true}

github-actions · 2021-09-27T13:05:18Z

🎉 This PR is included in version 0.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Tommy Nguyen (tido64) · 2021-09-08T08:30:28Z

Description

When components is missing or empty in app.json, we attempt to populate the home screen with entries found in the AppRegistry.

Resolves#189.

Platforms affected

Android
iOS
macOS
Windows

Test plan

Run yarn in example folder
```
cd example
yarn
```

Remove components from app.json:

diff --git a/example/app.json b/example/app.json
index 8463354..0d50753 100644
--- a/example/app.json+++ b/example/app.json@@ -1,17 +1,6 @@
{
"name": "Example",
"displayName": "Example",
- "components": [- {- "appKey": "Example",- "displayName": "App"- },- {- "appKey": "Example",- "displayName": "App (modal)",- "presentationStyle": "modal"- }- ],
"resources": {
"android": [
"dist/res",

Build and run test app, e.g. for iOS:

pod install --project-directory=ios
yarn ios
# In a separate terminal:
yarn start

Remaining work

Since this solution relies on JSI, we cannot reuse it on Android without requiring the user to install NDK. React Native currently does not have this requirement, and we don't want to add extra dependencies. A solution would be to build and ship AARs like react-native does, but this will have to be a separate PR.

Andrew Coates (acoates-ms) · 2021-09-14T20:41:34Z

+ // loading. However, it seems that by posting a callback, we can
+ // defer fetching app keys until everything is done executing.
+ reactContext.JSDispatcher().Post([reactContext]() noexcept {
+ auto &runtime =


What happens if you get here when webdebugging?

This is a good call. The test app is broken due to an unrelated issue fixed in #493.
With the fix applied, what happens is that we return early with an empty array here:
react-native-test-app/common/AppRegistry.cpp
Lines 22 to 25 in 09fca86
auto global = runtime.global();
if (!global.hasProperty(runtime, kFbBatchedBridgeId)) {
return result;
}
I'm hesitant to implement a fallback for this, especially when web debugging might go away soon. Unless you have any suggestions, I'm going to leave this as is.

Araz Abishov (arazabishov) · 2021-09-17T07:55:59Z

Could we send the list of components over the bridge instead? (to include android)

Tommy Nguyen (tido64) · 2021-09-17T07:57:23Z

Could we send the list of components over the bridge instead? (to include android)

We could, but that requires changes to the JS. I'm not sure how we can achieve that without requiring users to add an extra import or similar.

Tom Underhill (tom-un) · 2021-09-27T09:53:56Z

 }

- let components = manifest.components
+ onComponentsRegistered(components, enable: false)


If there is a list of componetns in the manifest, wouldn't you want to call this with enable: true?

The property is for deciding whether the menu item should be enabled. Since the bridge hasn't been initialized yet, we should prevent them from being clicked. They get enabled when it is:
react-native-test-app/macos/ReactTestApp/AppDelegate.swift
Line 83 in fae8b9f
strongSelf.reactMenu.items.forEach{ $0.isEnabled =true}

github-actions · 2021-09-27T13:05:18Z

🎉 This PR is included in version 0.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Tommy Nguyen (tido64) · 2021-09-08T08:30:28Z

Description

When components is missing or empty in app.json, we attempt to populate the home screen with entries found in the AppRegistry.

Resolves#189.

Platforms affected

Android
iOS
macOS
Windows

Test plan

Run yarn in example folder
```
cd example
yarn
```

Remove components from app.json:

diff --git a/example/app.json b/example/app.json
index 8463354..0d50753 100644
--- a/example/app.json+++ b/example/app.json@@ -1,17 +1,6 @@
{
"name": "Example",
"displayName": "Example",
- "components": [- {- "appKey": "Example",- "displayName": "App"- },- {- "appKey": "Example",- "displayName": "App (modal)",- "presentationStyle": "modal"- }- ],
"resources": {
"android": [
"dist/res",

Build and run test app, e.g. for iOS:

pod install --project-directory=ios
yarn ios
# In a separate terminal:
yarn start

Remaining work

Since this solution relies on JSI, we cannot reuse it on Android without requiring the user to install NDK. React Native currently does not have this requirement, and we don't want to add extra dependencies. A solution would be to build and ship AARs like react-native does, but this will have to be a separate PR.

Andrew Coates (acoates-ms) · 2021-09-14T20:41:34Z

+ // loading. However, it seems that by posting a callback, we can
+ // defer fetching app keys until everything is done executing.
+ reactContext.JSDispatcher().Post([reactContext]() noexcept {
+ auto &runtime =


What happens if you get here when webdebugging?

This is a good call. The test app is broken due to an unrelated issue fixed in #493.
With the fix applied, what happens is that we return early with an empty array here:
react-native-test-app/common/AppRegistry.cpp
Lines 22 to 25 in 09fca86
auto global = runtime.global();
if (!global.hasProperty(runtime, kFbBatchedBridgeId)) {
return result;
}
I'm hesitant to implement a fallback for this, especially when web debugging might go away soon. Unless you have any suggestions, I'm going to leave this as is.

Araz Abishov (arazabishov) · 2021-09-17T07:55:59Z

Could we send the list of components over the bridge instead? (to include android)

Tommy Nguyen (tido64) · 2021-09-17T07:57:23Z

Could we send the list of components over the bridge instead? (to include android)

We could, but that requires changes to the JS. I'm not sure how we can achieve that without requiring users to add an extra import or similar.

Tom Underhill (tom-un) · 2021-09-27T09:53:56Z

 }

- let components = manifest.components
+ onComponentsRegistered(components, enable: false)


If there is a list of componetns in the manifest, wouldn't you want to call this with enable: true?

The property is for deciding whether the menu item should be enabled. Since the bridge hasn't been initialized yet, we should prevent them from being clicked. They get enabled when it is:
react-native-test-app/macos/ReactTestApp/AppDelegate.swift
Line 83 in fae8b9f
strongSelf.reactMenu.items.forEach{ $0.isEnabled =true}

github-actions · 2021-09-27T13:05:18Z

🎉 This PR is included in version 0.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Tommy Nguyen (tido64) · 2021-09-08T08:30:28Z

Description

When components is missing or empty in app.json, we attempt to populate the home screen with entries found in the AppRegistry.

Resolves#189.

Platforms affected

Android
iOS
macOS
Windows

Test plan

Run yarn in example folder
```
cd example
yarn
```

Remove components from app.json:

diff --git a/example/app.json b/example/app.json
index 8463354..0d50753 100644
--- a/example/app.json+++ b/example/app.json@@ -1,17 +1,6 @@
{
"name": "Example",
"displayName": "Example",
- "components": [- {- "appKey": "Example",- "displayName": "App"- },- {- "appKey": "Example",- "displayName": "App (modal)",- "presentationStyle": "modal"- }- ],
"resources": {
"android": [
"dist/res",

Build and run test app, e.g. for iOS:

pod install --project-directory=ios
yarn ios
# In a separate terminal:
yarn start

Remaining work

Since this solution relies on JSI, we cannot reuse it on Android without requiring the user to install NDK. React Native currently does not have this requirement, and we don't want to add extra dependencies. A solution would be to build and ship AARs like react-native does, but this will have to be a separate PR.

Andrew Coates (acoates-ms) · 2021-09-14T20:41:34Z

+ // loading. However, it seems that by posting a callback, we can
+ // defer fetching app keys until everything is done executing.
+ reactContext.JSDispatcher().Post([reactContext]() noexcept {
+ auto &runtime =


What happens if you get here when webdebugging?

This is a good call. The test app is broken due to an unrelated issue fixed in #493.
With the fix applied, what happens is that we return early with an empty array here:
react-native-test-app/common/AppRegistry.cpp
Lines 22 to 25 in 09fca86
auto global = runtime.global();
if (!global.hasProperty(runtime, kFbBatchedBridgeId)) {
return result;
}
I'm hesitant to implement a fallback for this, especially when web debugging might go away soon. Unless you have any suggestions, I'm going to leave this as is.

Araz Abishov (arazabishov) · 2021-09-17T07:55:59Z

Could we send the list of components over the bridge instead? (to include android)

Tommy Nguyen (tido64) · 2021-09-17T07:57:23Z

Could we send the list of components over the bridge instead? (to include android)

We could, but that requires changes to the JS. I'm not sure how we can achieve that without requiring users to add an extra import or similar.

Tom Underhill (tom-un) · 2021-09-27T09:53:56Z

 }

- let components = manifest.components
+ onComponentsRegistered(components, enable: false)


If there is a list of componetns in the manifest, wouldn't you want to call this with enable: true?

The property is for deciding whether the menu item should be enabled. Since the bridge hasn't been initialized yet, we should prevent them from being clicked. They get enabled when it is:
react-native-test-app/macos/ReactTestApp/AppDelegate.swift
Line 83 in fae8b9f
strongSelf.reactMenu.items.forEach{ $0.isEnabled =true}

github-actions · 2021-09-27T13:05:18Z

🎉 This PR is included in version 0.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Tommy Nguyen (tido64) · 2021-09-08T08:30:28Z

Description

When components is missing or empty in app.json, we attempt to populate the home screen with entries found in the AppRegistry.

Resolves#189.

Platforms affected

Android
iOS
macOS
Windows

Test plan

Run yarn in example folder
```
cd example
yarn
```

Remove components from app.json:

diff --git a/example/app.json b/example/app.json
index 8463354..0d50753 100644
--- a/example/app.json+++ b/example/app.json@@ -1,17 +1,6 @@
{
"name": "Example",
"displayName": "Example",
- "components": [- {- "appKey": "Example",- "displayName": "App"- },- {- "appKey": "Example",- "displayName": "App (modal)",- "presentationStyle": "modal"- }- ],
"resources": {
"android": [
"dist/res",

Build and run test app, e.g. for iOS:

pod install --project-directory=ios
yarn ios
# In a separate terminal:
yarn start

Remaining work

Since this solution relies on JSI, we cannot reuse it on Android without requiring the user to install NDK. React Native currently does not have this requirement, and we don't want to add extra dependencies. A solution would be to build and ship AARs like react-native does, but this will have to be a separate PR.

Andrew Coates (acoates-ms) · 2021-09-14T20:41:34Z

+ // loading. However, it seems that by posting a callback, we can
+ // defer fetching app keys until everything is done executing.
+ reactContext.JSDispatcher().Post([reactContext]() noexcept {
+ auto &runtime =


What happens if you get here when webdebugging?

This is a good call. The test app is broken due to an unrelated issue fixed in #493.
With the fix applied, what happens is that we return early with an empty array here:
react-native-test-app/common/AppRegistry.cpp
Lines 22 to 25 in 09fca86
auto global = runtime.global();
if (!global.hasProperty(runtime, kFbBatchedBridgeId)) {
return result;
}
I'm hesitant to implement a fallback for this, especially when web debugging might go away soon. Unless you have any suggestions, I'm going to leave this as is.

Araz Abishov (arazabishov) · 2021-09-17T07:55:59Z

Could we send the list of components over the bridge instead? (to include android)

Tommy Nguyen (tido64) · 2021-09-17T07:57:23Z

Could we send the list of components over the bridge instead? (to include android)

We could, but that requires changes to the JS. I'm not sure how we can achieve that without requiring users to add an extra import or similar.

Tom Underhill (tom-un) · 2021-09-27T09:53:56Z

 }

- let components = manifest.components
+ onComponentsRegistered(components, enable: false)


If there is a list of componetns in the manifest, wouldn't you want to call this with enable: true?

The property is for deciding whether the menu item should be enabled. Since the bridge hasn't been initialized yet, we should prevent them from being clicked. They get enabled when it is:
react-native-test-app/macos/ReactTestApp/AppDelegate.swift
Line 83 in fae8b9f
strongSelf.reactMenu.items.forEach{ $0.isEnabled =true}

github-actions · 2021-09-27T13:05:18Z

🎉 This PR is included in version 0.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Tommy Nguyen (tido64) · 2021-09-08T08:30:28Z

Description

When components is missing or empty in app.json, we attempt to populate the home screen with entries found in the AppRegistry.

Resolves#189.

Platforms affected

Android
iOS
macOS
Windows

Test plan

Run yarn in example folder
```
cd example
yarn
```

Remove components from app.json:

diff --git a/example/app.json b/example/app.json
index 8463354..0d50753 100644
--- a/example/app.json+++ b/example/app.json@@ -1,17 +1,6 @@
{
"name": "Example",
"displayName": "Example",
- "components": [- {- "appKey": "Example",- "displayName": "App"- },- {- "appKey": "Example",- "displayName": "App (modal)",- "presentationStyle": "modal"- }- ],
"resources": {
"android": [
"dist/res",

Build and run test app, e.g. for iOS:

pod install --project-directory=ios
yarn ios
# In a separate terminal:
yarn start

Remaining work

Since this solution relies on JSI, we cannot reuse it on Android without requiring the user to install NDK. React Native currently does not have this requirement, and we don't want to add extra dependencies. A solution would be to build and ship AARs like react-native does, but this will have to be a separate PR.

Andrew Coates (acoates-ms) · 2021-09-14T20:41:34Z

+ // loading. However, it seems that by posting a callback, we can
+ // defer fetching app keys until everything is done executing.
+ reactContext.JSDispatcher().Post([reactContext]() noexcept {
+ auto &runtime =


What happens if you get here when webdebugging?

This is a good call. The test app is broken due to an unrelated issue fixed in #493.
With the fix applied, what happens is that we return early with an empty array here:
react-native-test-app/common/AppRegistry.cpp
Lines 22 to 25 in 09fca86
auto global = runtime.global();
if (!global.hasProperty(runtime, kFbBatchedBridgeId)) {
return result;
}
I'm hesitant to implement a fallback for this, especially when web debugging might go away soon. Unless you have any suggestions, I'm going to leave this as is.

Araz Abishov (arazabishov) · 2021-09-17T07:55:59Z

Could we send the list of components over the bridge instead? (to include android)

Tommy Nguyen (tido64) · 2021-09-17T07:57:23Z

Could we send the list of components over the bridge instead? (to include android)

We could, but that requires changes to the JS. I'm not sure how we can achieve that without requiring users to add an extra import or similar.

Tom Underhill (tom-un) · 2021-09-27T09:53:56Z

 }

- let components = manifest.components
+ onComponentsRegistered(components, enable: false)


If there is a list of componetns in the manifest, wouldn't you want to call this with enable: true?

The property is for deciding whether the menu item should be enabled. Since the bridge hasn't been initialized yet, we should prevent them from being clicked. They get enabled when it is:
react-native-test-app/macos/ReactTestApp/AppDelegate.swift
Line 83 in fae8b9f
strongSelf.reactMenu.items.forEach{ $0.isEnabled =true}

github-actions · 2021-09-27T13:05:18Z

🎉 This PR is included in version 0.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actionsBot added platform: iOS This affects iOS platform: macOS This affects macOS platform: Windows This affects Windows labels Sep 8, 2021

Andrew Coates (acoates-ms) reviewed Sep 14, 2021
View reviewed changes

Comment threadwindows/ReactTestApp/ReactInstance.cpp Outdated

Andrew Coates (acoates-ms) reviewed Sep 14, 2021
View reviewed changes

Tommy Nguyen (tido64)force-pushed the tido/auto-populate branch from b8d52b6 to d00c982Compare September 15, 2021 18:58

Tommy Nguyen (tido64) mentioned this pull request Sep 16, 2021
Breaking changes in 1.0 #496
Merged
31 tasks

Tommy Nguyen (tido64) requested review from Araz Abishov (arazabishov), Lorenzo Sciandra (kelset), Sam Mathias Weggersen (sweggersen) and Tom Underhill (tom-un)September 16, 2021 10:18

Tommy Nguyen (tido64) marked this pull request as ready for review September 16, 2021 10:18

Tommy Nguyen (tido64) added 13 commits September 17, 2021 14:37

feat: populate home screen with AppRegistry entries
efeb8b7

i -> reverseIndex
67c57f6

fix ManifestTests.swift
1a6c760

add common/AppRegistry.*
4c11767

add common/AppRegistry.* to podspec
cbfc3fe

Windows implementation
ddbaea7

publish /common
ad57946

comment
57a4c68

more comments
e212114

align const placement
9f17681

comment #endif
6796844

use ReactInstanceSettings.InstanceLoaded
4c05bf1

unused capture
fae8b9f

Tommy Nguyen (tido64)force-pushed the tido/auto-populate branch from d00c982 to fae8b9fCompare September 17, 2021 12:42

Tommy Nguyen (tido64) added this to the 1.0 milestone Sep 22, 2021

Tom Underhill (tom-un) reviewed Sep 27, 2021
View reviewed changes

Tom Underhill (tom-un) approved these changes Sep 27, 2021
View reviewed changes

Tommy Nguyen (tido64) merged commit 5f0f9fd into trunkSep 27, 2021

Tommy Nguyen (tido64) deleted the tido/auto-populate branch September 27, 2021 12:42

Tommy Nguyen (tido64) mentioned this pull request Sep 27, 2021
Populate components list from AppRegistry if app.json is empty/missing #189
Closed
4 tasks

github-actionsBot added the released label Sep 27, 2021

Tommy Nguyen (tido64) mentioned this pull request Sep 21, 2022
feat(android): populate home screen with AppRegistry entries #1127
Merged
10 tasks