Skip to content

Fix live output with HotReload - #3983

Merged
Jakub Jareš (nohwnd) merged 2 commits into
rel/3.6from
fix-live-output-for-hotreload
Nov 4, 2024
Merged

Fix live output with HotReload#3983
Jakub Jareš (nohwnd) merged 2 commits into
rel/3.6from
fix-live-output-for-hotreload

Conversation

@nohwnd

@nohwndJakub Jareš (nohwnd) commented Oct 31, 2024

Copy link
Copy Markdown
Member

@Evangelink

Copy link
Copy Markdown
Member

I would have used the same display as for the regular live output with support for the same options but at least it's fixing the hot reload experience so that's good step forward.

@nohwnd

Copy link
Copy Markdown
MemberAuthor

This is using the same display as the normal logger with all the options it has. User can suppress the progress for example by calling with --no-progress. The special methods for hot reload call to the same api as normal run. We just need to NOT call the final completion because user would see Aborted message on ctrl_C and that looked ugly and unexpected.

@Evangelink

Copy link
Copy Markdown
Member

Jakub Jareš (@nohwnd) do we see the passed tests by default or is it just you have enabled the detailed output for the gif? I'd really want for the various modes to have the same view by default to provide consistent experience.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Branch is not ready for the next iteration, let's not merge now

@Evangelink

Copy link
Copy Markdown
Member

I think this is also fixing #3831

@microsoft-github-policy-servicemicrosoft-github-policy-serviceBot added needs/attention Needs maintainer attention. and removed needs/author-feedback Waiting on the original author. labels Nov 4, 2024
@nohwnd

Copy link
Copy Markdown
MemberAuthor

Yes the default output is to show passed tests in hotReload mode.

@microsoft-github-policy-servicemicrosoft-github-policy-serviceBot removed the needs/attention Needs maintainer attention. label Nov 4, 2024
@nohwnd

Copy link
Copy Markdown
MemberAuthor

I think this is also fixing #3831

Yes, true. Adding to auto-close.

@Evangelink

Copy link
Copy Markdown
Member

Can we make it to have consistent output in the various mode and don't show passed tests by default (like for a normal run)?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but would love to have the consistent experience.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but would love to have the consistent experience.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@nohwnd@Evangelink