Uh oh!
There was an error while loading. Please reload this page.
[link-checker] Fix broken documentation links - #9042
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes malformed GitHub pull request URLs in the documentation changelogs so that changelog entries link correctly to the referenced PRs.
Changes:
- Corrected
https://github.com/microsoft/testfx/pull//NNNN→.../pull/NNNNindocs/Changelog.md. - Corrected three
pull//NNNNlinks indocs/Changelog-Platform.md. - Verified there are no remaining
pull//occurrences indocs/*.md.
Show a summary per file
| File | Description |
|---|---|
| docs/Changelog.md | Fixes the PR #4013 link by removing the double slash in the URL. |
| docs/Changelog-Platform.md | Fixes PR links for #3983, #3992, and #3994 by removing the double slash in the URLs. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 0
Amaury Levé (Evangelink)
left a comment
There was a problem hiding this comment.
Note
🤖 Automated review by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.
Code Review Summary
Verdict: ✅ All clear — pure documentation correctness fix.
This PR fixes 4 malformed PR hyperlinks in changelog files, changing double-slash paths (/pull//NNNN) to correct single-slash paths (/pull/NNNN). All 4 corrected URLs resolve to valid PRs in the microsoft/testfx repository.
| # | Dimension | Verdict | Notes |
|---|---|---|---|
| 1 | Algorithmic Correctness | ✅ N/A | docs-only |
| 2 | Security | ✅ N/A | docs-only |
| 3 | Performance | ✅ N/A | docs-only |
| 4 | Error Handling | ✅ N/A | docs-only |
| 5 | Resource Management | ✅ N/A | docs-only |
| 6 | Concurrency | ✅ N/A | docs-only |
| 7 | Data Validation | ✅ N/A | docs-only |
| 8 | API Design | ✅ N/A | docs-only |
| 9 | Testability | ✅ N/A | docs-only |
| 10 | Maintainability | ✅ Clean | Broken links repaired; changelog integrity improved |
| 11 | Documentation Correctness | ✅ Clean | All 4 fixed URLs (/pull/3983, /pull/3992, /pull/3994, /pull/4013) are well-formed and point to valid PRs |
| 12 | Naming Conventions | ✅ N/A | docs-only |
| 13 | Code Duplication | ✅ N/A | docs-only |
| 14 | Dependencies | ✅ N/A | docs-only |
| 15 | Configuration | ✅ N/A | docs-only |
| 16 | Logging / Observability | ✅ N/A | docs-only |
| 17 | Backward Compatibility | ✅ N/A | docs-only |
| 18 | Internationalization | ✅ N/A | docs-only |
| 19 | Accessibility | ✅ N/A | docs-only |
| 20 | License / Legal | ✅ N/A | docs-only |
| 21 | Test Coverage | ✅ N/A | docs-only; no code changed |
| 22 | Fix Correctness | ✅ Clean | // → / is the correct single mechanical change needed; no surrounding context was altered |
No issues found. The change is minimal, targeted, and correct.
🤖 Automated content by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Expert Code Review (on PR ready) workflow. · 184.2 AIC · ⌖ 14.6 AIC · ◷
Uh oh!
There was an error while loading. Please reload this page.
Summary
Fixed 4 malformed pull request URLs in changelog files that had double slashes (
pull//NNNN) instead of correct single slash (pull/NNNN) format.Links Fixed
docs/Changelog-Platform.mdpull//3983pull/3983docs/Changelog-Platform.mdpull//3992pull/3992docs/Changelog-Platform.mdpull//3994pull/3994docs/Changelog.mdpull//4013pull/4013Known Unfixable Links (skipped)
The following links remain broken but are intentional or historical and cannot be fixed:
https://github.com/microsoft/testanywhere/compare/...— retired repo, historical changelog entriesgithub.com/microsoft/testfx/compare/entries for old tags (v1.x–v2.x) that no longer existAdd this agentic workflows to your repo
To install this agentic workflow, run