Uh oh!
There was an error while loading. Please reload this page.
Fix hangdump not showing tests in progress - #3992
Merged
Merged
Conversation
Jakub Jareš (nohwnd)
requested review from
Amaury Levé (Evangelink) and Marco Rossignoli (MarcoRossignoli)
as code ownersNovember 4, 2024 10:19
Amaury Levé (Evangelink)
left a comment
Member
There was a problem hiding this comment.
Could you please add some test? Acceptance is probably the easiest.
Uh oh!
There was an error while loading. Please reload this page.
Amaury Levé (Evangelink)
approved these changes
Nov 4, 2024
Amaury Levé (Evangelink)
commented
Nov 4, 2024
Member
Please forward port this. |
Jakub Jareš (nohwnd) added a commit
that referenced
this pull request
Nov 4, 2024
Jakub Jareš (nohwnd)
commented
Nov 4, 2024
MemberAuthor
Amaury Levé (Evangelink) pushed a commit
that referenced
this pull request
Nov 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes cases where method names are same in multiple classes (e.g. TestMethod1) and are not visible among the hanging tests.
The bug happens when Class1.TestMethod1 and Class2.TestMethod1 run in parallel, and one of them is not hanging. The first one to complete will remove the entry from tests in progress.
Using UID reduces the chance of this happening significantly, and will also correctly show that two tests with name TestMethod1 were running.