Skip to content

Fix xlf generation - #8490

Merged
Amaury Levé (Evangelink) merged 1 commit into
mainfrom
dev/amauryleve/xlf
May 22, 2026
Merged

Fix xlf generation#8490
Amaury Levé (Evangelink) merged 1 commit into
mainfrom
dev/amauryleve/xlf

Conversation

@Evangelink

@EvangelinkAmaury Levé (Evangelink) commented May 22, 2026

Copy link
Copy Markdown
Member

No description provided.

CopilotAI review requested due to automatic review settings May 22, 2026 10:57
@Evangelink
Amaury Levé (Evangelink) merged commit a4f9539 into mainMay 22, 2026
6 checks passed
@Evangelink
Amaury Levé (Evangelink) deleted the dev/amauryleve/xlf branch May 22, 2026 10:58
CopilotAI reviewed May 22, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the CrashDump extension’s localized XLF files to include a missing resource entry, aligning translations with CrashDumpResources.resx and unblocking consistent XLF generation.

Changes:

  • Added the MissingCrashDumpMainOption trans-unit to all CrashDumpResources *.xlf files.
  • Marked the new entry as untranslated (state="new") while retaining the English source text, consistent with existing repo XLF patterns.
Show a summary per file
FileDescription
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.zh-Hant.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.zh-Hans.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.tr.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.ru.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.pt-BR.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.pl.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.ko.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.ja.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.it.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.fr.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.es.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.de.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.cs.xlfAdds MissingCrashDumpMainOption trans-unit entry.

Copilot's findings

  • Files reviewed: 13/13 changed files
  • Comments generated: 0

Evangelink
Amaury Levé (Evangelink) commented May 22, 2026
View reviewed changes

@EvangelinkAmaury Levé (Evangelink) left a comment

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Summary

#DimensionVerdict
9Localization & Resources🔴 1 BLOCKING

✅ 20/21 dimensions clean.

BLOCKING Issue

  • Localization — Manual .xlf file edits violate build automation

Context:
This PR adds the MissingCrashDumpMainOption resource string to 13 localization files (.xlf files for cs, de, es, fr, it, ja, ko, pl, pt-BR, ru, tr, zh-Hans, zh-Hant). The resource string was correctly added to CrashDumpResources.resx (lines 144-146), which is the authoritative source.

Why this is blocking:
Per TestFx localization conventions (Knowledge Area #3 in the expert-reviewer instructions):

User-facing strings must be in .resx resource files. Never manually edit *.xlf files — build generates them.

Manually editing .xlf files causes:

  1. Build conflicts — the localization build auto-generates .xlf entries from .resx
  2. Workflow violations — translators expect state="new" entries to appear automatically via build
  3. Maintenance issues — manual edits can be overwritten or create merge conflicts

Correct workflow:

  1. ✅ Add the string to CrashDumpResources.resx (already done correctly)
  2. ❌ Manually add entries to all .xlf files (should NOT be done)
  3. ✅ Let the build system auto-generate the .xlf entries with state="new"

Recommendation:
Revert all 13 .xlf file changes. Keep only the CrashDumpResources.resx change. The build system will handle .xlf generation automatically.

If this PR represents what the build system actually generated (post-build artifact), then the title "Fix xlf generation" suggests a build system fix rather than manual edits — please clarify the intent.

Note: This PR was already merged (closed at 2026-05-22T10:58:03Z). This review serves as documentation for future reference and to prevent similar issues in follow-up PRs.

Generated by Expert Code Review (on open) for issue #8490 · ● 6M

Comment threadsrc/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.cs.xlf
</trans-unit>
<trans-unit id="MissingCrashDumpMainOption">
<source>You specified one or more crash dump parameters but did not enable crash dumps. Add --crashdump or --crash-report to the command line.</source>
<target state="new">You specified one or more crash dump parameters but did not enable crash dumps. Add --crashdump or --crash-report to the command line.</target>

@EvangelinkAmaury Levé (Evangelink)May 22, 2026

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[BLOCKING] Localization & Resources

The .xlf files should never be manually edited. According to TestFx's localization rules (documented in the expert-reviewer instructions and .github/copilot-instructions.md), the build system automatically generates .xlf files from the .resx source.

Scenario that triggers the issue:

  1. A developer adds a resource string to CrashDumpResources.resx (e.g., MissingCrashDumpMainOption)
  2. The developer manually edits all 13 .xlf files to add <target state="new"> entries
  3. The localization build runs and may overwrite or conflict with manual edits
  4. Translation workflow expects state="new" entries to be auto-generated, not manually created

Root cause:
This PR manually adds the MissingCrashDumpMainOption trans-unit to all 13 .xlf files with state="new" attributes. This is the wrong workflow.

Correct workflow:

  1. Add the resource string to CrashDumpResources.resx only (already done)
  2. Run the build — it will automatically generate the .xlf entries with state="new"
  3. The localization system will pick up state="new" entries for translation
  4. After translation, the build updates .xlf files with state="translated"

Recommendation:

  1. Revert all changes to the 13 .xlf files in this PR
  2. Keep only the change to CrashDumpResources.resx (lines 144-146)
  3. Run the build system to auto-generate the .xlf entries
  4. If the build already ran and generated these entries, this PR should include only the .resx change

Reference: See dimension #9 (Localization & Resources) in the expert-reviewer instructions.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Evangelink
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Fix xlf generation by Evangelink · Pull Request #8490 · microsoft/testfx · GitHub
Skip to content
Fix xlf generation - #8490
Merged
Amaury Levé (Evangelink) merged 1 commit into
mainfrom 
dev/amauryleve/xlf
May 22, 2026
Merged
Fix xlf generation#8490
Amaury Levé (Evangelink) merged 1 commit into
mainfrom 
dev/amauryleve/xlf
Conversation
@Evangelink
@EvangelinkAmaury Levé (Evangelink)
commented
May 22, 2026

Copy link


Copy Markdown

Member
 No description provided. 
CopilotAI
review requested due to automatic review settings
May 22, 2026 10:57
@Evangelink
Amaury Levé (Evangelink)
merged commit a4f9539
into
mainMay 22, 2026

6 checks passed

@Evangelink
Amaury Levé (Evangelink)
deleted the

dev/amauryleve/xlf

branch
May 22, 2026 10:58
CopilotAI
reviewed
May 22, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Updates the CrashDump extension’s localized XLF files to include a missing resource entry, aligning translations with CrashDumpResources.resx and unblocking consistent XLF generation.
Changes:
  • Added the MissingCrashDumpMainOption trans-unit to all CrashDumpResources *.xlf files.
  • Marked the new entry as untranslated (state="new") while retaining the English source text, consistent with existing repo XLF patterns.
Show a summary per file
FileDescription
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.zh-Hant.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.zh-Hans.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.tr.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.ru.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.pt-BR.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.pl.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.ko.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.ja.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.it.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.fr.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.es.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.de.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.cs.xlfAdds MissingCrashDumpMainOption trans-unit entry.
Copilot's findings
  • Files reviewed: 13/13 changed files
  • Comments generated: 0
Evangelink
Amaury Levé (Evangelink)
commented
May 22, 2026
View reviewed changes
@EvangelinkAmaury Levé (Evangelink)
left a comment


Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Summary
#DimensionVerdict
9Localization & Resources🔴 1 BLOCKING
✅ 20/21 dimensions clean.
BLOCKING Issue
  • Localization — Manual .xlf file edits violate build automation
Context:

This PR adds the MissingCrashDumpMainOption resource string to 13 localization files (.xlf files for cs, de, es, fr, it, ja, ko, pl, pt-BR, ru, tr, zh-Hans, zh-Hant). The resource string was correctly added to CrashDumpResources.resx (lines 144-146), which is the authoritative source.
Why this is blocking:

Per TestFx localization conventions (Knowledge Area #3 in the expert-reviewer instructions):
User-facing strings must be in .resx resource files. Never manually edit *.xlf files — build generates them.
Manually editing .xlf files causes:
  1. Build conflicts — the localization build auto-generates .xlf entries from .resx
  2. Workflow violations — translators expect state="new" entries to appear automatically via build
  3. Maintenance issues — manual edits can be overwritten or create merge conflicts
Correct workflow:
  1. ✅ Add the string to CrashDumpResources.resx (already done correctly)
  2. ❌ Manually add entries to all .xlf files (should NOT be done)
  3. ✅ Let the build system auto-generate the .xlf entries with state="new"
Recommendation:

Revert all 13 .xlf file changes. Keep only the CrashDumpResources.resx change. The build system will handle .xlf generation automatically.
If this PR represents what the build system actually generated (post-build artifact), then the title "Fix xlf generation" suggests a build system fix rather than manual edits — please clarify the intent.
Note: This PR was already merged (closed at 2026-05-22T10:58:03Z). This review serves as documentation for future reference and to prevent similar issues in follow-up PRs.
Generated by Expert Code Review (on open) for issue #8490 · ● 6M
Comment threadsrc/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.cs.xlf
 </trans-unit>
 <trans-unit id="MissingCrashDumpMainOption">
 <source>You specified one or more crash dump parameters but did not enable crash dumps. Add --crashdump or --crash-report to the command line.</source>
 <target state="new">You specified one or more crash dump parameters but did not enable crash dumps. Add --crashdump or --crash-report to the command line.</target>
@EvangelinkAmaury Levé (Evangelink)May 22, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[BLOCKING] Localization & Resources
The .xlf files should never be manually edited. According to TestFx's localization rules (documented in the expert-reviewer instructions and .github/copilot-instructions.md), the build system automatically generates .xlf files from the .resx source.
Scenario that triggers the issue:
  1. A developer adds a resource string to CrashDumpResources.resx (e.g., MissingCrashDumpMainOption)
  2. The developer manually edits all 13 .xlf files to add <target state="new"> entries
  3. The localization build runs and may overwrite or conflict with manual edits
  4. Translation workflow expects state="new" entries to be auto-generated, not manually created
Root cause:

This PR manually adds the MissingCrashDumpMainOption trans-unit to all 13 .xlf files with state="new" attributes. This is the wrong workflow.
Correct workflow:
  1. Add the resource string to CrashDumpResources.resx only (already done)
  2. Run the build — it will automatically generate the .xlf entries with state="new"
  3. The localization system will pick up state="new" entries for translation
  4. After translation, the build updates .xlf files with state="translated"
Recommendation:
  1. Revert all changes to the 13 .xlf files in this PR
  2. Keep only the change to CrashDumpResources.resx (lines 144-146)
  3. Run the build system to auto-generate the .xlf entries
  4. If the build already ran and generated these entries, this PR should include only the .resx change
Reference: See dimension #9 (Localization & Resources) in the expert-reviewer instructions.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@Evangelink

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Fix xlf generation by Evangelink · Pull Request #8490 · microsoft/testfx · GitHub
Skip to content
Fix xlf generation - #8490
Merged
Amaury Levé (Evangelink) merged 1 commit into
mainfrom 
dev/amauryleve/xlf
May 22, 2026
Merged
Fix xlf generation#8490
Amaury Levé (Evangelink) merged 1 commit into
mainfrom 
dev/amauryleve/xlf
Conversation
@Evangelink
@EvangelinkAmaury Levé (Evangelink)
commented
May 22, 2026

Copy link


Copy Markdown

Member
 No description provided. 
CopilotAI
review requested due to automatic review settings
May 22, 2026 10:57
@Evangelink
Amaury Levé (Evangelink)
merged commit a4f9539
into
mainMay 22, 2026

6 checks passed

@Evangelink
Amaury Levé (Evangelink)
deleted the

dev/amauryleve/xlf

branch
May 22, 2026 10:58
CopilotAI
reviewed
May 22, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Updates the CrashDump extension’s localized XLF files to include a missing resource entry, aligning translations with CrashDumpResources.resx and unblocking consistent XLF generation.
Changes:
  • Added the MissingCrashDumpMainOption trans-unit to all CrashDumpResources *.xlf files.
  • Marked the new entry as untranslated (state="new") while retaining the English source text, consistent with existing repo XLF patterns.
Show a summary per file
FileDescription
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.zh-Hant.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.zh-Hans.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.tr.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.ru.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.pt-BR.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.pl.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.ko.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.ja.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.it.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.fr.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.es.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.de.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.cs.xlfAdds MissingCrashDumpMainOption trans-unit entry.
Copilot's findings
  • Files reviewed: 13/13 changed files
  • Comments generated: 0
Evangelink
Amaury Levé (Evangelink)
commented
May 22, 2026
View reviewed changes
@EvangelinkAmaury Levé (Evangelink)
left a comment


Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Summary
#DimensionVerdict
9Localization & Resources🔴 1 BLOCKING
✅ 20/21 dimensions clean.
BLOCKING Issue
  • Localization — Manual .xlf file edits violate build automation
Context:

This PR adds the MissingCrashDumpMainOption resource string to 13 localization files (.xlf files for cs, de, es, fr, it, ja, ko, pl, pt-BR, ru, tr, zh-Hans, zh-Hant). The resource string was correctly added to CrashDumpResources.resx (lines 144-146), which is the authoritative source.
Why this is blocking:

Per TestFx localization conventions (Knowledge Area #3 in the expert-reviewer instructions):
User-facing strings must be in .resx resource files. Never manually edit *.xlf files — build generates them.
Manually editing .xlf files causes:
  1. Build conflicts — the localization build auto-generates .xlf entries from .resx
  2. Workflow violations — translators expect state="new" entries to appear automatically via build
  3. Maintenance issues — manual edits can be overwritten or create merge conflicts
Correct workflow:
  1. ✅ Add the string to CrashDumpResources.resx (already done correctly)
  2. ❌ Manually add entries to all .xlf files (should NOT be done)
  3. ✅ Let the build system auto-generate the .xlf entries with state="new"
Recommendation:

Revert all 13 .xlf file changes. Keep only the CrashDumpResources.resx change. The build system will handle .xlf generation automatically.
If this PR represents what the build system actually generated (post-build artifact), then the title "Fix xlf generation" suggests a build system fix rather than manual edits — please clarify the intent.
Note: This PR was already merged (closed at 2026-05-22T10:58:03Z). This review serves as documentation for future reference and to prevent similar issues in follow-up PRs.
Generated by Expert Code Review (on open) for issue #8490 · ● 6M
Comment threadsrc/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.cs.xlf
 </trans-unit>
 <trans-unit id="MissingCrashDumpMainOption">
 <source>You specified one or more crash dump parameters but did not enable crash dumps. Add --crashdump or --crash-report to the command line.</source>
 <target state="new">You specified one or more crash dump parameters but did not enable crash dumps. Add --crashdump or --crash-report to the command line.</target>
@EvangelinkAmaury Levé (Evangelink)May 22, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[BLOCKING] Localization & Resources
The .xlf files should never be manually edited. According to TestFx's localization rules (documented in the expert-reviewer instructions and .github/copilot-instructions.md), the build system automatically generates .xlf files from the .resx source.
Scenario that triggers the issue:
  1. A developer adds a resource string to CrashDumpResources.resx (e.g., MissingCrashDumpMainOption)
  2. The developer manually edits all 13 .xlf files to add <target state="new"> entries
  3. The localization build runs and may overwrite or conflict with manual edits
  4. Translation workflow expects state="new" entries to be auto-generated, not manually created
Root cause:

This PR manually adds the MissingCrashDumpMainOption trans-unit to all 13 .xlf files with state="new" attributes. This is the wrong workflow.
Correct workflow:
  1. Add the resource string to CrashDumpResources.resx only (already done)
  2. Run the build — it will automatically generate the .xlf entries with state="new"
  3. The localization system will pick up state="new" entries for translation
  4. After translation, the build updates .xlf files with state="translated"
Recommendation:
  1. Revert all changes to the 13 .xlf files in this PR
  2. Keep only the change to CrashDumpResources.resx (lines 144-146)
  3. Run the build system to auto-generate the .xlf entries
  4. If the build already ran and generated these entries, this PR should include only the .resx change
Reference: See dimension #9 (Localization & Resources) in the expert-reviewer instructions.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@Evangelink

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Fix xlf generation by Evangelink · Pull Request #8490 · microsoft/testfx · GitHub
Skip to content
Fix xlf generation - #8490
Merged
Amaury Levé (Evangelink) merged 1 commit into
mainfrom 
dev/amauryleve/xlf
May 22, 2026
Merged
Fix xlf generation#8490
Amaury Levé (Evangelink) merged 1 commit into
mainfrom 
dev/amauryleve/xlf
Conversation
@Evangelink
@EvangelinkAmaury Levé (Evangelink)
commented
May 22, 2026

Copy link


Copy Markdown

Member
 No description provided. 
CopilotAI
review requested due to automatic review settings
May 22, 2026 10:57
@Evangelink
Amaury Levé (Evangelink)
merged commit a4f9539
into
mainMay 22, 2026

6 checks passed

@Evangelink
Amaury Levé (Evangelink)
deleted the

dev/amauryleve/xlf

branch
May 22, 2026 10:58
CopilotAI
reviewed
May 22, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Updates the CrashDump extension’s localized XLF files to include a missing resource entry, aligning translations with CrashDumpResources.resx and unblocking consistent XLF generation.
Changes:
  • Added the MissingCrashDumpMainOption trans-unit to all CrashDumpResources *.xlf files.
  • Marked the new entry as untranslated (state="new") while retaining the English source text, consistent with existing repo XLF patterns.
Show a summary per file
FileDescription
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.zh-Hant.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.zh-Hans.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.tr.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.ru.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.pt-BR.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.pl.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.ko.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.ja.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.it.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.fr.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.es.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.de.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.cs.xlfAdds MissingCrashDumpMainOption trans-unit entry.
Copilot's findings
  • Files reviewed: 13/13 changed files
  • Comments generated: 0
Evangelink
Amaury Levé (Evangelink)
commented
May 22, 2026
View reviewed changes
@EvangelinkAmaury Levé (Evangelink)
left a comment


Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Summary
#DimensionVerdict
9Localization & Resources🔴 1 BLOCKING
✅ 20/21 dimensions clean.
BLOCKING Issue
  • Localization — Manual .xlf file edits violate build automation
Context:

This PR adds the MissingCrashDumpMainOption resource string to 13 localization files (.xlf files for cs, de, es, fr, it, ja, ko, pl, pt-BR, ru, tr, zh-Hans, zh-Hant). The resource string was correctly added to CrashDumpResources.resx (lines 144-146), which is the authoritative source.
Why this is blocking:

Per TestFx localization conventions (Knowledge Area #3 in the expert-reviewer instructions):
User-facing strings must be in .resx resource files. Never manually edit *.xlf files — build generates them.
Manually editing .xlf files causes:
  1. Build conflicts — the localization build auto-generates .xlf entries from .resx
  2. Workflow violations — translators expect state="new" entries to appear automatically via build
  3. Maintenance issues — manual edits can be overwritten or create merge conflicts
Correct workflow:
  1. ✅ Add the string to CrashDumpResources.resx (already done correctly)
  2. ❌ Manually add entries to all .xlf files (should NOT be done)
  3. ✅ Let the build system auto-generate the .xlf entries with state="new"
Recommendation:

Revert all 13 .xlf file changes. Keep only the CrashDumpResources.resx change. The build system will handle .xlf generation automatically.
If this PR represents what the build system actually generated (post-build artifact), then the title "Fix xlf generation" suggests a build system fix rather than manual edits — please clarify the intent.
Note: This PR was already merged (closed at 2026-05-22T10:58:03Z). This review serves as documentation for future reference and to prevent similar issues in follow-up PRs.
Generated by Expert Code Review (on open) for issue #8490 · ● 6M
Comment threadsrc/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.cs.xlf
 </trans-unit>
 <trans-unit id="MissingCrashDumpMainOption">
 <source>You specified one or more crash dump parameters but did not enable crash dumps. Add --crashdump or --crash-report to the command line.</source>
 <target state="new">You specified one or more crash dump parameters but did not enable crash dumps. Add --crashdump or --crash-report to the command line.</target>
@EvangelinkAmaury Levé (Evangelink)May 22, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[BLOCKING] Localization & Resources
The .xlf files should never be manually edited. According to TestFx's localization rules (documented in the expert-reviewer instructions and .github/copilot-instructions.md), the build system automatically generates .xlf files from the .resx source.
Scenario that triggers the issue:
  1. A developer adds a resource string to CrashDumpResources.resx (e.g., MissingCrashDumpMainOption)
  2. The developer manually edits all 13 .xlf files to add <target state="new"> entries
  3. The localization build runs and may overwrite or conflict with manual edits
  4. Translation workflow expects state="new" entries to be auto-generated, not manually created
Root cause:

This PR manually adds the MissingCrashDumpMainOption trans-unit to all 13 .xlf files with state="new" attributes. This is the wrong workflow.
Correct workflow:
  1. Add the resource string to CrashDumpResources.resx only (already done)
  2. Run the build — it will automatically generate the .xlf entries with state="new"
  3. The localization system will pick up state="new" entries for translation
  4. After translation, the build updates .xlf files with state="translated"
Recommendation:
  1. Revert all changes to the 13 .xlf files in this PR
  2. Keep only the change to CrashDumpResources.resx (lines 144-146)
  3. Run the build system to auto-generate the .xlf entries
  4. If the build already ran and generated these entries, this PR should include only the .resx change
Reference: See dimension #9 (Localization & Resources) in the expert-reviewer instructions.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@Evangelink

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Fix xlf generation by Evangelink · Pull Request #8490 · microsoft/testfx · GitHub
Skip to content
Fix xlf generation - #8490
Merged
Amaury Levé (Evangelink) merged 1 commit into
mainfrom 
dev/amauryleve/xlf
May 22, 2026
Merged
Fix xlf generation#8490
Amaury Levé (Evangelink) merged 1 commit into
mainfrom 
dev/amauryleve/xlf
Conversation
@Evangelink
@EvangelinkAmaury Levé (Evangelink)
commented
May 22, 2026

Copy link


Copy Markdown

Member
 No description provided. 
CopilotAI
review requested due to automatic review settings
May 22, 2026 10:57
@Evangelink
Amaury Levé (Evangelink)
merged commit a4f9539
into
mainMay 22, 2026

6 checks passed

@Evangelink
Amaury Levé (Evangelink)
deleted the

dev/amauryleve/xlf

branch
May 22, 2026 10:58
CopilotAI
reviewed
May 22, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Updates the CrashDump extension’s localized XLF files to include a missing resource entry, aligning translations with CrashDumpResources.resx and unblocking consistent XLF generation.
Changes:
  • Added the MissingCrashDumpMainOption trans-unit to all CrashDumpResources *.xlf files.
  • Marked the new entry as untranslated (state="new") while retaining the English source text, consistent with existing repo XLF patterns.
Show a summary per file
FileDescription
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.zh-Hant.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.zh-Hans.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.tr.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.ru.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.pt-BR.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.pl.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.ko.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.ja.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.it.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.fr.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.es.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.de.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.cs.xlfAdds MissingCrashDumpMainOption trans-unit entry.
Copilot's findings
  • Files reviewed: 13/13 changed files
  • Comments generated: 0
Evangelink
Amaury Levé (Evangelink)
commented
May 22, 2026
View reviewed changes
@EvangelinkAmaury Levé (Evangelink)
left a comment


Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Summary
#DimensionVerdict
9Localization & Resources🔴 1 BLOCKING
✅ 20/21 dimensions clean.
BLOCKING Issue
  • Localization — Manual .xlf file edits violate build automation
Context:

This PR adds the MissingCrashDumpMainOption resource string to 13 localization files (.xlf files for cs, de, es, fr, it, ja, ko, pl, pt-BR, ru, tr, zh-Hans, zh-Hant). The resource string was correctly added to CrashDumpResources.resx (lines 144-146), which is the authoritative source.
Why this is blocking:

Per TestFx localization conventions (Knowledge Area #3 in the expert-reviewer instructions):
User-facing strings must be in .resx resource files. Never manually edit *.xlf files — build generates them.
Manually editing .xlf files causes:
  1. Build conflicts — the localization build auto-generates .xlf entries from .resx
  2. Workflow violations — translators expect state="new" entries to appear automatically via build
  3. Maintenance issues — manual edits can be overwritten or create merge conflicts
Correct workflow:
  1. ✅ Add the string to CrashDumpResources.resx (already done correctly)
  2. ❌ Manually add entries to all .xlf files (should NOT be done)
  3. ✅ Let the build system auto-generate the .xlf entries with state="new"
Recommendation:

Revert all 13 .xlf file changes. Keep only the CrashDumpResources.resx change. The build system will handle .xlf generation automatically.
If this PR represents what the build system actually generated (post-build artifact), then the title "Fix xlf generation" suggests a build system fix rather than manual edits — please clarify the intent.
Note: This PR was already merged (closed at 2026-05-22T10:58:03Z). This review serves as documentation for future reference and to prevent similar issues in follow-up PRs.
Generated by Expert Code Review (on open) for issue #8490 · ● 6M
Comment threadsrc/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.cs.xlf
 </trans-unit>
 <trans-unit id="MissingCrashDumpMainOption">
 <source>You specified one or more crash dump parameters but did not enable crash dumps. Add --crashdump or --crash-report to the command line.</source>
 <target state="new">You specified one or more crash dump parameters but did not enable crash dumps. Add --crashdump or --crash-report to the command line.</target>
@EvangelinkAmaury Levé (Evangelink)May 22, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[BLOCKING] Localization & Resources
The .xlf files should never be manually edited. According to TestFx's localization rules (documented in the expert-reviewer instructions and .github/copilot-instructions.md), the build system automatically generates .xlf files from the .resx source.
Scenario that triggers the issue:
  1. A developer adds a resource string to CrashDumpResources.resx (e.g., MissingCrashDumpMainOption)
  2. The developer manually edits all 13 .xlf files to add <target state="new"> entries
  3. The localization build runs and may overwrite or conflict with manual edits
  4. Translation workflow expects state="new" entries to be auto-generated, not manually created
Root cause:

This PR manually adds the MissingCrashDumpMainOption trans-unit to all 13 .xlf files with state="new" attributes. This is the wrong workflow.
Correct workflow:
  1. Add the resource string to CrashDumpResources.resx only (already done)
  2. Run the build — it will automatically generate the .xlf entries with state="new"
  3. The localization system will pick up state="new" entries for translation
  4. After translation, the build updates .xlf files with state="translated"
Recommendation:
  1. Revert all changes to the 13 .xlf files in this PR
  2. Keep only the change to CrashDumpResources.resx (lines 144-146)
  3. Run the build system to auto-generate the .xlf entries
  4. If the build already ran and generated these entries, this PR should include only the .resx change
Reference: See dimension #9 (Localization & Resources) in the expert-reviewer instructions.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@Evangelink

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Fix xlf generation by Evangelink · Pull Request #8490 · microsoft/testfx · GitHub
Skip to content
Fix xlf generation - #8490
Merged
Amaury Levé (Evangelink) merged 1 commit into
mainfrom 
dev/amauryleve/xlf
May 22, 2026
Merged
Fix xlf generation#8490
Amaury Levé (Evangelink) merged 1 commit into
mainfrom 
dev/amauryleve/xlf
Conversation
@Evangelink
@EvangelinkAmaury Levé (Evangelink)
commented
May 22, 2026

Copy link


Copy Markdown

Member
 No description provided. 
CopilotAI
review requested due to automatic review settings
May 22, 2026 10:57
@Evangelink
Amaury Levé (Evangelink)
merged commit a4f9539
into
mainMay 22, 2026

6 checks passed

@Evangelink
Amaury Levé (Evangelink)
deleted the

dev/amauryleve/xlf

branch
May 22, 2026 10:58
CopilotAI
reviewed
May 22, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Updates the CrashDump extension’s localized XLF files to include a missing resource entry, aligning translations with CrashDumpResources.resx and unblocking consistent XLF generation.
Changes:
  • Added the MissingCrashDumpMainOption trans-unit to all CrashDumpResources *.xlf files.
  • Marked the new entry as untranslated (state="new") while retaining the English source text, consistent with existing repo XLF patterns.
Show a summary per file
FileDescription
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.zh-Hant.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.zh-Hans.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.tr.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.ru.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.pt-BR.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.pl.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.ko.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.ja.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.it.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.fr.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.es.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.de.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.cs.xlfAdds MissingCrashDumpMainOption trans-unit entry.
Copilot's findings
  • Files reviewed: 13/13 changed files
  • Comments generated: 0
Evangelink
Amaury Levé (Evangelink)
commented
May 22, 2026
View reviewed changes
@EvangelinkAmaury Levé (Evangelink)
left a comment


Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Summary
#DimensionVerdict
9Localization & Resources🔴 1 BLOCKING
✅ 20/21 dimensions clean.
BLOCKING Issue
  • Localization — Manual .xlf file edits violate build automation
Context:

This PR adds the MissingCrashDumpMainOption resource string to 13 localization files (.xlf files for cs, de, es, fr, it, ja, ko, pl, pt-BR, ru, tr, zh-Hans, zh-Hant). The resource string was correctly added to CrashDumpResources.resx (lines 144-146), which is the authoritative source.
Why this is blocking:

Per TestFx localization conventions (Knowledge Area #3 in the expert-reviewer instructions):
User-facing strings must be in .resx resource files. Never manually edit *.xlf files — build generates them.
Manually editing .xlf files causes:
  1. Build conflicts — the localization build auto-generates .xlf entries from .resx
  2. Workflow violations — translators expect state="new" entries to appear automatically via build
  3. Maintenance issues — manual edits can be overwritten or create merge conflicts
Correct workflow:
  1. ✅ Add the string to CrashDumpResources.resx (already done correctly)
  2. ❌ Manually add entries to all .xlf files (should NOT be done)
  3. ✅ Let the build system auto-generate the .xlf entries with state="new"
Recommendation:

Revert all 13 .xlf file changes. Keep only the CrashDumpResources.resx change. The build system will handle .xlf generation automatically.
If this PR represents what the build system actually generated (post-build artifact), then the title "Fix xlf generation" suggests a build system fix rather than manual edits — please clarify the intent.
Note: This PR was already merged (closed at 2026-05-22T10:58:03Z). This review serves as documentation for future reference and to prevent similar issues in follow-up PRs.
Generated by Expert Code Review (on open) for issue #8490 · ● 6M
Comment threadsrc/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.cs.xlf
 </trans-unit>
 <trans-unit id="MissingCrashDumpMainOption">
 <source>You specified one or more crash dump parameters but did not enable crash dumps. Add --crashdump or --crash-report to the command line.</source>
 <target state="new">You specified one or more crash dump parameters but did not enable crash dumps. Add --crashdump or --crash-report to the command line.</target>
@EvangelinkAmaury Levé (Evangelink)May 22, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[BLOCKING] Localization & Resources
The .xlf files should never be manually edited. According to TestFx's localization rules (documented in the expert-reviewer instructions and .github/copilot-instructions.md), the build system automatically generates .xlf files from the .resx source.
Scenario that triggers the issue:
  1. A developer adds a resource string to CrashDumpResources.resx (e.g., MissingCrashDumpMainOption)
  2. The developer manually edits all 13 .xlf files to add <target state="new"> entries
  3. The localization build runs and may overwrite or conflict with manual edits
  4. Translation workflow expects state="new" entries to be auto-generated, not manually created
Root cause:

This PR manually adds the MissingCrashDumpMainOption trans-unit to all 13 .xlf files with state="new" attributes. This is the wrong workflow.
Correct workflow:
  1. Add the resource string to CrashDumpResources.resx only (already done)
  2. Run the build — it will automatically generate the .xlf entries with state="new"
  3. The localization system will pick up state="new" entries for translation
  4. After translation, the build updates .xlf files with state="translated"
Recommendation:
  1. Revert all changes to the 13 .xlf files in this PR
  2. Keep only the change to CrashDumpResources.resx (lines 144-146)
  3. Run the build system to auto-generate the .xlf entries
  4. If the build already ran and generated these entries, this PR should include only the .resx change
Reference: See dimension #9 (Localization & Resources) in the expert-reviewer instructions.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@Evangelink

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Fix xlf generation by Evangelink · Pull Request #8490 · microsoft/testfx · GitHub
Skip to content
Fix xlf generation - #8490
Merged
Amaury Levé (Evangelink) merged 1 commit into
mainfrom 
dev/amauryleve/xlf
May 22, 2026
Merged
Fix xlf generation#8490
Amaury Levé (Evangelink) merged 1 commit into
mainfrom 
dev/amauryleve/xlf
Conversation
@Evangelink
@EvangelinkAmaury Levé (Evangelink)
commented
May 22, 2026

Copy link


Copy Markdown

Member
 No description provided. 
CopilotAI
review requested due to automatic review settings
May 22, 2026 10:57
@Evangelink
Amaury Levé (Evangelink)
merged commit a4f9539
into
mainMay 22, 2026

6 checks passed

@Evangelink
Amaury Levé (Evangelink)
deleted the

dev/amauryleve/xlf

branch
May 22, 2026 10:58
CopilotAI
reviewed
May 22, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Updates the CrashDump extension’s localized XLF files to include a missing resource entry, aligning translations with CrashDumpResources.resx and unblocking consistent XLF generation.
Changes:
  • Added the MissingCrashDumpMainOption trans-unit to all CrashDumpResources *.xlf files.
  • Marked the new entry as untranslated (state="new") while retaining the English source text, consistent with existing repo XLF patterns.
Show a summary per file
FileDescription
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.zh-Hant.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.zh-Hans.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.tr.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.ru.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.pt-BR.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.pl.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.ko.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.ja.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.it.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.fr.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.es.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.de.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.cs.xlfAdds MissingCrashDumpMainOption trans-unit entry.
Copilot's findings
  • Files reviewed: 13/13 changed files
  • Comments generated: 0
Evangelink
Amaury Levé (Evangelink)
commented
May 22, 2026
View reviewed changes
@EvangelinkAmaury Levé (Evangelink)
left a comment


Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Summary
#DimensionVerdict
9Localization & Resources🔴 1 BLOCKING
✅ 20/21 dimensions clean.
BLOCKING Issue
  • Localization — Manual .xlf file edits violate build automation
Context:

This PR adds the MissingCrashDumpMainOption resource string to 13 localization files (.xlf files for cs, de, es, fr, it, ja, ko, pl, pt-BR, ru, tr, zh-Hans, zh-Hant). The resource string was correctly added to CrashDumpResources.resx (lines 144-146), which is the authoritative source.
Why this is blocking:

Per TestFx localization conventions (Knowledge Area #3 in the expert-reviewer instructions):
User-facing strings must be in .resx resource files. Never manually edit *.xlf files — build generates them.
Manually editing .xlf files causes:
  1. Build conflicts — the localization build auto-generates .xlf entries from .resx
  2. Workflow violations — translators expect state="new" entries to appear automatically via build
  3. Maintenance issues — manual edits can be overwritten or create merge conflicts
Correct workflow:
  1. ✅ Add the string to CrashDumpResources.resx (already done correctly)
  2. ❌ Manually add entries to all .xlf files (should NOT be done)
  3. ✅ Let the build system auto-generate the .xlf entries with state="new"
Recommendation:

Revert all 13 .xlf file changes. Keep only the CrashDumpResources.resx change. The build system will handle .xlf generation automatically.
If this PR represents what the build system actually generated (post-build artifact), then the title "Fix xlf generation" suggests a build system fix rather than manual edits — please clarify the intent.
Note: This PR was already merged (closed at 2026-05-22T10:58:03Z). This review serves as documentation for future reference and to prevent similar issues in follow-up PRs.
Generated by Expert Code Review (on open) for issue #8490 · ● 6M
Comment threadsrc/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.cs.xlf
 </trans-unit>
 <trans-unit id="MissingCrashDumpMainOption">
 <source>You specified one or more crash dump parameters but did not enable crash dumps. Add --crashdump or --crash-report to the command line.</source>
 <target state="new">You specified one or more crash dump parameters but did not enable crash dumps. Add --crashdump or --crash-report to the command line.</target>
@EvangelinkAmaury Levé (Evangelink)May 22, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[BLOCKING] Localization & Resources
The .xlf files should never be manually edited. According to TestFx's localization rules (documented in the expert-reviewer instructions and .github/copilot-instructions.md), the build system automatically generates .xlf files from the .resx source.
Scenario that triggers the issue:
  1. A developer adds a resource string to CrashDumpResources.resx (e.g., MissingCrashDumpMainOption)
  2. The developer manually edits all 13 .xlf files to add <target state="new"> entries
  3. The localization build runs and may overwrite or conflict with manual edits
  4. Translation workflow expects state="new" entries to be auto-generated, not manually created
Root cause:

This PR manually adds the MissingCrashDumpMainOption trans-unit to all 13 .xlf files with state="new" attributes. This is the wrong workflow.
Correct workflow:
  1. Add the resource string to CrashDumpResources.resx only (already done)
  2. Run the build — it will automatically generate the .xlf entries with state="new"
  3. The localization system will pick up state="new" entries for translation
  4. After translation, the build updates .xlf files with state="translated"
Recommendation:
  1. Revert all changes to the 13 .xlf files in this PR
  2. Keep only the change to CrashDumpResources.resx (lines 144-146)
  3. Run the build system to auto-generate the .xlf entries
  4. If the build already ran and generated these entries, this PR should include only the .resx change
Reference: See dimension #9 (Localization & Resources) in the expert-reviewer instructions.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@Evangelink

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Fix xlf generation by Evangelink · Pull Request #8490 · microsoft/testfx · GitHub
Skip to content
Fix xlf generation - #8490
Merged
Amaury Levé (Evangelink) merged 1 commit into
mainfrom 
dev/amauryleve/xlf
May 22, 2026
Merged
Fix xlf generation#8490
Amaury Levé (Evangelink) merged 1 commit into
mainfrom 
dev/amauryleve/xlf
Conversation
@Evangelink
@EvangelinkAmaury Levé (Evangelink)
commented
May 22, 2026

Copy link


Copy Markdown

Member
 No description provided. 
CopilotAI
review requested due to automatic review settings
May 22, 2026 10:57
@Evangelink
Amaury Levé (Evangelink)
merged commit a4f9539
into
mainMay 22, 2026

6 checks passed

@Evangelink
Amaury Levé (Evangelink)
deleted the

dev/amauryleve/xlf

branch
May 22, 2026 10:58
CopilotAI
reviewed
May 22, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Updates the CrashDump extension’s localized XLF files to include a missing resource entry, aligning translations with CrashDumpResources.resx and unblocking consistent XLF generation.
Changes:
  • Added the MissingCrashDumpMainOption trans-unit to all CrashDumpResources *.xlf files.
  • Marked the new entry as untranslated (state="new") while retaining the English source text, consistent with existing repo XLF patterns.
Show a summary per file
FileDescription
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.zh-Hant.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.zh-Hans.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.tr.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.ru.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.pt-BR.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.pl.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.ko.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.ja.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.it.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.fr.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.es.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.de.xlfAdds MissingCrashDumpMainOption trans-unit entry.
src/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.cs.xlfAdds MissingCrashDumpMainOption trans-unit entry.
Copilot's findings
  • Files reviewed: 13/13 changed files
  • Comments generated: 0
Evangelink
Amaury Levé (Evangelink)
commented
May 22, 2026
View reviewed changes
@EvangelinkAmaury Levé (Evangelink)
left a comment


Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Summary
#DimensionVerdict
9Localization & Resources🔴 1 BLOCKING
✅ 20/21 dimensions clean.
BLOCKING Issue
  • Localization — Manual .xlf file edits violate build automation
Context:

This PR adds the MissingCrashDumpMainOption resource string to 13 localization files (.xlf files for cs, de, es, fr, it, ja, ko, pl, pt-BR, ru, tr, zh-Hans, zh-Hant). The resource string was correctly added to CrashDumpResources.resx (lines 144-146), which is the authoritative source.
Why this is blocking:

Per TestFx localization conventions (Knowledge Area #3 in the expert-reviewer instructions):
User-facing strings must be in .resx resource files. Never manually edit *.xlf files — build generates them.
Manually editing .xlf files causes:
  1. Build conflicts — the localization build auto-generates .xlf entries from .resx
  2. Workflow violations — translators expect state="new" entries to appear automatically via build
  3. Maintenance issues — manual edits can be overwritten or create merge conflicts
Correct workflow:
  1. ✅ Add the string to CrashDumpResources.resx (already done correctly)
  2. ❌ Manually add entries to all .xlf files (should NOT be done)
  3. ✅ Let the build system auto-generate the .xlf entries with state="new"
Recommendation:

Revert all 13 .xlf file changes. Keep only the CrashDumpResources.resx change. The build system will handle .xlf generation automatically.
If this PR represents what the build system actually generated (post-build artifact), then the title "Fix xlf generation" suggests a build system fix rather than manual edits — please clarify the intent.
Note: This PR was already merged (closed at 2026-05-22T10:58:03Z). This review serves as documentation for future reference and to prevent similar issues in follow-up PRs.
Generated by Expert Code Review (on open) for issue #8490 · ● 6M
Comment threadsrc/Platform/Microsoft.Testing.Extensions.CrashDump/Resources/xlf/CrashDumpResources.cs.xlf
 </trans-unit>
 <trans-unit id="MissingCrashDumpMainOption">
 <source>You specified one or more crash dump parameters but did not enable crash dumps. Add --crashdump or --crash-report to the command line.</source>
 <target state="new">You specified one or more crash dump parameters but did not enable crash dumps. Add --crashdump or --crash-report to the command line.</target>
@EvangelinkAmaury Levé (Evangelink)May 22, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[BLOCKING] Localization & Resources
The .xlf files should never be manually edited. According to TestFx's localization rules (documented in the expert-reviewer instructions and .github/copilot-instructions.md), the build system automatically generates .xlf files from the .resx source.
Scenario that triggers the issue:
  1. A developer adds a resource string to CrashDumpResources.resx (e.g., MissingCrashDumpMainOption)
  2. The developer manually edits all 13 .xlf files to add <target state="new"> entries
  3. The localization build runs and may overwrite or conflict with manual edits
  4. Translation workflow expects state="new" entries to be auto-generated, not manually created
Root cause:

This PR manually adds the MissingCrashDumpMainOption trans-unit to all 13 .xlf files with state="new" attributes. This is the wrong workflow.
Correct workflow:
  1. Add the resource string to CrashDumpResources.resx only (already done)
  2. Run the build — it will automatically generate the .xlf entries with state="new"
  3. The localization system will pick up state="new" entries for translation
  4. After translation, the build updates .xlf files with state="translated"
Recommendation:
  1. Revert all changes to the 13 .xlf files in this PR
  2. Keep only the change to CrashDumpResources.resx (lines 144-146)
  3. Run the build system to auto-generate the .xlf entries
  4. If the build already ran and generated these entries, this PR should include only the .resx change
Reference: See dimension #9 (Localization & Resources) in the expert-reviewer instructions.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@Evangelink