Porting BugFix#260653: DataRowTests not getting appended by arguments by jayaranigarg · Pull Request #9 · microsoft/testfx

Jayarani garg (jayaranigarg) · 2016-09-08T13:32:09Z

No description provided.

Always exit test script with 0

* Fix stale 21-dimension references throughout the doc now that the count is 22 (lines: 'Assess all 21 dimensions...', batching math '4 batches for 21 dimensions, last batch has 3' -> 'last batch has 4', summary table denominator 'N/21' -> 'N/22', example footers '19/21' and '21/21' updated, MSBuild supplemental section now says it is 'not a 23rd dimension'). * Perf rule #7: clarify the cross-TFM-safe fix. `MemoryMarshal.CreateReadOnlySpan(ref ch, 1)` with the `ReadOnlySpan<char>` overload of `Encoding.GetBytes` is not universally available, and `ref ch` cannot be applied to a `foreach` iteration variable. Recommend a single `char[1]` declared outside the loop (works on every TFM), with `stackalloc char[1]` + Span overload as the net6+ alternative. * Split former rule #8 in two: #8 (PowerShell ` += `) and #9 (C# `result = result.Concat(page).ToArray()`). The reviewer correctly noted that `array +=` is PowerShell-specific and lumping both forms under one rule confuses C#-only reviewers. * IPC rule #5: add the explicit bounds checks (`charCount > 0 && charCount < input.Length`) before indexing `input[charCount - 1]`. Without them the rule's own recommended fix would throw on truncate-to-zero inputs. * PowerShell rule #6: stop suggesting `catch { \$failures += '...' }` which reintroduces the O(n^2) accumulation defect called out by rule #2. Recommend a `List[string]` + `.Add()` instead. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…und in CI * Skip samples/CtrfPlayground/{Mtp,XunitMtp} under 'dotnet test -p:UsingDotNetTest=true' (the playground intentionally contains failing/throwing/skipped tests for diffing against xunit.v3 CTRF output). Mirrors the WasiPlayground pattern. Fixes the Windows/MacOS Debug Test CI failures. * Split CTRF stdout/stderr into per-line array entries. The CTRF schema types these as 'lines of output'; we now split on LF (normalizing CRLF) and omit the trailing empty entry when input ends with a newline. Brad Wilson's xunit.v3 CTRF comparison item microsoft#9. * Replace the misleading 'we never deduplicate on TestNode.Uid' wording in CtrfReportGenerator with a comment pointing at CtrfReportEngine.CollapseAttempts (which DOES collapse same-UID captures into retryAttempts[]). Adds two unit tests for the new line-splitting behavior (CRLF normalization, trailing-newline handling, single-line output). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…icrosoft#9) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Jayarani garg (jayaranigarg) · 2016-09-08T13:32:09Z

No description provided.

Always exit test script with 0

* Fix stale 21-dimension references throughout the doc now that the count is 22 (lines: 'Assess all 21 dimensions...', batching math '4 batches for 21 dimensions, last batch has 3' -> 'last batch has 4', summary table denominator 'N/21' -> 'N/22', example footers '19/21' and '21/21' updated, MSBuild supplemental section now says it is 'not a 23rd dimension'). * Perf rule #7: clarify the cross-TFM-safe fix. `MemoryMarshal.CreateReadOnlySpan(ref ch, 1)` with the `ReadOnlySpan<char>` overload of `Encoding.GetBytes` is not universally available, and `ref ch` cannot be applied to a `foreach` iteration variable. Recommend a single `char[1]` declared outside the loop (works on every TFM), with `stackalloc char[1]` + Span overload as the net6+ alternative. * Split former rule #8 in two: #8 (PowerShell ` += `) and #9 (C# `result = result.Concat(page).ToArray()`). The reviewer correctly noted that `array +=` is PowerShell-specific and lumping both forms under one rule confuses C#-only reviewers. * IPC rule #5: add the explicit bounds checks (`charCount > 0 && charCount < input.Length`) before indexing `input[charCount - 1]`. Without them the rule's own recommended fix would throw on truncate-to-zero inputs. * PowerShell rule #6: stop suggesting `catch { \$failures += '...' }` which reintroduces the O(n^2) accumulation defect called out by rule #2. Recommend a `List[string]` + `.Add()` instead. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…und in CI * Skip samples/CtrfPlayground/{Mtp,XunitMtp} under 'dotnet test -p:UsingDotNetTest=true' (the playground intentionally contains failing/throwing/skipped tests for diffing against xunit.v3 CTRF output). Mirrors the WasiPlayground pattern. Fixes the Windows/MacOS Debug Test CI failures. * Split CTRF stdout/stderr into per-line array entries. The CTRF schema types these as 'lines of output'; we now split on LF (normalizing CRLF) and omit the trailing empty entry when input ends with a newline. Brad Wilson's xunit.v3 CTRF comparison item microsoft#9. * Replace the misleading 'we never deduplicate on TestNode.Uid' wording in CtrfReportGenerator with a comment pointing at CtrfReportEngine.CollapseAttempts (which DOES collapse same-UID captures into retryAttempts[]). Adds two unit tests for the new line-splitting behavior (CRLF normalization, trailing-newline handling, single-line output). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…icrosoft#9) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Jayarani garg (jayaranigarg) · 2016-09-08T13:32:09Z

No description provided.

Always exit test script with 0

* Fix stale 21-dimension references throughout the doc now that the count is 22 (lines: 'Assess all 21 dimensions...', batching math '4 batches for 21 dimensions, last batch has 3' -> 'last batch has 4', summary table denominator 'N/21' -> 'N/22', example footers '19/21' and '21/21' updated, MSBuild supplemental section now says it is 'not a 23rd dimension'). * Perf rule #7: clarify the cross-TFM-safe fix. `MemoryMarshal.CreateReadOnlySpan(ref ch, 1)` with the `ReadOnlySpan<char>` overload of `Encoding.GetBytes` is not universally available, and `ref ch` cannot be applied to a `foreach` iteration variable. Recommend a single `char[1]` declared outside the loop (works on every TFM), with `stackalloc char[1]` + Span overload as the net6+ alternative. * Split former rule #8 in two: #8 (PowerShell ` += `) and #9 (C# `result = result.Concat(page).ToArray()`). The reviewer correctly noted that `array +=` is PowerShell-specific and lumping both forms under one rule confuses C#-only reviewers. * IPC rule #5: add the explicit bounds checks (`charCount > 0 && charCount < input.Length`) before indexing `input[charCount - 1]`. Without them the rule's own recommended fix would throw on truncate-to-zero inputs. * PowerShell rule #6: stop suggesting `catch { \$failures += '...' }` which reintroduces the O(n^2) accumulation defect called out by rule #2. Recommend a `List[string]` + `.Add()` instead. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…und in CI * Skip samples/CtrfPlayground/{Mtp,XunitMtp} under 'dotnet test -p:UsingDotNetTest=true' (the playground intentionally contains failing/throwing/skipped tests for diffing against xunit.v3 CTRF output). Mirrors the WasiPlayground pattern. Fixes the Windows/MacOS Debug Test CI failures. * Split CTRF stdout/stderr into per-line array entries. The CTRF schema types these as 'lines of output'; we now split on LF (normalizing CRLF) and omit the trailing empty entry when input ends with a newline. Brad Wilson's xunit.v3 CTRF comparison item microsoft#9. * Replace the misleading 'we never deduplicate on TestNode.Uid' wording in CtrfReportGenerator with a comment pointing at CtrfReportEngine.CollapseAttempts (which DOES collapse same-UID captures into retryAttempts[]). Adds two unit tests for the new line-splitting behavior (CRLF normalization, trailing-newline handling, single-line output). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…icrosoft#9) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Jayarani garg (jayaranigarg) · 2016-09-08T13:32:09Z

No description provided.

Always exit test script with 0

* Fix stale 21-dimension references throughout the doc now that the count is 22 (lines: 'Assess all 21 dimensions...', batching math '4 batches for 21 dimensions, last batch has 3' -> 'last batch has 4', summary table denominator 'N/21' -> 'N/22', example footers '19/21' and '21/21' updated, MSBuild supplemental section now says it is 'not a 23rd dimension'). * Perf rule #7: clarify the cross-TFM-safe fix. `MemoryMarshal.CreateReadOnlySpan(ref ch, 1)` with the `ReadOnlySpan<char>` overload of `Encoding.GetBytes` is not universally available, and `ref ch` cannot be applied to a `foreach` iteration variable. Recommend a single `char[1]` declared outside the loop (works on every TFM), with `stackalloc char[1]` + Span overload as the net6+ alternative. * Split former rule #8 in two: #8 (PowerShell ` += `) and #9 (C# `result = result.Concat(page).ToArray()`). The reviewer correctly noted that `array +=` is PowerShell-specific and lumping both forms under one rule confuses C#-only reviewers. * IPC rule #5: add the explicit bounds checks (`charCount > 0 && charCount < input.Length`) before indexing `input[charCount - 1]`. Without them the rule's own recommended fix would throw on truncate-to-zero inputs. * PowerShell rule #6: stop suggesting `catch { \$failures += '...' }` which reintroduces the O(n^2) accumulation defect called out by rule #2. Recommend a `List[string]` + `.Add()` instead. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…und in CI * Skip samples/CtrfPlayground/{Mtp,XunitMtp} under 'dotnet test -p:UsingDotNetTest=true' (the playground intentionally contains failing/throwing/skipped tests for diffing against xunit.v3 CTRF output). Mirrors the WasiPlayground pattern. Fixes the Windows/MacOS Debug Test CI failures. * Split CTRF stdout/stderr into per-line array entries. The CTRF schema types these as 'lines of output'; we now split on LF (normalizing CRLF) and omit the trailing empty entry when input ends with a newline. Brad Wilson's xunit.v3 CTRF comparison item microsoft#9. * Replace the misleading 'we never deduplicate on TestNode.Uid' wording in CtrfReportGenerator with a comment pointing at CtrfReportEngine.CollapseAttempts (which DOES collapse same-UID captures into retryAttempts[]). Adds two unit tests for the new line-splitting behavior (CRLF normalization, trailing-newline handling, single-line output). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…icrosoft#9) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Jayarani garg (jayaranigarg) · 2016-09-08T13:32:09Z

No description provided.

Always exit test script with 0

* Fix stale 21-dimension references throughout the doc now that the count is 22 (lines: 'Assess all 21 dimensions...', batching math '4 batches for 21 dimensions, last batch has 3' -> 'last batch has 4', summary table denominator 'N/21' -> 'N/22', example footers '19/21' and '21/21' updated, MSBuild supplemental section now says it is 'not a 23rd dimension'). * Perf rule #7: clarify the cross-TFM-safe fix. `MemoryMarshal.CreateReadOnlySpan(ref ch, 1)` with the `ReadOnlySpan<char>` overload of `Encoding.GetBytes` is not universally available, and `ref ch` cannot be applied to a `foreach` iteration variable. Recommend a single `char[1]` declared outside the loop (works on every TFM), with `stackalloc char[1]` + Span overload as the net6+ alternative. * Split former rule #8 in two: #8 (PowerShell ` += `) and #9 (C# `result = result.Concat(page).ToArray()`). The reviewer correctly noted that `array +=` is PowerShell-specific and lumping both forms under one rule confuses C#-only reviewers. * IPC rule #5: add the explicit bounds checks (`charCount > 0 && charCount < input.Length`) before indexing `input[charCount - 1]`. Without them the rule's own recommended fix would throw on truncate-to-zero inputs. * PowerShell rule #6: stop suggesting `catch { \$failures += '...' }` which reintroduces the O(n^2) accumulation defect called out by rule #2. Recommend a `List[string]` + `.Add()` instead. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…und in CI * Skip samples/CtrfPlayground/{Mtp,XunitMtp} under 'dotnet test -p:UsingDotNetTest=true' (the playground intentionally contains failing/throwing/skipped tests for diffing against xunit.v3 CTRF output). Mirrors the WasiPlayground pattern. Fixes the Windows/MacOS Debug Test CI failures. * Split CTRF stdout/stderr into per-line array entries. The CTRF schema types these as 'lines of output'; we now split on LF (normalizing CRLF) and omit the trailing empty entry when input ends with a newline. Brad Wilson's xunit.v3 CTRF comparison item microsoft#9. * Replace the misleading 'we never deduplicate on TestNode.Uid' wording in CtrfReportGenerator with a comment pointing at CtrfReportEngine.CollapseAttempts (which DOES collapse same-UID captures into retryAttempts[]). Adds two unit tests for the new line-splitting behavior (CRLF normalization, trailing-newline handling, single-line output). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…icrosoft#9) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Jayarani garg (jayaranigarg) · 2016-09-08T13:32:09Z

No description provided.

Always exit test script with 0

* Fix stale 21-dimension references throughout the doc now that the count is 22 (lines: 'Assess all 21 dimensions...', batching math '4 batches for 21 dimensions, last batch has 3' -> 'last batch has 4', summary table denominator 'N/21' -> 'N/22', example footers '19/21' and '21/21' updated, MSBuild supplemental section now says it is 'not a 23rd dimension'). * Perf rule #7: clarify the cross-TFM-safe fix. `MemoryMarshal.CreateReadOnlySpan(ref ch, 1)` with the `ReadOnlySpan<char>` overload of `Encoding.GetBytes` is not universally available, and `ref ch` cannot be applied to a `foreach` iteration variable. Recommend a single `char[1]` declared outside the loop (works on every TFM), with `stackalloc char[1]` + Span overload as the net6+ alternative. * Split former rule #8 in two: #8 (PowerShell ` += `) and #9 (C# `result = result.Concat(page).ToArray()`). The reviewer correctly noted that `array +=` is PowerShell-specific and lumping both forms under one rule confuses C#-only reviewers. * IPC rule #5: add the explicit bounds checks (`charCount > 0 && charCount < input.Length`) before indexing `input[charCount - 1]`. Without them the rule's own recommended fix would throw on truncate-to-zero inputs. * PowerShell rule #6: stop suggesting `catch { \$failures += '...' }` which reintroduces the O(n^2) accumulation defect called out by rule #2. Recommend a `List[string]` + `.Add()` instead. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…und in CI * Skip samples/CtrfPlayground/{Mtp,XunitMtp} under 'dotnet test -p:UsingDotNetTest=true' (the playground intentionally contains failing/throwing/skipped tests for diffing against xunit.v3 CTRF output). Mirrors the WasiPlayground pattern. Fixes the Windows/MacOS Debug Test CI failures. * Split CTRF stdout/stderr into per-line array entries. The CTRF schema types these as 'lines of output'; we now split on LF (normalizing CRLF) and omit the trailing empty entry when input ends with a newline. Brad Wilson's xunit.v3 CTRF comparison item microsoft#9. * Replace the misleading 'we never deduplicate on TestNode.Uid' wording in CtrfReportGenerator with a comment pointing at CtrfReportEngine.CollapseAttempts (which DOES collapse same-UID captures into retryAttempts[]). Adds two unit tests for the new line-splitting behavior (CRLF normalization, trailing-newline handling, single-line output). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…icrosoft#9) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Jayarani garg (jayaranigarg) · 2016-09-08T13:32:09Z

No description provided.

Always exit test script with 0

* Fix stale 21-dimension references throughout the doc now that the count is 22 (lines: 'Assess all 21 dimensions...', batching math '4 batches for 21 dimensions, last batch has 3' -> 'last batch has 4', summary table denominator 'N/21' -> 'N/22', example footers '19/21' and '21/21' updated, MSBuild supplemental section now says it is 'not a 23rd dimension'). * Perf rule #7: clarify the cross-TFM-safe fix. `MemoryMarshal.CreateReadOnlySpan(ref ch, 1)` with the `ReadOnlySpan<char>` overload of `Encoding.GetBytes` is not universally available, and `ref ch` cannot be applied to a `foreach` iteration variable. Recommend a single `char[1]` declared outside the loop (works on every TFM), with `stackalloc char[1]` + Span overload as the net6+ alternative. * Split former rule #8 in two: #8 (PowerShell ` += `) and #9 (C# `result = result.Concat(page).ToArray()`). The reviewer correctly noted that `array +=` is PowerShell-specific and lumping both forms under one rule confuses C#-only reviewers. * IPC rule #5: add the explicit bounds checks (`charCount > 0 && charCount < input.Length`) before indexing `input[charCount - 1]`. Without them the rule's own recommended fix would throw on truncate-to-zero inputs. * PowerShell rule #6: stop suggesting `catch { \$failures += '...' }` which reintroduces the O(n^2) accumulation defect called out by rule #2. Recommend a `List[string]` + `.Add()` instead. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…und in CI * Skip samples/CtrfPlayground/{Mtp,XunitMtp} under 'dotnet test -p:UsingDotNetTest=true' (the playground intentionally contains failing/throwing/skipped tests for diffing against xunit.v3 CTRF output). Mirrors the WasiPlayground pattern. Fixes the Windows/MacOS Debug Test CI failures. * Split CTRF stdout/stderr into per-line array entries. The CTRF schema types these as 'lines of output'; we now split on LF (normalizing CRLF) and omit the trailing empty entry when input ends with a newline. Brad Wilson's xunit.v3 CTRF comparison item microsoft#9. * Replace the misleading 'we never deduplicate on TestNode.Uid' wording in CtrfReportGenerator with a comment pointing at CtrfReportEngine.CollapseAttempts (which DOES collapse same-UID captures into retryAttempts[]). Adds two unit tests for the new line-splitting behavior (CRLF normalization, trailing-newline handling, single-line output). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…icrosoft#9) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Jayarani garg (jayaranigarg) · 2016-09-08T13:32:09Z

No description provided.

Always exit test script with 0

* Fix stale 21-dimension references throughout the doc now that the count is 22 (lines: 'Assess all 21 dimensions...', batching math '4 batches for 21 dimensions, last batch has 3' -> 'last batch has 4', summary table denominator 'N/21' -> 'N/22', example footers '19/21' and '21/21' updated, MSBuild supplemental section now says it is 'not a 23rd dimension'). * Perf rule #7: clarify the cross-TFM-safe fix. `MemoryMarshal.CreateReadOnlySpan(ref ch, 1)` with the `ReadOnlySpan<char>` overload of `Encoding.GetBytes` is not universally available, and `ref ch` cannot be applied to a `foreach` iteration variable. Recommend a single `char[1]` declared outside the loop (works on every TFM), with `stackalloc char[1]` + Span overload as the net6+ alternative. * Split former rule #8 in two: #8 (PowerShell ` += `) and #9 (C# `result = result.Concat(page).ToArray()`). The reviewer correctly noted that `array +=` is PowerShell-specific and lumping both forms under one rule confuses C#-only reviewers. * IPC rule #5: add the explicit bounds checks (`charCount > 0 && charCount < input.Length`) before indexing `input[charCount - 1]`. Without them the rule's own recommended fix would throw on truncate-to-zero inputs. * PowerShell rule #6: stop suggesting `catch { \$failures += '...' }` which reintroduces the O(n^2) accumulation defect called out by rule #2. Recommend a `List[string]` + `.Add()` instead. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…und in CI * Skip samples/CtrfPlayground/{Mtp,XunitMtp} under 'dotnet test -p:UsingDotNetTest=true' (the playground intentionally contains failing/throwing/skipped tests for diffing against xunit.v3 CTRF output). Mirrors the WasiPlayground pattern. Fixes the Windows/MacOS Debug Test CI failures. * Split CTRF stdout/stderr into per-line array entries. The CTRF schema types these as 'lines of output'; we now split on LF (normalizing CRLF) and omit the trailing empty entry when input ends with a newline. Brad Wilson's xunit.v3 CTRF comparison item microsoft#9. * Replace the misleading 'we never deduplicate on TestNode.Uid' wording in CtrfReportGenerator with a comment pointing at CtrfReportEngine.CollapseAttempts (which DOES collapse same-UID captures into retryAttempts[]). Adds two unit tests for the new line-splitting behavior (CRLF normalization, trailing-newline handling, single-line output). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…icrosoft#9) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Jayarani garg (jayaranigarg) added 9 commits August 31, 2016 15:15

Bug Fix #258333 with UT
255a16b

Correcting UT
86f8d13

Editing UT
6ce370b

Bug Fix #233637 with UT
9cd135f

Resolving merge conflicts
d3471e7

Resolving merge conflicts
39a0423

Addressing PR comments
97d3eb9

Porting BugFix#260653: DataRowTests not getting appended by arguments
71e6eb3

Merge branch 'master' into datarow
af2e81e

Jayarani garg (jayaranigarg) merged commit dcc0685 into microsoft:masterSep 9, 2016

Jayarani garg (jayaranigarg) deleted the datarow branch September 9, 2016 08:44

Sarabjot Singh (singhsarab) pushed a commit to singhsarab/testfx that referenced this pull request Apr 8, 2019
Merge pull requestmicrosoft#9from codito/test-exit-code
5916863
Always exit test script with 0

Amaury Levé (Evangelink) mentioned this pull request May 22, 2026
Fix xlf generation #8490
Merged

Amaury Levé (Evangelink) mentioned this pull request Jun 4, 2026
RFC 016: Filter command-line option #8820
Draft

Amaury Levé (Evangelink) mentioned this pull request Jun 8, 2026
Add Microsoft.Testing.Extensions.CtrfReport extension (CTRF reporter) #8903
Merged

Amaury Levé (Evangelink) mentioned this pull request Jun 16, 2026
RFC 018: Artifact post-processing for dotnet test (MTP) #9187
Merged

Azat Mukhametshin (azat-msft) added a commit to azat-msft/testfx that referenced this pull request Jul 1, 2026
Add Changelog-Platform entry for GitHubActionsReport (Amaury reviewm…
db13b15
…icrosoft#9) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>