Uh oh!
There was an error while loading. Please reload this page.
Add --progress {auto|on|off} and deprecate --no-progress in MTP terminal reporter - #9145
Merged
Amaury Levé (Evangelink) merged 2 commits intoJun 15, 2026
Merged
Conversation
…nal reporter Fixes#9138 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Microsoft.Testing.Platform’s terminal reporter CLI to introduce a positive --progress {auto|on|off} option, while keeping --no-progress as a deprecated alias that emits a one-per-process stderr warning. The change aligns progress behavior/configuration with the existing --ansi {auto|on|off} pattern and updates unit/acceptance tests plus localized resources accordingly.
Changes:
- Add
--progress {auto|on|off}to the terminal reporter options provider and validate its arguments. - Update
TerminalOutputDeviceto prefer--progress, fall back to--no-progresswith a deprecation warning, and keep precedence semantics clear. - Update test infrastructure + unit/integration acceptance tests and help/info expectation strings; regenerate localized
.xlfcontent.
Show a summary per file
| File | Description |
|---|---|
| test/Utilities/Microsoft.Testing.TestInfrastructure/TestHost.cs | Switch injected default args from --no-progress to --progress off to avoid deprecation noise in tests. |
| test/UnitTests/Microsoft.Testing.Platform.UnitTests/OutputDevice/TerminalOutputDeviceTests.cs | Add coverage for deprecated alias warning emission and precedence behavior. |
| test/UnitTests/Microsoft.Testing.Platform.UnitTests/OutputDevice/Terminal/TerminalTestReporterCommandLineOptionsProviderTests.cs | Add validation tests for --progress and assert option presence. |
| test/IntegrationTests/MSTest.Acceptance.IntegrationTests/ShowOutputOptionTests.cs | Migrate test runs to use --progress off. |
| test/IntegrationTests/MSTest.Acceptance.IntegrationTests/SdkTests.cs | Migrate dotnet test invocation to --progress off. |
| test/IntegrationTests/MSTest.Acceptance.IntegrationTests/HelpInfoTests.cs | Update expected --help output for --progress and --no-progress deprecation text. |
| test/IntegrationTests/Microsoft.Testing.Platform.Acceptance.IntegrationTests/HelpInfoTests.cs | Update expected help/info output and command line echo to match new injected args. |
| test/IntegrationTests/Microsoft.Testing.Platform.Acceptance.IntegrationTests/HelpInfoAllExtensionsTests.cs | Update expected help/info output for all-extensions case. |
| test/IntegrationTests/Microsoft.Testing.Platform.Acceptance.IntegrationTests/ExitOnProcessExitTests.cs | Migrate invocation to --progress off. |
| test/IntegrationTests/Microsoft.Testing.Platform.Acceptance.IntegrationTests/AnsiOptionTests.cs | Update comments/assertion context to reflect new injected args. |
| src/Platform/Microsoft.Testing.Platform/Resources/PlatformResources.resx | Add/update strings for --progress, deprecation warning, and updated --ansi guidance. |
| src/Platform/Microsoft.Testing.Platform/OutputDevice/TerminalOutputDevice.cs | Implement --progress parsing/precedence and --no-progress deprecation warning (once per process). |
| src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporterCommandLineOptionsProvider.cs | Register --progress option and validation logic; keep --no-progress as a built-in option. |
| src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.zh-Hant.xlf | Regenerated localized strings for new/updated terminal options text. |
| src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.zh-Hans.xlf | Regenerated localized strings for new/updated terminal options text. |
| src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.tr.xlf | Regenerated localized strings for new/updated terminal options text. |
| src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.ru.xlf | Regenerated localized strings for new/updated terminal options text. |
| src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.pt-BR.xlf | Regenerated localized strings for new/updated terminal options text. |
| src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.pl.xlf | Regenerated localized strings for new/updated terminal options text. |
| src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.ko.xlf | Regenerated localized strings for new/updated terminal options text. |
| src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.ja.xlf | Regenerated localized strings for new/updated terminal options text. |
| src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.it.xlf | Regenerated localized strings for new/updated terminal options text. |
| src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.fr.xlf | Regenerated localized strings for new/updated terminal options text. |
| src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.es.xlf | Regenerated localized strings for new/updated terminal options text. |
| src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.de.xlf | Regenerated localized strings for new/updated terminal options text. |
| src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.cs.xlf | Regenerated localized strings for new/updated terminal options text. |
Copilot's findings
- Files reviewed: 26/26 changed files
- Comments generated: 1
Uh oh!
There was an error while loading. Please reload this page.
This comment has been minimized.
This comment has been minimized.
TestHost.ExecuteAsync already injects --no-ansi --progress off, and --progress is arity-1 so passing it again on the test command line trips 'Option --progress expects at most 1 arguments' validation and breaks the ShowOutputOptionTests on Linux/macOS Debug. While here, drop the remaining explicit --no-progress usages in ParameterizedTestTests and HangDumpOutputTests so they don't emit the new deprecation warning (Copilot review feedback on #9145). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Amaury Levé (Evangelink)
commented
Jun 15, 2026
MemberAuthor
🧪 Test quality grade — PR #914531 tests graded across 11 files (7 new, 24 modified). 28 earned A (90–100): clean structure, meaningful assertions, and no anti-patterns. The 3 B-grade tests are the new
This advisory comment was generated automatically. Grades are heuristic
|
Amaury Levé (Evangelink)
enabled auto-merge (squash)
June 15, 2026 11:54
Jan Krivanek (JanKrivanek)
approved these changes
Jun 15, 2026
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Jun 16, 2026
Amaury Levé (Evangelink) added a commit
that referenced
this pull request
Jun 17, 2026
Arcade's MTP test runner hardcodes --no-progress, and testfx CI runs with TestCaptureOutput=false, so the deprecation warning (PR #9145) written to stderr surfaced as EXEC errors and broke the build. Emit the warning only when not in a CI environment; --no-progress still works as a silent alias for --progress off. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#9138.
Summary
Replaces the negative
--no-progressswitch on the Microsoft.Testing.Platform terminal reporter with a positive--progress {auto|on|off}option, mirroring the existing--ansi {auto|on|off}flag.--no-progresskeeps working as a deprecated alias.Behavior
--progress auto(default): current behavior — show progress unless the terminal cannot update in place (NoAnsi/SimpleAnsi), or we are a test-host controller,--list-tests, or server mode.--progress on: same asautotoday (a dedicated heartbeat renderer for non-cursor modes is tracked by Add CI-friendly textual progress heartbeat to MTP terminal reporter (raw log progress signal) #9125).--progress off: equivalent to today's--no-progress.--no-progress: still works, routed to--progress off, and emits a one-per-process stderr warning:warning: --no-progress is deprecated; use --progress off instead.--progressalways wins when both are supplied.Changes
TerminalTestReporterCommandLineOptionsProvider: new--progressoption + validation.TerminalOutputDevice: read--progressfirst, fall back to--no-progresswith the deprecation warning.PlatformResources.resx; all.xlfregenerated viaUpdateXlf. The--ansidescription now recommends--progress offinstead of the deprecated flag.--help/--infoacceptance test expectations.TestHost.ExecuteAsyncnow injects--progress off(instead of--no-progress) so the deprecation warning doesn't flood acceptance tests; explicit--no-progressusages in tests migrated to--progress off.Tests
--progressvalidation and for the deprecation-warning behavior (warning emitted for--no-progress, suppressed for--progress off, and--progresstaking precedence).--help/--infooutput confirmed to match the updated expectations.Out of scope (per issue)
--no-progressin the next major.