Skip to content

http-client-java, use polling metadata in emitter for mgmt - #9109

Merged
Weidong Xu (weidongxu-microsoft) merged 6 commits into
microsoft:mainfrom
weidongxu-microsoft:http-client-java_use-PollingMetadata
Dec 1, 2025
Merged

http-client-java, use polling metadata in emitter for mgmt#9109
Weidong Xu (weidongxu-microsoft) merged 6 commits into
microsoft:mainfrom
weidongxu-microsoft:http-client-java_use-PollingMetadata

Conversation

@weidongxu-microsoft

@weidongxu-microsoftWeidong Xu (weidongxu-microsoft) commented Nov 28, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

@microsoft-github-policy-servicemicrosoft-github-policy-serviceBot added the emitter:client:java Issue for the Java client emitter: @typespec/http-client-java label Nov 28, 2025
@github-actions

github-actionsBot commented Nov 28, 2025

Copy link
Copy Markdown
Contributor

No changes needing a change description found.

@azure-sdk

Azure SDK Bot (azure-sdk) commented Nov 28, 2025•
edited
Loading

Copy link
Copy Markdown
Collaborator

You can try these changes here

🛝 Playground🌐 Website🛝 VSCode Extension

@weidongxu-microsoft
Weidong Xu (weidongxu-microsoft) marked this pull request as ready for review November 28, 2025 06:52
haolingdong-msft
Haoling Dong (haolingdong-msft) approved these changes Dec 1, 2025
View reviewed changes

@haolingdong-msftHaoling Dong (haolingdong-msft) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Just add two comments for clarification purpose. Thanks!

Comment thread...com/microsoft/typespec/http/client/generator/core/mapper/ClientMethodsReturnDescription.java Outdated
Comment threadpackages/http-client-java/generator/http-client-generator-test/tsp/arm.tsp
@weidongxu-microsoftWeidong Xu (weidongxu-microsoft) mentioned this pull request Dec 1, 2025
Closed
Merged via the queue into microsoft:main with commit c03ab1aDec 1, 2025
26 checks passed
@weidongxu-microsoft
Weidong Xu (weidongxu-microsoft) deleted the http-client-java_use-PollingMetadata branch December 1, 2025 09:17
@weidongxu-microsoftWeidong Xu (weidongxu-microsoft) mentioned this pull request Dec 5, 2025
Merged
github-merge-queueBot pushed a commit that referenced this pull request Dec 8, 2025
@weidongxu-microsoft
http-client-java, fix FinalResult model incorrectly removed (#9145)
b1176f5
Caused by #9109
Happens in mgmt flow, where we clean up unused model.
Therefore, when we use FinalResult (instead of Response) model from LRO,
we'd need to change this logic too.
---
test Azure/autorest.java#3237Azure/azure-sdk-for-java#47475 (some model get
removed, Build pass)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@haolingdong-msftHaoling Dong (haolingdong-msft)haolingdong-msft approved these changes
@srnagarSrikanta (srnagar)Awaiting requested review from srnagar
@anuchandyAnu Thomas (anuchandy)Awaiting requested review from anuchandy
@XiaofeiCaoXiaofei Cao (XiaofeiCao)Awaiting requested review from XiaofeiCaoXiaofeiCao is a code owner

Assignees

No one assigned

Labels

emitter:client:javaIssue for the Java client emitter: @typespec/http-client-java

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

mgmt, LRO response is wrong for some legacy typespec

3 participants

@weidongxu-microsoft@azure-sdk@haolingdong-msft