Uh oh!
There was an error while loading. Please reload this page.
http-client-java, fix FinalResult model incorrectly removed - #9145
Merged
Xiaofei Cao (XiaofeiCao) merged 6 commits intoDec 8, 2025
Conversation
Contributor
No changes needing a change description found. |
Azure SDK Bot (azure-sdk)
commented
Dec 5, 2025
Collaborator
You can try these changes here
|
Weidong Xu (weidongxu-microsoft)
marked this pull request as ready for review
December 5, 2025 10:12
Weidong Xu (weidongxu-microsoft)
commented
Dec 5, 2025
ContributorAuthor
Xiaofei Cao (@XiaofeiCao) |
Xiaofei Cao (XiaofeiCao)
approved these changes
Dec 8, 2025
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caused by #9109
Happens in mgmt flow, where we clean up unused model.
Therefore, when we use FinalResult (instead of Response) model from LRO, we'd need to change this logic too.
test Azure/autorest.java#3237
Azure/azure-sdk-for-java#47475 (some model get removed, Build pass)