fix(board): async searchParams; drop project filter; agent docs

[joryirving]

Summary

Closes#42, #35, #33, #32. (#36 split out per discussion — schema change deserves its own PR.)

• Fix Board filters resetting and remove stale project-label filtering #42 — Board filter dropdowns reset because searchParams is read synchronously in src/app/board/page.tsx, which is invalid under Next 16. Type searchParams as Promise<...> and await it. Remove the stale Project name text filter (repos are the project boundary, project/* labels aren't required). Rename Agent/Owner dropdowns to All agent labels / All owner labels with aria-label/title so the label-only filter behavior is explicit. Keep /api/issues API surface unchanged (zero blast radius outside the board UI).
• Add regression tests for issue move validation and audit behavior #35 — route.test.ts already covers validation, label mutation shape, and success-path AuditLog. Adds the one missing case: AuditLog row written with success: false and the captured errorMessage when the GitHub mutation throws.
• Define openclaw agent workflow contract for Mission Control #33 — New "OpenClaw Agent Workflow Contract" section in AGENTS.md: heartbeat lifecycle (best-effort /api/sync at start, /api/agent-runs at end), read path (/api/issues, prefer agent/* label assignment, treat no-status as backlog), source-of-truth rules (GitHub authoritative, Projects deprecated, no auto-close), failure modes (Mission Control failures don't fail the heartbeat, tokens are secrets), and auditability.
• Add pre-openclaw agent migration runtime smoke checklist #32 — New "Pre-migration Smoke Checklist" section in README.md with a 10-step checklist (health, automation sync, repos, issue sync, issue read, board render, projects render, agent heartbeat visible, label-change audit row, no Prisma/BigInt/FK errors).
• Adds a regression test (src/app/board/page.test.tsx) that calls BoardPage with Promise.resolve({...}) and asserts the Prisma query receives the resolved filter values. Catches sync-access reverts.

Test plan

• npm run lint — clean
• npm run typecheck — clean (after npx prisma generate, matching CI)
• npm test — 53/53 passing (9 files)
• CI green on PR
• Manual: open /board, pick a repo from the dropdown, confirm it sticks across reload and filters the cards
• Manual: open /board?project=foo from an old bookmark, confirm nothing breaks (param is ignored silently)

🤖 Generated with Claude Code

[its-miso]

✅ Automated recommendation: APPROVE

Analysis engine: anthropic/MiniMax-M2.7@https://litellm.jory.dev/v1 (anthropic)

PR Review: fix(board): async searchParams; drop project filter; agent docs

Recommendation

Approve. This PR cleanly addresses all four linked issues (#42, #35, #33, #32) with correct implementation, appropriate test coverage, and documentation that follows repository conventions.

---

Change-by-Change Findings

1. src/app/board/page.tsx — Core fix for #42

• searchParams type change: Changed from searchParams: { ... } to searchParams: Promise<{ ... }> ✓
• await usage: Added const params = await searchParams before accessing any params ✓
• project filter removal: Removed project parameter from getIssues() and removed if (project) where.labels = { has: 'project/${project}' } ✓
• activeFilters: Removed project from the filter object passed to FilterBar ✓

This matches the Next 16 pattern shown in issue #42's "Likely fix direction" section.

2. src/components/filter-bar.tsx — UX improvements for #42

• Project Input removed: The Input component for "Project name" was removed ✓
• aria-label and title added: Agent dropdown gets "Filter by agent label" + "Filters by agent/* label only"; Owner dropdown gets equivalent ✓
• Option text renamed: "All Agents" → "All agent labels", "All Owners" → "All owner labels" ✓

This addresses the acceptance criterion "Decide and document Agent/Owner filter behavior: either label-only by design, with clear UI text."

3. src/app/board/page.test.tsx — Regression test for #42 (NEW FILE)

• 5 test cases covering repo, agent, owner, priority filters, and empty params
• Mocks Prisma queries and verifies the where clause passed to findMany
• Uses Promise.resolve({...}) to simulate Next 16 async searchParams ✓

4. src/app/api/issues/move/route.test.ts — AuditLog test for #35

• Adds test case: it("writes an AuditLog entry with success=false when the GitHub mutation fails")
• Mocks removeIssueLabel.mockRejectedValueOnce(new Error("github 500"))
• Verifies createAuditLog called with success: false and errorMessage: "github 500" ✓

5. AGENTS.md — OpenClaw Agent Workflow Contract for #33

• 11-point contract covering heartbeat lifecycle, read path, source of truth, failure modes, and auditability
• Language is generic (uses agent/*, not specific agent names) per AGENTS.md Code Standards ✓
• Consistent with existing codebase patterns (e.g., token names MISSION_CONTROL_AGENT_TOKEN, /api/sync, /api/agent-runs)

6. README.md — Pre-migration Smoke Checklist for #32

• 10-step checklist using curl commands and browser/manual steps
• Ends with: "Only flip the agent's workflow over once all ten steps pass." ✓

---

Standards Compliance

Standard	Status
Next 16 async searchParams pattern	✓ Correctly implemented with Promise<...> type and await
Generic agent names in docs (AGENTS.md Code Standard #1)	✓ Uses agent/* pattern, not specific names
Error handling (error instanceof Error)	✓ PR body and tests use new Error() pattern
Test coverage for acceptance criteria	✓ Regression tests added for board filters
No commit of secrets	✓ No .env or secrets in changes

---

Linked Issue Fit

#42 — Board filters resetting (Primary)

Acceptance Criterion	Status
Uses Next-compatible async searchParams	✓ Promise<{...}> + await
Selecting a repo keeps selection after navigation	✓ Fixed by async params; regression test verifies Prisma query
Selecting a priority keeps selection after navigation	✓ Fixed by async params; regression test verifies Prisma query
Filtering changes the issue set	✓ Prisma where clause built from params; test verifies
Clear filter with "All *" option	✓ "All agent labels" / "All owner labels" remain valid clear options
Regression tests for board search params	✓ New 78-line test file with 5 cases
Agent/Owner filter behavior documented in UI	✓ aria-label + title attributes + renamed options
Remove stale Project filter	✓ Removed from page.tsx, getIssues(), FilterBar

#35 — AuditLog on GitHub mutation failure

• Test added: "writes an AuditLog entry with success=false when the GitHub mutation fails"
• Verifies createAuditLog called with success: false and errorMessage
• ✓ Matches the gap identified in the issue

#33 — Agent Workflow Contract

• New "OpenClaw Agent Workflow Contract" section in AGENTS.md
• Covers heartbeat lifecycle, read path, source of truth, failure modes, auditability
• ✓ Addresses the missing documentation

#32 — Pre-migration Smoke Checklist

• New 10-step checklist in README.md
• Covers health, sync, issues, board render, projects render, agents page, audit log, logs
• ✓ Addresses the checklist requirement

---

Evidence Provider Findings

No evidence providers configured — no findings to report.

---

Tool Harness Findings

No tool requests were executed. The PR description states npm test passes 53/53 tests (9 files), which includes the 5 new board tests and 1 new AuditLog test added by this PR.

---

Unknowns / Needs Verification

1. CI green: The PR body shows - [ ] CI green on PR as a pending checklist item. This review assumes CI will pass based on local test results and the clean diff.

2. Manual browser testing: Two manual items remain unchecked in the PR body:

   • "Open /board, pick a repo from the dropdown, confirm it sticks across reload and filters the cards"
   • "Open /board?project=foo from an old bookmark, confirm nothing breaks"

3. No breaking API change: The /api/issues route is unchanged (PR body states "zero blast radius outside the board UI"). Old ?project=foo URLs will silently ignore the project param — this is the intended behavior per issue Fix Board filters resetting and remove stale project-label filtering #42.

---

Summary

The PR correctly implements the Next 16 async searchParams fix for issue #42, removes the stale project filter, adds appropriate regression tests, fills the AuditLog test gap for #35, and documents the agent contract (#33) and migration checklist (#32). Code changes are minimal and focused. No violations of repository standards detected.

[joryirving]

Summary

Closes#42, #35, #33, #32. (#36 split out per discussion — schema change deserves its own PR.)

• Fix Board filters resetting and remove stale project-label filtering #42 — Board filter dropdowns reset because searchParams is read synchronously in src/app/board/page.tsx, which is invalid under Next 16. Type searchParams as Promise<...> and await it. Remove the stale Project name text filter (repos are the project boundary, project/* labels aren't required). Rename Agent/Owner dropdowns to All agent labels / All owner labels with aria-label/title so the label-only filter behavior is explicit. Keep /api/issues API surface unchanged (zero blast radius outside the board UI).
• Add regression tests for issue move validation and audit behavior #35 — route.test.ts already covers validation, label mutation shape, and success-path AuditLog. Adds the one missing case: AuditLog row written with success: false and the captured errorMessage when the GitHub mutation throws.
• Define openclaw agent workflow contract for Mission Control #33 — New "OpenClaw Agent Workflow Contract" section in AGENTS.md: heartbeat lifecycle (best-effort /api/sync at start, /api/agent-runs at end), read path (/api/issues, prefer agent/* label assignment, treat no-status as backlog), source-of-truth rules (GitHub authoritative, Projects deprecated, no auto-close), failure modes (Mission Control failures don't fail the heartbeat, tokens are secrets), and auditability.
• Add pre-openclaw agent migration runtime smoke checklist #32 — New "Pre-migration Smoke Checklist" section in README.md with a 10-step checklist (health, automation sync, repos, issue sync, issue read, board render, projects render, agent heartbeat visible, label-change audit row, no Prisma/BigInt/FK errors).
• Adds a regression test (src/app/board/page.test.tsx) that calls BoardPage with Promise.resolve({...}) and asserts the Prisma query receives the resolved filter values. Catches sync-access reverts.

Test plan

• npm run lint — clean
• npm run typecheck — clean (after npx prisma generate, matching CI)
• npm test — 53/53 passing (9 files)
• CI green on PR
• Manual: open /board, pick a repo from the dropdown, confirm it sticks across reload and filters the cards
• Manual: open /board?project=foo from an old bookmark, confirm nothing breaks (param is ignored silently)

🤖 Generated with Claude Code

[its-miso]

✅ Automated recommendation: APPROVE

Analysis engine: anthropic/MiniMax-M2.7@https://litellm.jory.dev/v1 (anthropic)

PR Review: fix(board): async searchParams; drop project filter; agent docs

Recommendation

Approve. This PR cleanly addresses all four linked issues (#42, #35, #33, #32) with correct implementation, appropriate test coverage, and documentation that follows repository conventions.

---

Change-by-Change Findings

1. src/app/board/page.tsx — Core fix for #42

• searchParams type change: Changed from searchParams: { ... } to searchParams: Promise<{ ... }> ✓
• await usage: Added const params = await searchParams before accessing any params ✓
• project filter removal: Removed project parameter from getIssues() and removed if (project) where.labels = { has: 'project/${project}' } ✓
• activeFilters: Removed project from the filter object passed to FilterBar ✓

This matches the Next 16 pattern shown in issue #42's "Likely fix direction" section.

2. src/components/filter-bar.tsx — UX improvements for #42

• Project Input removed: The Input component for "Project name" was removed ✓
• aria-label and title added: Agent dropdown gets "Filter by agent label" + "Filters by agent/* label only"; Owner dropdown gets equivalent ✓
• Option text renamed: "All Agents" → "All agent labels", "All Owners" → "All owner labels" ✓

This addresses the acceptance criterion "Decide and document Agent/Owner filter behavior: either label-only by design, with clear UI text."

3. src/app/board/page.test.tsx — Regression test for #42 (NEW FILE)

• 5 test cases covering repo, agent, owner, priority filters, and empty params
• Mocks Prisma queries and verifies the where clause passed to findMany
• Uses Promise.resolve({...}) to simulate Next 16 async searchParams ✓

4. src/app/api/issues/move/route.test.ts — AuditLog test for #35

• Adds test case: it("writes an AuditLog entry with success=false when the GitHub mutation fails")
• Mocks removeIssueLabel.mockRejectedValueOnce(new Error("github 500"))
• Verifies createAuditLog called with success: false and errorMessage: "github 500" ✓

5. AGENTS.md — OpenClaw Agent Workflow Contract for #33

• 11-point contract covering heartbeat lifecycle, read path, source of truth, failure modes, and auditability
• Language is generic (uses agent/*, not specific agent names) per AGENTS.md Code Standards ✓
• Consistent with existing codebase patterns (e.g., token names MISSION_CONTROL_AGENT_TOKEN, /api/sync, /api/agent-runs)

6. README.md — Pre-migration Smoke Checklist for #32

• 10-step checklist using curl commands and browser/manual steps
• Ends with: "Only flip the agent's workflow over once all ten steps pass." ✓

---

Standards Compliance

Standard	Status
Next 16 async searchParams pattern	✓ Correctly implemented with Promise<...> type and await
Generic agent names in docs (AGENTS.md Code Standard #1)	✓ Uses agent/* pattern, not specific names
Error handling (error instanceof Error)	✓ PR body and tests use new Error() pattern
Test coverage for acceptance criteria	✓ Regression tests added for board filters
No commit of secrets	✓ No .env or secrets in changes

---

Linked Issue Fit

#42 — Board filters resetting (Primary)

Acceptance Criterion	Status
Uses Next-compatible async searchParams	✓ Promise<{...}> + await
Selecting a repo keeps selection after navigation	✓ Fixed by async params; regression test verifies Prisma query
Selecting a priority keeps selection after navigation	✓ Fixed by async params; regression test verifies Prisma query
Filtering changes the issue set	✓ Prisma where clause built from params; test verifies
Clear filter with "All *" option	✓ "All agent labels" / "All owner labels" remain valid clear options
Regression tests for board search params	✓ New 78-line test file with 5 cases
Agent/Owner filter behavior documented in UI	✓ aria-label + title attributes + renamed options
Remove stale Project filter	✓ Removed from page.tsx, getIssues(), FilterBar

#35 — AuditLog on GitHub mutation failure

• Test added: "writes an AuditLog entry with success=false when the GitHub mutation fails"
• Verifies createAuditLog called with success: false and errorMessage
• ✓ Matches the gap identified in the issue

#33 — Agent Workflow Contract

• New "OpenClaw Agent Workflow Contract" section in AGENTS.md
• Covers heartbeat lifecycle, read path, source of truth, failure modes, auditability
• ✓ Addresses the missing documentation

#32 — Pre-migration Smoke Checklist

• New 10-step checklist in README.md
• Covers health, sync, issues, board render, projects render, agents page, audit log, logs
• ✓ Addresses the checklist requirement

---

Evidence Provider Findings

No evidence providers configured — no findings to report.

---

Tool Harness Findings

No tool requests were executed. The PR description states npm test passes 53/53 tests (9 files), which includes the 5 new board tests and 1 new AuditLog test added by this PR.

---

Unknowns / Needs Verification

1. CI green: The PR body shows - [ ] CI green on PR as a pending checklist item. This review assumes CI will pass based on local test results and the clean diff.

2. Manual browser testing: Two manual items remain unchecked in the PR body:

   • "Open /board, pick a repo from the dropdown, confirm it sticks across reload and filters the cards"
   • "Open /board?project=foo from an old bookmark, confirm nothing breaks"

3. No breaking API change: The /api/issues route is unchanged (PR body states "zero blast radius outside the board UI"). Old ?project=foo URLs will silently ignore the project param — this is the intended behavior per issue Fix Board filters resetting and remove stale project-label filtering #42.

---

Summary

The PR correctly implements the Next 16 async searchParams fix for issue #42, removes the stale project filter, adds appropriate regression tests, fills the AuditLog test gap for #35, and documents the agent contract (#33) and migration checklist (#32). Code changes are minimal and focused. No violations of repository standards detected.

[joryirving]

Summary

Closes#42, #35, #33, #32. (#36 split out per discussion — schema change deserves its own PR.)

• Fix Board filters resetting and remove stale project-label filtering #42 — Board filter dropdowns reset because searchParams is read synchronously in src/app/board/page.tsx, which is invalid under Next 16. Type searchParams as Promise<...> and await it. Remove the stale Project name text filter (repos are the project boundary, project/* labels aren't required). Rename Agent/Owner dropdowns to All agent labels / All owner labels with aria-label/title so the label-only filter behavior is explicit. Keep /api/issues API surface unchanged (zero blast radius outside the board UI).
• Add regression tests for issue move validation and audit behavior #35 — route.test.ts already covers validation, label mutation shape, and success-path AuditLog. Adds the one missing case: AuditLog row written with success: false and the captured errorMessage when the GitHub mutation throws.
• Define openclaw agent workflow contract for Mission Control #33 — New "OpenClaw Agent Workflow Contract" section in AGENTS.md: heartbeat lifecycle (best-effort /api/sync at start, /api/agent-runs at end), read path (/api/issues, prefer agent/* label assignment, treat no-status as backlog), source-of-truth rules (GitHub authoritative, Projects deprecated, no auto-close), failure modes (Mission Control failures don't fail the heartbeat, tokens are secrets), and auditability.
• Add pre-openclaw agent migration runtime smoke checklist #32 — New "Pre-migration Smoke Checklist" section in README.md with a 10-step checklist (health, automation sync, repos, issue sync, issue read, board render, projects render, agent heartbeat visible, label-change audit row, no Prisma/BigInt/FK errors).
• Adds a regression test (src/app/board/page.test.tsx) that calls BoardPage with Promise.resolve({...}) and asserts the Prisma query receives the resolved filter values. Catches sync-access reverts.

Test plan

• npm run lint — clean
• npm run typecheck — clean (after npx prisma generate, matching CI)
• npm test — 53/53 passing (9 files)
• CI green on PR
• Manual: open /board, pick a repo from the dropdown, confirm it sticks across reload and filters the cards
• Manual: open /board?project=foo from an old bookmark, confirm nothing breaks (param is ignored silently)

🤖 Generated with Claude Code

[its-miso]

✅ Automated recommendation: APPROVE

Analysis engine: anthropic/MiniMax-M2.7@https://litellm.jory.dev/v1 (anthropic)

PR Review: fix(board): async searchParams; drop project filter; agent docs

Recommendation

Approve. This PR cleanly addresses all four linked issues (#42, #35, #33, #32) with correct implementation, appropriate test coverage, and documentation that follows repository conventions.

---

Change-by-Change Findings

1. src/app/board/page.tsx — Core fix for #42

• searchParams type change: Changed from searchParams: { ... } to searchParams: Promise<{ ... }> ✓
• await usage: Added const params = await searchParams before accessing any params ✓
• project filter removal: Removed project parameter from getIssues() and removed if (project) where.labels = { has: 'project/${project}' } ✓
• activeFilters: Removed project from the filter object passed to FilterBar ✓

This matches the Next 16 pattern shown in issue #42's "Likely fix direction" section.

2. src/components/filter-bar.tsx — UX improvements for #42

• Project Input removed: The Input component for "Project name" was removed ✓
• aria-label and title added: Agent dropdown gets "Filter by agent label" + "Filters by agent/* label only"; Owner dropdown gets equivalent ✓
• Option text renamed: "All Agents" → "All agent labels", "All Owners" → "All owner labels" ✓

This addresses the acceptance criterion "Decide and document Agent/Owner filter behavior: either label-only by design, with clear UI text."

3. src/app/board/page.test.tsx — Regression test for #42 (NEW FILE)

• 5 test cases covering repo, agent, owner, priority filters, and empty params
• Mocks Prisma queries and verifies the where clause passed to findMany
• Uses Promise.resolve({...}) to simulate Next 16 async searchParams ✓

4. src/app/api/issues/move/route.test.ts — AuditLog test for #35

• Adds test case: it("writes an AuditLog entry with success=false when the GitHub mutation fails")
• Mocks removeIssueLabel.mockRejectedValueOnce(new Error("github 500"))
• Verifies createAuditLog called with success: false and errorMessage: "github 500" ✓

5. AGENTS.md — OpenClaw Agent Workflow Contract for #33

• 11-point contract covering heartbeat lifecycle, read path, source of truth, failure modes, and auditability
• Language is generic (uses agent/*, not specific agent names) per AGENTS.md Code Standards ✓
• Consistent with existing codebase patterns (e.g., token names MISSION_CONTROL_AGENT_TOKEN, /api/sync, /api/agent-runs)

6. README.md — Pre-migration Smoke Checklist for #32

• 10-step checklist using curl commands and browser/manual steps
• Ends with: "Only flip the agent's workflow over once all ten steps pass." ✓

---

Standards Compliance

Standard	Status
Next 16 async searchParams pattern	✓ Correctly implemented with Promise<...> type and await
Generic agent names in docs (AGENTS.md Code Standard #1)	✓ Uses agent/* pattern, not specific names
Error handling (error instanceof Error)	✓ PR body and tests use new Error() pattern
Test coverage for acceptance criteria	✓ Regression tests added for board filters
No commit of secrets	✓ No .env or secrets in changes

---

Linked Issue Fit

#42 — Board filters resetting (Primary)

Acceptance Criterion	Status
Uses Next-compatible async searchParams	✓ Promise<{...}> + await
Selecting a repo keeps selection after navigation	✓ Fixed by async params; regression test verifies Prisma query
Selecting a priority keeps selection after navigation	✓ Fixed by async params; regression test verifies Prisma query
Filtering changes the issue set	✓ Prisma where clause built from params; test verifies
Clear filter with "All *" option	✓ "All agent labels" / "All owner labels" remain valid clear options
Regression tests for board search params	✓ New 78-line test file with 5 cases
Agent/Owner filter behavior documented in UI	✓ aria-label + title attributes + renamed options
Remove stale Project filter	✓ Removed from page.tsx, getIssues(), FilterBar

#35 — AuditLog on GitHub mutation failure

• Test added: "writes an AuditLog entry with success=false when the GitHub mutation fails"
• Verifies createAuditLog called with success: false and errorMessage
• ✓ Matches the gap identified in the issue

#33 — Agent Workflow Contract

• New "OpenClaw Agent Workflow Contract" section in AGENTS.md
• Covers heartbeat lifecycle, read path, source of truth, failure modes, auditability
• ✓ Addresses the missing documentation

#32 — Pre-migration Smoke Checklist

• New 10-step checklist in README.md
• Covers health, sync, issues, board render, projects render, agents page, audit log, logs
• ✓ Addresses the checklist requirement

---

Evidence Provider Findings

No evidence providers configured — no findings to report.

---

Tool Harness Findings

No tool requests were executed. The PR description states npm test passes 53/53 tests (9 files), which includes the 5 new board tests and 1 new AuditLog test added by this PR.

---

Unknowns / Needs Verification

1. CI green: The PR body shows - [ ] CI green on PR as a pending checklist item. This review assumes CI will pass based on local test results and the clean diff.

2. Manual browser testing: Two manual items remain unchecked in the PR body:

   • "Open /board, pick a repo from the dropdown, confirm it sticks across reload and filters the cards"
   • "Open /board?project=foo from an old bookmark, confirm nothing breaks"

3. No breaking API change: The /api/issues route is unchanged (PR body states "zero blast radius outside the board UI"). Old ?project=foo URLs will silently ignore the project param — this is the intended behavior per issue Fix Board filters resetting and remove stale project-label filtering #42.

---

Summary

The PR correctly implements the Next 16 async searchParams fix for issue #42, removes the stale project filter, adds appropriate regression tests, fills the AuditLog test gap for #35, and documents the agent contract (#33) and migration checklist (#32). Code changes are minimal and focused. No violations of repository standards detected.

[joryirving]

Summary

Closes#42, #35, #33, #32. (#36 split out per discussion — schema change deserves its own PR.)

• Fix Board filters resetting and remove stale project-label filtering #42 — Board filter dropdowns reset because searchParams is read synchronously in src/app/board/page.tsx, which is invalid under Next 16. Type searchParams as Promise<...> and await it. Remove the stale Project name text filter (repos are the project boundary, project/* labels aren't required). Rename Agent/Owner dropdowns to All agent labels / All owner labels with aria-label/title so the label-only filter behavior is explicit. Keep /api/issues API surface unchanged (zero blast radius outside the board UI).
• Add regression tests for issue move validation and audit behavior #35 — route.test.ts already covers validation, label mutation shape, and success-path AuditLog. Adds the one missing case: AuditLog row written with success: false and the captured errorMessage when the GitHub mutation throws.
• Define openclaw agent workflow contract for Mission Control #33 — New "OpenClaw Agent Workflow Contract" section in AGENTS.md: heartbeat lifecycle (best-effort /api/sync at start, /api/agent-runs at end), read path (/api/issues, prefer agent/* label assignment, treat no-status as backlog), source-of-truth rules (GitHub authoritative, Projects deprecated, no auto-close), failure modes (Mission Control failures don't fail the heartbeat, tokens are secrets), and auditability.
• Add pre-openclaw agent migration runtime smoke checklist #32 — New "Pre-migration Smoke Checklist" section in README.md with a 10-step checklist (health, automation sync, repos, issue sync, issue read, board render, projects render, agent heartbeat visible, label-change audit row, no Prisma/BigInt/FK errors).
• Adds a regression test (src/app/board/page.test.tsx) that calls BoardPage with Promise.resolve({...}) and asserts the Prisma query receives the resolved filter values. Catches sync-access reverts.

Test plan

• npm run lint — clean
• npm run typecheck — clean (after npx prisma generate, matching CI)
• npm test — 53/53 passing (9 files)
• CI green on PR
• Manual: open /board, pick a repo from the dropdown, confirm it sticks across reload and filters the cards
• Manual: open /board?project=foo from an old bookmark, confirm nothing breaks (param is ignored silently)

🤖 Generated with Claude Code

[its-miso]

✅ Automated recommendation: APPROVE

Analysis engine: anthropic/MiniMax-M2.7@https://litellm.jory.dev/v1 (anthropic)

PR Review: fix(board): async searchParams; drop project filter; agent docs

Recommendation

Approve. This PR cleanly addresses all four linked issues (#42, #35, #33, #32) with correct implementation, appropriate test coverage, and documentation that follows repository conventions.

---

Change-by-Change Findings

1. src/app/board/page.tsx — Core fix for #42

• searchParams type change: Changed from searchParams: { ... } to searchParams: Promise<{ ... }> ✓
• await usage: Added const params = await searchParams before accessing any params ✓
• project filter removal: Removed project parameter from getIssues() and removed if (project) where.labels = { has: 'project/${project}' } ✓
• activeFilters: Removed project from the filter object passed to FilterBar ✓

This matches the Next 16 pattern shown in issue #42's "Likely fix direction" section.

2. src/components/filter-bar.tsx — UX improvements for #42

• Project Input removed: The Input component for "Project name" was removed ✓
• aria-label and title added: Agent dropdown gets "Filter by agent label" + "Filters by agent/* label only"; Owner dropdown gets equivalent ✓
• Option text renamed: "All Agents" → "All agent labels", "All Owners" → "All owner labels" ✓

This addresses the acceptance criterion "Decide and document Agent/Owner filter behavior: either label-only by design, with clear UI text."

3. src/app/board/page.test.tsx — Regression test for #42 (NEW FILE)

• 5 test cases covering repo, agent, owner, priority filters, and empty params
• Mocks Prisma queries and verifies the where clause passed to findMany
• Uses Promise.resolve({...}) to simulate Next 16 async searchParams ✓

4. src/app/api/issues/move/route.test.ts — AuditLog test for #35

• Adds test case: it("writes an AuditLog entry with success=false when the GitHub mutation fails")
• Mocks removeIssueLabel.mockRejectedValueOnce(new Error("github 500"))
• Verifies createAuditLog called with success: false and errorMessage: "github 500" ✓

5. AGENTS.md — OpenClaw Agent Workflow Contract for #33

• 11-point contract covering heartbeat lifecycle, read path, source of truth, failure modes, and auditability
• Language is generic (uses agent/*, not specific agent names) per AGENTS.md Code Standards ✓
• Consistent with existing codebase patterns (e.g., token names MISSION_CONTROL_AGENT_TOKEN, /api/sync, /api/agent-runs)

6. README.md — Pre-migration Smoke Checklist for #32

• 10-step checklist using curl commands and browser/manual steps
• Ends with: "Only flip the agent's workflow over once all ten steps pass." ✓

---

Standards Compliance

Standard	Status
Next 16 async searchParams pattern	✓ Correctly implemented with Promise<...> type and await
Generic agent names in docs (AGENTS.md Code Standard #1)	✓ Uses agent/* pattern, not specific names
Error handling (error instanceof Error)	✓ PR body and tests use new Error() pattern
Test coverage for acceptance criteria	✓ Regression tests added for board filters
No commit of secrets	✓ No .env or secrets in changes

---

Linked Issue Fit

#42 — Board filters resetting (Primary)

Acceptance Criterion	Status
Uses Next-compatible async searchParams	✓ Promise<{...}> + await
Selecting a repo keeps selection after navigation	✓ Fixed by async params; regression test verifies Prisma query
Selecting a priority keeps selection after navigation	✓ Fixed by async params; regression test verifies Prisma query
Filtering changes the issue set	✓ Prisma where clause built from params; test verifies
Clear filter with "All *" option	✓ "All agent labels" / "All owner labels" remain valid clear options
Regression tests for board search params	✓ New 78-line test file with 5 cases
Agent/Owner filter behavior documented in UI	✓ aria-label + title attributes + renamed options
Remove stale Project filter	✓ Removed from page.tsx, getIssues(), FilterBar

#35 — AuditLog on GitHub mutation failure

• Test added: "writes an AuditLog entry with success=false when the GitHub mutation fails"
• Verifies createAuditLog called with success: false and errorMessage
• ✓ Matches the gap identified in the issue

#33 — Agent Workflow Contract

• New "OpenClaw Agent Workflow Contract" section in AGENTS.md
• Covers heartbeat lifecycle, read path, source of truth, failure modes, auditability
• ✓ Addresses the missing documentation

#32 — Pre-migration Smoke Checklist

• New 10-step checklist in README.md
• Covers health, sync, issues, board render, projects render, agents page, audit log, logs
• ✓ Addresses the checklist requirement

---

Evidence Provider Findings

No evidence providers configured — no findings to report.

---

Tool Harness Findings

No tool requests were executed. The PR description states npm test passes 53/53 tests (9 files), which includes the 5 new board tests and 1 new AuditLog test added by this PR.

---

Unknowns / Needs Verification

1. CI green: The PR body shows - [ ] CI green on PR as a pending checklist item. This review assumes CI will pass based on local test results and the clean diff.

2. Manual browser testing: Two manual items remain unchecked in the PR body:

   • "Open /board, pick a repo from the dropdown, confirm it sticks across reload and filters the cards"
   • "Open /board?project=foo from an old bookmark, confirm nothing breaks"

3. No breaking API change: The /api/issues route is unchanged (PR body states "zero blast radius outside the board UI"). Old ?project=foo URLs will silently ignore the project param — this is the intended behavior per issue Fix Board filters resetting and remove stale project-label filtering #42.

---

Summary

The PR correctly implements the Next 16 async searchParams fix for issue #42, removes the stale project filter, adds appropriate regression tests, fills the AuditLog test gap for #35, and documents the agent contract (#33) and migration checklist (#32). Code changes are minimal and focused. No violations of repository standards detected.

[joryirving]

Summary

Closes#42, #35, #33, #32. (#36 split out per discussion — schema change deserves its own PR.)

• Fix Board filters resetting and remove stale project-label filtering #42 — Board filter dropdowns reset because searchParams is read synchronously in src/app/board/page.tsx, which is invalid under Next 16. Type searchParams as Promise<...> and await it. Remove the stale Project name text filter (repos are the project boundary, project/* labels aren't required). Rename Agent/Owner dropdowns to All agent labels / All owner labels with aria-label/title so the label-only filter behavior is explicit. Keep /api/issues API surface unchanged (zero blast radius outside the board UI).
• Add regression tests for issue move validation and audit behavior #35 — route.test.ts already covers validation, label mutation shape, and success-path AuditLog. Adds the one missing case: AuditLog row written with success: false and the captured errorMessage when the GitHub mutation throws.
• Define openclaw agent workflow contract for Mission Control #33 — New "OpenClaw Agent Workflow Contract" section in AGENTS.md: heartbeat lifecycle (best-effort /api/sync at start, /api/agent-runs at end), read path (/api/issues, prefer agent/* label assignment, treat no-status as backlog), source-of-truth rules (GitHub authoritative, Projects deprecated, no auto-close), failure modes (Mission Control failures don't fail the heartbeat, tokens are secrets), and auditability.
• Add pre-openclaw agent migration runtime smoke checklist #32 — New "Pre-migration Smoke Checklist" section in README.md with a 10-step checklist (health, automation sync, repos, issue sync, issue read, board render, projects render, agent heartbeat visible, label-change audit row, no Prisma/BigInt/FK errors).
• Adds a regression test (src/app/board/page.test.tsx) that calls BoardPage with Promise.resolve({...}) and asserts the Prisma query receives the resolved filter values. Catches sync-access reverts.

Test plan

• npm run lint — clean
• npm run typecheck — clean (after npx prisma generate, matching CI)
• npm test — 53/53 passing (9 files)
• CI green on PR
• Manual: open /board, pick a repo from the dropdown, confirm it sticks across reload and filters the cards
• Manual: open /board?project=foo from an old bookmark, confirm nothing breaks (param is ignored silently)

🤖 Generated with Claude Code

[its-miso]

✅ Automated recommendation: APPROVE

Analysis engine: anthropic/MiniMax-M2.7@https://litellm.jory.dev/v1 (anthropic)

PR Review: fix(board): async searchParams; drop project filter; agent docs

Recommendation

Approve. This PR cleanly addresses all four linked issues (#42, #35, #33, #32) with correct implementation, appropriate test coverage, and documentation that follows repository conventions.

---

Change-by-Change Findings

1. src/app/board/page.tsx — Core fix for #42

• searchParams type change: Changed from searchParams: { ... } to searchParams: Promise<{ ... }> ✓
• await usage: Added const params = await searchParams before accessing any params ✓
• project filter removal: Removed project parameter from getIssues() and removed if (project) where.labels = { has: 'project/${project}' } ✓
• activeFilters: Removed project from the filter object passed to FilterBar ✓

This matches the Next 16 pattern shown in issue #42's "Likely fix direction" section.

2. src/components/filter-bar.tsx — UX improvements for #42

• Project Input removed: The Input component for "Project name" was removed ✓
• aria-label and title added: Agent dropdown gets "Filter by agent label" + "Filters by agent/* label only"; Owner dropdown gets equivalent ✓
• Option text renamed: "All Agents" → "All agent labels", "All Owners" → "All owner labels" ✓

This addresses the acceptance criterion "Decide and document Agent/Owner filter behavior: either label-only by design, with clear UI text."

3. src/app/board/page.test.tsx — Regression test for #42 (NEW FILE)

• 5 test cases covering repo, agent, owner, priority filters, and empty params
• Mocks Prisma queries and verifies the where clause passed to findMany
• Uses Promise.resolve({...}) to simulate Next 16 async searchParams ✓

4. src/app/api/issues/move/route.test.ts — AuditLog test for #35

• Adds test case: it("writes an AuditLog entry with success=false when the GitHub mutation fails")
• Mocks removeIssueLabel.mockRejectedValueOnce(new Error("github 500"))
• Verifies createAuditLog called with success: false and errorMessage: "github 500" ✓

5. AGENTS.md — OpenClaw Agent Workflow Contract for #33

• 11-point contract covering heartbeat lifecycle, read path, source of truth, failure modes, and auditability
• Language is generic (uses agent/*, not specific agent names) per AGENTS.md Code Standards ✓
• Consistent with existing codebase patterns (e.g., token names MISSION_CONTROL_AGENT_TOKEN, /api/sync, /api/agent-runs)

6. README.md — Pre-migration Smoke Checklist for #32

• 10-step checklist using curl commands and browser/manual steps
• Ends with: "Only flip the agent's workflow over once all ten steps pass." ✓

---

Standards Compliance

Standard	Status
Next 16 async searchParams pattern	✓ Correctly implemented with Promise<...> type and await
Generic agent names in docs (AGENTS.md Code Standard #1)	✓ Uses agent/* pattern, not specific names
Error handling (error instanceof Error)	✓ PR body and tests use new Error() pattern
Test coverage for acceptance criteria	✓ Regression tests added for board filters
No commit of secrets	✓ No .env or secrets in changes

---

Linked Issue Fit

#42 — Board filters resetting (Primary)

Acceptance Criterion	Status
Uses Next-compatible async searchParams	✓ Promise<{...}> + await
Selecting a repo keeps selection after navigation	✓ Fixed by async params; regression test verifies Prisma query
Selecting a priority keeps selection after navigation	✓ Fixed by async params; regression test verifies Prisma query
Filtering changes the issue set	✓ Prisma where clause built from params; test verifies
Clear filter with "All *" option	✓ "All agent labels" / "All owner labels" remain valid clear options
Regression tests for board search params	✓ New 78-line test file with 5 cases
Agent/Owner filter behavior documented in UI	✓ aria-label + title attributes + renamed options
Remove stale Project filter	✓ Removed from page.tsx, getIssues(), FilterBar

#35 — AuditLog on GitHub mutation failure

• Test added: "writes an AuditLog entry with success=false when the GitHub mutation fails"
• Verifies createAuditLog called with success: false and errorMessage
• ✓ Matches the gap identified in the issue

#33 — Agent Workflow Contract

• New "OpenClaw Agent Workflow Contract" section in AGENTS.md
• Covers heartbeat lifecycle, read path, source of truth, failure modes, auditability
• ✓ Addresses the missing documentation

#32 — Pre-migration Smoke Checklist

• New 10-step checklist in README.md
• Covers health, sync, issues, board render, projects render, agents page, audit log, logs
• ✓ Addresses the checklist requirement

---

Evidence Provider Findings

No evidence providers configured — no findings to report.

---

Tool Harness Findings

No tool requests were executed. The PR description states npm test passes 53/53 tests (9 files), which includes the 5 new board tests and 1 new AuditLog test added by this PR.

---

Unknowns / Needs Verification

1. CI green: The PR body shows - [ ] CI green on PR as a pending checklist item. This review assumes CI will pass based on local test results and the clean diff.

2. Manual browser testing: Two manual items remain unchecked in the PR body:

   • "Open /board, pick a repo from the dropdown, confirm it sticks across reload and filters the cards"
   • "Open /board?project=foo from an old bookmark, confirm nothing breaks"

3. No breaking API change: The /api/issues route is unchanged (PR body states "zero blast radius outside the board UI"). Old ?project=foo URLs will silently ignore the project param — this is the intended behavior per issue Fix Board filters resetting and remove stale project-label filtering #42.

---

Summary

The PR correctly implements the Next 16 async searchParams fix for issue #42, removes the stale project filter, adds appropriate regression tests, fills the AuditLog test gap for #35, and documents the agent contract (#33) and migration checklist (#32). Code changes are minimal and focused. No violations of repository standards detected.

[joryirving]

Summary

Closes#42, #35, #33, #32. (#36 split out per discussion — schema change deserves its own PR.)

• Fix Board filters resetting and remove stale project-label filtering #42 — Board filter dropdowns reset because searchParams is read synchronously in src/app/board/page.tsx, which is invalid under Next 16. Type searchParams as Promise<...> and await it. Remove the stale Project name text filter (repos are the project boundary, project/* labels aren't required). Rename Agent/Owner dropdowns to All agent labels / All owner labels with aria-label/title so the label-only filter behavior is explicit. Keep /api/issues API surface unchanged (zero blast radius outside the board UI).
• Add regression tests for issue move validation and audit behavior #35 — route.test.ts already covers validation, label mutation shape, and success-path AuditLog. Adds the one missing case: AuditLog row written with success: false and the captured errorMessage when the GitHub mutation throws.
• Define openclaw agent workflow contract for Mission Control #33 — New "OpenClaw Agent Workflow Contract" section in AGENTS.md: heartbeat lifecycle (best-effort /api/sync at start, /api/agent-runs at end), read path (/api/issues, prefer agent/* label assignment, treat no-status as backlog), source-of-truth rules (GitHub authoritative, Projects deprecated, no auto-close), failure modes (Mission Control failures don't fail the heartbeat, tokens are secrets), and auditability.
• Add pre-openclaw agent migration runtime smoke checklist #32 — New "Pre-migration Smoke Checklist" section in README.md with a 10-step checklist (health, automation sync, repos, issue sync, issue read, board render, projects render, agent heartbeat visible, label-change audit row, no Prisma/BigInt/FK errors).
• Adds a regression test (src/app/board/page.test.tsx) that calls BoardPage with Promise.resolve({...}) and asserts the Prisma query receives the resolved filter values. Catches sync-access reverts.

Test plan

• npm run lint — clean
• npm run typecheck — clean (after npx prisma generate, matching CI)
• npm test — 53/53 passing (9 files)
• CI green on PR
• Manual: open /board, pick a repo from the dropdown, confirm it sticks across reload and filters the cards
• Manual: open /board?project=foo from an old bookmark, confirm nothing breaks (param is ignored silently)

🤖 Generated with Claude Code

[its-miso]

✅ Automated recommendation: APPROVE

Analysis engine: anthropic/MiniMax-M2.7@https://litellm.jory.dev/v1 (anthropic)

PR Review: fix(board): async searchParams; drop project filter; agent docs

Recommendation

Approve. This PR cleanly addresses all four linked issues (#42, #35, #33, #32) with correct implementation, appropriate test coverage, and documentation that follows repository conventions.

---

Change-by-Change Findings

1. src/app/board/page.tsx — Core fix for #42

• searchParams type change: Changed from searchParams: { ... } to searchParams: Promise<{ ... }> ✓
• await usage: Added const params = await searchParams before accessing any params ✓
• project filter removal: Removed project parameter from getIssues() and removed if (project) where.labels = { has: 'project/${project}' } ✓
• activeFilters: Removed project from the filter object passed to FilterBar ✓

This matches the Next 16 pattern shown in issue #42's "Likely fix direction" section.

2. src/components/filter-bar.tsx — UX improvements for #42

• Project Input removed: The Input component for "Project name" was removed ✓
• aria-label and title added: Agent dropdown gets "Filter by agent label" + "Filters by agent/* label only"; Owner dropdown gets equivalent ✓
• Option text renamed: "All Agents" → "All agent labels", "All Owners" → "All owner labels" ✓

This addresses the acceptance criterion "Decide and document Agent/Owner filter behavior: either label-only by design, with clear UI text."

3. src/app/board/page.test.tsx — Regression test for #42 (NEW FILE)

• 5 test cases covering repo, agent, owner, priority filters, and empty params
• Mocks Prisma queries and verifies the where clause passed to findMany
• Uses Promise.resolve({...}) to simulate Next 16 async searchParams ✓

4. src/app/api/issues/move/route.test.ts — AuditLog test for #35

• Adds test case: it("writes an AuditLog entry with success=false when the GitHub mutation fails")
• Mocks removeIssueLabel.mockRejectedValueOnce(new Error("github 500"))
• Verifies createAuditLog called with success: false and errorMessage: "github 500" ✓

5. AGENTS.md — OpenClaw Agent Workflow Contract for #33

• 11-point contract covering heartbeat lifecycle, read path, source of truth, failure modes, and auditability
• Language is generic (uses agent/*, not specific agent names) per AGENTS.md Code Standards ✓
• Consistent with existing codebase patterns (e.g., token names MISSION_CONTROL_AGENT_TOKEN, /api/sync, /api/agent-runs)

6. README.md — Pre-migration Smoke Checklist for #32

• 10-step checklist using curl commands and browser/manual steps
• Ends with: "Only flip the agent's workflow over once all ten steps pass." ✓

---

Standards Compliance

Standard	Status
Next 16 async searchParams pattern	✓ Correctly implemented with Promise<...> type and await
Generic agent names in docs (AGENTS.md Code Standard #1)	✓ Uses agent/* pattern, not specific names
Error handling (error instanceof Error)	✓ PR body and tests use new Error() pattern
Test coverage for acceptance criteria	✓ Regression tests added for board filters
No commit of secrets	✓ No .env or secrets in changes

---

Linked Issue Fit

#42 — Board filters resetting (Primary)

Acceptance Criterion	Status
Uses Next-compatible async searchParams	✓ Promise<{...}> + await
Selecting a repo keeps selection after navigation	✓ Fixed by async params; regression test verifies Prisma query
Selecting a priority keeps selection after navigation	✓ Fixed by async params; regression test verifies Prisma query
Filtering changes the issue set	✓ Prisma where clause built from params; test verifies
Clear filter with "All *" option	✓ "All agent labels" / "All owner labels" remain valid clear options
Regression tests for board search params	✓ New 78-line test file with 5 cases
Agent/Owner filter behavior documented in UI	✓ aria-label + title attributes + renamed options
Remove stale Project filter	✓ Removed from page.tsx, getIssues(), FilterBar

#35 — AuditLog on GitHub mutation failure

• Test added: "writes an AuditLog entry with success=false when the GitHub mutation fails"
• Verifies createAuditLog called with success: false and errorMessage
• ✓ Matches the gap identified in the issue

#33 — Agent Workflow Contract

• New "OpenClaw Agent Workflow Contract" section in AGENTS.md
• Covers heartbeat lifecycle, read path, source of truth, failure modes, auditability
• ✓ Addresses the missing documentation

#32 — Pre-migration Smoke Checklist

• New 10-step checklist in README.md
• Covers health, sync, issues, board render, projects render, agents page, audit log, logs
• ✓ Addresses the checklist requirement

---

Evidence Provider Findings

No evidence providers configured — no findings to report.

---

Tool Harness Findings

No tool requests were executed. The PR description states npm test passes 53/53 tests (9 files), which includes the 5 new board tests and 1 new AuditLog test added by this PR.

---

Unknowns / Needs Verification

1. CI green: The PR body shows - [ ] CI green on PR as a pending checklist item. This review assumes CI will pass based on local test results and the clean diff.

2. Manual browser testing: Two manual items remain unchecked in the PR body:

   • "Open /board, pick a repo from the dropdown, confirm it sticks across reload and filters the cards"
   • "Open /board?project=foo from an old bookmark, confirm nothing breaks"

3. No breaking API change: The /api/issues route is unchanged (PR body states "zero blast radius outside the board UI"). Old ?project=foo URLs will silently ignore the project param — this is the intended behavior per issue Fix Board filters resetting and remove stale project-label filtering #42.

---

Summary

The PR correctly implements the Next 16 async searchParams fix for issue #42, removes the stale project filter, adds appropriate regression tests, fills the AuditLog test gap for #35, and documents the agent contract (#33) and migration checklist (#32). Code changes are minimal and focused. No violations of repository standards detected.

[joryirving]

Summary

Closes#42, #35, #33, #32. (#36 split out per discussion — schema change deserves its own PR.)

• Fix Board filters resetting and remove stale project-label filtering #42 — Board filter dropdowns reset because searchParams is read synchronously in src/app/board/page.tsx, which is invalid under Next 16. Type searchParams as Promise<...> and await it. Remove the stale Project name text filter (repos are the project boundary, project/* labels aren't required). Rename Agent/Owner dropdowns to All agent labels / All owner labels with aria-label/title so the label-only filter behavior is explicit. Keep /api/issues API surface unchanged (zero blast radius outside the board UI).
• Add regression tests for issue move validation and audit behavior #35 — route.test.ts already covers validation, label mutation shape, and success-path AuditLog. Adds the one missing case: AuditLog row written with success: false and the captured errorMessage when the GitHub mutation throws.
• Define openclaw agent workflow contract for Mission Control #33 — New "OpenClaw Agent Workflow Contract" section in AGENTS.md: heartbeat lifecycle (best-effort /api/sync at start, /api/agent-runs at end), read path (/api/issues, prefer agent/* label assignment, treat no-status as backlog), source-of-truth rules (GitHub authoritative, Projects deprecated, no auto-close), failure modes (Mission Control failures don't fail the heartbeat, tokens are secrets), and auditability.
• Add pre-openclaw agent migration runtime smoke checklist #32 — New "Pre-migration Smoke Checklist" section in README.md with a 10-step checklist (health, automation sync, repos, issue sync, issue read, board render, projects render, agent heartbeat visible, label-change audit row, no Prisma/BigInt/FK errors).
• Adds a regression test (src/app/board/page.test.tsx) that calls BoardPage with Promise.resolve({...}) and asserts the Prisma query receives the resolved filter values. Catches sync-access reverts.

Test plan

• npm run lint — clean
• npm run typecheck — clean (after npx prisma generate, matching CI)
• npm test — 53/53 passing (9 files)
• CI green on PR
• Manual: open /board, pick a repo from the dropdown, confirm it sticks across reload and filters the cards
• Manual: open /board?project=foo from an old bookmark, confirm nothing breaks (param is ignored silently)

🤖 Generated with Claude Code

[its-miso]

✅ Automated recommendation: APPROVE

Analysis engine: anthropic/MiniMax-M2.7@https://litellm.jory.dev/v1 (anthropic)

PR Review: fix(board): async searchParams; drop project filter; agent docs

Recommendation

Approve. This PR cleanly addresses all four linked issues (#42, #35, #33, #32) with correct implementation, appropriate test coverage, and documentation that follows repository conventions.

---

Change-by-Change Findings

1. src/app/board/page.tsx — Core fix for #42

• searchParams type change: Changed from searchParams: { ... } to searchParams: Promise<{ ... }> ✓
• await usage: Added const params = await searchParams before accessing any params ✓
• project filter removal: Removed project parameter from getIssues() and removed if (project) where.labels = { has: 'project/${project}' } ✓
• activeFilters: Removed project from the filter object passed to FilterBar ✓

This matches the Next 16 pattern shown in issue #42's "Likely fix direction" section.

2. src/components/filter-bar.tsx — UX improvements for #42

• Project Input removed: The Input component for "Project name" was removed ✓
• aria-label and title added: Agent dropdown gets "Filter by agent label" + "Filters by agent/* label only"; Owner dropdown gets equivalent ✓
• Option text renamed: "All Agents" → "All agent labels", "All Owners" → "All owner labels" ✓

This addresses the acceptance criterion "Decide and document Agent/Owner filter behavior: either label-only by design, with clear UI text."

3. src/app/board/page.test.tsx — Regression test for #42 (NEW FILE)

• 5 test cases covering repo, agent, owner, priority filters, and empty params
• Mocks Prisma queries and verifies the where clause passed to findMany
• Uses Promise.resolve({...}) to simulate Next 16 async searchParams ✓

4. src/app/api/issues/move/route.test.ts — AuditLog test for #35

• Adds test case: it("writes an AuditLog entry with success=false when the GitHub mutation fails")
• Mocks removeIssueLabel.mockRejectedValueOnce(new Error("github 500"))
• Verifies createAuditLog called with success: false and errorMessage: "github 500" ✓

5. AGENTS.md — OpenClaw Agent Workflow Contract for #33

• 11-point contract covering heartbeat lifecycle, read path, source of truth, failure modes, and auditability
• Language is generic (uses agent/*, not specific agent names) per AGENTS.md Code Standards ✓
• Consistent with existing codebase patterns (e.g., token names MISSION_CONTROL_AGENT_TOKEN, /api/sync, /api/agent-runs)

6. README.md — Pre-migration Smoke Checklist for #32

• 10-step checklist using curl commands and browser/manual steps
• Ends with: "Only flip the agent's workflow over once all ten steps pass." ✓

---

Standards Compliance

Standard	Status
Next 16 async searchParams pattern	✓ Correctly implemented with Promise<...> type and await
Generic agent names in docs (AGENTS.md Code Standard #1)	✓ Uses agent/* pattern, not specific names
Error handling (error instanceof Error)	✓ PR body and tests use new Error() pattern
Test coverage for acceptance criteria	✓ Regression tests added for board filters
No commit of secrets	✓ No .env or secrets in changes

---

Linked Issue Fit

#42 — Board filters resetting (Primary)

Acceptance Criterion	Status
Uses Next-compatible async searchParams	✓ Promise<{...}> + await
Selecting a repo keeps selection after navigation	✓ Fixed by async params; regression test verifies Prisma query
Selecting a priority keeps selection after navigation	✓ Fixed by async params; regression test verifies Prisma query
Filtering changes the issue set	✓ Prisma where clause built from params; test verifies
Clear filter with "All *" option	✓ "All agent labels" / "All owner labels" remain valid clear options
Regression tests for board search params	✓ New 78-line test file with 5 cases
Agent/Owner filter behavior documented in UI	✓ aria-label + title attributes + renamed options
Remove stale Project filter	✓ Removed from page.tsx, getIssues(), FilterBar

#35 — AuditLog on GitHub mutation failure

• Test added: "writes an AuditLog entry with success=false when the GitHub mutation fails"
• Verifies createAuditLog called with success: false and errorMessage
• ✓ Matches the gap identified in the issue

#33 — Agent Workflow Contract

• New "OpenClaw Agent Workflow Contract" section in AGENTS.md
• Covers heartbeat lifecycle, read path, source of truth, failure modes, auditability
• ✓ Addresses the missing documentation

#32 — Pre-migration Smoke Checklist

• New 10-step checklist in README.md
• Covers health, sync, issues, board render, projects render, agents page, audit log, logs
• ✓ Addresses the checklist requirement

---

Evidence Provider Findings

No evidence providers configured — no findings to report.

---

Tool Harness Findings

No tool requests were executed. The PR description states npm test passes 53/53 tests (9 files), which includes the 5 new board tests and 1 new AuditLog test added by this PR.

---

Unknowns / Needs Verification

1. CI green: The PR body shows - [ ] CI green on PR as a pending checklist item. This review assumes CI will pass based on local test results and the clean diff.

2. Manual browser testing: Two manual items remain unchecked in the PR body:

   • "Open /board, pick a repo from the dropdown, confirm it sticks across reload and filters the cards"
   • "Open /board?project=foo from an old bookmark, confirm nothing breaks"

3. No breaking API change: The /api/issues route is unchanged (PR body states "zero blast radius outside the board UI"). Old ?project=foo URLs will silently ignore the project param — this is the intended behavior per issue Fix Board filters resetting and remove stale project-label filtering #42.

---

Summary

The PR correctly implements the Next 16 async searchParams fix for issue #42, removes the stale project filter, adds appropriate regression tests, fills the AuditLog test gap for #35, and documents the agent contract (#33) and migration checklist (#32). Code changes are minimal and focused. No violations of repository standards detected.

[joryirving]

Summary

Closes#42, #35, #33, #32. (#36 split out per discussion — schema change deserves its own PR.)

• Fix Board filters resetting and remove stale project-label filtering #42 — Board filter dropdowns reset because searchParams is read synchronously in src/app/board/page.tsx, which is invalid under Next 16. Type searchParams as Promise<...> and await it. Remove the stale Project name text filter (repos are the project boundary, project/* labels aren't required). Rename Agent/Owner dropdowns to All agent labels / All owner labels with aria-label/title so the label-only filter behavior is explicit. Keep /api/issues API surface unchanged (zero blast radius outside the board UI).
• Add regression tests for issue move validation and audit behavior #35 — route.test.ts already covers validation, label mutation shape, and success-path AuditLog. Adds the one missing case: AuditLog row written with success: false and the captured errorMessage when the GitHub mutation throws.
• Define openclaw agent workflow contract for Mission Control #33 — New "OpenClaw Agent Workflow Contract" section in AGENTS.md: heartbeat lifecycle (best-effort /api/sync at start, /api/agent-runs at end), read path (/api/issues, prefer agent/* label assignment, treat no-status as backlog), source-of-truth rules (GitHub authoritative, Projects deprecated, no auto-close), failure modes (Mission Control failures don't fail the heartbeat, tokens are secrets), and auditability.
• Add pre-openclaw agent migration runtime smoke checklist #32 — New "Pre-migration Smoke Checklist" section in README.md with a 10-step checklist (health, automation sync, repos, issue sync, issue read, board render, projects render, agent heartbeat visible, label-change audit row, no Prisma/BigInt/FK errors).
• Adds a regression test (src/app/board/page.test.tsx) that calls BoardPage with Promise.resolve({...}) and asserts the Prisma query receives the resolved filter values. Catches sync-access reverts.

Test plan

• npm run lint — clean
• npm run typecheck — clean (after npx prisma generate, matching CI)
• npm test — 53/53 passing (9 files)
• CI green on PR
• Manual: open /board, pick a repo from the dropdown, confirm it sticks across reload and filters the cards
• Manual: open /board?project=foo from an old bookmark, confirm nothing breaks (param is ignored silently)

🤖 Generated with Claude Code

[its-miso]

✅ Automated recommendation: APPROVE

Analysis engine: anthropic/MiniMax-M2.7@https://litellm.jory.dev/v1 (anthropic)

PR Review: fix(board): async searchParams; drop project filter; agent docs

Recommendation

Approve. This PR cleanly addresses all four linked issues (#42, #35, #33, #32) with correct implementation, appropriate test coverage, and documentation that follows repository conventions.

---

Change-by-Change Findings

1. src/app/board/page.tsx — Core fix for #42

• searchParams type change: Changed from searchParams: { ... } to searchParams: Promise<{ ... }> ✓
• await usage: Added const params = await searchParams before accessing any params ✓
• project filter removal: Removed project parameter from getIssues() and removed if (project) where.labels = { has: 'project/${project}' } ✓
• activeFilters: Removed project from the filter object passed to FilterBar ✓

This matches the Next 16 pattern shown in issue #42's "Likely fix direction" section.

2. src/components/filter-bar.tsx — UX improvements for #42

• Project Input removed: The Input component for "Project name" was removed ✓
• aria-label and title added: Agent dropdown gets "Filter by agent label" + "Filters by agent/* label only"; Owner dropdown gets equivalent ✓
• Option text renamed: "All Agents" → "All agent labels", "All Owners" → "All owner labels" ✓

This addresses the acceptance criterion "Decide and document Agent/Owner filter behavior: either label-only by design, with clear UI text."

3. src/app/board/page.test.tsx — Regression test for #42 (NEW FILE)

• 5 test cases covering repo, agent, owner, priority filters, and empty params
• Mocks Prisma queries and verifies the where clause passed to findMany
• Uses Promise.resolve({...}) to simulate Next 16 async searchParams ✓

4. src/app/api/issues/move/route.test.ts — AuditLog test for #35

• Adds test case: it("writes an AuditLog entry with success=false when the GitHub mutation fails")
• Mocks removeIssueLabel.mockRejectedValueOnce(new Error("github 500"))
• Verifies createAuditLog called with success: false and errorMessage: "github 500" ✓

5. AGENTS.md — OpenClaw Agent Workflow Contract for #33

• 11-point contract covering heartbeat lifecycle, read path, source of truth, failure modes, and auditability
• Language is generic (uses agent/*, not specific agent names) per AGENTS.md Code Standards ✓
• Consistent with existing codebase patterns (e.g., token names MISSION_CONTROL_AGENT_TOKEN, /api/sync, /api/agent-runs)

6. README.md — Pre-migration Smoke Checklist for #32

• 10-step checklist using curl commands and browser/manual steps
• Ends with: "Only flip the agent's workflow over once all ten steps pass." ✓

---

Standards Compliance

Standard	Status
Next 16 async searchParams pattern	✓ Correctly implemented with Promise<...> type and await
Generic agent names in docs (AGENTS.md Code Standard #1)	✓ Uses agent/* pattern, not specific names
Error handling (error instanceof Error)	✓ PR body and tests use new Error() pattern
Test coverage for acceptance criteria	✓ Regression tests added for board filters
No commit of secrets	✓ No .env or secrets in changes

---

Linked Issue Fit

#42 — Board filters resetting (Primary)

Acceptance Criterion	Status
Uses Next-compatible async searchParams	✓ Promise<{...}> + await
Selecting a repo keeps selection after navigation	✓ Fixed by async params; regression test verifies Prisma query
Selecting a priority keeps selection after navigation	✓ Fixed by async params; regression test verifies Prisma query
Filtering changes the issue set	✓ Prisma where clause built from params; test verifies
Clear filter with "All *" option	✓ "All agent labels" / "All owner labels" remain valid clear options
Regression tests for board search params	✓ New 78-line test file with 5 cases
Agent/Owner filter behavior documented in UI	✓ aria-label + title attributes + renamed options
Remove stale Project filter	✓ Removed from page.tsx, getIssues(), FilterBar

#35 — AuditLog on GitHub mutation failure

• Test added: "writes an AuditLog entry with success=false when the GitHub mutation fails"
• Verifies createAuditLog called with success: false and errorMessage
• ✓ Matches the gap identified in the issue

#33 — Agent Workflow Contract

• New "OpenClaw Agent Workflow Contract" section in AGENTS.md
• Covers heartbeat lifecycle, read path, source of truth, failure modes, auditability
• ✓ Addresses the missing documentation

#32 — Pre-migration Smoke Checklist

• New 10-step checklist in README.md
• Covers health, sync, issues, board render, projects render, agents page, audit log, logs
• ✓ Addresses the checklist requirement

---

Evidence Provider Findings

No evidence providers configured — no findings to report.

---

Tool Harness Findings

No tool requests were executed. The PR description states npm test passes 53/53 tests (9 files), which includes the 5 new board tests and 1 new AuditLog test added by this PR.

---

Unknowns / Needs Verification

1. CI green: The PR body shows - [ ] CI green on PR as a pending checklist item. This review assumes CI will pass based on local test results and the clean diff.

2. Manual browser testing: Two manual items remain unchecked in the PR body:

   • "Open /board, pick a repo from the dropdown, confirm it sticks across reload and filters the cards"
   • "Open /board?project=foo from an old bookmark, confirm nothing breaks"

3. No breaking API change: The /api/issues route is unchanged (PR body states "zero blast radius outside the board UI"). Old ?project=foo URLs will silently ignore the project param — this is the intended behavior per issue Fix Board filters resetting and remove stale project-label filtering #42.

---

Summary

The PR correctly implements the Next 16 async searchParams fix for issue #42, removes the stale project filter, adds appropriate regression tests, fills the AuditLog test gap for #35, and documents the agent contract (#33) and migration checklist (#32). Code changes are minimal and focused. No violations of repository standards detected.