Uh oh!
There was an error while loading. Please reload this page.
Fixing the unit test for overlapping subnet - #2189
Merged
Merged
Conversation
Signed-off-by: Abhinandan Prativadi <abhi@docker.com>
codecov-io
commented
Jun 18, 2018
Codecov Report
@@ Coverage Diff @@## master #2189 +/- ##
=========================================
Coverage ? 40.64% =========================================
Files ? 139 Lines ? 22496 Branches ? 0 =========================================
Hits ? 9144 Misses ? 12029 Partials ? 1323Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requsting for the same subnet pool will result in error. So modifying the test case to report error on repeated subnet pool requests.
Signed-off-by: Abhinandan Prativadi abhi@docker.com