Skip to content

[backport 18.03] Adding a check for subnet pool overlap - #2190

Merged
fcrisciani merged 3 commits into
moby:bump_18.03from
abhi:bump_18.03
Jun 18, 2018
Merged

[backport 18.03] Adding a check for subnet pool overlap#2190
fcrisciani merged 3 commits into
moby:bump_18.03from
abhi:bump_18.03

Conversation

@abhi

@abhiabhi commented Jun 18, 2018

Copy link
Copy Markdown
Contributor

Backport PRs: #2148 and #2189

abhi added 3 commits June 18, 2018 13:28
Signed-off-by: Abhinandan Prativadi <abhi@docker.com>
(cherry picked from commit 8579c5d)
Signed-off-by: Abhinandan Prativadi <abhi@docker.com>
(cherry picked from commit e65fabd)
Signed-off-by: Abhinandan Prativadi <abhi@docker.com>
(cherry picked from commit a496037)
@codecov-io

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (bump_18.03@557bac2). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@ Coverage Diff @@## bump_18.03 #2190 +/- ##
=============================================
Coverage ? 40.53% =============================================
Files ? 139 Lines ? 22487 Branches ? 0 =============================================
Hits ? 9116 Misses ? 12040 Partials ? 1331
Impacted FilesCoverage Δ
ipam/structures.go86.31% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 557bac2...658ebd8. Read the comment docs.

@fcriscianifcrisciani left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fcrisciani
fcrisciani merged commit 45b5da6 into moby:bump_18.03Jun 18, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@abhi@codecov-io@fcrisciani