') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Update process-wrap to v9.0 by DaleSeo · Pull Request #586 · modelcontextprotocol/rust-sdk · GitHub
Skip to content

Update process-wrap to v9.0 - #586

Merged
jokemanfire merged 1 commit into
modelcontextprotocol:mainfrom
DaleSeo:up-process-wrap
Dec 15, 2025
Merged

Update process-wrap to v9.0#586
jokemanfire merged 1 commit into
modelcontextprotocol:mainfrom
DaleSeo:up-process-wrap

Conversation

@DaleSeo

@DaleSeoDaleSeo commented Dec 12, 2025

Copy link
Copy Markdown
Member

Updates process-wrap dependency from v8.2.1 to v9.0.0 and adapts code to API changes.

Motivation and Context

Fixes#578

The rmcp crate was using process-wrap v8.2.1, but v9.0.0 introduced breaking API changes that caused dependency conflicts for users who needed both rmcp and the latest process-wrap in their projects. This update ensures compatibility with process-wrap v9.0.0 and prevents version conflicts.

How Has This Been Tested?

All the existing unit tests are passing, and all the examples are building.

Breaking Changes

None for users of rmcp. This is an internal dependency update that maintains the same public API.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@github-actionsgithub-actionsBot added T-dependencies Dependencies related changes T-config Configuration file changes T-core Core library changes T-transport Transport layer changes labels Dec 12, 2025
DaleSeo
DaleSeo commented Dec 12, 2025
View reviewed changes
Comment threadcrates/rmcp/src/transport/child_process.rs
self.transport.close().await?;

let wait_fut = Box::into_pin(child.wait());
let wait_fut = child.wait();

@DaleSeoDaleSeoDec 12, 2025

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait() now returns Pin<Box<dyn Future>> so it can be awaited directly

@DaleSeo
DaleSeo marked this pull request as ready for review December 12, 2025 01:08
@jokemanfire
jokemanfire merged commit d7a05aa into modelcontextprotocol:mainDec 15, 2025
11 checks passed
@github-actionsgithub-actionsBot mentioned this pull request Dec 10, 2025
Merged
takumi-earth pushed a commit to earthlings-dev/rmcp that referenced this pull request Jan 27, 2026
@DaleSeo
fix: update process-wrap to v9.0 (modelcontextprotocol#586)
a939a45
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jokemanfirejokemanfirejokemanfire approved these changes

Assignees

No one assigned

Labels

T-configConfiguration file changesT-coreCore library changesT-dependenciesDependencies related changesT-transportTransport layer changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

process-wrap v8.2.1, which uses the TokioCommandWrap struct. However, process-wrap v9.0.0 has renamed this to CommandWrap

2 participants

@DaleSeo@jokemanfire